Review: publicfile 0.52-13
Review Information
accepted — allocated to awm 1 month, 23 days ago, started 1 month, 23 days ago, completed 1 month, 23 days ago.
Final Comment
Happy to accept this into Debian. Note that there are some URLs which could be rewritten to https://cr.yp.to/...
I: debian/control: Homepage: http://cr.yp.to/publicfile.html: INFORMATION (Certainty:certain)
The web page at http://cr.yp.to/publicfile.html works, but is also available via https://cr.yp.to/publicfile.html, please consider switching to HTTPS urls.
I: debian/copyright:4: URL: http://cr.yp.to/publicfile/publicfile-0.52.tar.gz: INFORMATION (Certainty:possible)
The web page at http://cr.yp.to/publicfile/publicfile-0.52.tar.gz works, but is also available via https://cr.yp.to/publicfile/publicfile-0.52.tar.gz, please consider switching to HTTPS urls.
I: debian/patches/filetype.patch:26: URL: http://www.ohse.de/uwe/patches/publicfile-0.52-filetype-diff: INFORMATION (Certainty:possible)
URL schema changed from HTTP to HTTPS during redirect(s): http://www.ohse.de -> https://www.ohse.de
Please investigate and update the URL eventually, to avoid unnecessary redirects!
Public Notes
1 month, 23 days ago
● public
duck - check URL redirections
Command: env PERL5OPT=-m-lib=. duck
Exit code: 0
I: debian/control: Homepage: http://cr.yp.to/publicfile.html: INFORMATION (Certainty:certain)
The web page at http://cr.yp.to/publicfile.html works, but is also available via https://cr.yp.to/publicfile.html, please consider switching to HTTPS urls.
I: debian/copyright:4: URL: http://cr.yp.to/publicfile/publicfile-0.52.tar.gz: INFORMATION (Certainty:possible)
The web page at http://cr.yp.to/publicfile/publicfile-0.52.tar.gz works, but is also available via https://cr.yp.to/publicfile/publicfile-0.52.tar.gz, please consider switching to HTTPS urls.
I: debian/patches/filetype.patch:26: URL: http://www.ohse.de/uwe/patches/publicfile-0.52-filetype-diff: INFORMATION (Certainty:possible)
URL schema changed from HTTP to HTTPS during redirect(s): http://www.ohse.de -> https://www.ohse.de
Please investigate and update the URL eventually, to avoid unnecessary redirects!
1 month, 23 days ago
● public
suspicious-source
Command: suspicious-source
Exit code: 0
./leapsecs.dat
1 month, 23 days ago
● public
vulture
Command: vulture .
Exit code: 0
(no output)
1 month, 23 days ago
● public
debmake -cc
Command: debmake -cc
Exit code: 0
I: set parameters
I: scan source for copyright+license text and file extensions
I: 80 %, ext = c
I: 4 %, ext = h2
I: 4 %, ext = h1
I: 3 %, ext = sh
I: 3 %, ext = patch
I: 1 %, ext = 1
I: 1 %, ext = 8
I: 1 %, ext = exp
I: 1 %, ext = dat
I: 1 %, ext = tests
I: 1 %, ext = Debian
I: 1 %, ext = sslserver
I: check_all_licenses
I: .....................................................W: Non-UTF-8 char found, using latin-1: leapsecs.dat
W: ... 'utf-8' codec can't decode byte 0xb2 in position 5: invalid start byte
W: analyze_copyright: skip name="", years=9999-0
......................................................................................................................................
I: check_all_licenses completed for 187 files.
I: bunch_all_licenses
I: format_all_licenses
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: package
Upstream-Contact: <preferred name and address to reach the upstream project>
Source: <url://example.com>
#
# Please double check copyright with the licensecheck(1) command.
Files: CHANGES
FILES
Makefile
SYSDEPS
TARGETS
TODO
VERSION
alloc.c
alloc.h
alloc_re.c
auto-str.c
auto_home.h
byte.h
byte_chr.c
byte_copy.c
byte_cr.c
byte_diff.c
byte_rchr.c
byte_zero.c
caldate.h
caldate_fmjd.c
caltime.h
caltime_utc.c
case.h
case_diffs.c
case_lowerb.c
case_startb.c
chkshsgr.c
choose.sh
conf-cc
conf-home
conf-ld
configure.c
debian/README.Debian
debian/TODO
debian/autoindex/NEWS
debian/autoindex/ad1810-autoindex
debian/autoindex/update-ad1810-autoindex
debian/control
debian/docs
debian/examples
debian/ftpd.8
debian/get-publicfile-docs
debian/get-publicfile-docs.1
debian/install
debian/lintian-overrides
debian/manpages
debian/patches/implicit-int.patch
debian/patches/series
debian/postinst
debian/publicfile-httpd.8
debian/rules
debian/source/format
debian/source/lintian-overrides
debian/update-publicfile-contenttype
debian/update-publicfile-contenttype.1
debian/watch
direntry.h1
direntry.h2
env.c
env.h
error.c
error.h
error_str.c
error_temp.c
exit.h
fetch.c
fetch.h
file.c
file.h
filetype.c
filetype.h
find-systype.sh
fmt.h
fmt_str.c
fmt_uint.c
fmt_ulong.c
fmt_xlong.c
ftpd.c
gen_alloc.h
gen_allocdefs.h
getln.c
getln.h
getln2.c
hasdevtcp.h1
hasdevtcp.h2
hassgact.h1
hassgact.h2
hassgprm.h1
hassgprm.h2
hasshsgr.h1
hasshsgr.h2
hier.c
httpd.c
httpdate.c
httpdate.h
install.c
instcheck.c
ip.c
ip.h
leapsecs.dat
leapsecs.h
leapsecs_init.c
leapsecs_read.c
leapsecs_sub.c
main.c
ndelay.h
ndelay_off.c
ndelay_on.c
open.h
open_read.c
open_trunc.c
pathdecode.c
pathdecode.h
percent.c
percent.h
prot.c
prot.h
readwrite.h
rts.exp
rts.sh
rts.tests
scan.h
scan_ulong.c
select.h1
select.h2
sig.h
sig_block.c
sig_catch.c
sig_pause.c
sig_pipe.c
str.h
str_chr.c
str_diff.c
str_len.c
str_rchr.c
str_start.c
stralloc.h
stralloc_cat.c
stralloc_catb.c
stralloc_cats.c
stralloc_copy.c
stralloc_eady.c
stralloc_num.c
stralloc_opyb.c
stralloc_opys.c
stralloc_pend.c
strerr.h
strerr_die.c
strerr_sys.c
subfd.h
subfderr.c
substdi.c
substdio.c
substdio.h
substdio_copy.c
substdo.c
tai.h
tai_now.c
tai_sub.c
tai_unpack.c
timeoutaccept.c
timeoutaccept.h
timeoutconn.c
timeoutconn.h
timeoutread.c
timeoutread.h
timeoutwrite.c
timeoutwrite.h
trycpp.c
trydrent.c
trylsock.c
trysgact.c
trysgprm.c
tryshsgr.c
trysysel.c
tryulong64.c
uint64.h1
uint64.h2
utime.c
warn-auto.sh
warn-shsgr
Copyright: __NO_COPYRIGHT_NOR_LICENSE__
License: __NO_COPYRIGHT_NOR_LICENSE__
Files: debian/patches/ftbfs-implicit-declaration.patch
Copyright: __NO_COPYRIGHT__ in: debian/patches/ftbfs-implicit-declaration.patch
License: __UNKNOWN__
NB FIXME this patch is very much WiP
.
This patch fixes fatal errors like:
.
./compile configure.c
configure.c: In function ‘finish’:
configure.c:55:7: error: implicit declaration of function
‘fsync’ [-Wimplicit-function-declaration]
Files: debian/patches/publicfile.sslserver
Copyright: __NO_COPYRIGHT__ in: debian/patches/publicfile.sslserver
License: __UNKNOWN__
Linked to from http://thedjbway.b0llix.net/ssl/httpsd.html , archived at and
fetched from
http://web.archive.org/web/20091117140942/https://www.superscript.com/patches/publicfile.sslserver
Files: README
Copyright: 1999 D. J. Bernstein
License: __UNKNOWN__
publicfile home page: http://pobox.com/~djb/publicfile.html
Installation instructions: http://pobox.com/~djb/publicfile/install.html
Files: debian/patches/errno.patch
Copyright: __NO_COPYRIGHT__ in: debian/patches/errno.patch
License: __UNKNOWN__
diff -u publicfile-0.52.old/error.h publicfile-0.52/error.h
Files: debian/patches/filetype.patch
Copyright: __NO_COPYRIGHT__ in: debian/patches/filetype.patch
License: __UNKNOWN__
diff -u publicfile-0.52.old/filetype.c publicfile-0.52/filetype.c
1 month, 23 days ago
● public
Licenserecon
Command: lrc -l
Exit code: 0
en: Versions: licenserecon '11.0' licensecheck '3.3.9-1'
Parsing Source Tree ....
Reading d/copyright ....
Running licensecheck ....
d/copyright | licensecheck
public-domain | public-domain debian/autoindex/ad1810-autoindex
public-domain | public-domain debian/autoindex/update-ad1810-autoindex
public-domain | public-domain debian/ftpd.8
public-domain | public-domain debian/get-publicfile-docs
public-domain | public-domain debian/get-publicfile-docs.1
public-domain | public-domain debian/postinst
public-domain | public-domain debian/publicfile-httpd.8
public-domain | public-domain debian/rules
public-domain | public-domain debian/update-publicfile-contenttype
public-domain | public-domain debian/update-publicfile-contenttype.1
No significant differences found
1 month, 23 days ago
● public
licensecheck
Command: licensecheck -c '.*' -r --deb-machine -l 0 .
Exit code: 0
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: FIXME
Upstream-Contact: FIXME
Source: FIXME
Disclaimer: Autogenerated by licensecheck
Files: ./CHANGES
./FILES
./Makefile
./SYSDEPS
./TARGETS
./TODO
./VERSION
./alloc.c
./alloc.h
./alloc_re.c
./auto-str.c
./auto_home.h
./byte.h
./byte_chr.c
./byte_copy.c
./byte_cr.c
./byte_diff.c
./byte_rchr.c
./byte_zero.c
./caldate.h
./caldate_fmjd.c
./caltime.h
./caltime_utc.c
./case.h
./case_diffs.c
./case_lowerb.c
./case_startb.c
./chkshsgr.c
./choose.sh
./conf-cc
./conf-home
./conf-ld
./configure.c
./debian/README.Debian
./debian/TODO
./debian/autoindex/NEWS
./debian/control
./debian/docs
./debian/examples
./debian/install
./debian/lintian-overrides
./debian/manpages
./debian/patches/errno.patch
./debian/patches/filetype.patch
./debian/patches/ftbfs-implicit-declaration.patch
./debian/patches/implicit-int.patch
./debian/patches/publicfile.sslserver
./debian/patches/series
./debian/source/format
./debian/source/lintian-overrides
./debian/watch
./direntry.h1
./direntry.h2
./env.c
./env.h
./error.c
./error.h
./error_str.c
./error_temp.c
./exit.h
./fetch.c
./fetch.h
./file.c
./file.h
./filetype.c
./filetype.h
./find-systype.sh
./fmt.h
./fmt_str.c
./fmt_uint.c
./fmt_ulong.c
./fmt_xlong.c
./ftpd.c
./gen_alloc.h
./gen_allocdefs.h
./getln.c
./getln.h
./getln2.c
./hasdevtcp.h1
./hasdevtcp.h2
./hassgact.h1
./hassgact.h2
./hassgprm.h1
./hassgprm.h2
./hasshsgr.h1
./hasshsgr.h2
./hier.c
./httpd.c
./httpdate.c
./httpdate.h
./install.c
./instcheck.c
./ip.c
./ip.h
./leapsecs.dat
./leapsecs.h
./leapsecs_init.c
./leapsecs_read.c
./leapsecs_sub.c
./main.c
./ndelay.h
./ndelay_off.c
./ndelay_on.c
./open.h
./open_read.c
./open_trunc.c
./pathdecode.c
./pathdecode.h
./percent.c
./percent.h
./prot.c
./prot.h
./readwrite.h
./rts.exp
./rts.sh
./rts.tests
./scan.h
./scan_ulong.c
./select.h1
./select.h2
./sig.h
./sig_block.c
./sig_catch.c
./sig_pause.c
./sig_pipe.c
./str.h
./str_chr.c
./str_diff.c
./str_len.c
./str_rchr.c
./str_start.c
./stralloc.h
./stralloc_cat.c
./stralloc_catb.c
./stralloc_cats.c
./stralloc_copy.c
./stralloc_eady.c
./stralloc_num.c
./stralloc_opyb.c
./stralloc_opys.c
./stralloc_pend.c
./strerr.h
./strerr_die.c
./strerr_sys.c
./subfd.h
./subfderr.c
./substdi.c
./substdio.c
./substdio_copy.c
./substdo.c
./tai.h
./tai_now.c
./tai_sub.c
./tai_unpack.c
./timeoutaccept.c
./timeoutaccept.h
./timeoutconn.c
./timeoutconn.h
./timeoutread.c
./timeoutread.h
./timeoutwrite.c
./timeoutwrite.h
./trycpp.c
./trydrent.c
./trylsock.c
./trysgact.c
./trysgprm.c
./tryshsgr.c
./trysysel.c
./tryulong64.c
./uint64.h1
./uint64.h2
./utime.c
./warn-auto.sh
./warn-shsgr
Copyright: NONE
License: UNKNOWN
FIXME
Files: ./debian/autoindex/ad1810-autoindex
./debian/autoindex/update-ad1810-autoindex
./debian/ftpd.8
./debian/get-publicfile-docs
./debian/get-publicfile-docs.1
./debian/postinst
./debian/publicfile-httpd.8
./debian/rules
./debian/update-publicfile-contenttype
./debian/update-publicfile-contenttype.1
Copyright: NONE
License: public-domain
FIXME
Files: ./substdio.h
Copyright: 0 )
License: UNKNOWN
FIXME
Files: ./README
Copyright: 1999, D. J. Bernstein
License: UNKNOWN
FIXME
Files: ./debian/copyright
Copyright: 1999, D. J. Bernstein
2002, mw@csi.hu
n/a
License: public-domain
FIXME
Files: ./debian/changelog
Copyright: Update according to public-domain release
add reference to Berne Convention and other docs in order
add some extra information.
adjust layout; fix lintian warning
clarify license situation of publicfile-0.52-filetype-diff.
make lintian happy: add an "empty" line.
now machine parsable; add license on files
use "https" form of copyright-format URL.
License: public-domain
FIXME
1 month, 23 days ago
● public
copyright check
Command: cme check dpkg-copyright
Exit code: 255
Element 'License-Alias' of node 'Files:"debian/patches/filetype.patch"' is deprecated
Configuration item 'Files:"debian/patches/filetype.patch" License short_name' has a wrong value:
value 'public-domain' does not match grammar from model: license 'public-domain' is not declared in a stand-alone License paragraph. Did not find any stand-alone License paragraph.
value is computed from '$replace{$alias}', where
'alias' from path '- - License-Alias' is undef