Review: python-locationsharinglib 5.0.3-1
Package Information
| Description | library for retrieving shared locations from Google Maps This library uses exported Google account cookies to access locations shared with that account through Google Maps. It provides coordinates, timestamps, addresses and location accuracy, along with battery level and charging status when available. People and their coordinates can be retrieved by full name or nickname. |
|---|---|
| Maintainer | Home Assistant Team <team+homeassistant@tracker.debian.org> |
| Changed By | Edward Betts <edward@4angle.com> |
| Sponsor | edward@debian.org |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/homeassistant-team/deps/python-locationsharinglib.git (browse) |
| Closes | #1149358 |
| Tracker | https://tracker.debian.org/pkg/python-locationsharinglib |
| Uploaded | 23 days ago |
New Package Report
.changes
| Distribution | unstable |
|---|---|
| Date | Tue, 29 Sep 2026 16:45:48 +0100 |
| Source | python-locationsharinglib |
| Version | 5.0.3-1 |
| Changed-By | Edward Betts <edward@4angle.com> |
| Architecture | all source |
Changelog
python-locationsharinglib (5.0.3-1) unstable; urgency=medium . * Initial release. (Closes: #1149358)
.dsc
| Section | python |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | python3-locationsharinglib deb python optional arch=all |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: locationsharinglib
Upstream-Contact: Costas Tyfoxylos <costas.tyf@gmail.com>
Source: https://github.com/costastf/locationsharinglib
Files: *
Copyright: 2017 Costas Tyfoxylos
License: MIT
Files: _CI/*
Copyright: 2018 Costas Tyfoxylos
License: MIT
Files: _CI/library/core_library.py
Copyright: 2018 Costas Tyfoxylos
2004 Michael Foord
License: MIT
Files: _CI/library/patch.py
Copyright: 2008-2016 anatoly techtonik
License: MIT
Files: _CI/scripts/lock.py
Copyright: 2019 Ilija Matoski
License: MIT
Files: debian/*
Copyright: 2026 Edward Betts <edward@4angle.com>
License: MIT
License: MIT
Permission is hereby granted, free of charge, to any person
obtaining a copy of this software and associated documentation
files (the "Software"), to deal in the Software without
restriction, including without limitation the rights to use,
copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the
Software is furnished to do so, subject to the following
conditions:
.
The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
OTHER DEALINGS IN THE SOFTWARE.
Review Information
accepted — allocated to awm 21 days ago, started 21 days ago, completed 21 days ago.
Final Comment
Hi,
Some pedantica packaging issues you might want to review...
Packaging quality
- pybuild-plugin-pyproject declared but no pyproject.toml exists.
debian/control:11 depends on pybuild-plugin-pyproject, yet the tarball has only legacy setup.py/setup.cfg (no pyproject.toml anywhere). The plugin is unused/inconsistent with the actual build system.
- override_dh_auto_test is empty (debian/rules:10-11)
it contains only a comment and never calls dh_auto_test, so the test suite is silently skipped. The rationale comment ("only an empty test scaffold") is only roughly accurate: tests/test_locationsharinglib.py does define a BetamaxTestCase class, just with no test methods. Combined with the <!nocheck> test-only Build-Depends (betamax, pytest, cachetools, coloredlogs, pytz) that are then never exercised, this means autopkgtest-pkg-python runs nothing meaningful.
- Docs build isn't gated on nodoc.
debian/rules:8 unconditionally runs sphinx-build, while the sphinx/rtd-theme Build-Depends are marked <!nodoc> (debian/control:21-22). Building with dpkg-buildpackage -Pnodoc would still attempt the docs build and fail.
- _version.py fallback is incomplete (minor).
The Debian patch (debian/patches/dgit-changes) adds from importlib.metadata import version and catches only FileNotFoundError before it. When no .VERSION is present and the package isn't installed as a distribution, version('locationsharinglib') raises PackageNotFoundError (uncaught). Fine in the Debian-installed case, but fragile.
Thanks!