Review: python-sigimax 1.0.2-2
New Package Report
.changes
| Source | python-sigimax |
|---|---|
| Version | 1.0.2-2 |
| Changed-By | Roland Mas <lolando@debian.org> |
| Architecture | source all |
| Distribution | unstable |
| Date | Wed, 21 Oct 2026 11:24:45 +0200 |
Changelog
python-sigimax (1.0.2-2) unstable; urgency=medium . * Update packaging according to the DFSG-Team's LLM's suggestions. . python-sigimax (1.0.2-1) unstable; urgency=low . * Initial packaging.
.dsc
| Package-List | python3-sigimax deb python optional arch=all |
|---|---|
| Section | python |
| Priority | optional |
| Component | main |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: sigimax
Upstream-Contact: Pierre Raybaut <p.raybaut@codra.fr>
Source: https://github.com/DataLab-Platform/SigimaX
Files: *
Copyright: 2023, DataLab Platform Developers
License: BSD-3-clause
Files: debian/*
Copyright: 2026 Roland Mas <lolando@debian.org>
License: BSD-3-clause
License: BSD-3-clause
Copyright (c) 2023, DataLab Platform Developers.
All rights reserved.
.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
.
1. Redistributions of source code must retain the above copyright notice, this
list of conditions and the following disclaimer.
.
2. Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.
.
3. Neither the name of the copyright holder nor the names of its
contributors may be used to endorse or promote products derived from
this software without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
DFSG Assistant LLM REVIEW 0 blocker, 1 important, 0 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 17 days ago.
Report
DFSG NEW review for python-sigimax version 1.0.2-2
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: No
- Issues: 0 blocker, 1 important, 0 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
debian/copyright is DEP-5 machine-readable with a Files:* BSD-3-clause catch-all and a debian/* stanza, plus a full BSD-3-clause License paragraph. Every source file carries a Copyright (c) DataLab Platform Developers, BSD 3-Clause license, see LICENSE file header or, in the .po translation files, # Copyright (C) 2025/2026, DataLab Platform Developers; the top-level LICENSE is BSD-3-clause. Binary/data files (the HDF5 test fixtures sigimax/data/tests/empty.h5 and reordering_test.h5, and the documentation PNG images and favicon in doc/_static and doc/images) are data in their preferred form, drawn from the same project, and are covered by the catch-all Files:* stanza. The sparse SVG icon set under sigimax/data/icons has no per-file header but is project data covered by Files:*. No non-free terms (no NC/ND, no field-of-use clauses) and no embedded third-party code were found; every copyright holder found by the scan is named in debian/copyright.
Packaging
The binary package python3-sigimax declares only python3, ${misc:Depends} and ${python3:Depends}, but the module has hard top-level runtime imports of guidata, plotpy, sigima and qtpy (sigimax/config.py import guidata.dataset as gds, from plotpy import config, from sigima.config import OptionsContainer; sigimax/app.py and mainwindow.py from qtpy import ...), and pyproject.toml declares these as required dependencies. None of python3-guidata, python3-plotpy, python3-sigima or python3-qtpy is in Depends; they exist in the archive. Installing the package and importing sigimax will therefore fail with ImportError. The packaging is otherwise clean: dh compat 14, dh-sequence-python3/pybuild, Standards-Version 4.7.4, autopkgtest-pkg-pybuild, runtime-dep imports correctly limited to the <!nocheck> build-deps.
Issues
important packaging 1. Binary package missing all runtime Depends ◂
- Files:
debian/control (Package: python3-sigimax) - Basis: checked, in the package or with a reference tool
- Evidence: pyproject.toml
dependencies = ["guidata >= 3.15.0", "PlotPy >= 2.11.0", "psutil >= 5.7", "Sigima >= 1.2.0"]; sigimax/config.pyimport guidata.dataset as gds,from plotpy import config,from sigima.config import OptionsContainer; sigimax/app.py and mainwindow.pyfrom qtpy import QtWidgets. Package Depends is onlypython3, ${misc:Depends}, ${python3:Depends}. - Problem: python3:Depends from dh-python covers only the Python interpreter and compiled-extension ABI, not arbitrary module imports. The runtime imports of guidata, plotpy, sigima and qtpy (qtypy is not even in Build-Depends) are undeclared, so a plain
python3 -c 'import sigimax'(which pulls in sigimax.app -> mainwindow -> qtpy, and sigimax.config -> guidata/plotpy/sigima) fails until the user installs them by hand. - Fix: Add
python3-guidata, python3-plotpy, python3-sigima, python3-qtpy(and any other imported modules) to the python3-sigimax Depends.
Verified ◂
- Every .py source file in sigimax/, doc/, scripts/ and sigimax/tests/ carries the
Copyright (c) DataLab Platform Developers, BSD 3-Clauseheader; the .po files sayCopyright (C) 2025/2026, DataLab Platform Developers. Licence is uniformly BSD-3-clause, matching debian/copyright's Files:* stanza and the full License paragraph. - Binary/data files are test fixtures and doc images only: sigimax/data/tests/empty.h5 and reordering_test.h5 (HDF5, not UTF-8) are test data; doc/_static/Sigima-Frontpage.png, codra.png, favicon.ico and doc/images/SigimaX-Banner.png are documentation images, with matching .svg sources present (Sigima.svg, DataLab-.svg, SigimaX-Banner.svg). All covered by the Files: BSD-3-clause catch-all.
- No .pyc, minified JS, .class/.jar/.so, or built artifacts without sources; the tree is pure Python plus SVG/PNG/HDF5 data. No embedded third-party code and no non-free terms (no NC/ND, no JSON-style field-of-use clause) found.
- debian/copyright is DEP-5 with correct catch-all Files:* and debian/* stanzas, and the full BSD-3-clause text; Files-Excluded is absent and no excluded files remain in the tree. The prescan's holder check found every declared holder already named in debian/copyright.
- debian/control: debhelper-compat (= 14) with dh via
dh $@ --buildsystem=pybuildin rules; substvars ${misc:Depends}/${python3:Depends} present (fine at compat 14); Standards-Version 4.7.4 (current); Testsuite: autopkgtest-pkg-pybuild; python3-all, Architecture: all pure-Python. Runtime-dep imports appear in Build-Depends only under <!nocheck>, correct at compat 14 where dh skips dh_auto_test overrides under nocheck. - Changelog has two unstable entries (1.0.2-1, 1.0.2-2) in sane format.
- uscan found the packaged version as the newest upstream release (upstream
1.0.2, packaged1.0.2).
Not confirmed ◂
- Whether sigimax actually imports/runs against Debian's shipped plotpy 2.8.4 and guidata 3.14.2 — pyproject declares minima PlotPy >= 2.11.0 and guidata >= 3.15.0 (apt-cache: python3-plotpy 2.8.4-2, python3-guidata 3.14.2-2), so an actual incompatibility is possible; a build/autopkgtest would show it.
- debian/pybuild.testfiles lists
sigimax/tests, which would install the test suite into the binary package; whether this matches intent was not verified.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader was emailed about the review 17 days ago.
Review Information
accepted — allocated to awm 14 days ago, started 14 days ago, completed 14 days ago.
Final Comment
Superseded by review of later version