Review: python-tinytag 2.2.1-1
New Package Report
.changes
| Source | python-tinytag |
|---|---|
| Version | 2.2.1-1 |
| Changed-By | Aryan Karamtoth |
| Architecture | source all |
| Distribution | unstable |
| Date | Sun, 26 Apr 2026 18:32:49 +0530 |
Changelog
python-tinytag (2.2.1-1) unstable; urgency=medium . * Initial release. (Closes: #1134944)
.dsc
| Package-List | python3-tinytag deb python optional arch=all |
|---|---|
| Section | python |
| Priority | optional |
| Component | main |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Source: https://github.com/tinytag/tinytag Upstream-Name: tinytag Upstream-Contact: Tom Wallroth and Mat (mathiascode) Files: * Copyright: 2014-2026 Tom Wallroth 2014-2026 Mat (mathiascode) License: Expat Files: debian/* Copyright: 2026 Aryan Karamtoth <spaciouscoder78@disroot.org> License: Expat License: Expat Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
Review Information
rejected — allocated to siretart 3 days ago, started 3 days ago, completed 3 days ago.
Final Comment
Thanks for your work on python-tinytag. I've taken a look at the
source for DFSG compliance and copyright accuracy. Overall, the package
looks very clean, but I noticed a few discrepancies in the
documentation that should be addressed before it goes into the archive.
The debian/copyright file currently lists everything under the MIT
(Expat) license. However, the upstream source includes a REUSE.toml
in tinytag/tests/samples/ which explicitly identifies all files in
that directory as being under the CC0-1.0 license. Since CC0 is more
permissive than Expat, this isn't a freeness issue, but it is an
inaccuracy in the documentation. You should add a separate stanza for
tinytag/tests/samples/* with the CC0-1.0 license and include the
full license text in debian/copyright.
Regarding the copyright holders, the LICENSE file and several source
headers (like tinytag/tinytag.py) mention "Tom Wallroth, Mat
(mathiascode), et al." or "tinytag Contributors". The current
debian/copyright only lists the two main authors. It would be better
to include "tinytag Contributors" or "et al." to more accurately
reflect the upstream copyright statement.
I also noticed that some of the test samples (e.g., vbri.mp3,
chinese_id3.mp3) contain very short snippets (less than 0.5 seconds)
of recognizable copyrighted music. While these are likely acceptable in
the main archive as "de minimis" test data (used only to verify
metadata parsing), the upstream claim that they are CC0-1.0 is
legally questionable for the musical content itself. It might be worth
adding a brief note in debian/copyright or debian/README.Debian
clarifying that these are tiny fragments used for testing purposes.
Finally, just a small detail: the SVG files in tinytag/icons/ also
have their own SPDX headers. While they are MIT licensed and covered
by your current Files: * stanza, they specify "2024 tinytag
Contributors" as the copyright holder, which reinforces the need to
include the contributor group in your documentation.
Aside from these documentation tweaks, the package seems DFSG-free and
well-structured.
-rt
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 2.2.1-1 | 48a3dd3d… | 2026-05-06 09:56 | 2026-05-06 10:30 | siretart | accepted | VIEW |