Review: qt-advanced-docking-system 4.5.0-1
Review Information
accepted — allocated to awm 1 month, 11 days ago, started 1 month, 11 days ago, completed 1 month, 11 days ago.
Final Comment
Public Notes
1 month, 11 days ago
● public
vulture
Command: vulture .
Exit code: 3
demo/main.py:7: unused import 'QRect' (90% confidence)
demo/main.py:27: unused import 'rc' (90% confidence)
demo/main.py:78: unused method 'minimumSizeHint' (60% confidence)
demo/main.py:84: unused method 'createDockAreaTitleBar' (60% confidence)
demo/main.py:333: unused method 'on_actionSaveState_triggered' (60% confidence)
demo/main.py:337: unused method 'on_actionRestoreState_triggered' (60% confidence)
demo/main.py:361: unused variable 'visible' (100% confidence)
demo/main.py:406: unused method 'toggle_dock_widget_window_title' (60% confidence)
demo/status_dialog.py:23: unused method 'on_dockWidgetsComboBox_currentIndexChanged' (60% confidence)
examples/autohide/main.py:5: unused import 'QTimer' (90% confidence)
examples/autohide/main.py:7: unused import 'QToolBar' (90% confidence)
examples/autohide/main.py:91: unused variable 'blocker' (60% confidence)
examples/autohidedragndrop/main.py:5: unused import 'QTimer' (90% confidence)
examples/autohidedragndrop/main.py:7: unused import 'QToolBar' (90% confidence)
examples/autohidedragndrop/main.py:69: unused variable 'blocker' (60% confidence)
examples/centralwidget/main.py:5: unused import 'QTimer' (90% confidence)
examples/centralwidget/main.py:7: unused import 'QToolBar' (90% confidence)
examples/centralwidget/main.py:91: unused variable 'blocker' (60% confidence)
examples/deleteonclose/main.py:5: unused import 'pyqtSlot' (90% confidence)
examples/deleteonclose/main.py:6: unused import 'QMenuBar' (90% confidence)
examples/dockindock/dockindock.py:157: unused function 'setNewPerspectiveDefaultName' (60% confidence)
examples/dockindock/dockindockmanager.py:101: unused method 'removePerspectivesRec' (60% confidence)
examples/dockindock/perspectives.py:143: unused variable 'debug' (60% confidence)
examples/emptydockarea/main.py:92: unused variable 'blocker' (60% confidence)
examples/simple/main.py:5: unused import 'QTimer' (90% confidence)
project.py:13: unused attribute 'bindings_factories' (60% confidence)
1 month, 11 days ago
● public
Licenserecon
Command: lrc -l
Exit code: 1
en: Versions: licenserecon '11.0' licensecheck '3.3.9-1'
Parsing Source Tree ....
Reading d/copyright ....
Invalid DEP-5 header in debian/copyright
Failed to process debian/copyright
1 month, 11 days ago
● public
CME fix
Command: cme fix --verbose dpkg
Exit code: 0
Reading package lists... 0%
Reading package lists... 100%
Reading package lists... Done
Building dependency tree... 0%
Building dependency tree... 0%
Building dependency tree... 50%
Building dependency tree... 50%
Building dependency tree... Done
Reading state information... 0%
Reading state information... 0%
Reading state information... Done
cme: running fix on dpkg configuration...
Connecting to api.ftp-master.debian.org to check 6 package versions. Please wait...
Got info from api.ftp-master.debian.org for 6 packages.
Warning in 'control source Standards-Version': Current standards version is '4.7.3'. Please read https://www.debian.org/doc/debian-policy/upgrading-checklist.html for the changes that may be needed on your package
to upgrade it from standard version '4.6.0' to '4.7.3'.
Offending value: '4.6.0'
Warning in 'install:"libqt-advanced-docking-system-dev" content:0': path should not begin with '/'
Offending value: '/usr/include'
Warning in 'install:"libqt-advanced-docking-system-dev" content:1': path should not begin with '/'
Offending value: '/usr/lib/*/*.so'
Warning in 'install:"libqt-advanced-docking-system-dev" content:2': path should not begin with '/'
Offending value: '/usr/lib/*/cmake'
Warning in 'install:"libqt-advanced-docking-system4" content:0': path should not begin with '/'
Offending value: '/usr/lib/*/*.so.*'
Changes applied to dpkg configuration:
- control source Standards-Version: '4.6.0' -> '4.7.3' # applied fix for :Current standards version is '4.7.3'. Please read https://www.debian.org/doc/debian-policy/upgrading-checklist.html for the changes that may be needed on your package
to upgrade it from standard version '4.6.0' to '4.7.3'.
- install:"libqt-advanced-docking-system-dev" content:0: '/usr/include' -> 'usr/include' # applied fix for :path should not begin with '/'
- install:"libqt-advanced-docking-system-dev" content:1: '/usr/lib/*/*.so' -> 'usr/lib/*/*.so' # applied fix for :path should not begin with '/'
- install:"libqt-advanced-docking-system-dev" content:2: '/usr/lib/*/cmake' -> 'usr/lib/*/cmake' # applied fix for :path should not begin with '/'
- install:"libqt-advanced-docking-system4" content:0: '/usr/lib/*/*.so.*' -> 'usr/lib/*/*.so.*' # applied fix for :path should not begin with '/'
- patches:"install-to-standard-paths.patch" Synopsis has new value: 'Install to standard paths' # applied fix for :Empty synopsis
- patches:"do-not-install-license.patch" Synopsis has new value: 'Do not install license' # applied fix for :Empty synopsis
- patches:"link-with-xcb.patch" Synopsis has new value: 'Link with xcb' # applied fix for :Empty synopsis
- patches:"fix-path-to-Versioning.patch" Synopsis has new value: 'Fix path to Versioning' # applied fix for :Empty synopsis