DFSG NEW Queue

DFSG, Licensing & New Packages Team

qt6-qmltermwidget 0.2+git20260531-1

Package Information

DescriptionTerminal Widget QML module

This project is a QML port of qtermwidget. It is written to be as close as possible to the upstream project in order to make cooperation possible.

At the moment this plugin is powering cool-retro-term and the lomiri-terminal-app.

This package contains the QML module and also a simple test application.

MaintainerDebian UBports Team <team+ubports@tracker.debian.org>
Changed ByJeremy Bícha <jbicha@ubuntu.com>
Sponsorjbicha@debian.org
Distributionexperimental
Architectureany all
VCSgit: https://salsa.debian.org/ubports-team/qmltermwidget.git (browse)
Trackerhttps://tracker.debian.org/pkg/qt6-qmltermwidget
Uploaded1 hour ago

Takes Over Existing Binary Packages

This upload builds binary packages that a different source package currently builds in unstable. Check that the takeover is intended and explained, for example in the changelog.

BinaryCurrently built by
qmltermwidget-commonqmltermwidget

New Package Report

.changes◂
Sourceqt6-qmltermwidget
Version0.2+git20260531-1
Changed-ByJeremy Bícha <jbicha@ubuntu.com>
Architecturesource amd64 all
Distributionexperimental
DateWed, 04 Nov 2026 22:54:51 +0100
Changelog◂
qt6-qmltermwidget (0.2+git20260531-1) experimental; urgency=medium
 .
   * Team upload
 .
   [ Guido Berhoerster ]
   * Rename source package because upstream only support qt6
   * Update packaging for qt6
   * debian/copyright{,in}: Update copyright files
 .
   [ Jeremy Bícha ]
   * Misc packaging updates
 .
   [ Mike Gabriel ]
   * debian/control: Remove Gürkan Myczko from Uploaders: field as requested
     via IRC. Thanks for all the previous work.
 .
   [ Thorsten Alteholz ]
   * Enable Salsa CI using default template
.dsc◂
Componentmain
Package-Listqml6-module-termwidget deb libs optional arch=any
qmltermwidget-common deb libs optional arch=all
Sectionlibs
Priorityoptional
debian/copyright◂
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://github.com/Swordfish90/qmltermwidget
Upstream-Name: qmltermwidget

Files: .editorconfig
 .gitignore
 .translation-update
 AUTHORS
 cmake/qtermwidget6-config.cmake.in
 docs/configuration.md
 lib.pri
 lib/ColorTables.h
 lib/DefaultTranslatorText.h
 lib/ExtendedDefaultTranslator.h
 lib/LineFont.h
 lib/LineFont.src
 lib/SearchBar.ui
 lib/color-schemes/BlackOnLightYellow.colorscheme
 lib/color-schemes/BlackOnRandomLight.colorscheme
 lib/color-schemes/BlackOnWhite.colorscheme
 lib/color-schemes/BreezeModified.colorscheme
 lib/color-schemes/DarkPastels.colorscheme
 lib/color-schemes/Falcon.colorscheme
 lib/color-schemes/GreenOnBlack.colorscheme
 lib/color-schemes/Linux.colorscheme
 lib/color-schemes/Solarized.colorscheme
 lib/color-schemes/SolarizedLight.colorscheme
 lib/color-schemes/Tango.colorscheme
 lib/color-schemes/Ubuntu.colorscheme
 lib/color-schemes/WhiteOnBlack.colorscheme
 lib/color-schemes/cool-retro-term.colorscheme
 lib/color-schemes/historic/BlackOnLightColor.schema
 lib/color-schemes/historic/DarkPicture.schema
 lib/color-schemes/historic/Example.Schema
 lib/color-schemes/historic/GreenOnBlack.schema
 lib/color-schemes/historic/GreenTint.schema
 lib/color-schemes/historic/GreenTint_MC.schema
 lib/color-schemes/historic/LightPicture.schema
 lib/color-schemes/historic/Linux.schema
 lib/color-schemes/historic/README.Schema
 lib/color-schemes/historic/README.default.Schema
 lib/color-schemes/historic/Transparent.schema
 lib/color-schemes/historic/Transparent_MC.schema
 lib/color-schemes/historic/Transparent_darkbg.schema
 lib/color-schemes/historic/Transparent_lightbg.schema
 lib/color-schemes/historic/XTerm.schema
 lib/color-schemes/historic/syscolor.schema
 lib/color-schemes/historic/vim.schema
 lib/default.keytab
 lib/kb-layouts/README
 lib/kb-layouts/default.keytab
 lib/kb-layouts/historic/vt100.keytab
 lib/kb-layouts/historic/x11r5.keytab
 lib/kb-layouts/linux.keytab
 lib/kb-layouts/macbook.keytab
 lib/kb-layouts/solaris.keytab
 lib/kb-layouts/vt420pc.keytab
 lib/konsole_wcwidth.cpp
 lib/konsole_wcwidth.h
 lib/mac-vkcode.h
 lib/qtermwidget_export.h
 lib/qtermwidget_version.h
 lib/tools.cpp
 lib/tools.h
 lib/translations/CMakeLists.txt
 lib/translations/qtermwidget.ts
 lib/translations/qtermwidget_ar.ts
 lib/translations/qtermwidget_arn.ts
 lib/translations/qtermwidget_ast.ts
 lib/translations/qtermwidget_bg.ts
 lib/translations/qtermwidget_ca.ts
 lib/translations/qtermwidget_cs.ts
 lib/translations/qtermwidget_cy.ts
 lib/translations/qtermwidget_da.ts
 lib/translations/qtermwidget_de.ts
 lib/translations/qtermwidget_de_CH.ts
 lib/translations/qtermwidget_el.ts
 lib/translations/qtermwidget_en_GB.ts
 lib/translations/qtermwidget_es.ts
 lib/translations/qtermwidget_et.ts
 lib/translations/qtermwidget_fi.ts
 lib/translations/qtermwidget_fr.ts
 lib/translations/qtermwidget_gl.ts
 lib/translations/qtermwidget_he.ts
 lib/translations/qtermwidget_hr.ts
 lib/translations/qtermwidget_hu.ts
 lib/translations/qtermwidget_it.ts
 lib/translations/qtermwidget_ja.ts
 lib/translations/qtermwidget_ka.ts
 lib/translations/qtermwidget_kab.ts
 lib/translations/qtermwidget_ko.ts
 lib/translations/qtermwidget_lg.ts
 lib/translations/qtermwidget_lt.ts
 lib/translations/qtermwidget_nb_NO.ts
 lib/translations/qtermwidget_nl.ts
 lib/translations/qtermwidget_oc.ts
 lib/translations/qtermwidget_pl.ts
 lib/translations/qtermwidget_pt.ts
 lib/translations/qtermwidget_pt_BR.ts
 lib/translations/qtermwidget_ru.ts
 lib/translations/qtermwidget_si.ts
 lib/translations/qtermwidget_sk.ts
 lib/translations/qtermwidget_tr.ts
 lib/translations/qtermwidget_uk.ts
 lib/translations/qtermwidget_zh_CN.ts
 lib/translations/qtermwidget_zh_TW.ts
 qmltermwidget.pro
 qtermwidget.spec
 README.md
 src/QMLTermScrollbar.qml
 src/qmldir
 src/qmltermwidget_plugin.cpp
 src/qmltermwidget_plugin.h
 test-app/test-app.qml
Copyright: 1997-2020, qmltermwidget contributors
License: GPL-2+
Comment:
 No license headers provided in listed files.
 .
 Assuming GPL-2+ for these files as the majority of code files
 is also using the stronger GPL-2+ license.

Files: lib/ColorScheme.cpp
 lib/ColorScheme.h
 lib/Filter.cpp
 lib/Filter.h
 lib/KeyboardTranslator.cpp
 lib/KeyboardTranslator.h
 lib/ProcessInfo.h
 lib/ScreenWindow.cpp
 lib/ScreenWindow.h
Copyright: 2007, Robert Knight <robertknight@gmail.com>
  2007-2008, Robert Knight <robertknight@gmail.com>
License: GPL-2+

Files: lib/Character.h
 lib/CharacterColor.h
 lib/Emulation.h
 lib/Pty.h
 lib/Screen.h
 lib/TerminalDisplay.cpp
 lib/TerminalDisplay.h
 lib/Vt102Emulation.h
Copyright: 1997-1998, Lars Doelle <lars.doelle@on-line.de>
  2006-2008, Robert Knight <robertknight@gmail.com>
  2007-2008, Robert Knight <robertknight@gmail.com>
License: GPL-2+

Files: lib/kprocess.cpp
 lib/kprocess.h
 lib/kptydevice.h
 lib/kptyprocess.cpp
 lib/kptyprocess.h
Copyright: 2007, Oswald Buddenhagen <ossi@kde.org>
License: LGPL-2+

Files: lib/HistorySearch.cpp
 lib/HistorySearch.h
 lib/SearchBar.cpp
 lib/SearchBar.h
Copyright: 2013, Christian Surlykke
License: GPL-2+

Files: lib/History.cpp
 lib/History.h
 lib/Pty.cpp
Copyright: 1997-1998, Lars Doelle <lars.doelle@on-line.de>
License: GPL-2+

Files: lib/qtermwidget.json
Copyright: 2022-2025 LXQt
License: GPL-2+
Comment: Even though this file says GPLv2, README.md
 makes it clear that the license of this project is GPL-2+

Files: lib/Session.cpp
 lib/Session.h
Copyright: 1997-1998, Lars Doelle <lars.doelle@on-line.de>
  2006-2007, Robert Knight <robertknight@gmail.com>
  2007, Robert Knight <robertknight@gmail.com>
License: GPL-2+

Files: lib/ShellCommand.cpp
 lib/ShellCommand.h
Copyright: 2007, Robert Knight <robertknight@gmail.com>
  2008, e_k <e_k at users.sourceforge.net>
License: GPL-2+

Files: lib/BlockArray.cpp
 lib/BlockArray.h
Copyright: 2000, Stephan Kulow <coolo@kde.org>
  2008, e_k <e_k at users.sourceforge.net>
License: GPL-2+

Files: lib/ksession.cpp
 lib/ksession.h
Copyright: 2013, Dmitry Zagnoyko <hiroshidi@gmail.com>
License: GPL-2+

Files: lib/Screen.cpp
 lib/Vt102Emulation.cpp
Copyright: 1997-1998, Lars Doelle <lars.doelle@on-line.de>
  2007-2008, Robert Knight <robert.knight@gmail.com>
License: GPL-2+

Files: lib/kpty.h
 lib/kpty_p.h
Copyright: 2003, 2007, Oswald Buddenhagen <ossi@kde.org>
  2008, e_k <e_k at users.sourceforge.net>
License: LGPL-2+

Files: lib/TerminalCharacterDecoder.cpp
 lib/TerminalCharacterDecoder.h
Copyright: 2006-2008, Robert Knight <robertknight@gmail.com>
License: LGPL-2+

Files: lib/qtermwidget.cpp
 lib/qtermwidget.h
Copyright: 2008, e_k (e_k@users.sourceforge.net)
License: LGPL-2+

Files: lib/Emulation.cpp
Copyright: 1996, Matthias Ettrich <ettrich@kde.org>
  1997-1998, Lars Doelle <lars.doelle@on-line.de>
  2007-2008, Robert Knight <robertknight@gmail.com>
License: GPL-2+

Files: packaging/rpm/qmltermwidget.spec
Copyright: 2014, Markus S. <kamikazow@web.de>
License: GPL-2+

Files: lib/ProcessInfo.cpp
Copyright: 2007-2008, Robert Knight <robertknight@gmail.countm>
License: GPL-2+

Files: lib/kpty.cpp
Copyright: 2002, Waldo Bastian <bastian@kde.org>
  2002-2003, 2007, Oswald Buddenhagen <ossi@kde.org>
  2008, e_k <e_k at users.sourceforge.net>
License: LGPL-2+

Files: lib/qtermwidget_version.h.in
Copyright: 2020, Axel Kittenberger (axel.kittenberger@univie.ac.at)
License: LGPL-2+

Files: lib/qtermwidget_interface.h
Copyright: 2022, Francesc Martinez (info@francescmm.com)
License: LGPL-2+

Files: lib/kptydevice.cpp
Copyright: 2007, Oswald Buddenhagen <ossi@kde.org>
  2010, KDE e.V. <kde-ev-board@kde.org>
License: LGPL-2+

Files: cmake/FindUtf8Proc.cmake
Copyright: 2009-2011, Kitware, Inc.
  2009-2011, Philip Lowman <philip@yhbt.com>
License: BSD-3-clause

Files: debian/*
Copyright: 2022, Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
License: GPL-2+ or LGPL-2+ or BSD-3-clause

License: BSD-3-clause
 You may use this file under the terms of the BSD license as follows:
 .
 Redistribution and use in source and binary forms, with or without
 modification, are permitted provided that the following conditions are
 met:
   * Redistributions of source code must retain the above copyright
     notice, this list of conditions and the following disclaimer.
   * Redistributions in binary form must reproduce the above copyright
     notice, this list of conditions and the following disclaimer in
     the documentation and/or other materials provided with the
     distribution.
   * Neither the name of Digia Plc and its Subsidiary(-ies) nor the names
     of its contributors may be used to endorse or promote products derived
     from this software without specific prior written permission.
 .
 THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

License: GPL-2+
 This program is free software; you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by
 the Free Software Foundation; either version 2 of the License, or
 (at your option) any later version.
 .
 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 GNU General Public License for more details.
 .
 On Debian systems, the complete text of the GNU General
 Public License can be found in `/usr/share/common-licenses/GPL-2'.

License: LGPL-2+
 This library is free software; you can redistribute it and/or
 modify it under the terms of the GNU Lesser General Public
 License as published by the Free Software Foundation; either
 version 2 of the License, or (at your option) any later version.
 .
 This library is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 Lesser General Public License for more details.
 .
 On Debian systems, the full text of the GNU Lesser General Public License
 version 2 can be found in the file /usr/share/common-licenses/LGPL-2.

DFSG Assistant LLM REVIEW 1 blocker, 3 important, 5 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 0 hours ago.

Proposes a replacement debian/watch: debian/watch in version 5 format

Report◂

DFSG NEW review for qt6-qmltermwidget version 0.2+git20260531-1

Summary

  • Licensing is DFSG-compliant and debian/copyright is accurate: No
  • Packaging is of good quality: No
  • Issues: 1 blocker, 3 important, 5 minor
  • debian/watch: old format (version 4)
  • debian/copyright: machine-readable
  • Scan before the review: nothing found

Licensing

The source is free software throughout - GPL-2+, LGPL-2+, BSD-3-clause and public-domain code, all mutually compatible - and I found no non-commercial, no-modification or field-of-use term anywhere in the tree, so there is no DFSG problem. debian/copyright is nevertheless inaccurate: it has no catch-all stanza and none of its stanzas covers the four top-level licence files (LICENSE, LICENSE.LGPL2+, LICENSE.BSD-3-clause, COPYING-CMAKE-SCRIPTS); lib/konsole_wcwidth.cpp/h are declared GPL-2+ by the catch-all stanza although they carry Markus Kuhn's public-domain notice and Waldo Bastian's KDE adaptation; and the BSD-3-clause text reproduced in the file is the Qt/Digia wording, not the University of California text that the package's BSD files carry.

Packaging

The mechanics are sound: debhelper compat 13 with the dh sequencer, hardening=+all, a clean arch:any/arch:all split with a Multi-Arch: foreign data package, correct substvars, 3.0 (quilt), current Standards-Version 4.7.4, no maintainer scripts. But the rename from qmltermwidget to qt6-qmltermwidget left the binary package qmltermwidget-common with the name the existing qmltermwidget source already produces, so the upload cannot be accepted as it stands, and it left leftovers: a doc directory named after the old qml-module-termwidget, a description promising a test application that is not installed, and a stale licensecheck debian/copyright.in. The Debian-only patches 0001-0005 also carry no DEP-3 origin or forwarded information.

Issues

blocker licensing 1. debian/copyright matches no stanza to LICENSE, LICENSE.LGPL2+, LICENSE.BSD-3-clause and COPYING-CMAKE-SCRIPTS (no Files: * catch-all) ◂
  • Files: debian/copyright:5-120 (first stanza, the only broad one), LICENSE, LICENSE.LGPL2+, LICENSE.BSD-3-clause, COPYING-CMAKE-SCRIPTS
  • Basis: checked, in the package or with a reference tool
  • Evidence: The first stanza begins Files: .editorconfig and enumerates names only; a grep for Files: *, LICENSE and COPYING in debian/copyright returns nothing. The four files exist at the tree root; LICENSE and LICENSE.LGPL2+ are the GPL-2 and LGPL-2 texts, LICENSE.BSD-3-clause and COPYING-CMAKE-SCRIPTS both begin Copyright (c) The Regents of the University of California.
  • Problem: In copyright-format 1.0 a file is described only if a Files stanza matches it (section 6.9); with no catch-all, these four files have neither a copyright holder nor a licence in debian/copyright, and the two BSD files carry a copyright notice that the file does not mention at all. This is the inaccuracy that must be fixed before acceptance, per Policy 12.5.
  • Fix: Add a Files: * stanza (or list them) with Copyright: 1989, 1991 Free Software Foundation, Inc. for the GPL/LGPL texts and Copyright: The Regents of the University of California for the two BSD files, and the matching License: short names.
important licensing 2. lib/konsole_wcwidth.cpp/h are declared GPL-2+ with the headerless-files stanza although they carry Markus Kuhn's public-domain notice and Waldo Bastian's adaptation ◂
  • Files: lib/konsole_wcwidth.cpp:1-7, lib/konsole_wcwidth.h:1-5, debian/copyright:58-59,115-120
  • Basis: checked, in the package or with a reference tool
  • Evidence: The files say Markus Kuhn -- 2001-01-12 -- public domain and Adaptations for KDE by Waldo Bastian <bastian@kde.org>, Rewritten for QT4 by e_k <e_k at users.sourceforge.net>; the stanza covering them says Copyright: 1997-2020, qmltermwidget contributors, License: GPL-2+ and Comment: No license headers provided in listed files. ... Assuming GPL-2+.
  • Problem: The comment is false for these two files, Markus Kuhn is named nowhere in debian/copyright (Waldo Bastian appears only in the lib/kpty.cpp stanza), and the public-domain provenance of the wcwidth code is replaced by a GPL-2+ claim.
  • Fix: Give these two files their own stanza naming Markus Kuhn (public domain), Waldo Bastian and e_k, and state the licence as GPL-2+ for the qtermwidget modifications.
important licensing 3. The BSD-3-clause text in debian/copyright is the Qt/Digia wording; the package's BSD files carry the University of California text ◂
  • Files: debian/copyright:258-289, LICENSE.BSD-3-clause, COPYING-CMAKE-SCRIPTS, cmake/FindUtf8Proc.cmake:24-35
  • Basis: checked, in the package or with a reference tool
  • Evidence: debian/copyright has You may use this file under the terms of the BSD license as follows: with * Neither the name of Digia Plc and its Subsidiary(-ies) nor the names of its contributors; LICENSE.BSD-3-clause and COPYING-CMAKE-SCRIPTS have Copyright (c) The Regents of the University of California. with 3. Neither the name of the University nor the names of its contributors, and cmake/FindUtf8Proc.cmake says Distributed under the OSI-approved BSD License (the "License"); see accompanying file Copyright.txt for details.
  • Problem: The licence text that copyright-format 1.0 section 5.3 asks for is the one that actually applies, and a BSD licence requires the copyright notice and conditions to be reproduced as given. The text used here names Digia, a party with no connection to these files, and does not reproduce the UCB notice.
  • Fix: Replace the stand-alone BSD-3-clause paragraph with the University of California text, and name The Regents of the University of California for the two licence files in addition to Kitware/Philip Lowman for FindUtf8Proc.cmake.
important packaging 4. Binary package qmltermwidget-common keeps the name that the still-existing source package qmltermwidget builds ◂
  • Files: debian/control (Package: qmltermwidget-common), debian/changelog:3
  • Basis: inferred from what was read, not seen directly
  • Evidence: The .dsc lists Binary: qml6-module-termwidget, qmltermwidget-common for source qt6-qmltermwidget, while apt-cache shows qmltermwidget-common with Source: qmltermwidget, Version: 0.2+git20220109.6322802-4; the changelog says Rename source package because upstream only support qt6 and nothing about removing the old source or its binaries.
  • Problem: A binary package is built by one source package; while qmltermwidget still builds qmltermwidget-common the new source cannot also claim it, so the upload fails at the archive. If qmltermwidget is removed instead, the old Qt5 qml-module-termwidget (apt-cache: Depends: ... qmltermwidget-common (>= 0.2+git20220109.6322802-4)) stays installed on users' systems against a common package that now ships the Qt6 data layout, and this control file has no Breaks/Replaces for it. Policy 7.6.1 requires binary packages from a renamed source to carry the upgrade relations.
  • Fix: Rename the data package (e.g. qt6-qmltermwidget-common) so the source rename is complete, or keep the old name but coordinate the removal of qmltermwidget and add Breaks/Replaces: qml-module-termwidget (<< ...) for the retired Qt5 module; say which in the changelog.
minor packaging 5. rules installs README.kb-layouts into /usr/share/doc/qml-module-termwidget, a package that no longer exists ◂
  • Files: debian/rules:27-31, debian/qmltermwidget-common.install
  • Basis: inferred from what was read, not seen directly
  • Evidence: mkdir -p debian/tmp/usr/share/doc/qml-module-termwidget/ and mv debian/tmp/usr/share/QMLTermWidget/kb-layouts/README debian/tmp/usr/share/doc/qml-module-termwidget/README.kb-layouts; debian/qmltermwidget-common.install is just usr/share/, so dh_install copies it into that package, where the binary is qml6-module-termwidget and the doc directory is named after the old Qt5 package.
  • Problem: qmltermwidget-common ends up with a stray /usr/share/doc/qml-module-termwidget/ holding documentation that is not in the package's own /usr/share/doc/qmltermwidget-common/, and the directory name contradicts the package names of this source. The rename was not carried through here.
  • Fix: Use the current package name in the mkdir/mv (or a debian/.docs entry), so the file lands in the doc directory of the package it is shipped in.
minor packaging 6. qml6-module-termwidget's description advertises a test application that is not shipped ◂
  • Files: debian/control (qml6-module-termwidget Description), qmltermwidget.pro, debian/qml6-module-termwidget.install, debian/qmltermwidget-common.install
  • Basis: checked, in the package or with a reference tool
  • Evidence: The description says This package contains the QML module and also a simple test application., but qmltermwidget.pro only lists test-app/test-app.qml under OTHER_FILES and its INSTALLS hold target, qmldir, assets, colorschemes, kblayouts and scrollbar only; the two install files pick up usr/lib/ and usr/share/ from the build tree.
  • Problem: Policy 3.4 requires the description to be accurate; a user looking for the example terminal will not find it in any binary package of this source.
  • Fix: Drop the sentence, or install test-app/test-app.qml (and its runtime needs) into a package and keep the sentence.
minor packaging 7. debian/copyright.in is a leftover licensecheck stub with FIXME and UNKNOWN entries that contradicts debian/copyright ◂
  • Files: debian/copyright.in
  • Basis: checked, in the package or with a reference tool
  • Evidence: Upstream-Name: FIXME, Disclaimer: Autogenerated by licensecheck, Copyright: NONE, License: UNKNOWN, and it lists debian/qt6-qmltermwidget-common.install, which does not exist in this source (the file is debian/qmltermwidget-common.install). It also gives LICENSE.BSD-3-clause the holder The Regents of the University of California and LICENSE as GPL-2, which debian/copyright lacks.
  • Problem: It is a stale generated file carrying wrong licensing statements and a reference to a file that no longer exists; it is dead weight in the source package and could be mistaken for packaging, or regenerated over the real copyright file.
  • Fix: Delete it, or regenerate debian/copyright from it properly and keep them in sync.
minor packaging 8. Patches 0001-0005 have no DEP-3 Origin or Forwarded field although they are Debian-only and numbered as upstream work ◂
  • Files: debian/patches/0001_Expose-ColorSchemeManager-and-ColorScheme-to-QML.patch, debian/patches/0002_Expose-QMLTermWidget-foreground-and-background-color.patch, debian/patches/0003_Make-QmlTermWidget-scrollbarCurrentValue-property-wr.patch, debian/patches/0004_Add-QMLTermWidget-methods-to-query-whether-clipboard.patch, debian/patches/0005_Apply-color-scheme-if-changed.patch, debian/patches/README
  • Basis: checked, in the package or with a reference tool
  • Evidence: Each patch starts with a git From <sha> header, a Subject: [PATCH n/5] ... and Signed-off-by: Mike Gabriel <...>, with no Description:, Origin: or Forwarded: field (0006 has Origin: but no Forwarded:). debian/patches/README says 0xxx: Grabbed from upstream development.
  • Problem: These are Debian-only API additions that lomiri-terminal-app needs (new QML properties and methods); nothing records where they came from or whether they were offered upstream, and their 0xxx numbering according to this source's own README says the opposite. Policy 4.3 asks for patches to be documented and forwarded.
  • Fix: Add DEP-3 Description:, Origin: and Forwarded: (or a Bug: reference) to 0001-0006 and renumber them as 1xxx/2xxx per debian/patches/README.
minor packaging 9. debian/watch is in the old version 4 format ◂
  • Files: debian/watch
  • Basis: found by the review tooling's own checks
  • Evidence: version=4
  • Problem: Version 5 is the current format of debian/watch.
  • Fix: Convert it to version 5; a mechanical conversion is under Proposed changes.
Verified ◂
  • The scan listed no files and reported that every holder it found is named in debian/copyright; the author check covers the tree, but it missed Markus Kuhn, whom I report separately, and the scan's clean result on built files is consistent with what I read.
  • Read all of debian/ - control, rules, changelog, copyright and copyright.in, both .install files, clean, source/format, source/lintian-overrides, salsa-ci.yml, upstream/metadata, patches/series, patches/README and all six patches - plus qmltermwidget.pro, lib.pri, .editorconfig, .gitignore, .translation-update, AUTHORS, README.md, docs/configuration.md, both .spec files, test-app/test-app.qml and the whole src/ and cmake/ directories.
  • Read the copyright and licence headers of every lib/.cpp and lib/.h: they declare GPL-2+ or LGPL-2+ ('GNU General Public' or 'GNU Lesser/Library General Public ... either version 2 ... or any later version') and their holders (Robert Knight, Lars Doelle, Matthias Ettrich, Oswald Buddenhagen, Waldo Bastian, Christian Surlylke, Dmitry Zagnoyko, Stephan Kulow, e_k, Francesc Martinez, Axel Kittenberger, KDE e.V., Markus S.) are in debian/copyright under the right files.
  • No DFSG-restricted wording anywhere in the tree: no non-commercial, no-modification, field-of-use or 'All rights reserved' term in code, data or docs; the only licence texts are GPL-2, LGPL-2 and BSD-3, all compatible with the GPL-2+ binary.
  • Generated files have their inputs shipped: lib/LineFont.h (marked 'Autogenerated by "fontembedder ./linefont.src"') against lib/LineFont.src; lib/qtermwidget_version.h against lib/qtermwidget_version.h.in; lib/DefaultTranslatorText.h and lib/ExtendedDefaultTranslator.h are embedded keytab text and the keytabs are in lib/kb-layouts/.
  • The .ts translations, the color schemes, the keytabs, lib/SearchBar.ui, lib/qtermwidget_export.h, lib/qtools.*, docs/configuration.md, src/QMLTermScrollbar.qml, src/qmldir and test-app/test-app.qml have no notices of their own and are covered by the first stanza's project-wide GPL-2+; lib/qtermwidget.json ("Vendor": "LXQt", "License": "GPLv2") is described by its own stanza whose comment refers to README.md's GPL-2.0-or-later statement.
  • Standards-Version 4.7.4 against the reviewing system's Policy 4.7.4.1 (debian-policy from apt-cache), so current. Build-Depends satisfied on paper: qt6-base-dev/-private-dev and qt6-declarative-private-dev provide qmake6 and the private headers the plugin uses; no external library is linked, utf8proc being optional and not enabled by qmltermwidget.pro.
  • Debhelper compat 13 with dh $@, hardening=+all, no maintainer scripts, no debconf, 3.0 (quilt), .pc/ ignored; ${misc:Depends}/${shlibs:Depends} present, so no substvar fault. No autopkgtests, which is not a defect.
  • uscan found the packaged version as the newest upstream release (upstream 0.2+git20260531, packaged 0.2+git20260531).
  • Every pointer of debian/copyright to /usr/share/common-licenses names a file that is there (GPL-2, LGPL-2).
Not confirmed ◂
  • Whether the qmltermwidget source package is to be removed from the archive; the package does not say, and that decides how the qmltermwidget-common name clash must be resolved.
  • What the current Qt5 qmltermwidget-common package installs, so I could not establish whether the new common package's file layout keeps the old qml-module-termwidget working after an upgrade.
  • Build and test results were not run here, as instructed.
Proposed: debian/watch in version 5 format ◂

debian/watch is in an old format. This is the conversion made by uscan --update-watchfile, which has not been run against the upstream site: some defaults differ in version 5, so test it with uscan --report before use.

Version: 5

Source: https://github.com/swordfish90/qmltermwidget
Matching-Pattern: HEAD
Mode: git
Pgpmode: none
Git-Pretty: 0.2+git%cd

Uploader's response to the LLM review

Waiting for the uploader's response until , because the review found serious issues.

Back to Dashboard | View all reviews for this package