Review: qt6-qmltermwidget 0.2+git20260531-2
New Package Report
.changes
| Source | qt6-qmltermwidget |
|---|---|
| Version | 0.2+git20260531-2 |
| Changed-By | Jeremy Bícha <jbicha@ubuntu.com> |
| Architecture | source amd64 all |
| Distribution | experimental |
| Date | Sat, 07 Nov 2026 13:27:07 +0100 |
Changelog
qt6-qmltermwidget (0.2+git20260531-2) experimental; urgency=medium
.
* Team upload
* Update debian/copyright per initial DFSG review
* Update package description per initial DFSG review
* Adjust README installation location for package rename
* qmltermwidget-common is intentionally not renamed because its
files are still compatible with the qt5 version.dsc
| Package-List | qml6-module-termwidget deb libs optional arch=any qmltermwidget-common deb libs optional arch=all |
|---|---|
| Section | libs |
| Priority | optional |
| Component | main |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://github.com/Swordfish90/qmltermwidget
Upstream-Name: qmltermwidget
Files: .editorconfig
.gitignore
.translation-update
AUTHORS
cmake/qtermwidget6-config.cmake.in
docs/configuration.md
lib.pri
lib/ColorTables.h
lib/DefaultTranslatorText.h
lib/ExtendedDefaultTranslator.h
lib/LineFont.h
lib/LineFont.src
lib/SearchBar.ui
lib/color-schemes/BlackOnLightYellow.colorscheme
lib/color-schemes/BlackOnRandomLight.colorscheme
lib/color-schemes/BlackOnWhite.colorscheme
lib/color-schemes/BreezeModified.colorscheme
lib/color-schemes/DarkPastels.colorscheme
lib/color-schemes/Falcon.colorscheme
lib/color-schemes/GreenOnBlack.colorscheme
lib/color-schemes/Linux.colorscheme
lib/color-schemes/Solarized.colorscheme
lib/color-schemes/SolarizedLight.colorscheme
lib/color-schemes/Tango.colorscheme
lib/color-schemes/Ubuntu.colorscheme
lib/color-schemes/WhiteOnBlack.colorscheme
lib/color-schemes/cool-retro-term.colorscheme
lib/color-schemes/historic/BlackOnLightColor.schema
lib/color-schemes/historic/DarkPicture.schema
lib/color-schemes/historic/Example.Schema
lib/color-schemes/historic/GreenOnBlack.schema
lib/color-schemes/historic/GreenTint.schema
lib/color-schemes/historic/GreenTint_MC.schema
lib/color-schemes/historic/LightPicture.schema
lib/color-schemes/historic/Linux.schema
lib/color-schemes/historic/README.Schema
lib/color-schemes/historic/README.default.Schema
lib/color-schemes/historic/Transparent.schema
lib/color-schemes/historic/Transparent_MC.schema
lib/color-schemes/historic/Transparent_darkbg.schema
lib/color-schemes/historic/Transparent_lightbg.schema
lib/color-schemes/historic/XTerm.schema
lib/color-schemes/historic/syscolor.schema
lib/color-schemes/historic/vim.schema
lib/default.keytab
lib/kb-layouts/README
lib/kb-layouts/default.keytab
lib/kb-layouts/historic/vt100.keytab
lib/kb-layouts/historic/x11r5.keytab
lib/kb-layouts/linux.keytab
lib/kb-layouts/macbook.keytab
lib/kb-layouts/solaris.keytab
lib/kb-layouts/vt420pc.keytab
lib/mac-vkcode.h
lib/qtermwidget_export.h
lib/qtermwidget_version.h
lib/tools.cpp
lib/tools.h
lib/translations/CMakeLists.txt
lib/translations/qtermwidget.ts
lib/translations/qtermwidget_ar.ts
lib/translations/qtermwidget_arn.ts
lib/translations/qtermwidget_ast.ts
lib/translations/qtermwidget_bg.ts
lib/translations/qtermwidget_ca.ts
lib/translations/qtermwidget_cs.ts
lib/translations/qtermwidget_cy.ts
lib/translations/qtermwidget_da.ts
lib/translations/qtermwidget_de.ts
lib/translations/qtermwidget_de_CH.ts
lib/translations/qtermwidget_el.ts
lib/translations/qtermwidget_en_GB.ts
lib/translations/qtermwidget_es.ts
lib/translations/qtermwidget_et.ts
lib/translations/qtermwidget_fi.ts
lib/translations/qtermwidget_fr.ts
lib/translations/qtermwidget_gl.ts
lib/translations/qtermwidget_he.ts
lib/translations/qtermwidget_hr.ts
lib/translations/qtermwidget_hu.ts
lib/translations/qtermwidget_it.ts
lib/translations/qtermwidget_ja.ts
lib/translations/qtermwidget_ka.ts
lib/translations/qtermwidget_kab.ts
lib/translations/qtermwidget_ko.ts
lib/translations/qtermwidget_lg.ts
lib/translations/qtermwidget_lt.ts
lib/translations/qtermwidget_nb_NO.ts
lib/translations/qtermwidget_nl.ts
lib/translations/qtermwidget_oc.ts
lib/translations/qtermwidget_pl.ts
lib/translations/qtermwidget_pt.ts
lib/translations/qtermwidget_pt_BR.ts
lib/translations/qtermwidget_ru.ts
lib/translations/qtermwidget_si.ts
lib/translations/qtermwidget_sk.ts
lib/translations/qtermwidget_tr.ts
lib/translations/qtermwidget_uk.ts
lib/translations/qtermwidget_zh_CN.ts
lib/translations/qtermwidget_zh_TW.ts
qmltermwidget.pro
qtermwidget.spec
README.md
src/QMLTermScrollbar.qml
src/qmldir
src/qmltermwidget_plugin.cpp
src/qmltermwidget_plugin.h
test-app/test-app.qml
Copyright: 1997-2020, qmltermwidget contributors
License: GPL-2+
Comment:
No license headers provided in listed files.
.
Assuming GPL-2+ for these files as the majority of code files
is also using the stronger GPL-2+ license.
Files: lib/konsole_wcwidth.*
Copyright: 2001-01-12 Markus Kuhn
Waldo Bastian <bastian@kde.org>
License: GPL-2+
Comment: Original implementation by Markus Kuhn was released to the
public domain, but it was rewritten in C++ for KDE
Files: lib/ColorScheme.cpp
lib/ColorScheme.h
lib/Filter.cpp
lib/Filter.h
lib/KeyboardTranslator.cpp
lib/KeyboardTranslator.h
lib/ProcessInfo.h
lib/ScreenWindow.cpp
lib/ScreenWindow.h
Copyright: 2007, Robert Knight <robertknight@gmail.com>
2007-2008, Robert Knight <robertknight@gmail.com>
License: GPL-2+
Files: lib/Character.h
lib/CharacterColor.h
lib/Emulation.h
lib/Pty.h
lib/Screen.h
lib/TerminalDisplay.cpp
lib/TerminalDisplay.h
lib/Vt102Emulation.h
Copyright: 1997-1998, Lars Doelle <lars.doelle@on-line.de>
2006-2008, Robert Knight <robertknight@gmail.com>
2007-2008, Robert Knight <robertknight@gmail.com>
License: GPL-2+
Files: lib/kprocess.cpp
lib/kprocess.h
lib/kptydevice.h
lib/kptyprocess.cpp
lib/kptyprocess.h
Copyright: 2007, Oswald Buddenhagen <ossi@kde.org>
License: LGPL-2+
Files: lib/HistorySearch.cpp
lib/HistorySearch.h
lib/SearchBar.cpp
lib/SearchBar.h
Copyright: 2013, Christian Surlykke
License: GPL-2+
Files: lib/History.cpp
lib/History.h
lib/Pty.cpp
Copyright: 1997-1998, Lars Doelle <lars.doelle@on-line.de>
License: GPL-2+
Files: lib/qtermwidget.json
Copyright: 2022-2025 LXQt
License: GPL-2+
Comment: Even though this file says GPLv2, README.md
makes it clear that the license of this project is GPL-2+
Files: lib/Session.cpp
lib/Session.h
Copyright: 1997-1998, Lars Doelle <lars.doelle@on-line.de>
2006-2007, Robert Knight <robertknight@gmail.com>
2007, Robert Knight <robertknight@gmail.com>
License: GPL-2+
Files: lib/ShellCommand.cpp
lib/ShellCommand.h
Copyright: 2007, Robert Knight <robertknight@gmail.com>
2008, e_k <e_k at users.sourceforge.net>
License: GPL-2+
Files: lib/BlockArray.cpp
lib/BlockArray.h
Copyright: 2000, Stephan Kulow <coolo@kde.org>
2008, e_k <e_k at users.sourceforge.net>
License: GPL-2+
Files: lib/ksession.cpp
lib/ksession.h
Copyright: 2013, Dmitry Zagnoyko <hiroshidi@gmail.com>
License: GPL-2+
Files: lib/Screen.cpp
lib/Vt102Emulation.cpp
Copyright: 1997-1998, Lars Doelle <lars.doelle@on-line.de>
2007-2008, Robert Knight <robert.knight@gmail.com>
License: GPL-2+
Files: lib/kpty.h
lib/kpty_p.h
Copyright: 2003, 2007, Oswald Buddenhagen <ossi@kde.org>
2008, e_k <e_k at users.sourceforge.net>
License: LGPL-2+
Files: lib/TerminalCharacterDecoder.cpp
lib/TerminalCharacterDecoder.h
Copyright: 2006-2008, Robert Knight <robertknight@gmail.com>
License: LGPL-2+
Files: lib/qtermwidget.cpp
lib/qtermwidget.h
Copyright: 2008, e_k (e_k@users.sourceforge.net)
License: LGPL-2+
Files: lib/Emulation.cpp
Copyright: 1996, Matthias Ettrich <ettrich@kde.org>
1997-1998, Lars Doelle <lars.doelle@on-line.de>
2007-2008, Robert Knight <robertknight@gmail.com>
License: GPL-2+
Files: packaging/rpm/qmltermwidget.spec
Copyright: 2014, Markus S. <kamikazow@web.de>
License: GPL-2+
Files: lib/ProcessInfo.cpp
Copyright: 2007-2008, Robert Knight <robertknight@gmail.countm>
License: GPL-2+
Files: lib/kpty.cpp
Copyright: 2002, Waldo Bastian <bastian@kde.org>
2002-2003, 2007, Oswald Buddenhagen <ossi@kde.org>
2008, e_k <e_k at users.sourceforge.net>
License: LGPL-2+
Files: lib/qtermwidget_version.h.in
Copyright: 2020, Axel Kittenberger (axel.kittenberger@univie.ac.at)
License: LGPL-2+
Files: lib/qtermwidget_interface.h
Copyright: 2022, Francesc Martinez (info@francescmm.com)
License: LGPL-2+
Files: lib/kptydevice.cpp
Copyright: 2007, Oswald Buddenhagen <ossi@kde.org>
2010, KDE e.V. <kde-ev-board@kde.org>
License: LGPL-2+
Files: cmake/FindUtf8Proc.cmake
Copyright: 2009-2011, Kitware, Inc.
2009-2011, Philip Lowman <philip@yhbt.com>
License: BSD-3-clause
Files: debian/*
Copyright: 2022, Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
License: GPL-2+ or LGPL-2+ or BSD-3-clause
License: BSD-3-clause
Copyright (c) The Regents of the University of California.
All rights reserved.
.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
1. Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
3. Neither the name of the University nor the names of its contributors
may be used to endorse or promote products derived from this software
without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
SUCH DAMAGE.
License: GPL-2+
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
.
On Debian systems, the complete text of the GNU General
Public License can be found in `/usr/share/common-licenses/GPL-2'.
License: LGPL-2+
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
.
On Debian systems, the full text of the GNU Lesser General Public License
version 2 can be found in the file /usr/share/common-licenses/LGPL-2.
DFSG Assistant LLM REVIEW 1 blocker, 1 important, 4 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 7 days ago.
Proposes a replacement debian/watch:
debian/watch in version 5 format
Report
DFSG NEW review for qt6-qmltermwidget version 0.2+git20260531-2
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: No - Packaging is of good quality: Yes
- Issues: 1 blocker, 1 important, 4 minor
- debian/watch: old format (version 4)
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
The source is DFSG-free: GPL-2+ for most of lib/ and src/, LGPL-2+ for the KDE-derived kprocess/kpty/qtermwidget files and BSD-3-clause for the cmake module, all compatible and all documented in DEP-5 form with the full texts or common-licenses pointers. debian/copyright is nevertheless not accurate for every file: three holders named in the files' own headers (e_k 2008 for lib/Session.cpp and .h, Maxim Bourmistrov for the eight QTerminal-derived files, Adriaan de Groot for kptydevice.cpp) are missing from the stanzas that apply to them, and there is no Files: * stanza, so LICENSE, LICENSE.LGPL2+, LICENSE.BSD-3-clause and COPYING-CMAKE-SCRIPTS are covered by nothing. No DFSG violation was found: no non-free clause, no file without a licence, no missing source for a built file.
Packaging
The packaging is in good shape: 3.0 (quilt), compat 13 with a plain dh rules file, two sensible binary packages, patches with git-style headers and descriptions, current Standards-Version, Vcs-* and Homepage set, and the split of arch-dependent plugin and arch-independent data with symlinks that resolve correctly. Three minor defects remain: the kb-layouts README is installed into the other binary package's doc directory, the QML component shipped by the plugin imports QtQuick without a dependency on qml6-module-qtquick, and the stale licensecheck draft debian/copyright.in is still in debian/.
Issues
blocker licensing 1. Copyright stanzas omit holders named in the file headers: e_k (2008) for lib/Session.cpp/.h, Maxim Bourmistrov for the QTerminal-derived files, Adriaan de Groot for kptydevice.cpp ◂
- Files:
debian/copyright:181-186 (Files: lib/Session.cpp, lib/Session.h); lib/Session.cpp:7; lib/Session.h:7,lib/Pty.cpp:4; lib/Pty.h:4; lib/kprocess.cpp:4; lib/kprocess.h:4,lib/kptydevice.cpp:4 and :15; lib/kptydevice.h:4; lib/kptyprocess.cpp:4; lib/kptyprocess.h:4,debian/copyright:169-173 (Pty), :154-160 (kprocess), :211-215 (kpty_p.h group), :241-245 (kpty.cpp) - Basis: checked, in the package or with a reference tool
- Evidence: lib/Session.cpp and lib/Session.h end their copyright block with
Rewritten for QT4 by e_k <e_k at users.sourceforge.net>, Copyright (C)2008, but their stanza lists only1997-1998, Lars Doelleand2006-2007, Robert Knight/2007, Robert Knight. The eight QTerminal files carryThis file was un-linked from KDE and modified by Maxim Bourmistrov <maxim@unixconn.com>while the Pty.cpp stanza names only1997-1998, Lars Doelle, and the kprocess/kptydevice/kptyprocess stanzas only Oswald Buddenhagen (kptydevice.cpp also KDE e.V.). lib/kptydevice.cpp:15 addsAuthor Adriaan de Groot <groot@kde.org>under the KDE e.V. copyright line, which the stanza does not name. - Problem: debian/copyright must record the copyright holders of each file. A holder whose own copyright line appears in the file is left out of the stanza that covers it, so the record is inaccurate for 11 files even though the same names appear elsewhere in the file.
- Fix: Add
2008, e_k <e_k at users.sourceforge.net>to the lib/Session.cpp/lib/Session.h stanza,2008, Maxim Bourmistrov <maxim@unixconn.com>to the stanzas of lib/Pty., lib/kprocess., lib/kptydevice.* and lib/kptyprocess.*, andAdriaan de Groot <groot@kde.org>to the lib/kptydevice.cpp stanza.
important licensing 2. debian/copyright has no Files: * stanza and leaves LICENSE, LICENSE.LGPL2+, LICENSE.BSD-3-clause and COPYING-CMAKE-SCRIPTS covered by no stanza ◂
- Files:
debian/copyright:5-114 (first, explicit list of files, with no catch-all),LICENSE; LICENSE.LGPL2+; LICENSE.BSD-3-clause; COPYING-CMAKE-SCRIPTS - Basis: checked, in the package or with a reference tool
- Evidence: The first stanza is an explicit enumeration of upstream files (
Files: .editorconfig...test-app/test-app.qml), and the remaining stanzas name individual lib/ files or debian/*; none of the four files at the top of the tree appears in any Files field, and there is noFiles: *. - Problem: Every file in the source should be accounted for by a Files stanza. These four are the upstream copies of the GPL-2, LGPL-2 and BSD-3-clause texts (COPYING-CMAKE-SCRIPTS being the Regents/Kitware BSD-3 text for cmake/FindUtf8Proc.cmake); their licence wording is present as stand-alone License paragraphs, but the files themselves have no copyright holder or licence recorded, so the copyright file does not describe the whole tree (Policy 12.5).
- Fix: Add a
Files: *stanza (or one stanza per file) naming the Free Software Foundation for LICENSE/LICENSE.LGPL2+ and the Regents of the University of California / Kitware, Inc. for LICENSE.BSD-3-clause and COPYING-CMAKE-SCRIPTS, with the licences already defined in the file.
minor packaging 3. README.kb-layouts is installed by qmltermwidget-common into /usr/share/doc/qml6-module-termwidget/, another package's documentation directory ◂
- Files:
debian/rules:20-21 (mkdir/mv into debian/tmp/usr/share/doc/qml6-module-termwidget/),debian/qmltermwidget-common.install - Basis: checked, in the package or with a reference tool
- Evidence: rules creates
debian/tmp/usr/share/doc/qml6-module-termwidget/and moves.../kb-layouts/READMEinto it, whiledebian/qmltermwidget-common.installis the single lineusr/share/. dh_install globs everything under debian/tmp/usr/share for that package (dh_install hands every match to cp -a), so the README is shipped by qmltermwidget-common as /usr/share/doc/qml6-module-termwidget/README.kb-layouts instead of in the module package's or common's own doc directory. - Problem: One binary package ships a file inside the other binary package's /usr/share/doc directory; the intent of the mkdir/mv is not achieved, and the module package's doc directory is partly owned by qmltermwidget-common.
- Fix: Create debian/tmp/usr/share/doc/qmltermwidget-common/ instead (the kb-layouts data lives in that package), or install the file with debian/qmltermwidget-common.docs and exclude it from the usr/share/ glob.
minor packaging 4. qml6-module-termwidget does not depend on qml6-module-qtquick although the QML component it ships imports QtQuick 2.0 ◂
- Files:
src/QMLTermScrollbar.qml:1,debian/control (Package: qml6-module-termwidget, Depends) - Basis: inferred from what was read, not seen directly
- Evidence: src/QMLTermScrollbar.qml begins
import QtQuick 2.0and is installed into the module directory by the qmake project (scrollbar.files); qml6-module-termwidget depends only on qmltermwidget-common, ${misc:Depends} and ${shlibs:Depends}. ${shlibs:Depends} brings libqt6quick6, which has no relationship on qml6-module-qtquick (a separate binary package of qt6-declarative). - Problem: Importing QMLTermScrollbar on a system that has only this package and its dependencies fails at the QtQuick import; the QML module dependency of the QML files shipped is not declared.
- Fix: Add qml6-module-qtquick to Depends of qml6-module-termwidget.
minor packaging 5. debian/copyright.in is a stale licensecheck draft with FIXME/UNKNOWN placeholders still shipped in debian/ ◂
- Files:
debian/copyright.in - Basis: checked, in the package or with a reference tool
- Evidence: The file begins
Upstream-Name: FIXME,Upstream-Contact: FIXME,Source: FIXME,Disclaimer: Autogenerated by licensecheck, and its stanzas containCopyright: NONE/License: UNKNOWN/FIXME; it even listsdebian/qt6-qmltermwidget-common.install, which does not exist (the file is debian/qmltermwidget-common.install). Nothing in debian/rules or elsewhere refers to copyright.in. - Problem: A dead, half-finished copyright draft is part of the source package and is the file a reviewer or a future maintainer is likely to edit by mistake; it is covered by the debian/* stanza as if it were packaging source.
- Fix: Delete debian/copyright.in (or regenerate it from debian/copyright if the team really wants to keep the template).
minor packaging 6. debian/watch is in the old version 4 format ◂
- Files:
debian/watch - Basis: found by the review tooling's own checks
- Evidence:
version=4 - Problem: Version 5 is the current format of
debian/watch. - Fix: Convert it to version 5; a mechanical conversion is under Proposed changes.
Verified ◂
- Prescan accounted for: it listed no built files, archives, minified code, PDFs, images or fonts, and no non-free licence wording. Its author check matches holder names anywhere in debian/copyright, so it cannot see a holder omitted from the stanza that applies to one file; the omissions reported above come from reading each file's header against its own stanza.
- All licences are free and mutually compatible: GPL-2+ for most of lib/ and src/ (headers say
either version 2 of the License, or (at your option) any later version), LGPL-2+ for kprocess., kpty., qtermwidget., TerminalCharacterDecoder.* and qtermwidget_interface.h (GNU Library General Public License ... either version 2 ... or (at your option) any later version), BSD-3-clause for cmake/FindUtf8Proc.cmake; the short names and the presence or absence ofor latermatch the headers. GPL-2+ and LGPL-2+ can be combined in the one plugin. - Licence texts: LICENSE is the GPL-2 text, LICENSE.LGPL2+ the LGPL-2 text, LICENSE.BSD-3-clause and COPYING-CMAKE-SCRIPTS the BSD-3-clause text (the latter is the Regents/Kitware text belonging to the cmake module), and the BSD-3 text is reproduced in full as a stand-alone License paragraph while GPL-2 and LGPL-2 point at /usr/share/common-licenses/GPL-2 and /usr/share/common-licenses/LGPL-2. No file in the tree lacks a licence and no non-free term (NC, ND, no-modification, field of use) appears anywhere in it.
- No built or generated file is missing its source: lib/DefaultTranslatorText.h and lib/ExtendedDefaultTranslator.h are the keytab data of lib/default.keytab and lib/kb-layouts/default.keytab (both present), lib/LineFont.h is built from lib/LineFont.src (present), and lib/qtermwidget_version.h and lib/qtermwidget_export.h are short hand-written qmake stubs with no generated content. lib/qtermwidget.json's
License: GPLv2is recorded in its own stanza with a comment. - Ignore list honoured: .pc/ and debian/cargo-checksum.json (not present) were left out of every glob and search; the tree has no image, font, sound or other binary file.
- Packaging: debian/source/format is
3.0 (quilt), debhelper compat 13 with a plaindh $@rules file, no maintainer scripts, no debian/tests; patches 0001-0006 carry git-style From/Date/Subject with descriptions (0006 also an Origin:) and are applied by debian/patches/series; the get-orig-source target has its own lintian override as a deliberate team choice. - Standards-Version 4.7.4 against Policy 4.7.4.1 (first two components equal, so current); Vcs-Git, Vcs-Browser and Homepage are set and consistent with upstream; the changelog entries and distribution (experimental, team upload, explicit note on keeping the qmltermwidget-common name) are sane.
- Build dependencies resolve: qmake6 is pulled in by qt6-base-dev, and qmltermwidget-common 0.2+git20220109.6322802-4 exists in the archive from source qmltermwidget, so
qmltermwidget-common (>= ${source:Version})is satisfiable while the rename completes. - The symlinks made in execute_before_dh_install resolve: ../../../../../share/QMLTermWidget/kb-layouts and .../color-schemes from /usr/lib//qt6/qml/QMLTermWidget land on /usr/share/QMLTermWidget/..., and dh_install preserves symlinks.
- I read debian/copyright in full, every file under debian/, and the headers of the C++ sources in lib/ and src/ (54 files matched the copyright and licence greps); lintian and licensecheck were not re-run.
- uscan found the packaged version as the newest upstream release (upstream
0.2+git20260531, packaged0.2+git20260531). - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (GPL-2,LGPL-2).
Not confirmed ◂
- Whether the archive accepts qmltermwidget-common being taken over by this source package while source qmltermwidget is still in unstable and still lists that binary; the archive's source stanzas are not among the lists I can see.
- pkg-kde-tools, qt6-base-private-dev and qt6-declarative-private-dev are in Build-Depends, but nothing in rules includes pkg-kde-tools' makefile and no private Qt header is included anywhere in lib/ or src/. This looks like an unused build dependency, too slight to report as a fault.
Proposed: debian/watch in version 5 format ◂
debian/watch is in an old format. This is the conversion made by uscan --update-watchfile, which has not been run against the upstream site: some defaults differ in version 5, so test it with uscan --report before use.
Version: 5
Source: https://github.com/swordfish90/qmltermwidget
Matching-Pattern: HEAD
Mode: git
Pgpmode: none
Git-Pretty: 0.2+git%cd
Uploader's response to the LLM review
The uploader hasn't responded yet, and is welcome to at any time. The 24-hour hold has ended, so the package is now open for review as usual.
Review Information
rejected — allocated to dfsg-uploader 1 day ago, started 1 day ago, completed 1 day ago.
Final Comment
Superseded by review of later version