Review: qt6-qmltermwidget 0.2+git20260531-3
Package Information
| Description | Terminal Widget QML module This project is a QML port of qtermwidget. It is written to be as close as possible to the upstream project in order to make cooperation possible. At the moment this plugin is powering cool-retro-term and the lomiri-terminal-app. This package contains the QML module. |
|---|---|
| Maintainer | Debian UBports Team <team+ubports@tracker.debian.org> |
| Changed By | Jeremy Bícha <jbicha@ubuntu.com> |
| Sponsor | jbicha@debian.org |
| Distribution | experimental |
| Architecture | any all |
| VCS | git: https://salsa.debian.org/ubports-team/qt6-qmltermwidget.git (browse) |
| Tracker | https://tracker.debian.org/pkg/qt6-qmltermwidget |
| Uploaded | 2 days ago |
| Supersedes | 0.2+git20260531-2 |
New Package Report
.changes
| Version | 0.2+git20260531-3 |
|---|---|
| Changed-By | Jeremy Bícha <jbicha@ubuntu.com> |
| Architecture | source amd64 all |
| Distribution | experimental |
| Date | Thu, 12 Nov 2026 22:42:55 +0100 |
| Source | qt6-qmltermwidget |
Changelog
qt6-qmltermwidget (0.2+git20260531-3) experimental; urgency=medium
.
* Team upload
* debian/copyright: Add additional copyright holders per DFSG review
* Add qml6 Depends to qml package, per DFSG review
.
qt6-qmltermwidget (0.2+git20260531-2) experimental; urgency=medium
.
* Team upload
* Update debian/copyright per initial DFSG review
* Update package description per initial DFSG review
* Adjust README installation location for package rename
* qmltermwidget-common is intentionally not renamed because its
files are still compatible with the qt5 version.dsc
| Section | libs |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | qml6-module-termwidget deb libs optional arch=any qmltermwidget-common deb libs optional arch=all |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://github.com/Swordfish90/qmltermwidget
Upstream-Name: qmltermwidget
Files: .editorconfig
.gitignore
.translation-update
AUTHORS
cmake/qtermwidget6-config.cmake.in
docs/configuration.md
lib.pri
lib/ColorTables.h
lib/DefaultTranslatorText.h
lib/ExtendedDefaultTranslator.h
lib/LineFont.h
lib/LineFont.src
lib/SearchBar.ui
lib/color-schemes/BlackOnLightYellow.colorscheme
lib/color-schemes/BlackOnRandomLight.colorscheme
lib/color-schemes/BlackOnWhite.colorscheme
lib/color-schemes/BreezeModified.colorscheme
lib/color-schemes/DarkPastels.colorscheme
lib/color-schemes/Falcon.colorscheme
lib/color-schemes/GreenOnBlack.colorscheme
lib/color-schemes/Linux.colorscheme
lib/color-schemes/Solarized.colorscheme
lib/color-schemes/SolarizedLight.colorscheme
lib/color-schemes/Tango.colorscheme
lib/color-schemes/Ubuntu.colorscheme
lib/color-schemes/WhiteOnBlack.colorscheme
lib/color-schemes/cool-retro-term.colorscheme
lib/color-schemes/historic/BlackOnLightColor.schema
lib/color-schemes/historic/DarkPicture.schema
lib/color-schemes/historic/Example.Schema
lib/color-schemes/historic/GreenOnBlack.schema
lib/color-schemes/historic/GreenTint.schema
lib/color-schemes/historic/GreenTint_MC.schema
lib/color-schemes/historic/LightPicture.schema
lib/color-schemes/historic/Linux.schema
lib/color-schemes/historic/README.Schema
lib/color-schemes/historic/README.default.Schema
lib/color-schemes/historic/Transparent.schema
lib/color-schemes/historic/Transparent_MC.schema
lib/color-schemes/historic/Transparent_darkbg.schema
lib/color-schemes/historic/Transparent_lightbg.schema
lib/color-schemes/historic/XTerm.schema
lib/color-schemes/historic/syscolor.schema
lib/color-schemes/historic/vim.schema
lib/default.keytab
lib/kb-layouts/README
lib/kb-layouts/default.keytab
lib/kb-layouts/historic/vt100.keytab
lib/kb-layouts/historic/x11r5.keytab
lib/kb-layouts/linux.keytab
lib/kb-layouts/macbook.keytab
lib/kb-layouts/solaris.keytab
lib/kb-layouts/vt420pc.keytab
lib/mac-vkcode.h
lib/qtermwidget_export.h
lib/qtermwidget_version.h
lib/tools.cpp
lib/tools.h
lib/translations/CMakeLists.txt
lib/translations/qtermwidget.ts
lib/translations/qtermwidget_ar.ts
lib/translations/qtermwidget_arn.ts
lib/translations/qtermwidget_ast.ts
lib/translations/qtermwidget_bg.ts
lib/translations/qtermwidget_ca.ts
lib/translations/qtermwidget_cs.ts
lib/translations/qtermwidget_cy.ts
lib/translations/qtermwidget_da.ts
lib/translations/qtermwidget_de.ts
lib/translations/qtermwidget_de_CH.ts
lib/translations/qtermwidget_el.ts
lib/translations/qtermwidget_en_GB.ts
lib/translations/qtermwidget_es.ts
lib/translations/qtermwidget_et.ts
lib/translations/qtermwidget_fi.ts
lib/translations/qtermwidget_fr.ts
lib/translations/qtermwidget_gl.ts
lib/translations/qtermwidget_he.ts
lib/translations/qtermwidget_hr.ts
lib/translations/qtermwidget_hu.ts
lib/translations/qtermwidget_it.ts
lib/translations/qtermwidget_ja.ts
lib/translations/qtermwidget_ka.ts
lib/translations/qtermwidget_kab.ts
lib/translations/qtermwidget_ko.ts
lib/translations/qtermwidget_lg.ts
lib/translations/qtermwidget_lt.ts
lib/translations/qtermwidget_nb_NO.ts
lib/translations/qtermwidget_nl.ts
lib/translations/qtermwidget_oc.ts
lib/translations/qtermwidget_pl.ts
lib/translations/qtermwidget_pt.ts
lib/translations/qtermwidget_pt_BR.ts
lib/translations/qtermwidget_ru.ts
lib/translations/qtermwidget_si.ts
lib/translations/qtermwidget_sk.ts
lib/translations/qtermwidget_tr.ts
lib/translations/qtermwidget_uk.ts
lib/translations/qtermwidget_zh_CN.ts
lib/translations/qtermwidget_zh_TW.ts
qmltermwidget.pro
qtermwidget.spec
README.md
src/QMLTermScrollbar.qml
src/qmldir
src/qmltermwidget_plugin.cpp
src/qmltermwidget_plugin.h
test-app/test-app.qml
Copyright: 1997-2020, qmltermwidget contributors
License: GPL-2+
Comment:
No license headers provided in listed files.
.
Assuming GPL-2+ for these files as the majority of code files
is also using the stronger GPL-2+ license.
Files: lib/konsole_wcwidth.*
Copyright: 2001-01-12 Markus Kuhn
Waldo Bastian <bastian@kde.org>
License: GPL-2+
Comment: Original implementation by Markus Kuhn was released to the
public domain, but it was rewritten in C++ for KDE
Files: lib/ColorScheme.cpp
lib/ColorScheme.h
lib/Filter.cpp
lib/Filter.h
lib/KeyboardTranslator.cpp
lib/KeyboardTranslator.h
lib/ProcessInfo.h
lib/ScreenWindow.cpp
lib/ScreenWindow.h
Copyright: 2007, Robert Knight <robertknight@gmail.com>
2007-2008, Robert Knight <robertknight@gmail.com>
License: GPL-2+
Files: lib/Character.h
lib/CharacterColor.h
lib/Emulation.h
lib/Pty.h
lib/Screen.h
lib/TerminalDisplay.cpp
lib/TerminalDisplay.h
lib/Vt102Emulation.h
Copyright: 1997-1998, Lars Doelle <lars.doelle@on-line.de>
2006-2008, Robert Knight <robertknight@gmail.com>
2007-2008, Robert Knight <robertknight@gmail.com>
2008, Maxim Bourmistrov <maxim@unixconn.com>
License: GPL-2+
Files: lib/kprocess.cpp
lib/kprocess.h
lib/kptydevice.h
lib/kptyprocess.cpp
lib/kptyprocess.h
Copyright: 2007, Oswald Buddenhagen <ossi@kde.org>
2008, Maxim Bourmistrov <maxim@unixconn.com>
License: LGPL-2+
Files: lib/HistorySearch.cpp
lib/HistorySearch.h
lib/SearchBar.cpp
lib/SearchBar.h
Copyright: 2013, Christian Surlykke
License: GPL-2+
Files: lib/History.cpp
lib/History.h
lib/Pty.cpp
Copyright: 1997-1998, Lars Doelle <lars.doelle@on-line.de>
License: GPL-2+
Files: lib/qtermwidget.json
Copyright: 2022-2025 LXQt
License: GPL-2+
Comment: Even though this file says GPLv2, README.md
makes it clear that the license of this project is GPL-2+
Files: lib/Session.cpp
lib/Session.h
Copyright: 1997-1998, Lars Doelle <lars.doelle@on-line.de>
2006-2007, Robert Knight <robertknight@gmail.com>
2007, Robert Knight <robertknight@gmail.com>
License: GPL-2+
Files: lib/ShellCommand.cpp
lib/ShellCommand.h
Copyright: 2007, Robert Knight <robertknight@gmail.com>
2008, e_k <e_k at users.sourceforge.net>
License: GPL-2+
Files: lib/BlockArray.cpp
lib/BlockArray.h
Copyright: 2000, Stephan Kulow <coolo@kde.org>
2008, e_k <e_k at users.sourceforge.net>
License: GPL-2+
Files: lib/ksession.cpp
lib/ksession.h
Copyright: 2013, Dmitry Zagnoyko <hiroshidi@gmail.com>
2008, e_k <e_k at users.sourceforge.net>
License: GPL-2+
Files: lib/Screen.cpp
lib/Vt102Emulation.cpp
Copyright: 1997-1998, Lars Doelle <lars.doelle@on-line.de>
2007-2008, Robert Knight <robert.knight@gmail.com>
License: GPL-2+
Files: lib/kpty.h
lib/kpty_p.h
Copyright: 2003, 2007, Oswald Buddenhagen <ossi@kde.org>
2008, e_k <e_k at users.sourceforge.net>
License: LGPL-2+
Files: lib/TerminalCharacterDecoder.cpp
lib/TerminalCharacterDecoder.h
Copyright: 2006-2008, Robert Knight <robertknight@gmail.com>
License: LGPL-2+
Files: lib/qtermwidget.cpp
lib/qtermwidget.h
Copyright: 2008, e_k (e_k@users.sourceforge.net)
License: LGPL-2+
Files: lib/Emulation.cpp
Copyright: 1996, Matthias Ettrich <ettrich@kde.org>
1997-1998, Lars Doelle <lars.doelle@on-line.de>
2007-2008, Robert Knight <robertknight@gmail.com>
License: GPL-2+
Files: packaging/rpm/qmltermwidget.spec
Copyright: 2014, Markus S. <kamikazow@web.de>
License: GPL-2+
Files: lib/ProcessInfo.cpp
Copyright: 2007-2008, Robert Knight <robertknight@gmail.countm>
License: GPL-2+
Files: lib/kpty.cpp
Copyright: 2002, Waldo Bastian <bastian@kde.org>
2002-2003, 2007, Oswald Buddenhagen <ossi@kde.org>
2008, e_k <e_k at users.sourceforge.net>
License: LGPL-2+
Files: lib/qtermwidget_version.h.in
Copyright: 2020, Axel Kittenberger (axel.kittenberger@univie.ac.at)
License: LGPL-2+
Files: lib/qtermwidget_interface.h
Copyright: 2022, Francesc Martinez (info@francescmm.com)
License: LGPL-2+
Files: lib/kptydevice.cpp
Copyright: 2007, Oswald Buddenhagen <ossi@kde.org>
2010, KDE e.V. <kde-ev-board@kde.org>
Adriaan de Groot <groot@kde.org>
License: LGPL-2+
Files: cmake/FindUtf8Proc.cmake
Copyright: 2009-2011, Kitware, Inc.
2009-2011, Philip Lowman <philip@yhbt.com>
License: BSD-3-clause
Files: debian/*
Copyright: 2022, Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
License: GPL-2+ or LGPL-2+ or BSD-3-clause
License: BSD-3-clause
Copyright (c) The Regents of the University of California.
All rights reserved.
.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
1. Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
3. Neither the name of the University nor the names of its contributors
may be used to endorse or promote products derived from this software
without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
SUCH DAMAGE.
License: GPL-2+
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
.
On Debian systems, the complete text of the GNU General
Public License can be found in `/usr/share/common-licenses/GPL-2'.
License: LGPL-2+
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
.
On Debian systems, the full text of the GNU Lesser General Public License
version 2 can be found in the file /usr/share/common-licenses/LGPL-2.
DFSG Assistant LLM REVIEW 1 blocker, 0 important, 4 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 2 days ago.
Proposes a replacement debian/watch:
debian/watch in version 5 format
Report
DFSG NEW review for qt6-qmltermwidget version 0.2+git20260531-3
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: No - Packaging is of good quality: Yes
- Issues: 1 blocker, 0 important, 4 minor
- debian/watch: old format (version 4)
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
Every licence in the tree is free and mutually compatible: GPL-2+ for the Konsole/QTerminal code, LGPL-2+ for the KDE kpty/kprocess and qtermwidget files, BSD-3-clause for the CMake module, so the code itself is DFSG-compliant and has no non-free terms. debian/copyright is DEP-5 and mostly accurate, but not for every file: the stanza matching lib/Session.cpp and lib/Session.h drops e_k's 2008 copyright, and no catch-all stanza covers LICENSE, LICENSE.LGPL2+, LICENSE.BSD-3-clause or COPYING-CMAKE-SCRIPTS.
Packaging
The packaging is solid: 3.0 (quilt) with six applied patches, debhelper compat 13 driving the qmake6 buildsystem, hardening=+all, a correct Multi-Arch same/foreign split between the arch:any QML module and the arch:all data package, dependencies that exist in the archive, Vcs-* fields, upstream/metadata and Salsa CI. Two small defects remain: the kb-layouts README is packaged by the data package but placed in the other binary package's doc directory, and debian/copyright.in is a stale autogenerated licensecheck draft.
Issues
blocker licensing 1. Files stanza for lib/Session.cpp and lib/Session.h omits e_k's 2008 copyright ◂
- Files:
lib/Session.cpp:7,lib/Session.h:7,debian/copyright:183-188,debian/copyright:171-176,lib/Pty.cpp:3-5 - Basis: checked, in the package or with a reference tool
- Evidence: Both files assert
Rewritten for QT4 by e_k <e_k at users.sourceforge.net>, Copyright (C)2008, but the stanza's Copyright field lists only1997-1998, Lars Doelle <lars.doelle@on-line.de>,2006-2007, Robert Knightand2007, Robert Knight. The stanzas for lib/ShellCommand.cpp and lib/BlockArray.cpp, whose headers carry the identical line, do list2008, e_k <e_k at users.sourceforge.net>. lib/Pty.cpp:3-5 has the samemodified by Maxim Bourmistrov <maxim@unixconn.com>banner as lib/Pty.h, but its stanza (lib/History.cpp lib/History.h lib/Pty.cpp) names only Lars Doelle, while the Pty.h stanza names Bourmistrov. - Problem: The last Files stanza matching a file is what says who holds copyright in it (copyright-format 1.0 section 6.9), so debian/copyright as written states that Session.cpp/.h have no e_k copyright and that Pty.cpp has no Bourmistrov contribution, although the files themselves assert them and the same holders are named elsewhere in the file. The prescan's holder check matches names loosely against the whole file, so it cannot see this.
- Fix: Add
2008, e_k <e_k at users.sourceforge.net>to the lib/Session.cpp/.h stanza, and2008, Maxim Bourmistrov <maxim@unixconn.com>to the lib/History.cpp/lib/History.h/lib/Pty.cpp stanza.
minor licensing 2. No Files: * stanza; LICENSE, LICENSE.LGPL2+, LICENSE.BSD-3-clause and COPYING-CMAKE-SCRIPTS are not covered ◂
- Files:
debian/copyright:4-155,LICENSE,LICENSE.LGPL2+,LICENSE.BSD-3-clause,COPYING-CMAKE-SCRIPTS - Basis: checked, in the package or with a reference tool
- Evidence: The file consists of one enumerated stanza (
Files: .editorconfig...test-app/test-app.qml), a series of per-file stanzas and a finalFiles: debian/*(line 269); there is no catch-all, and the four licence texts at the top of the tree match no Files pattern. - Problem: A DEP-5 copyright file is expected to cover the whole tree; as it stands the four files holding the GPL-2, LGPL-2 and BSD-3 licence bodies (copyright of the Free Software Foundation and of the Regents of the University of California) are undocumented, and any file added upstream later would silently fall outside the file too.
- Fix: Add a
Files: *stanza ahead of the enumerated one (for example GPL-2+ for the project as a whole, overridden by the existing specific stanzas), or a stanza listing these four licence files with their holders and licences.
minor packaging 3. kb-layouts README is shipped by qmltermwidget-common inside /usr/share/doc/qml6-module-termwidget ◂
- Files:
debian/rules:27-29,debian/qmltermwidget-common.install:1,debian/qml6-module-termwidget.install:1 - Basis: checked, in the package or with a reference tool
- Evidence:
mkdir -p debian/tmp/usr/share/doc/qml6-module-termwidget/followed bymv .../kb-layouts/README debian/tmp/usr/share/doc/qml6-module-termwidget/README.kb-layouts, while qmltermwidget-common.install installsusr/share/; dh_install copies every path it matches below debian/tmp, so the README is packaged in qmltermwidget-common. - Problem: The arch:all data package ends up owning a file inside the arch:any package's documentation directory: qml6-module-termwidget's changelog and copyright come from the other package's build tree, so installing only qmltermwidget-common leaves a /usr/share/doc/qml6-module-termwidget belonging to a package that is not installed, and removing qmltermwidget-common takes a file out of it. The changelog entry for -2 says the location was adjusted for the rename, so this looks unintended.
- Fix: Move the file to debian/tmp/usr/share/doc/qmltermwidget-common/README.kb-layouts (the package that ships the data), or list it in debian/qml6-module-termwidget.docs and let dh_installdocs place it.
minor packaging 4. debian/copyright.in is a stale autogenerated licensecheck draft left in debian/ ◂
- Files:
debian/copyright.in:1-8,debian/copyright.in:120-140 - Basis: checked, in the package or with a reference tool
- Evidence:
Upstream-Name: FIXME,Upstream-Contact: FIXME,Source: FIXME,Disclaimer: Autogenerated by licensecheck,Copyright: NONE/License: UNKNOWNfor most files, and an entry fordebian/qt6-qmltermwidget-common.install, which does not exist (the file is qmltermwidget-common.install). - Problem: Nothing in debian/rules uses it, so it is dead weight in the source package, and it is a second, contradictory copyright statement (with FIXME/UNKNOWN placeholders) next to the real one.
- Fix: Delete debian/copyright.in.
minor packaging 5. debian/watch is in the old version 4 format ◂
- Files:
debian/watch - Basis: found by the review tooling's own checks
- Evidence:
version=4 - Problem: Version 5 is the current format of
debian/watch. - Fix: Convert it to version 5; a mechanical conversion is under Proposed changes.
Verified ◂
- Prescan: its holder check reported every holder it found named somewhere in debian/copyright. That check matches names against the whole file, so it cannot see the per-stanza omission in issue 1, which the stanza-by-stanza comparison found.
- All 166 tree files (excluding .pc/ and debian/) were accounted for; apart from the four licence texts in issue 2, each falls under a Files stanza.
- GPL-2+ stanzas checked against the file headers (BlockArray, Character, CharacterColor, ColorScheme, Emulation, Filter, History, HistorySearch, KeyboardTranslator, ProcessInfo, Pty, Screen, ScreenWindow, SearchBar, ShellCommand, TerminalDisplay, Vt102Emulation, ksession): all say
either version 2 of the License, or (at your option) any later version, so GPL-2+ is correct. - LGPL-2+ stanzas checked (kprocess, kpty, kpty_p, kptydevice, kptyprocess, TerminalCharacterDecoder, qtermwidget.*): each says
Library/Lesser General Public License ... version 2 ... or (at your option) any later version; LGPL-2+ is correct, not LGPL vs GPL. - Holders named in the matching stanzas: Robert Knight, Lars Doelle, Matthias Ettrich, Stephan Kulow, Christian Surlykke, Dmitry Zagnoyko, Oswald Buddenhagen, Waldo Bastian, KDE e.V./Adriaan de Groot, Maxim Bourmistrov, e_k, Markus Kuhn, Kitware/Philip Lowman, LXQt, Francesc Martinez, Axel Kittenberger, Markus S.
- LICENSE and LICENSE.LGPL2+ are the verbatim GPL-2 and LGPL-2 texts; LICENSE.BSD-3-clause and COPYING-CMAKE-SCRIPTS hold the Regents BSD-3 text that matches the copyright's BSD-3-clause paragraph; cmake/FindUtf8Proc.cmake is Kitware/Philip Lowman BSD-3 (
Distributed under the OSI-approved BSD License), used at build time only, so no licence conflict. - lib/konsole_wcwidth.cpp:1-9 and lib/konsole_wcwidth.h:1-7 carry Kuhn's
public domainnotice plus the KDE/e_k rewrite; declared GPL-2+ with a Comment explaining that, consistent with the files. - lib/mac-vkcode.h:2 says it was copied from Apple's Carbon Events.h; it contains only numeric key-code constants, no licence text, and is declared GPL-2+ by the assumption stated in the first stanza. Not treated as a defect, but its provenance is narrower than the stanza implies.
- Generated files have their inputs in the tree: lib/LineFont.h (
Autogenerated by "fontembedder ./linefont.src") from lib/LineFont.src, lib/qtermwidget_version.h from lib/qtermwidget_version.h.in, and lib/DefaultTranslatorText.h / lib/ExtendedDefaultTranslator.h embed lib/default.keytab. - Headerless files (lib/tools.cpp/.h, ColorTables.h, qtermwidget_export.h, qtermwidget_version.h, src/, test-app/test-app.qml, colour schemes, keytabs, translations/.ts) are declared GPL-2+ by the Comment in the first stanza; README.md:13 states GPL-2.0-or-later and none of them contains a contrary notice.
- lib/qtermwidget.json declares
"License" : "GPLv2"; declared GPL-2+ with a Comment giving the reason (README.md). - No built binaries, bytecode, minified code, PDFs, fonts or images in the tree; the data files (colour schemes, keytabs, .ts translations, LineFont.src) are plain text.
- No non-free wording anywhere (no non-commercial, no-modification or field-of-use terms, no NC/ND licence, no JSON "Good, not Evil" clause); GPL-2+ and LGPL-2+ combine compatibly into the GPL-2+ plugin.
- Packaging: source format 3.0 (quilt); patches/series lists the six patches, all applied (.pc/ present), each with From/Date/Subject (0006 also Origin); compat 13,
dh_auto_configure --buildsystem=qmake6, hardening=+all; dh_missing at compat 13 defaults to --fail-missing and all files in debian/tmp are installed. - Dependencies exist: qml6-module-qtquick and qml6-module-qtquick-controls (qt6-declarative 6.11.2); qmltermwidget-common exists in unstable from the qmltermwidget source and is taken over by this package; the Qt5 qml-module-termwidget still in unstable depends on qmltermwidget-common (>= 0.2+git20220109.6322802-4), which the new version satisfies, and installs no Qt6 path, so both can be installed together.
- qt6-base-private-dev and qt6-declarative-private-dev pull qt6-base-dev and qt6-declarative-dev, so the Qt Quick/QML headers are present; no private header is included, so the private packages are at most superfluous.
- Standards-Version 4.7.4 against Policy 4.7.4.1 - current. Vcs-* and Homepage match the source name; debian/upstream/metadata and salsa-ci.yml are well-formed.
- The /usr/share/QMLTermWidget move is functional: src/qmltermwidget_plugin.cpp:38-49 resolves color-schemes and kb-layouts from the QML import path, and debian/rules:21,25 provide exactly those symlinks.
- No maintainer scripts, no *.maintscript and no debian/tests directory.
- uscan found the packaged version as the newest upstream release (upstream
0.2+git20260531, packaged0.2+git20260531). - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (GPL-2,LGPL-2).
Not confirmed ◂
- I could not build or run the package: the plugin's behaviour, including the runtime lookup of colour schemes and keytabs, was read from the source only.
- Whether autopkgtests are expected for this package by the Qt/KDE or UBports team: none exist, but nothing in Policy requires them.
Proposed: debian/watch in version 5 format ◂
debian/watch is in an old format. This is the conversion made by uscan --update-watchfile, which has not been run against the upstream site: some defaults differ in version 5, so test it with uscan --report before use.
Version: 5
Source: https://github.com/swordfish90/qmltermwidget
Matching-Pattern: HEAD
Mode: git
Pgpmode: none
Git-Pretty: 0.2+git%cd
Uploader's response to the LLM review
The uploader rejected this upload in response to the review.
Review Information
rejected — allocated to dfsg-uploader 1 day ago, started 1 day ago, completed 1 day ago.
Final Comment
The uploader rejected this upload in response to the automated (LLM) review of it, so that they can fix the problems it found and upload again.