Review: qtea 0.1.1-1
Package Information
| Description | Quality Tea Frontend, Qt-based Jolly Good emulator frontend The Quality Tea Frontend is a frontend for emulator plugins using the Jolly Good API. It provides a menu-based user interface for emulation. The frontend currently only supports statically-built plugins; this package contains the source code required to build the frontend combined with a static plugin. |
|---|---|
| Maintainer | Debian Games Team <pkg-games-devel@lists.alioth.debian.org> |
| Changed By | Stephen Kitt <skitt@debian.org> |
| Sponsor | skitt@debian.org |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/games-team/nestopia.git (browse) |
| Closes | #1148917 |
| Tracker | https://tracker.debian.org/pkg/qtea |
| Uploaded | 1 month, 9 days ago |
New Package Report
.changes
| Changed-By | Stephen Kitt <skitt@debian.org> |
|---|---|
| Architecture | source all |
| Distribution | unstable |
| Date | Fri, 25 Sep 2026 12:01:42 +0200 |
| Source | qtea |
| Version | 0.1.1-1 |
Changelog
qtea (0.1.1-1) unstable; urgency=medium . * Initial release. Closes: #1148917.
.dsc
| Section | games |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | qtea-src deb games optional arch=all |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: qtea
Source: https://gitlab.com/jgemu/qtea/
Files: *
Copyright: 2021-2026 Jolly Good Emulation Team
License: BSD-3-Clause
Files: shaders/*
Copyright: 2020-2022 Rupert Carmichael
License: Expat
Files: shaders/mmpx.fs
Copyright: Morgan McGuire and Mara Gagiu
License: Expat
Files: shaders/omniscale.fs
Copyright: 2015-2016 Lior Halphon
License: Expat
Files: src/crc32.cpp
Copyright: 1986 Gary S. Brown
License: unrestricted
You may use this program, or code or tables extracted from it,
as desired without restriction.
Files: src/ini.h
Copyright: 2018 Danijel Durakovic
License: Expat
Files: src/lodepng.*
Copyright: 2005-2023 Lode Vandevenne
License: zlib
Files: src/md5.*
Copyright: 2001 Alexander Peslyak
License: public-domain
This software was written by Alexander Peslyak in 2001. No copyright is
claimed, and the software is hereby placed in the public domain.
In case this attempt to disclaim copyright and place the software in the
public domain is deemed null and void, then the software is
Copyright (c) 2001 Alexander Peslyak and it is hereby released to the
general public under the following terms:
.
Redistribution and use in source and binary forms, with or without
modification, are permitted.
.
There's ABSOLUTELY NO WARRANTY, express or implied.
Files: src/parson.*
Copyright: 2012-2023 Krzysztof Gabis
License: Expat
Files: debian/*
Copyright: 2026 Stephen Kitt <skitt@debian.org>
License: BSD-3-Clause
License: BSD-3-Clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
.
1. Redistributions of source code must retain the above copyright notice, this
list of conditions and the following disclaimer.
.
2. Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.
.
3. Neither the name of the copyright holder nor the names of its
contributors may be used to endorse or promote products derived from
this software without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
License: Expat
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
.
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
License: zlib
This software is provided 'as-is', without any express or implied
warranty. In no event will the authors be held liable for any damages
arising from the use of this software.
.
Permission is granted to anyone to use this software for any purpose,
including commercial applications, and to alter it and redistribute it
freely, subject to the following restrictions:
.
1. The origin of this software must not be misrepresented; you must not
claim that you wrote the original software. If you use this software
in a product, an acknowledgment in the product documentation would be
appreciated but is not required.
2. Altered source versions must be plainly marked as such, and must not be
misrepresented as being the original software.
3. This notice may not be removed or altered from any source distribution.
Review Information
rejected — allocated to awm 1 month, 8 days ago, started 1 month, 8 days ago, completed 1 month, 8 days ago.
Final Comment
Hi,
Packaging quality issues
- Wrong VCS URLs (copied from another package) — debian/control:7-8
Vcs-Browser: https://salsa.debian.org/games-team/nestopia
Vcs-Git: https://salsa.debian.org/games-team/nestopia.git
These point to the nestopia repository, not qtea. They were clearly copied from a different Debian Games Team package. The actual upstream is gitlab.com/jgemu/qtea (see debian/upstream/metadata:7-8), so these should be https://salsa.debian.org/games-team/qtea(.git).
- Missing/incorrect license entry for src/font/6x8.h — debian/copyright
The file header states src/font/6x8.h:1: "Public Domain 6x8 console font". There is no Files: src/font/6x8.h section in debian/copyright, so it is silently captured by Files: * (lines 5-7) and mislabeled as BSD-3-Clause. It should have its own public-domain entry. Same applies to the CRC table — crc32.cpp has its own section (debian/copyright:21-25), which is correct, but the font is an oversight.
- Minor: stale README attribution for shaders/sharp-bilinear.fs
README:44-45 credits it to "nyanpasu64 and wareya (MIT)", but the file header (shaders/sharp-bilinear.fs) and debian/copyright:9-11 both correctly credit Rupert Carmichael (2020-2022, MIT). The copyright file matches the actual header, so this is only an upstream README inconsistency — not a Debian defect, but worth noting since the README is the canonical license statement in the tree.
- Minimal debian/rules
debian/rules:6-8 empties both dh_auto_configure and dh_auto_build and relies on --with single-binary. This is defensible for a source-shipping qtea-src package (nothing is compiled), and debian/qtea-src.install handles installation. Not a bug, but there's no override_dh_auto_install or dh_clean cleanup, and no Rules-Requires-Root field in debian/control — minor policy hygiene items.
- Missing Author Credits
See full review details for a list of authors who are not credited in debian/copyright
Thanks!
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 0.1.1-1 | b6708946… | 2026-09-26 11:27 | 2026-09-26 11:41 | awm | accepted | VIEW |
Public Notes
Missed Author Check
Command: dnq author-check -prepare
Exit code: 0
Author check: scanned 96 files.
NOT IN debian/copyright (11):
Analog Devices Inc
SpeexDSP-BSD-3-Clause.txt:3
Commonwealth Scientific and Industrial Research
SpeexDSP-BSD-3-Clause.txt:4
David Rowe
SpeexDSP-BSD-3-Clause.txt:6
EpicGames
SpeexDSP-BSD-3-Clause.txt:7
Free Software Foundation, Inc. <http://fsf.org/>
Qt-GPL-3.0.txt:4
Qt-LGPL-3.0.txt:4
Jean-Marc Valin
SpeexDSP-BSD-3-Clause.txt:2
Jutta Degener, Carsten Bormann
SpeexDSP-BSD-3-Clause.txt:8
nyanpasu64 and wareya (MIT)
README:45
Sam Lantinga <slouken@libsdl.org>
SDL-Zlib.txt:1
Tim Kientzle
libarchive-BSD-2-Clause.txt:1
Xiph.org Foundation
SpeexDSP-BSD-3-Clause.txt:1
Result: ATTENTION REQUIRED — 11 authors not in debian/copyright
Lintian
Command: lintian -Iiv -L '>=warning' --show-overrides --color=never ../$(basename $PWD)_*.changes
Exit code: 0
N:
W: qtea-src: mismatched-override package-contains-documentation-outside-usr-share-doc [usr/share/qtea/CMakeLists.txt] [usr/share/lintian/overrides/qtea-src:6]
N:
N: The named tag would have been silenced except the context specified with
N: the override did not match.
N:
N: Lintian may now provide a different context for the tag, or something
N: could have changed in a new version of your package. Either way, overrides
N: work best when you require as little context as needed.
N:
N: You can use wildcards, such as * or ? in the context to make a match more
N: likely.
N:
N: Please remove or adjust the override.
N:
N: Visibility: warning
N: Show-Always: yes
N: Check: lintian
N:
CME fix
Command: cme fix --verbose dpkg
Exit code: 0
cme: running fix on dpkg configuration...
Warning in 'install:"qtea-src" content:0': path should not begin with '/'
Offending value: 'CMakeLists.txt /usr/share/qtea/'
Warning in 'install:"qtea-src" content:1': path should not begin with '/'
Offending value: 'LICENSE /usr/share/qtea/'
Warning in 'install:"qtea-src" content:2': path should not begin with '/'
Offending value: 'cmake /usr/share/qtea/'
Warning in 'install:"qtea-src" content:3': path should not begin with '/'
Offending value: 'icons /usr/share/qtea/'
Warning in 'install:"qtea-src" content:4': path should not begin with '/'
Offending value: 'shaders /usr/share/qtea/'
Warning in 'install:"qtea-src" content:5': path should not begin with '/'
Offending value: 'src /usr/share/qtea/'
Changes applied to dpkg configuration:
- install:"qtea-src" content:0: 'CMakeLists.txt /usr/share/qtea/' -> 'CMakeLists.txt usr/share/qtea/' # applied fix for :path should not begin with '/'
- install:"qtea-src" content:1: 'LICENSE /usr/share/qtea/' -> 'LICENSE usr/share/qtea/' # applied fix for :path should not begin with '/'
- install:"qtea-src" content:2: 'cmake /usr/share/qtea/' -> 'cmake usr/share/qtea/' # applied fix for :path should not begin with '/'
- install:"qtea-src" content:3: 'icons /usr/share/qtea/' -> 'icons usr/share/qtea/' # applied fix for :path should not begin with '/'
- install:"qtea-src" content:4: 'shaders /usr/share/qtea/' -> 'shaders usr/share/qtea/' # applied fix for :path should not begin with '/'
- install:"qtea-src" content:5: 'src /usr/share/qtea/' -> 'src usr/share/qtea/' # applied fix for :path should not begin with '/'