Review: quanty 0.0~git20250119191535.560ae00-1
Package Information
| Description | quantum many body script language Quanty is a script language which allows the user to program quantum mechanical problems in second quantization and when possible solve these. It can be used in quantum chemistry as post Hartree-Fock or in one of the LDA++ schemes. (self consistent field, configuration interaction, coupled cluster, restricted active space, …) The idea of Quanty is that the user can focus on the model and its physical or chemical meaning. Quanty will take care of the mathematics. |
|---|---|
| Maintainer | Debian PaN Maintainers <debian-pan-maintainers@alioth-lists.debian.net> |
| Changed By | Roland Mas <lolando@debian.org> |
| Sponsor | lolando@debian.org |
| Distribution | unstable |
| Architecture | any |
| VCS | git: https://salsa.debian.org/science-team/quanty.git (browse) |
| Tracker | https://tracker.debian.org/pkg/quanty |
| Uploaded | 26 days ago |
New Package Report
.changes
| Changed-By | Roland Mas <lolando@debian.org> |
|---|---|
| Architecture | source amd64 |
| Distribution | unstable |
| Date | Sat, 26 Sep 2026 20:10:22 +0200 |
| Source | quanty |
| Version | 0.0~git20250119191535.560ae00-1 |
Changelog
quanty (0.0~git20250119191535.560ae00-1) unstable; urgency=medium . * Initial packaging.
.dsc
| Section | science |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | quanty deb science optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: quanty Source: https://git.quanty.org/Quanty/release Files: * Copyright: Quanty License: CC-BY-4.0 Files: debian/* Copyright: 2026 Roland Mas <lolando@debian.org> License: CC-BY-4.0 License: CC-BY-4.0 On Debian GNU/Linux systems, the complete text of the Creative Commons Attribution License 4.0 can be found in `/usr/share/common-licenses/CC-BY-4.0'.
Review Information
rejected — allocated to awm 25 days ago, started 25 days ago, completed 25 days ago.
Final Comment
Hi,
Several issues that should be fixed here...
Licensing / DFSG
- Inaccurate debian/copyright — bundled Lua is mislabeled as CC-BY-4.0.
debian/copyright claims Files: * ... License: CC-BY-4.0 for the whole upstream tree, but the tree embeds a full copy of the Lua 5.2.3 interpreter (LuaInterface/lua/), whose header states Copyright (C) 1994-2013 Lua.org, PUC-Rio (LuaInterface/lua/lua.h:26) and is MIT-licensed. The copyright file never mentions Lua or its MIT license, so it violates the machine-readable format's requirement to identify all files and their licenses. This bundled Lua is also actually compiled into the binary via #include "lua/includeLua.c" (LuaInterface/main.cpp:24).
- The effective license deviates from the CC-BY-4.0 that debian/copyright claims.
LICENSE adds an obligation beyond CC-BY-4.0: "For our scientific code this means you need to site the proper papers in scientific work that is based on this code or derivatives of this code." This is an extra, field-of-use-style requirement that debian/copyright neither reproduces nor flags, and it's the part of the licensing most likely to raise DFSG concerns. (CC-BY-4.0 itself is generally treated as DFSG-free, so the copyright inaccuracy + added clause are the real problems, not the base license per se.)
If you can persuade them to, I think that upstream would be better to word it as something like "... this means you should cite the proper papers ...", which would not override the CC-BY-4.0, so you should propose that to them. It also corrects a spelling mistake (site -> cite).
- debian/copyright upstream holder is just Copyright: Quanty with no years/names. I guess if you don't know the years, you don't, but perhaps they can be discovered from the upstream repository? Is that really the copyright holder, or should it list the paper authors?
Packaging Quality Observations
None of these are showstoppers, but some of them definitely seem worth fixing. The vendored Lua should be explained, ideally, and definitely exposed.
- Test loop bug (duplicated in two files).
debian/rules:13 iterates for i in $$(find TestScripts -name *.Quanty) but then only echoes $$i while always running the hardcoded TestScripts/BitMaskToIndex.Quanty. The exact same bug is repeated in debian/tests/control:1. Only one script is ever exercised.
- Redundant tests.
The same test runs in override_dh_auto_test (debian/rules:12) and as an autopkgtest (debian/tests/control) — duplicate coverage.
- Vendored Lua, no system liblua, no Build-Depends.
The build (debian/rules:10) compiles only LuaInterface/main.cpp and relies on the amalgamated #include of the bundled Lua, rather than linking Debian's liblua. debian/control has no lua Build-Depends, and debian/copyright doesn't disclose the vendored copy (see #1). liblua*-dev should be a Build-Depends and the bundled copy dropped or at least documented.
- Hardcoded -O2 in debian/rules:10 after $(CXXFLAGS)
This can conflict with the optimizer level chosen by dpkg-buildflags (e.g. a -O3 from CXXFLAGS would be overridden by the trailing -O2), so reproducible/optimized builds aren't fully honored.
- debian/watch version scheme likely mismatches the changelog.
watch uses Mode: git + Matching-Pattern: HEAD + Git-Date: %Y%m%d%H%M%S, but the changelog version is 0.0~git20250119191535.560ae00-1 with a Dversionmangle: s/+ds\d+// that doesn't align with the ~git... suffix. uscan/gbp may fail to match and update the version properly.
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 0.9.0-1 | be4f0fa4… | 2026-10-06 05:14 | 2026-10-06 07:27 | awm | accepted | VIEW |
Public Notes
Licenserecon
Command: lrc -s
Exit code: 3
en: Versions: licenserecon '17.0' licensecheck '3.3.9-1'
Parsing Source Tree ....
Reading d/copyright ....
Running licensecheck ....
d/copyright | licensecheck
CC-BY-4.0 | BSD-3-clause Core/Random.cpp
Short option in use. Not all differences shown