DFSG NEW Queue

DFSG, Licensing & New Packages Team

Review: rar-rs 0.12.0+dfsg-1

Package Information

DescriptionPure-Rust RAR archive toolkit

A command-line tool for creating, reading, extracting, and modifying RAR 1.5-4.x, RAR5, and RAR7 archives without an external RAR binary.

MaintainerDebian Commons <rar-rs@packages.debian.org>
Changed ByBastian Germann <bage@debian.org>
Sponsorbage@debian.org
Distributionunstable
Architectureany
VCSgit: https://salsa.debian.org/debian/rar-rs.git (browse)
Closes#1153236
Trackerhttps://tracker.debian.org/pkg/rar-rs
Uploaded6 hours ago

New Package Report

.changes◂
Architecturesource amd64
Distributionunstable
DateFri, 06 Nov 2026 19:30:21 +0100
Sourcerar-rs
Version0.12.0+dfsg-1
Changed-ByBastian Germann <bage@debian.org>
Changelog◂ 
rar-rs (0.12.0+dfsg-1) unstable; urgency=medium
 .
   * Initial release. (Closes: #1153236)
.dsc◂
Priorityoptional
Componentmain
Package-Listrar-rs deb utils optional arch=any
unrar-rs deb utils optional arch=any
Sectionutils
debian/copyright◂ 
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://github.com/yjdyamv/rar-rs
Upstream-Name: rar-rs
Upstream-Contact: https://github.com/yjdyamv/rar-rs/issues
Files-Excluded:
 .github
 crates/rar/tests/fixtures/rar13/SFXSRC.EXE
 crates/rar/tests/fixtures/x86
 crates/rar/tests/fixtures/rar40/rarvm/filter_bsdcat_exe.rar
 crates/rar/tests/fixtures/rar40/rarvm/vm_encoded_u32_filter.rar
 crates/rar-napi
Comment:
 Exclude binary files that have propietary provenance or undocumented licenses.
 Exclude files that are not built and reference JavaScript libraries.

Files:
 *
Copyright:
 Copyright (c) 2025, librar contributors
 Copyright (c) 2026, yjdyamv
License: BSD-2-Clause
 Redistribution and use in source and binary forms, with or without
 modification, are permitted provided that the following conditions are met:
 .
 1. Redistributions of source code must retain the above copyright notice, this
    list of conditions and the following disclaimer.
 .
 2. Redistributions in binary form must reproduce the above copyright notice,
    this list of conditions and the following disclaimer in the documentation
    and/or other materials provided with the distribution.
 .
 THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
 AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
 IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
 DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
 FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
 DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
 SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
 CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
 OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
Comment:
 crates/rar/src/codec/modern/lzss_huff/mod.rs:
 Clean-room implementation for software conservation and educational
 purposes. Bitstream format derived from analysis of libarchive's
 archive_read_support_format_rar5.c by Grzegorz Antoniak (2018),
 an independent BSD-2-Clause licensed implementation.

Files:
 crates/rar/tests/fixtures/rar50/winrar5_multiple_files.rar
 crates/rar/tests/rar_vm_filters.rs
 crates/rar/src/crypto/rar50.rs
 crates/rar/src/crypto/rar13.rs
 crates/rar/src/format/rar13/mod.rs
 crates/rar/src/format/rar13/write.rs
 crates/rar/src/format/rar5/blake2sp.rs
 crates/rar/src/codec/legacy/ppmd.rs
 crates/rar/src/codec/legacy/rar15.rs
 crates/rar/src/codec/legacy/rar15_encoder.rs
 crates/rar/src/codec/legacy/rar20_encoder.rs
 crates/rar/src/codec/legacy/rar20.rs
 crates/rar/src/codec/legacy/rar29_encoder.rs
 crates/rar/src/codec/legacy/rar29.rs
 crates/rar/src/codec/legacy/rarvm.rs
 crates/rar/src/codec/common/filters.rs
 crates/rar/src/codec/common/match_finder.rs
 crates/rar/src/codec/modern/lzss_huff/encoder/parse/*
 crates/rar/src/recovery/rar50/*
 crates/rar/src/recovery/rev3/rs8.rs
 crates/rar/src/recovery/rev3/mod.rs
 crates/rar/src/recovery/legacy.rs
Comment: RAR5 archive created by WinRAR, vendored from
  the libarchive test suite (`test_read_format_rar5_multiple_files.rar`,
  BSD-2-Clause licensed, <https://github.com/libarchive/libarchive>).
Copyright: Tim Kientzle
 All rights reserved.
License: BSD-2-Clause-pos-unchanged
 Redistribution and use in source and binary forms, with or without
 modification, are permitted provided that the following conditions
 are met:
 1. Redistributions of source code must retain the above copyright
    notice, this list of conditions and the following disclaimer
    in this position and unchanged.
 2. Redistributions in binary form must reproduce the above copyright
    notice, this list of conditions and the following disclaimer in the
    documentation and/or other materials provided with the distribution.
 .
 THIS SOFTWARE IS PROVIDED BY THE AUTHOR(S) ``AS IS'' AND ANY EXPRESS OR
 IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
 OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
 IN NO EVENT SHALL THE AUTHOR(S) BE LIABLE FOR ANY DIRECT, INDIRECT,
 INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
 NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
 THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

Files:
 crates/rar/tests/fixtures/rar13/*
 crates/rar/tests/fixtures/rar40/*
Copyright: Gareth Davidson @bitplane
License: Apache-2
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
 .
     http://www.apache.org/licenses/LICENSE-2.0
 .
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,
 WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License.
Comment:
 On Debian systems, the full text of the License can be found in the file
 `/usr/share/common-licenses/Apache-2.0'.
 .
 A rars COPYING file read "WTFPL with 1 extra clause" for a few weeks
 in 2026; it never appeared in that project's workspace metadata or in a
 release, and was replaced by Apache-2.0. No file here claims WTFPL.
 Also, the alternative MIT license was removed later, so it is assumed
 that rars mistakenly referenced MIT in Cargo.toml.

Files:
 debian/*
Copyright:
 2000-2004 Petr Cech <cech@debian.org>
 2026 Bastian Germann <bage@debian.org>
License: public-domain
 Put under public domain. Feel free to do whatever you want with it.

DFSG Assistant LLM REVIEW 2 blocker, 0 important, 1 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 6 hours ago.

Report◂

DFSG NEW review for rar-rs version 0.12.0+dfsg-1

Summary

  • Licensing is DFSG-compliant and debian/copyright is accurate: No
  • Packaging is of good quality: Yes
  • Issues: 2 blocker, 0 important, 1 minor
  • debian/watch: version 5
  • debian/copyright: machine-readable
  • Scan before the review: 110 found (38 not listed by the scan, so not checked)

Licensing

The tree itself is free software (BSD-2-Clause project with MIT OR Apache-2.0 rars portions and BSD-2-Clause libarchive material; no non-free licence terms anywhere), but debian/copyright does not describe it accurately. The stanza that covers the rars-derived sources gives them libarchive's BSD-2-Clause-pos-unchanged and Tim Kientzle, although their own headers and THIRD_PARTY_LICENSES.md say they are ported from rars under MIT OR Apache-2.0 by Gareth Davidson; and the rar13/rar40 fixture stanza attributes the RAR 1.3/1.4 sample archives, including RARLAB's Russian RAR 1.40 (beta) README, to bitplane under Apache-2.0. Both are copyright inaccuracies that must be fixed before upload.

Packaging

The packaging is in good shape: compat 14 with dh-rust, build and test dependencies that match what the dh-rust cargo test and install steps need, a correct declarative alternatives file, six patches with purpose/forwarding headers, correct excluded-fixture handling in the tests, a sane changelog and Vcs fields, and a working two-binary split (rules renames rar to rar-rs in place and moves unrar to unrar-rs). The only fault found is minor: the rar-rs package ships /usr/bin/rar-rs without a manual page. There is no debian/tests; the suite runs at build time instead.

Issues

blocker licensing 1. debian/copyright records the 20 rars-ported sources under libarchive's BSD-2-Clause-pos-unchanged and Tim Kientzle instead of MIT OR Apache-2.0 by Gareth Davidson ◂
  • Files: debian/copyright:49-98, debian/copyright:53, crates/rar/src/crypto/rar13.rs:1-2, crates/rar/src/crypto/rar50.rs:4-5, crates/rar/src/recovery/rar50/mod.rs:4-5, crates/rar/src/recovery/rev3/rs8.rs:1-3, crates/rar/src/codec/legacy/rar15.rs:4, crates/rar/src/format/rar13/mod.rs:7, crates/rar/src/codec/common/filters.rs:173, crates/rar/tests/rar_vm_filters.rs:1-3, THIRD_PARTY_LICENSES.md
  • Basis: checked, in the package or with a reference tool
  • Evidence: The stanza at debian/copyright:49 lists crates/rar/src/crypto/rar13.rs (line 53) and 19 other sources with Copyright: Tim Kientzle and License: BSD-2-Clause-pos-unchanged (lines 75-77), although the file itself says //! RAR 1.3/1.4 member and comment cipher (ported from the rarsproject's //!crypto/rar13.rs, MIT OR Apache-2.0; see NOTICE).; crates/rar/src/recovery/rar50/mod.rs:4-5 says Ported from the rars project ... licensed MIT OR Apache-2.0, and THIRD_PARTY_LICENSES.md states Portions derived from other projects keep their own terms — the rars-derived files below are MIT OR Apache-2.0``.
  • Problem: Later stanzas override earlier ones (copyright-format 6.9), so this stanza, not Files: *, is what recipients take for these files. It states the wrong holder and the wrong licence for them: the libarchive BSD-2-Clause text with its in this position and unchanged clause belongs only to the libarchive-derived crates/rar/tests/fixtures/rar50/winrar5_multiple_files.rar (the stanza's own Comment describes only that archive), while the rars ports are MIT/Apache-2.0 by Gareth Davidson. MIT and Apache-2.0 terms are therefore not stated for files that require them, so debian/copyright does not contain the actual distribution licences as Policy 4.5 requires.
  • Fix: Split the stanza: leave crates/rar/tests/fixtures/rar50/winrar5_multiple_files.rar (and only files actually copied from libarchive) with Copyright: Tim Kientzle and the BSD-2-Clause-pos-unchanged text, and add a stanza for the rars ports with Copyright: Gareth Davidson and License: MIT or Apache-2.0, including the chosen licence text (Apache-2.0 can point at /usr/share/common-licenses/Apache-2.0, MIT text should be included or, if Apache-2.0 is chosen, say so in a Comment). Place crates/rar/tests/rar_vm_filters.rs, whose header credits only the rars corpus, with the rars stanza and check the rars-derived portion in crates/rar/src/codec/modern/lzss_huff/encoder/filter.rs (currently only in Files: *).
blocker licensing 2. Fixture stanza gives RARLAB's RAR 1.3/1.4 samples and documentation as Gareth Davidson / Apache-2.0 ◂
  • Files: debian/copyright:99-103, crates/rar/tests/fixtures/rar13/README, crates/rar/tests/fixtures/rar13/README.RAR, NOTICE:37-41, THIRD_PARTY_LICENSES.md
  • Basis: inferred from what was read, not seen directly
  • Evidence: crates/rar/tests/fixtures/rar13/README is the Russian RAR 1.40 (beta) README in CP866, listing RAR DOC, LICENSE DOC, TECHNOTE DOC; the whole rar13 set is the classic RAR 1.3/1.4 sample-archive corpus (its members are README, CMULTI.TXT, HELLO.TXT). debian/copyright:99-103 says Files: crates/rar/tests/fixtures/rar13/* and crates/rar/tests/fixtures/rar40/*, Copyright: Gareth Davidson @bitplane, License: Apache-2. NOTICE:37-41 says the fixtures contain archive files copied from the rars test corpus ... and remain subject to the terms of that corpus, and THIRD_PARTY_LICENSES.md says their own redistribution review is still outstanding.
  • Problem: RARLAB's documentation is not bitplane's work, and the copyright file names no RARLAB/Eugene Roshal holder and states no licence for it or for the RAR 1.4 sample archives that contain it. Upstream itself has not cleared the corpus, and the packager already excluded SFXSRC.EXE, the bsdcat archives and the ntoskrnl data from the same corpus for exactly this reason. The stanza therefore does not accurately describe these files and their DFSG status is not established.
  • Fix: Establish each fixture group's provenance and holder: name RARLAB / Alexander Roshal and record the terms for the RAR 1.3/1.4 material (or drop it), and assign the remaining groups to their real holders (rars/bitplane, libarchive/Tim Kientzle, the rar-rs project). If the RAR 1.4 material cannot be licensed, add the affected archives and the extracted rar13/README to Files-Excluded and adjust or ignore the dependent tests as already done for SFXSRC.EXE.
minor packaging 3. rar-rs ships /usr/bin/rar-rs without a manual page ◂
  • Files: debian/unrar-rs.manpages:1, debian/rules:9
  • Basis: checked, in the package or with a reference tool
  • Evidence: debian/unrar-rs.manpages contains only debian/unrar-rs.1; the only .TH line in the tree is debian/unrar-rs.1:1, and debian/rules:9 installs the rar program as /usr/bin/rar-rs.
  • Problem: Policy 12.1: Each program, utility, and function should have an associated manual page included in the same package or a dependency, and a missing manual page is considered a bug. The rar-rs package's only program has none, while unrar-rs's has one.
  • Fix: Ship a manual page for the rar CLI in the rar-rs package (a variant of debian/unrar-rs.1 with the rar commands), and list it in a debian/rar-rs.manpages file.
Verified ◂
  • Read all of debian/ in full: control, rules, changelog, copyright, patches/series with all six patches, unrar-rs.1, unrar-rs.alternatives, unrar-rs.manpages, source/format, source/lintian-overrides, salsa-ci.yml. There is no debian/tests, no install/links/dirs/docs/maintscript, no gbp.conf and no debian/upstream/metadata.
  • Build-Depends all exist in unstable with versions satisfying the manifests: dh-rust 0.1.4 (Provides dh-sequence-rust), librust-aes-dev 0.9.3, librust-hmac-dev 0.13.0, librust-sha2-dev 0.11.1, librust-clap-dev 4.6.7, librust-rand-dev 0.10.3, librust-rayon-dev 1.12.0, librust-zeroize-dev 1.9.0; cargo Depends rustc.
  • The buildsystem is dh-rust, not dh-cargo. /usr/share/perl5/Debian/Debhelper/Buildsystem/rust.pm runs cargo test in its test step and installs each crate named in a package's X-Cargo-Crates into that package's directory; with X-Cargo-Crates: rar-cli (debian/control:27) both rar and unrar land in debian/rar-rs, and debian/rules:8-9 then moves unrar to unrar-rs and renames rar to rar-rs in place, so rar-rs ships /usr/bin/rar-rs and unrar-rs /usr/bin/unrar-rs. The absent debian/cargo-checksum.json is a dh-cargo file, not needed by dh-rust.
  • Because the dh-rust test step runs cargo test, the test-only dependencies are correctly in Build-Depends (tempfile, sha2, libc); fuzz/ declares its own [workspace] and is not built, so libfuzzer-sys need not be a build dependency.
  • Tests that need the excluded files are marked #[ignore = excluded fixture: ...] (crates/rar/tests/rar13_read.rs:176, rar50_roundtrip.rs:915, rar_vm_filters.rs:83 and :113), and the official-RAR interop tests skip when SA_OFFICIAL_RAR/SA_OFFICIAL_UNRAR are unset (crates/rar-cli/tests/cli_behavior/basics.rs:86-94).
  • All Files-Excluded entries are absent from the tree: .github, crates/rar-napi (also removed from the workspace by a patch), crates/rar/tests/fixtures/x86 including ntoskrnl_dense_prefix.bin, rar13/SFXSRC.EXE, and rar40/rarvm/filter_bsdcat_exe.rar and vm_encoded_u32_filter.rar.
  • debian/unrar-rs.alternatives follows the dh_installalternatives(1) format, with Name/Link/Alternative/Priority and one correct --slave triple (/usr/share/man/man1/unrar.1.gz unrar.1.gz /usr/share/man/man1/unrar-rs.1.gz); dh_installalternatives is in the compat 14 sequence.
  • No vendored third-party library and no embedded C code: the only third-party portions are the rars and libarchive-derived files, which carry headers and are inventoried in NOTICE and THIRD_PARTY_LICENSES.md.
  • No non-free terms in the shipped files: the WTFPL mention in NOTICE and PLAN.md describes a rars COPYING file and says no file here claims it; LICENSES/ holds only Apache-2.0.txt and MIT.txt; no GPL/LGPL/MPL/CC-NC/CC-ND wording occurs.
  • debian/copyright is copyright-format 1.0; Files: * is the catch-all and later stanzas override it (copyright-format 6.9); every pattern was matched against the tree and all Files-Excluded paths verified absent.
  • The 20 rars-derived sources named in debian/copyright:49-71 do claim MIT OR Apache-2.0 in their headers (grep MIT OR Apache-2.0): codec/legacy/{rar15,rar15_encoder,rar20,rar20_encoder,rar29,rar29_encoder,ppmd,rarvm}.rs, codec/common/{filters,match_finder}.rs, crypto/{rar13,rar50}.rs, format/rar13/{mod,write}.rs, format/rar5/blake2sp.rs, recovery/legacy.rs, recovery/rar50/{mod,gf16}.rs, recovery/rev3/{mod,rs8}.rs and lzss_huff/encoder/parse/optimal.rs; THIRD_PARTY_LICENSES.md repeats the same claim.
  • crates/rar/tests/fixtures/rar13/README is the Russian RAR 1.40 (beta) README in CP866 (it lists RAR DOC, LICENSE DOC, TECHNOTE DOC), i.e. RARLAB material; crates/rar/tests/fixtures/rar40/rar154/doc_154_best.rar lists 17 .MD members (README.md, ARCH..., RAR1..., RAR5..., TEST...).
  • Every archive, volume and binary under crates/rar/tests/fixtures/ is test data, not built and not installed: rar13/ (including rar140_av/), rar40/ with comment/, encrypted/, multivol/, rar154/, rar2/, rar300/, rarvm/, repair/, rev3/, winrar591/, and rar50/. That covers the 31 unidentified binaries the scan listed: crates/rar/tests/fixtures/rar13/{BIG80K.RAR, CMULTIV.R00, CMULTIV.R01, CMULTIV.R02, CMULTIV.R03, CMULTIV.R04, CMULTIV.R05, CMULTIV.R06, CMULTIV.RAR, COMMENT.RAR, EMPTY.RAR, FCOMM.RAR, MULTIFIL.RAR, MULTIVOL.R00, MULTIVOL.R01, MULTIVOL.R02, MULTIVOL.RAR, README.RAR, README_password=password.rar, README_store.rar, REPEATB.RAR, SOLID.RAR, STOREPWD.RAR, WITHDIR.RAR}, crates/rar/tests/fixtures/rar13/rar140_av/{rar140_av_patched.rar, rar140_noav_baseline.rar}, crates/rar/tests/fixtures/rar13/solid_flag_cleared.rar and crates/rar/tests/fixtures/rar40/rev3/{rev_newstyle.part1.rev, rev_newstyle.part2.rev, rev_oldstyle.part4_2_1.rev, rev_oldstyle.part4_2_2.rev}; they are RAR 1.3 archives and RAR 3 recovery volumes read by the tests.
  • The rest of the fixture archives are the same kind of RAR test input (created by WinRAR/RAR or by the project's own writer, read by the tests, neither built nor installed): crates/rar/tests/fixtures/rar40/winrar591_store_m0.rar; crates/rar/tests/fixtures/rar40/comment/comment_zh.rar; crates/rar/tests/fixtures/rar40/encrypted/{header_enc_1234.rar, header_encrypted_multivol_rar300.r00, header_encrypted_multivol_rar300.rar, header_rar300_password.rar, header_rar420_password.rar, rar4_longpw_hp.rar, rar4_longpw_p.rar}; crates/rar/tests/fixtures/rar40/multivol/{compressed_multivol_prng_rar300.rar, compressed_multivol_prng_rar300.r00, compressed_multivol_prng_rar300.r01, compressed_multivol_prng_rar300.r02, compressed_multivol_prng_rar300.r03, encrypted_multivol_rar300.rar, encrypted_multivol_rar300.r00, multivol_newnaming_rar300.part01.rar, multivol_newnaming_rar300.part02.rar, multivol_oldnaming_rar300.rar, multivol_oldnaming_rar300.r00, stored_multivol_rar300.rar, stored_multivol_rar300.r00, stored_multivol_rar300.r01, stored_multivol_rar300.r02}; crates/rar/tests/fixtures/rar40/rar154/{audio_dos_names_unpack15.rar, audio_win_names_unpack15.rar, doc_154_best.rar, random.rar, random.r00, random.r01, readme_154_normal.rar, readme_154_password.rar, readme_154_store_solid.rar, solid_flag_cleared_rar15.rar}; crates/rar/tests/fixtures/rar40/rar2/{SOLID.RAR, comment_nopsw.rar, comment_psw.rar, rar20.rar, unpack20_audio_text.rar, unpack20_keep_tables.rar, unpack20_multiblock.rar}; crates/rar/tests/fixtures/rar40/rar300/{compressed_text_rar300.rar, ppmd_escape_rar300.rar, ppmd_lorem_rar300.rar, ppmd_lz_match_rar300.rar, ppmd_mixed_rar300.rar, ppmd_solid_rar300.rar, rarvm_audio_stereo_rar300.rar, rarvm_delta_4ch_rar300.rar, rarvm_itanium_synthetic_rar300.rar, rarvm_rgb_gradient_rar300.rar, rarvm_x86_e8_rar300.rar, rarvm_x86_e8e9_rar300.rar, solid_rar300.rar, solid_simple_rar300.rar}; crates/rar/tests/fixtures/rar40/rarvm/{delta_64_channels.rar, generic_delta_padding_mutation.rar, ppmd_embedded_vm_filter.rar, solid_e8_filter_member_offset.rar}; crates/rar/tests/fixtures/rar40/repair/{rar250_protect_head_rr1.rar, rar250_protect_head_rr5.rar}; crates/rar/tests/fixtures/rar40/rev3/{rev_newstyle.part1.rar, rev_newstyle.part2.rar, rev_newstyle.part3.rar, rev_newstyle.part4.rar, rev_oldstyle.part1.rar, rev_oldstyle.part2.rar, rev_oldstyle.part3.rar, rev_oldstyle.part4.rar}; crates/rar/tests/fixtures/rar40/winrar591/{c_m0.rar, c_m3.rar, c_m5.rar, c_pw.rar, c_solid.rar}; crates/rar/tests/fixtures/rar50/{winrar5_multiple_files.rar, winrar5_ntfs_stream.rar, winrar5_ntfs_stream_p.rar, winrar5_with_recovery_rr5.rar} and crates/rar/tests/fixtures/rar50/tail-match-362.bin (LZ tail-match regression input).
  • crates/rar/tests/fixtures/rar40/rarvm/solid_e8_filter_payload.exe is the expected decoded payload of the solid E8 filter test (read at crates/rar/tests/rar_vm_filters.rs:47 alongside solid_e8_filter_lead.txt); crates/rar/tests/fixtures/rar40/rarvm/README.md calls both expected payloads, and debian/source/lintian-overrides records it as manually constructed test data, so it is test data rather than a program built from absent sources. I did not open the binary.
  • Expected extraction payloads rar13/README, rar13/CMULTI.TXT, rar40/comment/comment.txt and rar40/rarvm/solid_e8_filter_lead.txt are test data read by the tests (e.g. crates/rar-cli/tests/winrar_interop/rar13.rs).
  • .pc/ was ignored throughout, as instructed.
  • uscan found upstream releases with debian/watch; a newer upstream version is available (upstream 0.14.0, packaged 0.12.0+dfsg), which is not a fault of the package.
  • Every pointer of debian/copyright to /usr/share/common-licenses names a file that is there (Apache-2.0).
Not confirmed ◂
  • Not built and the test suite was not run; the archive's build daemons and autopkgtest will exercise the build.
  • The RAR tool available here cannot read the old fixtures (Invalid RAR archive: signature not found for crates/rar/tests/fixtures/rar13/README.RAR; Unsupported RAR4 compression algorithm version 15 for crates/rar/tests/fixtures/rar40/rar154/doc_154_best.rar), so the member contents of the rar13 archives and of the rar154 archives were not opened.
  • The .exe fixture's bytes were not inspected; that it is a synthetic payload rests on its README and the lintian override.
  • No licence statement is inside crates/rar/tests/fixtures/rar13/README, so whether RARLAB's shareware terms permit its redistribution could not be verified.
  • Whether the .md members of crates/rar/tests/fixtures/rar40/rar154/doc_154_best.rar are the rar-rs project's own docs or rars' could not be determined.
Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader rejected this upload in response to the review.

Review Information

rejected — allocated to dfsg-uploader 4 hours ago, started 4 hours ago, completed 4 hours ago.

Final Comment

The uploader rejected this upload in response to the automated (LLM) review of it, so that they can fix the problems it found and upload again.

Back to Dashboard | View all reviews for this package