DFSG NEW Queue

DFSG, Licensing & New Packages Team

Review: rocm-llvm 7.2.3+dfsg-1~exp1

New Package Report

.changes
Distributionexperimental
DateFri, 22 May 2026 09:03:11 +0200
Sourcerocm-llvm
Version7.2.3+dfsg-1~exp1
Changed-ByTalha Can Havadar
Architecturesource amd64
Changelog
rocm-llvm (7.2.3+dfsg-1~exp1) experimental; urgency=medium
 .
   [ Talha Can Havadar ]
   * New upstream version 7.2.3+dfsg
   * d/p/upstream-llvm-compatibility: remove not needed reinterpret_cast.
     This fixes offload compression issue we see in ROCm stack with LLVM-21
     (LP: #2142813)
   * d/copyright: add libsycl and orc-rt into excluded files
   * d/patches: drop LLVM 21 compat patches superseded by upstream and
     LLVM 22 bump.
     Remove four patches that are no longer needed:
     cmake-4-compat.patch
     comgr-fix-createAsmStreamer.patch
     fix-DiagnosticOptions-IntrusiveRefCntPtr.patch
       These three carry Applied-Upstream headers pointing at commits
       that are already present in the 7.2.3 source tree, so they no
       longer apply cleanly nor add anything.
     upstream-llvm-compatibility.patch
       Worked around LLVM 21's removal of CompressedOffloadBundle::
       V3HeaderSize and an unsigned-char Header cast. With the rest of
       the package being bumped to LLVM 22, this LLVM-21-targeted
       workaround is no longer applicable.
   * debian: bump LLVM toolchain dependency from 21 to 22.
     ROCm 7.2.3's device-libs source uses AMDGPU builtins (the GFX12.5
     cluster intrinsics, among others) that are not present in clang-21.
     Move the package to the LLVM 22 toolchain available in resolute.
     debian/control: Bump b-d from 21 to 22 and the equivalent runtime deps
      Rename the rocm-device-libs-21 to rocm-device-libs-22
     debian/rules: Point comgr's CMAKE_PREFIX_PATH at /usr/lib/llvm-22.
      Add a DEVICE_LIBS_CONFIG_FLAGS entry that force-enables the AMDGPU
      subtarget features lerp-inst, cube-insts, qsad-insts and sad-insts
      via CLANG_OPTIONS_APPEND.
   * d/patches: refresh after upstream bump
   * d/patches: adapt comgr to LLVM 22 clang/Options/ split.
     LLVM 22 lifted the clang options machinery out of the Driver library
     into its own clang/Options tree.
     Without the patch, comgr-compiler.cpp fails to compile against
     libclang-cpp22-dev with "clang/Driver/Options.h: No such file or
     directory" and, once the include is fixed, "'GetResourcesPath' is not
     a member of 'clang::driver::Driver'".
     Upstream ROCm has done the equivalent migration on amd-staging, so
     this should drop out the next time the package syncs against an
     upstream that includes the change.
   * d/rules: stricter symbols check with level 4
   * d/p/fix-hip-clang-path.patch: bump to llvm-22
   * d/copyright: all licensing moved from NCSA-AMD to Apache 2.
     Upstream changed the licensing of the files in this package from
     NCSA-AMD to Apache-2-with-LLVM-exceptions following the upstream llvm
     project. Reflecting this change in copyright and also adding missing
     authors for debian/* files.
   * d/t/{control,amd-comgr-cmake.sh}: add amd_comgr find_package test
   * d/control: remove riscv64 from targets as it is FTBFS.
     This package with the current state, fails to build due to missing
     dependencies on riscv64. Ideally we can split rocm-device-libs into
     separate source package and add riscv64 target back for the rest but
     removing riscv64 targets from this source package for now.
 .
   [ Igor Luppi ]
   * d/control: Fix dependency to explicitly require libstdc++-16-dev for
     ROCm v7.1.0 stack (LP: #2143637)
.dsc
Componentmain
Package-Listhipcc deb devel optional arch=amd64,arm64,ppc64el
libamd-comgr-dev deb libdevel optional arch=amd64,arm64,ppc64el
libamd-comgr3 deb libs optional arch=amd64,arm64,ppc64el
rocm-device-libs-22 deb libs optional arch=amd64,arm64,ppc64el
Sectiondevel
Priorityoptional
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: llvm-project
Source: https://github.com/ROCm/llvm-project
Files-Excluded: amd/comgr/test/source/legacy
                amd/comgr/test/source/*.s
                amd/comgr/test/source/*.b
                amd/git-hooks
                amd/README.md
                amd/utils
                .azuredevops
                .ci
                .clang-format
                .clang-format-ignore
                .clang-tidy
                .git-blame-ignore-revs
                .gitattributes
                .github
                .gitignore
                .mailmap
                CODE_OF_CONDUCT.md
                CONTRIBUTING.md
                LICENSE.TXT
                README.md
                SECURITY.md
                bolt
                clang
                clang-tools-extra
                cmake
                compiler-rt
                cross-project-tests
                flang
                flang-rt
                libc
                libclc
                libcxx
                libcxxabi
                libunwind
                lld
                lldb
                llvm
                llvm-libgcc
                mlir
                offload
                openmp
                polly
                pstl
                pyproject.toml
                revert_patches.txt
                runtimes
                third-party
                utils
                libsycl
                orc-rt
Comment: These files are the LLVM codes from upstream repository.
 As we are using the LLVM in Debian's official archive, we exclude
 the LLVM-related codebase from the source package.
 .
 Besides, amd/comgr/test/source/legacy/* and *.s binary/assemble files are used to emit
 LLVM amdgpu v2/v3 code, which violates DFSG, so we exclude them as well.

Files: amd/hipcc/*
Copyright: 2008-2025, Advanced Micro Devices, Inc.
License: Expat

Files: amd/comgr/*
Copyright: 2014-2025, Advanced Micro Devices, Inc.
License: APACHE-2-LLVM-EXCEPTIONS
Comment: amd/comgr/LICENSE.txt was relicensed from NCSA to the Apache License
 v2.0 with LLVM Exceptions, and every source and test file under amd/comgr/
 now carries an SPDX "Apache-2.0 WITH LLVM-exception" header. A "Legacy Comgr
 License" section retaining the original NCSA terms is preserved in
 amd/comgr/LICENSE.txt for historical reference only.

Files: amd/device-libs/*
Copyright: 2014-2016, Advanced Micro Devices, Inc.
License: NCSA

Files: debian/*
Copyright: 2022, Maxime Chambonnet <maxzor@maxzor.eu>
           2022-2023, Étienne Mollier <emollier@debian.org>
           2022-2025, Cordell Bloor <cgmb@debian.org>
           2024, Xuanteng Huang <xuanteng.huang@outlook.com>
           2024, Christian Kastner <ckk@debian.org>
           2025, Igor Luppi <igor.luppi@canonical.com>
           2025-2026, Talha Can Havadar <havadartalha@gmail.com>
License: Expat
Comment: Some contents in the metafiles are borrowed from the origin rocm-hipamd
 repository (https://salsa.debian.org/rocm-team/rocm-hipamd) so we inherit the
 copyrights from there.

License: Expat
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in
 all copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.

License: APACHE-2-LLVM-EXCEPTIONS
 On Debian systems the full text of the Apache Software License 2.0 can be
 found in the `/usr/share/common-licenses/Apache-2.0' file.
 .
 ---- LLVM Exceptions to the Apache 2.0 License ----
 .
 As an exception, if, as a result of your compiling your source code, portions
 of this Software are embedded into an Object form of such source code, you
 may redistribute such embedded portions in such Object form without complying
 with the conditions of Sections 4(a), 4(b) and 4(d) of the License.
 .
 In addition, if you combine or link compiled forms of this Software with
 software that is licensed under the GPLv2 ("Combined Software") and if a
 court of competent jurisdiction determines that the patent provision (Section
 3), the indemnity provision (Section 9) or other Section of the License
 conflicts with the conditions of the GPLv2, you may retroactively and
 prospectively choose to deem waived or otherwise exclude such Section(s) of
 the License, but only in their entirety and only with respect to the Combined
 Software.

License: NCSA
 University of Illinois/NCSA
 Open Source License
 .
 All rights reserved.
 .
 Permission is hereby granted, free of charge, to any person obtaining a copy of
 this software and associated documentation files (the "Software"), to deal with
 the Software without restriction, including without limitation the rights to
 use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
 of the Software, and to permit persons to whom the Software is furnished to do
 so, subject to the following conditions:
 .
 * Redistributions of source code must retain the above copyright notice,
   this list of conditions and the following disclaimers.
 * Redistributions in binary form must reproduce the above copyright notice,
   this list of conditions and the following disclaimers in the
   documentation and/or other materials provided with the distribution.
 * Neither the names of the LLVM Team, University of Illinois at
   Urbana-Champaign, nor the names of its contributors may be used to
   endorse or promote products derived from this Software without specific
   prior written permission.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
 FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
 CONTRIBUTORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS WITH THE
 SOFTWARE.

Review Information

accepted — allocated to mechtilde 30 days ago, started 30 days ago, completed 30 days ago.

Final Comment

Hi,

At the next upload please add the files with the missed author separately.
Thanks

Public Notes

30 days ago ● public

Missed Author Check

Command: dnq author-check
Exit code: 0

Using active review (from current.json): rocm-llvm
Author check: rocm-llvm 7.2.3+dfsg-1~exp1

Scanned 881 files.
Authors declared in debian/copyright: 8

NOT IN debian/copyright (1):

  Sun Microsystems, Inc
    amd/device-libs/ocml/src/erfcD.cl:32
    amd/device-libs/ocml/src/erfcF.cl:32
    amd/device-libs/ocml/src/lgamma_rD.cl:15
    amd/device-libs/ocml/src/lgamma_rF.cl:14

Result: ATTENTION REQUIRED — 1 author not in debian/copyright

Back to Dashboard | View all reviews for this package