DFSG NEW Queue

DFSG, Licensing & New Packages Team

Review: rocprofiler-register 7.2.4+ds-1~exp1

Package Information

DescriptionROCm library for HSA/HIP/ROCTx call interception

The rocprofiler-register library is a helper library that coordinates the modification of the intercept API tables of the HSA/HIP/ROCTx runtime libraries by the ROCprofiler library.

The purpose of this library is to provide a consistent and automated mechanism of enabling performance analysis in the ROCm runtimes which does not rely on environment variables or unique methods for each runtime library.

MaintainerDebian ROCm Team <debian-ai@lists.debian.org>
Changed ByBastien Roucariès <rouca@debian.org>
Sponsorrouca@debian.org
Distributionexperimental
Architectureamd64 arm64 ppc64el
VCSgit: https://salsa.debian.org/rocm-team/rocprofiler-register.git (browse)
Closes#1111519
Trackerhttps://tracker.debian.org/pkg/rocprofiler-register
Uploaded27 days ago

New Package Report

.changes◂
Version7.2.4+ds-1~exp1
Changed-ByBastien Roucariès <rouca@debian.org>
Architecturesource amd64
Distributionexperimental
DateSun, 04 Oct 2026 19:41:13 +0200
Sourcerocprofiler-register
Changelog◂ 
rocprofiler-register (7.2.4+ds-1~exp1) experimental; urgency=medium
 .
   * Initial release. (Closes: #1111519)
.dsc◂
Package-Listlibrocprofiler-register-0 deb devel optional arch=amd64,arm64,ppc64el
librocprofiler-register-0-dev deb devel optional arch=amd64,arm64,ppc64el
Sectiondevel
Priorityoptional
Componentmain
debian/copyright◂ 
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://github.com/ROCm/rocm-systems/
Upstream-Name: rocprofiler-register
Upstream-Contact: https://github.com/ROCm/rocm-systems/
Files-Excluded: *
Files-Included: projects/rocprofiler-register/*
Comment: upstream use a mono repo. Drop every file than include only the library dir.
 See  mk-origtargz (1)

Files: *
Copyright: 2014-2025 Advanced Micro Devices, Inc.
License: Expat

Files: debian/*
Copyright: 2026 Bastien Roucariès
License: Expat

License: Expat
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in all
 copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.

Review Information

accepted — allocated to awm 26 days ago, started 26 days ago, completed 26 days ago.

Final Comment

Hi,

An LLM assisted review came up with the following issues. Due to the somewhat bleeding edge nature of ROCm I wouldn't be at all surprised to find these are not actually issues, but maybe they are... I'm pretty sure that first issue is wrong in some ways though :-)

  1. [packaging] libhsa-runtime-dev build-dep is unneeded and amd64-only, making arm64/ppc64el
    unbuildable
  • Files: debian/control:4-10, debian/control:21
  • Evidence: Build-Depends: debhelper-compat (= 14), architecture-is-64-bit, cmake, libhsa-runtime-dev (>= 7~), libgoogle-glog-dev, libfmt-dev; Architecture: amd64 arm64 ppc64el. apt-cache shows libhsa-runtime-dev ... Architecture: amd64 (both 7.2.4+dfsg-1~exp1 and 6.4.3+dfsg-5).
  • Problem: The library does not include any HSA header: source/ only declares #pragma weak/extern import symbols for hsa/hip/roctx (rocprofiler_register.cpp) and the HSA/HIP/ROCTx mock runtimes are built only from the tests tree, which is OFF by default (ROCPROFILER_REGISTER_BUILD_TESTS OFF, not enabled in rules). CMake links only fmt, glog, dl, stdc++fs, Threads. The dependency is therefore unused, and because libhsa-runtime-dev exists only for amd64 the Build-Depends are unsatisfiable on arm64 and ppc64el, so the two architectures declared in the Architecture field can never be built (a sponsor would reject the arch list / dep combination).
  • Fix: Drop libhsa-runtime-dev (>= 7~) from Build-Depends (it is not needed to compile or link), which also lets arm64/ppc64el satisfy the build-dependencies; reconsider whether ppc64el (not a ROCm target) belongs in Architecture at all.
  1. [packaging] debian/watch: wrong GitHub template Project name and dead Filename-Mangle
  • Files: debian/watch:4-19
  • Evidence: Project: rocm-system (actual repo is ROCm/rocm-systems, masked only by the explicit Source: field); uscan verbose: Parsing filenamemangle: s%.*/(?:[-_]?[Vv]?([0-9...]))%rocprofiler-register-$1.tar.gz% then Filename (filenamemangled) for downloaded file: rocm-7.2.4.
  • Problem: The template's Owner/Project pair points at a non-existent repository and only works because Source: overrides it; the Filename-Mangle pattern cannot match the GitHub API/tarball URL once @ANY_VERSION@ expands to the version regex, so the intended rocprofiler-register-<ver>.tar.gz filename is never produced (uscan would save rocm-7.2.4). Purely cosmetic; the scan itself finds and compares rocm-7.2.4 correctly.
  • Fix: Use Project: rocm-systems, drop the now-redundant Source/Matching-Pattern overrides, and either fix the Filename-Mangle so it matches the version digits at the end of the mangled download URL or drop it.

Thanks!

Back to Dashboard | View all reviews for this package