Review: rust-anstyle-hyperlink 1.0.2-1
Package Information
| Description | ANSI escape code hyperlinks (OSC 8) - Rust source code Source code for Debianized Rust crate "anstyle-hyperlink" |
|---|---|
| Maintainer | Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net> |
| Changed By | Simon Quigley <tsimonq2@debian.org> |
| Sponsor | tsimonq2@debian.org |
| Distribution | unstable |
| Architecture | any |
| VCS | git: https://salsa.debian.org/rust-team/debcargo-conf.git [src/anstyle-hyperlink] (browse) |
| Tracker | https://tracker.debian.org/pkg/rust-anstyle-hyperlink |
| Uploaded | 28 days ago |
New Package Report
.changes
| Distribution | unstable |
|---|---|
| Date | Sat, 10 Oct 2026 07:50:15 -0500 |
| Source | rust-anstyle-hyperlink |
| Version | 1.0.2-1 |
| Changed-By | Simon Quigley <tsimonq2@debian.org> |
| Architecture | source amd64 |
Changelog
rust-anstyle-hyperlink (1.0.2-1) unstable; urgency=medium . * Package anstyle-hyperlink 1.0.2 from crates.io using debcargo 2.8.4
.dsc
| Section | rust |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | librust-anstyle-hyperlink-dev deb rust optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: anstyle-hyperlink Upstream-Contact: Ed Page <eopage@gmail.com> Source: https://github.com/rust-cli/anstyle.git Files: * Copyright: 2026 Ed Page <eopage@gmail.com> 2026 Daniel Scherzer <daniel.e.scherzer@gmail.com> Individual contributors License: Expat or Apache-2.0 Comment: Named holders are the git authors of crates/anstyle-hyperlink. LICENSE-MIT reads "Copyright (c) Individual contributors". Files: debian/* Copyright: 2026 Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net> 2026 Simon Quigley <tsimonq2@debian.org> License: Expat or Apache-2.0 License: Apache-2.0 Debian systems provide the Apache 2.0 license in /usr/share/common-licenses/Apache-2.0 License: Expat Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
DFSG Assistant LLM REVIEW 0 blocker, 1 important, 0 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 24 days ago.
Report
DFSG NEW review for rust-anstyle-hyperlink version 1.0.2-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: No - Packaging is of good quality: Yes
- Issues: 0 blocker, 1 important, 0 minor
- debian/watch: version 5
- debian/copyright: machine-readable
Licensing
The upstream code is dual-licensed Expat (MIT) or Apache-2.0, both DFSG-free, and debian/copyright is in DEP-5 format with the full Expat text reproduced and Apache-2.0 pointed at /usr/share/common-licenses; no non-free terms, no minified/generated binaries and no vendored libraries are present. The one inaccuracy is src/hostname.rs, which its own header states is copied from ripgrep: that file's third-party copyright is not represented by the Files: * stanza, which attributes every upstream file only to the anstyle-hyperlink git authors under 'Expat or Apache-2.0'.
Packaging
Standard debcargo-generated packaging: dh-sequence-cargo with debhelper compat 13, correct Build-Depends/Build-Depends-Arch split, a single librust-anstyle-hyperlink-dev package with Architecture: any / Multi-Arch: same and the usual collapsed Provides, current Standards-Version 4.7.4, Vcs-* fields, a well-formed DEP-3 relax-deps patch limited to the generated Cargo.toml, and six autopkgtests. All dependencies (librust-libc-0.2+default-dev >= 0.2.180, librust-percent-encoding-2+default-dev >= 2.3.2, librust-snapbox-0.6+default-dev >= 0.6.21) resolve on the archive. Nothing a sponsor would require changed.
Issues
important licensing 1. debian/copyright misses the ripgrep copyright/licence of the copied src/hostname.rs ◂
- Files:
src/hostname.rs:1; debian/copyright, 'Files: *' stanza (lines 6-14) - Evidence: src/hostname.rs:1
// Copied from https://github.com/BurntSushi/ripgrep/blob/7099e174acbcbd940f57e4ab4913fee4040c826e/crates/cli/src/hostname.rs; the file carries no copyright notice of its own, and debian/copyright's catch-all statesFiles: */Copyright: 2026 Ed Page ... 2026 Daniel Scherzer ... Individual contributors/License: Expat or Apache-2.0. - Problem: The file is verbatim third-party code from ripgrep (MIT or Unlicense, (c) Andrew Gallant). Under the MIT option its copyright notice and permission notice must be retained, so the blanket Files: * stanza, which names only the anstyle-hyperlink git authors and offers 'Expat or Apache-2.0' for every upstream file, does not accurately describe this file's copyright and licensing.
- Fix: Add a separate Files stanza for src/hostname.rs naming the ripgrep copyright holder (Andrew Gallant / the ripgrep contributors) and the MIT or Unlicense terms (including the notice text), or obtain confirmation from upstream that the file is covered by their licensing and state the provenance.
Verified ◂
- Read all of debian/ (control, rules, changelog, copyright, copyright.debcargo.hint, debcargo.toml, source/format, tests/control, upstream/metadata, cargo-checksum.json, patches/series, patches/relax-deps.patch) and the .dsc.
- Read LICENSE-APACHE, LICENSE-MIT, README.md, Cargo.toml, Cargo.toml.orig and every file under src/ (lib.rs, hyperlink.rs, hostname.rs, file.rs in full); grepped the tree for copyright/licence markers.
- Upstream tree is only Cargo.toml, Cargo.toml.orig, Cargo.lock, .cargo_vcs_info.json, LICENSE-APACHE, LICENSE-MIT, README.md and src/*.rs; no binaries, fonts, images, minified JS/CSS, .so/.a, or vendored third-party directories.
- The only non-anstyle provenance marker in the tree is the 'Copied from ... ripgrep' header of src/hostname.rs.
- All runtime and test dependencies exist: librust-libc-dev 0.2.186 provides librust-libc-0.2+default-dev; librust-percent-encoding-dev 2.3.2-2+b1 provides librust-percent-encoding-2+default-dev; librust-snapbox-dev 0.6.21-1+b1 provides librust-snapbox-0.6+default-dev; dh-sequence-cargo/debhelper-compat 13 used as standard.
- Standards-Version 4.7.4 matches the installed Debian Policy 4.7.4.1; debian/tests/control is well formed and Testsuite: autopkgtest is set in the .dsc.
- Cargo.lock was sampled (crate name/version/checksum list), not read line by line.
- uscan found the packaged version as the newest upstream release (upstream
1.0.2, packaged1.0.2).
Not confirmed ◂
- The exact wording of ripgrep's copyright/permission notice could not be read on the reviewing system (ripgrep is not installed and no file outside the package and /usr,/etc may be fetched); the finding relies on the file's own 'Copied from ... ripgrep' header and ripgrep's known MIT/Unlicense dual licensing.
- No build or test run was attempted, per the instructions; nothing in the package itself indicates a build or test failure.
Proposed changes ◂
None.
Review Information
accepted — allocated to mechtilde 23 days ago, started 23 days ago, completed 23 days ago.