Review: rust-atuin-vte 0.15.1-1
Package Information
| Description | Atuin's fork of vte, a parser for implementing terminal emulators - Rust source code Source code for Debianized Rust crate "atuin-vte" |
|---|---|
| Maintainer | Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net> |
| Changed By | Blair Nyktas <ncts@debian.org> |
| Distribution | unstable |
| Architecture | any |
| VCS | git: https://salsa.debian.org/rust-team/debcargo-conf.git [src/atuin-vte] (browse) |
| Tracker | https://tracker.debian.org/pkg/rust-atuin-vte |
| Uploaded | 2 hours ago |
New Package Report
.changes
| Source | rust-atuin-vte |
|---|---|
| Version | 0.15.1-1 |
| Changed-By | Blair Nyktas <ncts@debian.org> |
| Architecture | amd64 source |
| Distribution | unstable |
Changelog
rust-atuin-vte (0.15.1-1) unstable; urgency=medium . * Package atuin-vte 0.15.1 from crates.io using debcargo 2.8.4
.dsc
| Section | rust |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | librust-atuin-vte-dev deb rust optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: atuin-vte Upstream-Contact: Joe Wilm <joe@jwilm.com> Christian Duerr <contact@christianduerr.com> Source: https://github.com/atuinsh/vte Files: * Copyright: 2016 Joe Wilm <joe@jwilm.com> Christian Duerr <contact@christianduerr.com> License: Apache-2.0 or MIT Files: debian/* Copyright: 2026 Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net> 2026 Blair Nyktas <ncts@debian.org> License: Apache-2.0 or MIT License: Apache-2.0 Debian systems provide the Apache 2.0 license in /usr/share/common-licenses/Apache-2.0 License: MIT Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 1 hour ago.
Report
DFSG NEW review for rust-atuin-vte version 0.15.1-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 0 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
The tree is a small dual-licensed Rust crate (Apache-2.0 OR MIT, per Cargo.toml), with LICENSE-APACHE and LICENSE-MIT shipped at top level. debian/copyright is DEP-5, its Files: * catch-all covers every upstream file (src/lib.rs, src/params.rs, src/ansi.rs, Cargo.toml, Cargo.toml.orig, Cargo.lock, .cargo_vcs_info.json, README.md, both LICENSE files) and the later debian/* stanza covers the packaging. Both holders found in the tree (Joe Wilm, Christian Duerr) are named; the MIT text is reproduced in full and Apache-2.0 points at /usr/share/common-licenses/Apache-2.0. No third-party code is vendored, no non-free terms, no built or generated files. Nothing non-DFSG-free.
Packaging
Standard debcargo-generated packaging: debhelper-compat 13 with dh-sequence-cargo, a single librust-atuin-vte-dev binary with Multi-Arch: same and the usual Provides for the collapsed feature set, Build-Depends-Arch marked <!nocheck> with the runtime deps actually needed by a default-feature cargo test, feature-combination tests in debian/tests/control, 3.0 (quilt) with no patches, correct Vcs-* and Homepage, and Standards-Version 4.7.4 against Policy 4.7.4.1. No maintainer scripts, no build or upgrade hazards. It is ready for sponsorship apart from the usual review of the generated copyright, which is already resolved.
Issues
None.
Verified ◂
- Prescan: the holder check reported that every holder found is named in debian/copyright; it listed no files needing individual judgement. The only notices in the tree are
LICENSE-MIT: Copyright (c) 2016 Joe Wilmandsrc/ansi.rs:1 // SPDX-License-Identifier: Apache-2.0, both holders being named in theFiles: *stanza of debian/copyright. - Decoded the whole tree (glob with gitignore/hidden enabled): 3 upstream sources (src/lib.rs, src/ansi.rs, src/params.rs), Cargo.toml, Cargo.toml.orig, Cargo.lock, .cargo_vcs_info.json, README.md, LICENSE-APACHE (176 lines, Apache 2.0 text) and LICENSE-MIT (MIT text, Joe Wilm 2016). debian/ holds control, copyright, copyright.debcargo.hint, changelog, rules, debcargo.toml, watch, source/format, tests/control, upstream/metadata, an empty patches/ and the .pc/ and cargo-checksum.json I was told to skip.
- debian/copyright is DEP-5 (
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/), withFiles: *->License: Apache-2.0 or MIT, thenFiles: debian/*overriding for the packaging; both short names have stand-alone License paragraphs, MIT with full text and Apache-2.0 by pointer to /usr/share/common-licenses/Apache-2.0. Every path is matched by one of the two stanzas, so no file is left unlicensed. - src/ansi.rs says
// SPDX-License-Identifier: Apache-2.0and states it was originally part of alacritty_terminal, licensed under Apache-2.0; that licence is one of the two options declared forFiles: *, so the file is covered by a licence named in debian/copyright (the per-file marker is narrower than the crate-levellicense = "Apache-2.0 OR MIT"in Cargo.toml, not broader). No separate stanza needed. - Read LICENSE-MIT in full: standard MIT permission text, DFSG-free, with the copyright notice reproduced both in the file and in debian/copyright. LICENSE-APACHE is the unmodified Apache License 2.0. Mutually compatible; no non-commercial, no-modification or field-of-use terms anywhere in the tree.
- No vendored third-party sources, no subdirectory LICENSE/COPYING/NOTICE files, no fonts, images, sounds or opaque data files; no generated or built files (no target/, no minified or PDF files).
- debian/control: debhelper-compat (= 13) with dh-sequence-cargo; the single binary librust-atuin-vte-dev has Architecture: any, Multi-Arch: same, the usual Provides for the collapsed feature set, and
Breaks: rustc (<< 1.62.1~)matching rust-version 1.62.1. At compat 13 dh_gencontrol supplies ${misc:Depends} itself, and ${misc:Depends} is named here anyway. - debian/rules:
dh $@ --buildsystem cargowithoverride_dh_auto_test: dh_auto_test -- test --all. Checked /usr/share/perl5/Debian/Debhelper/Buildsystem/cargo.pm: the test step runscargo testwith the arguments given, and--allis cargo's workspace alias, not all features, so only the default features (arrayvec, memchr) are compiled; those two dev packages are exactly what Build-Depends-Arch lists. The optional bitflags, cursor-icon, log and serde deps are exercised only by the autopkgtest entries, where they come in as Depends of the -dev package. Cargo.toml has no [dev-dependencies], so no dev-dependency is missing from Build-Depends. - debian/tests/control: nine cargo-auto-test entries (
--all-features, default, and each feature and none), all withDepends: dh-cargo (>= 33~), rustc (>= 1.62.1), @andRestrictions: allow-stderr; the single-feature runs carryArchitecture: !riscv64, which is debcargo's normal exclusion for the slow feature matrix and not a defect. - Format is 3.0 (quilt), debian/patches exists but is empty with no series file (confirmed against the .debian.tar.xz member list), so there are no patches to judge for DEP-3 headers or forwarding; the .dsc, control and changelog agree on version 0.15.1-1, distribution unstable, with a signed-off entry from the uploader.
- Standards-Version 4.7.4 against Policy 4.7.4.1 (checked with the policy tool): first two components match, so it is current and not an issue.
- Dependencies exist in the archive: librust-memchr-2-dev is provided by librust-memchr-dev 2.8.3-1 (satisfies >= 2.7.4), librust-arrayvec-0.7-dev by librust-arrayvec-dev 0.7.8-1 (satisfies >= 0.7.2), librust-cursor-icon-1-dev by librust-cursor-icon-dev 1.2.0-1. librust-atuin-vte-dev is this upload. Homepage and Vcs-Git/Vcs-Browser point at the right repositories; debian/upstream/metadata names crates.io and the fork's git repository.
- debian/copyright.debcargo.hint is debcargo's working file, not installed into the binary; its
FIXME (overlay) UNKNOWN-LICENSEfor LICENSE-MIT has been resolved in the real debian/copyright, which carries the MIT text, and its year warning is moot as debian/copyright states 2016 for Joe Wilm, matching LICENSE-MIT. - uscan found the packaged version as the newest upstream release (upstream
0.15.1, packaged0.15.1). - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (Apache-2.0).
Not confirmed ◂
- debian/copyright's
Files: *names only Joe Wilm and Christian Duerr. Contributions made in the Atuin fork carry no in-file notices in the crates.io tarball (only the crate-level Cargo.toml authors and the inherited alacritty_terminal header), so whether any additional holder of fork-only changes should be named cannot be checked from the package alone; nothing in the tree contradicts the current list.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader was emailed about the review 1 hour ago.
Review Information
accepted — allocated to mechtilde 0 hours ago, started 0 hours ago, completed 0 hours ago.