DFSG NEW Queue

DFSG, Licensing & New Packages Team

rust-bazaar 3.5.5-1

Package Information

DescriptionThe Bazaar formats and protocols - Rust source code

Source code for Debianized Rust crate "bazaar"

MaintainerDebian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net>
Changed ByJelmer Vernooij <jelmer@debian.org>
Sponsorjelmer@debian.org
Distributionunstable
Architectureany
VCSgit: https://salsa.debian.org/rust-team/debcargo-conf.git [src/bazaar] (browse)
Trackerhttps://tracker.debian.org/pkg/rust-bazaar
Uploaded2 hours ago

New Package Report

.changes◂
Distributionunstable
DateSun, 22 Nov 2026 18:05:13 +0000
Sourcerust-bazaar
Version3.5.5-1
Changed-ByJelmer Vernooij <jelmer@debian.org>
Architectureamd64 source
Changelog◂
rust-bazaar (3.5.5-1) unstable; urgency=medium
 .
   * Package bazaar 3.5.5 from crates.io using debcargo 2.8.4
   * Drop gate-legacy-format-tests.patch, merged upstream.
   * Relax base64 dependency to allow 0.22.
   * Add drop-criterion.patch: criterion 0.8 is not in the archive.
   * Add fix-load-mounts-test.patch: test_load_mounts failed in chroots.
   * Add gate-knit-tests.patch from upstream: knit tests failed without the
     knit feature.
.dsc◂
Sectionrust
Priorityoptional
Componentmain
Package-Listlibrust-bazaar-dev deb rust optional arch=any
debian/copyright◂
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: bazaar
Upstream-Contact:
 Martin Packman <gzlist@googlemail.com>
 Jelmer Vernooij <jelmer@jelmer.uk>

Files: *
Copyright:
 2005-2016 Canonical Ltd.
 2018-2026 Martin Packman <gzlist@googlemail.com>
 2018-2026 Jelmer Vernooij <jelmer@jelmer.uk>
License: GPL-2.0+

Files: debian/*
Copyright:
 2026 Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net>
 2026 Jelmer Vernooij <jelmer@debian.org>
License: GPL-2.0+

License: GPL-2.0+
 Debian systems provide the GPL 2.0 in /usr/share/common-licenses/GPL-2

DFSG Assistant LLM REVIEW 0 blocker, 1 important, 1 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 1 hour ago.

Report◂

DFSG NEW review for rust-bazaar version 3.5.5-1

Summary

  • Licensing is DFSG-compliant and debian/copyright is accurate: No
  • Packaging is of good quality: No
  • Issues: 0 blocker, 1 important, 1 minor
  • debian/watch: version 5
  • debian/copyright: machine-readable
  • Scan before the review: nothing found

Licensing

The whole crate is GPL-2.0+ (declared in Cargo.toml/Cargo.toml.orig, and stated in the file headers that carry notices); there is no non-free wording, no missing licence text and no unclear-provenance data, so the licensing itself is DFSG-compliant. debian/copyright is DEP-5, its Format line is the current one, and its Files: * licence is right, but it omits two holders of src/groupcompress/rabin_delta.rs, the Git/LibXDiff-derived delta code: Nicolas Pitre and John Arbash Meinel. Because dh-cargo installs the crate unmodified as plain text (so the notices travel with it), Policy 2.3 does not require those notices in the binary's copyright file and the omission is minor, but a complete DEP-5 file should name them.

Packaging

The debcargo-generated packaging is otherwise sound: correct Build-Depends and binary split, compat 13 with dh-sequence-cargo, current Standards-Version, valid Vcs-*/Homepage/upstream metadata, a working autopkgtest matrix, and dependency versions that all exist in the archive (checked against the package lists). The one real defect is patch hygiene: debian/patches/fix-load-mounts-test.patch and gate-knit-tests.patch are shipped but absent from patches/series, while the changelog says they were added; both changes are already in upstream 3.5.5, so the files are dead weight and the changelog misdescribes the upload. One build-dependency asymmetry (gpg's sequoia crate in Depends but not Build-Depends-Arch) is noted as unconfirmed.

Issues

important packaging 1. fix-load-mounts-test.patch and gate-knit-tests.patch are shipped but not in patches/series, though the changelog says they were added ◂
  • Files: debian/patches/fix-load-mounts-test.patch, debian/patches/gate-knit-tests.patch, debian/patches/series, debian/changelog:7-9, src/osutils/mounts-unix.rs:146-154, src/workingtree/mod.rs:4439
  • Basis: checked, in the package or with a reference tool
  • Evidence: debian/patches/series holds only drop-criterion.patch, relax-deps, fix-fancy-regex-captures.patch, and .pc/applied-patches agrees; the changelog nevertheless says * Add fix-load-mounts-test.patch: test_load_mounts failed in chroots. and * Add gate-knit-tests.patch from upstream: knit tests failed without the knit feature. Yet the unpacked sources already contain both changes: assert!(mounts .windows(2) .all(...)) in mounts-unix.rs and a #[cfg(feature = "knit")] gate before fn create_commit_read_knit() in workingtree/mod.rs.
  • Problem: Upstream 3.5.5 already carries both fixes, so the two patch files can never be applied (adding them to series would make dpkg-source fail); they are obsolete leftovers. The changelog entry is therefore factually wrong about the contents of the source package, which misleads users and future maintainers, and the unused files are dead weight in the diff.
  • Fix: Delete debian/patches/fix-load-mounts-test.patch and debian/patches/gate-knit-tests.patch, and drop (or reword to say the fixes are merged upstream) the two changelog bullets that claim they were added.
minor licensing 2. Files: * does not name Nicolas Pitre and John Arbash Meinel, holders of src/groupcompress/rabin_delta.rs ◂
  • Files: debian/copyright, src/groupcompress/rabin_delta.rs:14-15

  • Basis: checked, in the package or with a reference tool

  • Evidence:

    In src/groupcompress/rabin_delta.rs:

    /// Rewritten for GIT by Nicolas Pitre <nico@fluxnic.net>, (C) 2005-2007
    /// Adapted for Bazaar by John Arbash Meinel <john@arbash-meinel.com> (C) 2009
    

    while the Files: * stanza names only 2005-2016 Canonical Ltd., Martin Packman and Jelmer Vernooij.

  • Problem: The file states two copyright holders that debian/copyright does not name, so the DEP-5 file is incomplete. Policy 2.3 does not require their notices in the binary package's copyright file here: dh-cargo's install step (/usr/share/perl5/Debian/Debhelper/Buildsystem/cargo.pm, sub install) copies the crate unchanged to /usr/share/cargo/registry/bazaar-3.5.5/, so rabin_delta.rs ships as plain text with its notice still in it (Policy 2.3, condition 3). It is nonetheless a real gap in a machine-readable copyright file, and the licence stated there (GPL-2.0+) is correct, including the note that Nicolas Pitre allowed use under "version 2 or later".

  • Fix:

    Add a stanza before the Files: * one (or after it) for the file, e.g.

    Files: src/groupcompress/rabin_delta.rs
    Copyright: 2005-2007 Nicolas Pitre <nico@fluxnic.net>
               2009 John Arbash Meinel <john@arbash-meinel.com>
    License: GPL-2.0+
    
Verified ◂
  • Inventoried the whole tree (coverage: every path outside .pc/ and debian/, 123 files per the prescan): only Rust sources, TOML, Markdown and JSON; no built programs/libraries, minified code, archives, PDFs, fonts, images or other binary files, and no generated source without its generator.
  • No LICENSE/COPYING file is shipped; the licence is declared in Cargo.toml.orig and Cargo.toml as license = "GPL-2.0+" and the crate source is GPL-2+-headed, so nothing is unlicensed.
  • Files carrying notices: src/btree_serializer.rs (Canonical 2008-2010, Jelmer Vernooij 2024, GPL-2+), src/recordcounter.rs (Canonical 2010, GPL-2+), src/rio.rs (Jelmer Vernooij 2023, Canonical 2005; copyright lines only, covered by the crate-level GPL-2.0+), all named in debian/copyright except as noted; src/groupcompress/rabin_delta.rs (covered by the licensing issue).
  • The FIXME-UNKNOWN-LICENSE stanzas in debian/copyright.debcargo.hint for src/btree_serializer.rs, src/recordcounter.rs and src/rio.rs are resolved: the first two state GPL-2+ in their headers and the third is the crate author's own file under the crate's GPL-2.0+ declaration.
  • /// This code was greatly inspired by parts of LibXDiff from Davide Libenzi in rabin_delta.rs is an acknowledgement, not a separate copyright/grant line; the file's own GPL-2+ notice covers the code.
  • debian/copyright uses the current DEP-5 Format URL, has a Files: * stanza, a debian/* stanza and one stand-alone GPL-2.0+ paragraph pointing at /usr/share/common-licenses/GPL-2; no Files-Excluded is needed (unmodified crates.io tarball).
  • No non-free terms anywhere in the tree: searched for non-commercial, no-modification, field-of-use and similar wording, plus MPL/MIT/ISC/CC0/LGPL/dual-licence markers; none found.
  • Package metadata: Standards-Version 4.7.4 against Policy 4.7.4.1 (current); debhelper compat 13 with dh-sequence-cargo; Section rust; Multi-Arch: same on the single -dev package; Vcs-Git/Vcs-Browser on salsa.debian.org/rust-team/debcargo-conf; Homepage; X-Cargo-Crate/-Version; debian/upstream/metadata complete; debian/source/format 3.0 (quilt); changelog version 3.5.5-1, distribution unstable; no maintainer scripts.
  • Build-Depends versions checked with apt-cache: memchr 2.8.3, vcs-graph 3.6.0, pyo3 0.28.2, adler2 2.0.1, inventory 0.3.25, patiencediff 0.3.0, rand 0.10.3, bendy 0.6.1, sequoia-openpgp 2.4.2 (provides the -2+crypto-openssl virtual name), fancy-regex 0.11.0, xmltree 0.10.3, base64 0.22.1, nix 0.30.1, lru 0.16.4, md-5 0.11.0 - all satisfy the declared ranges, and the relax-deps ranges match what unstable has.
  • The patched dependency versions are exercised by the code: fancy-regex 0.11 is the Captures<'_> form fix-fancy-regex-captures.patch adapts to, and xmltree is used only through Element::parse, available in 0.10.3.
  • criterion 0.8 is not in the reviewing system's package lists, matching the stated reason for drop-criterion.patch; the patch removes the bench targets and the dev-dependency, so the remaining benches/*.rs are inert files.
  • debian/tests/control is well-formed autopkgtest control: dh-cargo + rustc with the binary package's own Depends (@), per test the @ is expanded so the gpg all-features test gets librust-sequoia-openpgp-2+crypto-openssl-dev from librust-bazaar-dev's Depends.
  • The override_dh_auto_test: dh_auto_test -- test --all target at compat 13 is not run in a nocheck build; all test-time Build-Depends are correctly marked <!nocheck>, and with test passed to dh_auto_test the crate's tests (tempfile and friends are ordinary deps; no dev-dependencies remain after drop-criterion) are the only thing compiled.
  • The prescan's other categories (built files, minified code, PDFs, non-free wording, unacceptable licences) found nothing to explain.
  • uscan found the packaged version as the newest upstream release (upstream 3.5.5, packaged 3.5.5).
  • Every pointer of debian/copyright to /usr/share/common-licenses names a file that is there (GPL-2).
Not confirmed ◂
  • Build-Depends-Arch omits librust-sequoia-openpgp-2+crypto-openssl-dev although Cargo.toml declares sequoia-openpgp as an optional normal dependency and librust-bazaar-dev Depends on it for the gpg feature; cargo resolves normal dependencies - including inactive optional ones, and target-specific ones, which is why relax-deps strips the cfg(windows) winapi dependency - against the registry linked from /usr/share/cargo/registry, and only dev-dependencies are skipped (the wrapper adds -Zavoid-dev-deps). A clean sbuild would show whether cargo build fails with "no matching package named sequoia-openpgp" when the gpg feature is off; if it does not, the omission is intentional and harmless.
  • The gpg and other feature tests in debian/tests/control carry Architecture: !riscv64 while the --all-features test, which also enables gpg, has no architecture restriction; whether that is deliberate (sequoia unavailable/FTBFSing on riscv64) could only be judged from an autopkgtest run on riscv64.
Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader was emailed about the review 1 hour ago.

Back to Dashboard | View all reviews for this package