Review: rust-binstring 0.1.8-1
Package Information
| Description | Rust crate to convert binary data to an ASCII text format and back - Rust source code Source code for Debianized Rust crate "binstring" |
|---|---|
| Maintainer | Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net> |
| Changed By | Guido Günther <agx@sigxcpu.org> |
| Sponsor | tsimonq2@debian.org |
| Distribution | unstable |
| Architecture | any |
| VCS | git: https://salsa.debian.org/rust-team/debcargo-conf.git [src/binstring] (browse) |
| Closes | #1151620 |
| Tracker | https://tracker.debian.org/pkg/rust-binstring |
| Uploaded | 13 days ago |
New Package Report
.changes
| Date | Sun, 25 Oct 2026 15:07:53 -0500 |
|---|---|
| Source | rust-binstring |
| Version | 0.1.8-1 |
| Changed-By | Guido Günther <agx@sigxcpu.org> |
| Architecture | source amd64 |
| Distribution | unstable |
Changelog
rust-binstring (0.1.8-1) unstable; urgency=medium
.
* Initial release (Closes: #1151620)
* Package binstring 0.1.8 from crates.io using debcargo 2.8.4
needed as a dependency of libunifiedpush..dsc
| Component | main |
|---|---|
| Package-List | librust-binstring-dev deb rust optional arch=any |
| Section | rust |
| Priority | optional |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: binstring Upstream-Contact: Frank Denis <github@pureftpd.org> Source: https://github.com/jedisct1/rust-binstring.git Files: * Copyright: 2022-2025 Frank Denis <github@pureftpd.org> License: MIT Files: debian/* Copyright: 2026 Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net> 2026 Guido Günther <agx@sigxcpu.org> License: MIT License: MIT Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 12 days ago.
Report
DFSG NEW review for rust-binstring version 0.1.8-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 0 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
The whole tree is MIT. The only licence notice is LICENSE (MIT, Copyright (c) 2022-2025 Frank Denis), Cargo.toml declares license = "MIT" and names Frank Denis alone, and src/lib.rs, README.md, .github/workflows/ci.yml and the Cargo files carry no separate terms. debian/copyright is DEP-5, names that holder with matching years, and covers everything with Files: * plus a debian/* stanza; the MIT text is reproduced in full. No non-free terms, no vendored third-party code, no binaries or generated-but-sourceless files.
Packaging
Standard debcargo 2.8.4 output, correct and complete for a Rust library source package: debhelper-compat 13 with dh-sequence-cargo (Provided by dh-cargo 34), an Architecture: any / Multi-Arch: same librust-binstring-dev with the usual Provides, a single librust-binstring-dev binary, autopkgtest using cargo-auto-test, Homepage/Vcs-* and upstream metadata present, Standards-Version 4.7.4 against current Policy 4.7.4.1. No patches (empty quilt series), no maintainer scripts, changelog sane (0.1.8-1, unstable, closes #1151620).
Issues
None.
Verified ◂
- The pre-scan listed no files to account for: it ran only an author check, which reported that every copyright holder it found is named in debian/copyright. I re-checked this by grepping the tree for
Copyright,(C),SPDX-License-Identifier,GNU,Apache License,Mozilla Public,public domain,All rights reserved: the only hits are LICENSE and debian/copyright{,.debcargo.hint}. - LICENSE is the MIT text with
Copyright (c) 2022-2025 Frank Denis; it matches theFiles: *stanza (holder and years) and the stand-aloneLicense: MITparagraph in debian/copyright, and matches Cargo.toml'slicense = "MIT"/authors = ["Frank Denis <github@pureftpd.org>"](Cargo.toml.orig identical). - Whole upstream tree enumerated (9 non-debian files): .cargo_vcs_info.json, .gitignore, Cargo.lock, Cargo.toml, Cargo.toml.orig, LICENSE, README.md, .github/workflows/ci.yml, src/lib.rs. Cargo.toml and Cargo.lock are cargo-registry generated files whose input (Cargo.toml.orig) is present; .cargo_vcs_info.json just records the upstream git sha1.
- .github/workflows/ci.yml is a GitHub CI recipe (MIT-covered by
Files: *, no separate terms); it only names third-party actions, no code from them is vendored. - src/lib.rs has no licence header and its
#[cfg(test)]module uses nothing outside the crate; the crate declares no dependencies or dev-dependencies, so nothing is vendored and no external licence is involved. - No binary or non-preferred-form files in the tree: no .so/.o/.a/.jar/.class/.pyc/.dll/.exe, no minified JS/CSS, no images, fonts or firmware.
- No debian/patches directory and an empty quilt series (.pc/.quilt_patches names debian/patches, .quilt_series is empty), so no patch or DEP-3 concerns.
- Standards-Version 4.7.4: current Policy is 4.7.4.1 per the policy tool, so the first two components match - not an issue.
- Build-Depends: debhelper-compat (= 13), dh-sequence-cargo; apt-cache shows dh-cargo 34 (Provides: dh-sequence-cargo, Depends: cargo, debhelper, python3), so dh-sequence-cargo resolves. Build-Depends-Arch cargo:native <!nocheck>, rustc:native <!nocheck>, libstd-rust-dev <!nocheck> is right: at compat 13 dh skips the dh_auto_test override under nocheck, and in dh-cargo's buildsystem only the test step runs the compiler (/usr/share/perl5/Debian/Debhelper/Buildsystem/cargo.pm:
buildonly copies sources,testruns cargo), so a nocheck build needs no Rust toolchain. - debian/rules is the standard two-line override;
override_dh_auto_test: dh_auto_test -- test --allreaches cargo.pm'stestsub, which runscargo test, i.e. dh-cargo's compile check. Depends: ${misc:Depends} is present; the package ships no shared library, so no ${shlibs:Depends} is owed. No maintainer scripts exist. - debian/tests/control uses /usr/share/cargo/bin/cargo-auto-test, which exists in this system's /usr/share/cargo/bin (alongside cargo and dh-cargo-built-using); dh-cargo (>= 33~) is a sufficient dependency for it.
- debian/changelog: rust-binstring (0.1.8-1), unstable, urgency=medium, Closes: #1151620, dated Sun, 25 Oct 2026 (which is indeed a Sunday); source format 3.0 (quilt); debian/upstream/metadata names the crates.io archive and repository.
- debian/copyright.debcargo.hint is debcargo's own leftover template (contains
FIXME (overlay) UNKNOWN-YEARS); it is matched by theFiles: debian/*MIT stanza and is not installed into the binary package (cargo.pm's get_sources excludesdebianfrom the crate registry copy). Its FIXMEs were resolved in debian/copyright, which records the real holder and years. - uscan found the packaged version as the newest upstream release (upstream
0.1.8, packaged0.1.8).
Not confirmed ◂
- No build or autopkgtest run was possible in this read-only review; nothing in the package itself indicates a build or test failure (no missing file named by debian/rules, no Build-Depends that cannot be satisfied).
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader was emailed about the review 12 days ago.
Review Information
accepted — allocated to awm 12 days ago, started 12 days ago, completed 12 days ago.