Review: rust-const-fnv1a-hash 1.1.0-1

Package Information

Description	#![no_std] crate for performing FNV1A-16/32/64/128 hashing on Rust stable at compile time - Rust source code Source code for Debianized Rust crate "const-fnv1a-hash"
Maintainer	Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net>
Changed By	Alexander Kjäll <alexander.kjall@gmail.com>
Distribution	unstable
Architecture	any
VCS	git: https://salsa.debian.org/rust-team/debcargo-conf.git [src/const-fnv1a-hash] (browse)
Tracker	https://tracker.debian.org/pkg/rust-const-fnv1a-hash
Uploaded	1 month, 4 days ago

New Package Report

.changes◂

Changed-By	Alexander Kjäll <alexander.kjall@gmail.com>
Architecture	amd64 source
Distribution	unstable
Source	rust-const-fnv1a-hash
Version	1.1.0-1

Changelog◂

rust-const-fnv1a-hash (1.1.0-1) unstable; urgency=medium
 .
   * Package const-fnv1a-hash 1.1.0 from crates.io using debcargo 2.8.4

.dsc◂

Package-List	librust-const-fnv1a-hash-dev deb rust optional arch=any
Section	rust
Priority	optional
Component	main

debian/copyright◂

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: const-fnv1a-hash
Upstream-Contact: Hindrik Stegenga
Source: https://github.com/HindrikStegenga/const-fnv1a-hash

Files: *
Copyright: 2021-2022 Hindrik Stegenga
License: MIT

Files: debian/*
Copyright:
 2026 Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net>
 2026 Alexander Kjäll <alexander.kjall@gmail.com>
License: MIT

License: MIT
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in all
 copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.

DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 22 days ago.

Report◂

DFSG NEW review for rust-const-fnv1a-hash version 1.1.0-1

Summary

Licensing is DFSG-compliant and debian/copyright is accurate: Yes
Packaging is of good quality: Yes
Issues: 0 blocker, 0 important, 0 minor
debian/watch: version 5
debian/copyright: machine-readable
Scan before the review: nothing found

Licensing

The source is a single Rust file plus standard crates.io metadata, all under the MIT licence (upstream LICENSE, Copyright (c) 2021 Hindrik Stegenga). debian/copyright is machine-readable DEP-5 with a correct Format line, a Files: * stanza naming Hindrik Stegenga, a debian/* stanza naming the Debian Rust Maintainers and the uploader, and the full MIT text as a stand-alone License paragraph (MIT is not in /usr/share/common-licenses, so reproducing it is required and done). No file lacks a licence, no non-free or field-of-use terms appear anywhere in the tree, and there are no binaries, minified files, vendored third-party copies or generated artefacts. The pre-scan's author check reports all source authors named in debian/copyright.

Packaging

Textbook debcargo 2.8.4 output for a leaf library crate: 3.0 (quilt) source format with no patches, debhelper-compat 13 via debhelper-compat (= 13) and dh-sequence-cargo, a single librust-const-fnv1a-hash-dev package with the standard Provides/Collapse-Features versioned virtual packages, Multi-Arch: same and Architecture: any as usual for Rust rcrates, an autopkgtest using cargo-auto-test, upstream/metadata, Vcs-* and Homepage fields, and a sane single-entry unstable changelog closing no bugs. Standards-Version 4.7.4 matches current Policy 4.7.4.1. No maintainer scripts, so nothing to check for idempotence. Dependencies (dh-cargo 34 / rustc / libstd-rust-dev) all exist in the archive and the versioned autopkgtest dependency dh-cargo (>= 33~) is satisfied.

Issues

None.

Verified ◂

src/lib.rs - the only upstream code file; starts #![no_std], only macros and const fns with a #[cfg(test)] module; no copyright header, so no holder is missing from debian/copyright.
LICENSE - MIT text, Copyright (c) 2021 Hindrik Stegenga; reproduced verbatim (modulo whitespace) in the License: MIT paragraph of debian/copyright.
Cargo.toml / Cargo.toml.orig - license = "MIT", consistent with debian/copyright and LICENSE. Cargo.toml is the crates.io-normalised file, Cargo.toml.orig its input; both are plain text metadata covered by Files: *.
README.md - plain prose description; contains no licence terms. Covered by Files: *.
.gitignore, .cargo_vcs_info.json - trivial text metadata (9 and 4 lines); covered by Files: *.
No LICENSE/COPYING/NOTICE/AUTHORS file exists in any subdirectory; grep for Copyright/(C)/©/SPDX/Licensed under/GNU/Apache/Mozilla/public domain/All rights reserved matches only LICENSE and the two debian copyright files.
debian/copyright - DEP-5 with the exact canonical Format URL; stanzas Files: * and debian/* (later one overriding for debian paths) plus one stand-alone License: MIT paragraph. Machine-readable, so no replacement is proposed.
The pre-scan's copyright-holder check reported no missing holder: all three authors named in debian/copyright match the tree, and it listed no other file for attention.
Tree inventory (glob with gitignore:false): .gitignore, Cargo.toml, Cargo.toml.orig, LICENSE, README.md, .cargo_vcs_info.json, src/lib.rs, debian/{cargo-checksum.json,changelog,control,copyright,copyright.debcargo.hint,debcargo.toml,rules,source/format,tests/control,upstream/metadata,watch}. No binaries, archives, fonts, images or minified files.
debian/ has no patches/ directory and no maintainer scripts, so there is nothing to review there; debian/source/format is 3.0 (quilt).
debian/tests/control - autopkgtest running /usr/share/cargo/bin/cargo-auto-test const-fnv1a-hash 1.1.0 --all-targets --all-features, Depends dh-cargo (>= 33~), rustc; dh-cargo 34 (providing dh-sequence-cargo) and rustc exist in unstable, so the versioned dependency is satisfiable.
debian/changelog - version 1.1.0-1, distribution unstable, urgency medium, single debcargo entry, dated Sun 04 Oct 2026 (consistent weekday), no bug closures to verify.
dependencies in debian/control (debhelper-compat (= 13), dh-sequence-cargo, cargo:native, rustc:native, libstd-rust-dev, all with <!nocheck>) are the standard debcargo set; Build-Depends-Arch vs Build-Depends split is correct for a library-only package.
debian/copyright.debcargo.hint - retained debcargo template with FIXME/UNKNOWN placeholders; correctly superseded by the final debian/copyright and not installed in any binary package.
uscan found the packaged version as the newest upstream release (upstream 1.1.0, packaged 1.1.0).

Not confirmed ◂

The upstream copyright year range 2021-2022 in debian/copyright cannot be checked against the tree: LICENSE states only 2021, and no source file carries a dated notice (the debcargo hint says the years were read from the upstream git history, which is not available here). Harmless either way; only the absence of a holder would be an issue.
debian/watch is reviewed separately by the pre-upload program and was not examined.

Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader was emailed about the review 19 days ago.

Review Information

accepted — allocated to eamanu 1 month, 2 days ago, started 1 month, 2 days ago, completed 19 days ago.

Final Comment

Public Notes

1 month, 2 days ago ● public

licensecheck

Command: licensecheck -r --deb-machine .
Exit code: 0

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: FIXME
Upstream-Contact: FIXME
Source: FIXME
Disclaimer: Autogenerated by licensecheck

Files: ./.cargo_vcs_info.json
 ./Cargo.toml
 ./Cargo.toml.orig
 ./README.md
 ./debian/cargo-checksum.json
 ./debian/changelog
 ./debian/control
 ./debian/debcargo.toml
 ./debian/rules
 ./debian/source/format
 ./debian/tests/control
 ./debian/upstream/metadata
 ./debian/watch
 ./src/lib.rs
Copyright: NONE
License: UNKNOWN
 FIXME

Files: ./debian/copyright
Copyright: 2021-2022, Hindrik Stegenga
  2026, Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net>
License: Expat
 FIXME

Files: ./debian/copyright.debcargo.hint
Copyright: FIXME (overlay) UNKNOWN-AUTHORS FIXME (overlay) UNKNOWN-YEARS
License: Expat
 FIXME

Files: ./LICENSE
Copyright: 2021, Hindrik Stegenga
License: Expat
 FIXME

1 month, 2 days ago ● public

debian/copyright check

Command: cme check dpkg-copyright
Exit code: 0

WARN: Model Dpkg::Copyright class: accept attribute should be a list of hash with 'pattern' key. I.e. something like [ { pattern => 'xyz.*', info}, ...] instead of [ 'xyz.*' => {info}, ... ]
WARN: Model Dpkg::Copyright::LicenseSpec class: accept attribute should be a list of hash with 'pattern' key. I.e. something like [ { pattern => 'xyz.*', info}, ...] instead of [ 'xyz.*' => {info}, ... ]
WARN: Model Dpkg::Copyright::Content class: accept attribute should be a list of hash with 'pattern' key. I.e. something like [ { pattern => 'xyz.*', info}, ...] instead of [ 'xyz.*' => {info}, ... ]
Warning in 'Files:"*" License short_name': value is "MIT". There are many versions of the MIT license. Please use Expat instead, when it matches. See L<Debian copyright format|https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-specification> and L<wikipedia|https://en.wikipedia.org/wiki/MIT_License#Various_versions>for details.
Offending value: 'MIT'
Warning in 'Files:"debian/*" License short_name': value is "MIT". There are many versions of the MIT license. Please use Expat instead, when it matches. See L<Debian copyright format|https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-specification> and L<wikipedia|https://en.wikipedia.org/wiki/MIT_License#Various_versions>for details.
Offending value: 'MIT'
you can try 'cme fix dpkg-copyright' to fix the warnings shown above

1 month, 2 days ago ● public

licenserecon

Command: licenserecon
Exit code: 0

en: Versions: licenserecon '18.1'  licensecheck '3.3.9-1'

Parsing Source Tree  ....
Reading d/copyright  ....
Running licensecheck ....

No significant differences found

1 month, 2 days ago ● public

Look for SPDX

Command: grep -r -B1 'SPDX-'
Exit code: 1

(no output)

1 month, 2 days ago ● public

Lintian

Command: lintian -i -I -v --pedantic
Exit code: 0

N:
W: librust-const-fnv1a-hash-dev: initial-upload-closes-no-bugs [usr/share/doc/librust-const-fnv1a-hash-dev/changelog.Debian.gz:1]
N: 
N:   This package appears to be the first packaging of a new upstream software
N:   package (there is only one changelog entry and the Debian revision is 1),
N:   but it does not close any bugs. The initial upload of a new package should
N:   close the corresponding ITP bug for that package.
N:   
N:   This warning can be ignored if the package is not intended for Debian or
N:   if it is a split of an existing Debian package.
N: 
N:   Please refer to New packages (Section 5.1) in the Debian Developer's
N:   Reference for details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: debian/changelog
N:   Renamed from: new-package-should-close-itp-bug
N: 
N:
W: librust-const-fnv1a-hash-dev: synopsis-too-long
N: 
N:   The first line of the "Description:" must be less than 80 characters long.
N: 
N:   Please refer to The single line synopsis (Section 3.4.1) in the Debian
N:   Policy Manual for details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: fields/description
N:   Renamed from: description-too-long
N: 
N:
I: librust-const-fnv1a-hash-dev: extended-description-is-probably-too-short
N: 
N:   The extended description (the lines after the first line of the
N:   "Description:" field) is only one or two lines long. The extended
N:   description should provide a user with enough information to decide
N:   whether they want to install this package, what it contains, and how it
N:   compares to similar packages. One or two lines is normally not enough to
N:   do this.
N: 
N:   Please refer to General guidelines for package descriptions (Section
N:   6.2.1) in the Debian Developer's Reference and The long description
N:   (Section 6.2.3) in the Debian Developer's Reference for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: fields/description
N: 
N:
I: rust-const-fnv1a-hash source: file-contains-fixme-placeholder FIXME [debian/control:18]
N: 
N:   This file appears to be incomplete or insufficiently modified as it
N:   contains a "FIXME" placeholder text. These can often be generated by
N:   package generation tools such as dh_make or npm2deb.
N:   
N:   Please double-check the file and replace the placeholder with the required
N:   command or information.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: dh-make
N: 
N:
I: librust-const-fnv1a-hash-dev: package-contains-documentation-outside-usr-share-doc [usr/share/cargo/registry/const-fnv1a-hash-1.1.0/LICENSE]
N: 
N:   This package ships a documentation file outside /usr/share/doc
N:   Documentation files are normally installed inside /usr/share/doc.
N:   
N:   If this file doesn't describe the contents or purpose of the directory it
N:   is in, please consider moving this file to /usr/share/doc/ or maybe even
N:   removing it. If this file does describe the contents or purpose of the
N:   directory it is in, please add a lintian override.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: documentation
N: 
N:   Screen: python/egg/metadata
N:     Advocates: "Scott Kitterman" <debian@kitterman.com>
N:     Reason: The folders XXX.dist-info/ and XXX.egg-info/ hold metadata for
N:             Python modules. Those files are not documentation even though
N:             some of their names carry the .txt file extension.
N:             
N:             Python modules can be both public and private.
N:             
N:             Read more in
N:             https://www.python.org/dev/peps/pep-0427/#the-dist-info-directory,
N:             https://www.python.org/dev/peps/pep-0376/#id16,
N:             https://www.python.org/dev/peps/pep-0610/,
N:             https://www.python.org/dev/peps/pep-0639/,
N:             https://setuptools.pypa.io/en/latest/deprecated/python_eggs.html,
N:             and Bug#1003913.
N: 
N:
I: librust-const-fnv1a-hash-dev: package-contains-documentation-outside-usr-share-doc [usr/share/cargo/registry/const-fnv1a-hash-1.1.0/README.md]
N:
I: rust-const-fnv1a-hash source: upstream-metadata-missing-bug-tracking [debian/upstream/metadata]
N: 
N:   The DEP 12 metadata file does not specify any upstream bug tracking
N:   information (ie. the Bug-Database or Bug-Submit fields are missing).
N:   
N:   The upstream metadata can be found in the source package in the file
N:   debian/upstream/metadata.
N: 
N:   Please refer to https://dep-team.pages.debian.net/deps/dep12/ for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: debian/upstream/metadata
N: 
N:
P: rust-const-fnv1a-hash source: package-uses-old-debhelper-compat-version 13
N: 
N:   This package uses a debhelper compatibility level that is no longer
N:   recommended. Please consider using the recommended level.
N:   
N:   For most packages, the best way to set the compatibility level is to
N:   specify debhelper-compat (= X) as a Build-Depends in debian/control. You
N:   can also use the debian/compat file or export DH_COMPAT in debian/rules.
N:   
N:   If no level is selected debhelper defaults to level 1, which is
N:   deprecated.
N: 
N:   Please refer to the debhelper(7) manual page for details.
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: debhelper
N:

1 month, 2 days ago ● public

duck

Command: duck
Exit code: 0

(no output)

1 month, 2 days ago ● public

look for copyright

Command: egrep -R -i copyright
Exit code: 0

LICENSE:Copyright (c) 2021 Hindrik Stegenga
LICENSE:The above copyright notice and this permission notice shall be included in all
LICENSE:AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
debian/copyright.debcargo.hint:Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
debian/copyright.debcargo.hint:Copyright: FIXME (overlay) UNKNOWN-AUTHORS FIXME (overlay) UNKNOWN-YEARS
debian/copyright.debcargo.hint: FIXME (overlay): Since upstream copyright years are not available in
debian/copyright.debcargo.hint:Copyright: 2021 Hindrik Stegenga
debian/copyright.debcargo.hint:Copyright:
debian/copyright.debcargo.hint: The above copyright notice and this permission notice shall be included in all
debian/copyright.debcargo.hint: AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
debian/copyright:Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
debian/copyright:Copyright: 2021-2022 Hindrik Stegenga
debian/copyright:Copyright:
debian/copyright: The above copyright notice and this permission notice shall be included in all
debian/copyright: AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER

1 month, 2 days ago ● public

look for license

Command: egrep -R -i license
Exit code: 0

Cargo.toml.orig:license = "MIT"
Cargo.toml:license = "MIT"
LICENSE:MIT License
LICENSE:to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
debian/copyright.debcargo.hint:License: MIT
debian/copyright.debcargo.hint:Files: LICENSE
debian/copyright.debcargo.hint:License: UNKNOWN-LICENSE; FIXME (overlay)
debian/copyright.debcargo.hint:License: MIT
debian/copyright.debcargo.hint:License: MIT
debian/copyright.debcargo.hint: to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
debian/copyright:License: MIT
debian/copyright:License: MIT
debian/copyright:License: MIT
debian/copyright: to use, copy, modify, merge, publish, distribute, sublicense, and/or sell

Back to Dashboard | View all reviews for this package