Review: rust-dragonbox-ecma 0.1.12-1
New Package Report
.changes
| Source | rust-dragonbox-ecma |
|---|---|
| Version | 0.1.12-1 |
| Changed-By | Juan Manuel Méndez Rey |
| Architecture | source amd64 |
| Distribution | unstable |
| Date | Fri, 05 Jun 2026 00:23:43 +0200 |
Changelog
rust-dragonbox-ecma (0.1.12-1) unstable; urgency=medium . * Package dragonbox_ecma 0.1.12 from crates.io using debcargo 2.8.2 * Initial release. Closes: #1136351
.dsc
| Section | rust |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | librust-dragonbox-ecma-dev deb rust optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: dragonbox_ecma
Upstream-Contact:
David Tolnay <dtolnay@gmail.com>
magic-akari <akari.ccino@gmail.com>
Source: https://github.com/magic-akari/dragonbox
Files: *
Copyright:
2021-2026 David Tolnay <dtolnay@gmail.com>
2025-2026 magic-akari <akari.ccino@gmail.com>
License: APACHE-2-LLVM-EXCEPTIONS or BSL-1.0
Files: src/cache.rs src/div.rs src/lib.rs src/log.rs src/policy.rs src/to_chars.rs src/wuint.rs
Copyright: 2020-2025 Junekey Jeon
License: APACHE-2-LLVM-EXCEPTIONS or BSL-1.0
Files: tests/binary64_test.rs tests/binary64_test_ecma.rs
Copyright: 2018 Ulf Adams
License: Apache-2.0 or BSL-1.0
Files: debian/*
Copyright:
2026 Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net>
2026 Juan Manuel Méndez Rey <juan.mendezr@proton.me>
License: APACHE-2-LLVM-EXCEPTIONS or BSL-1.0
License: Apache-2.0
On Debian systems, the full text of the Apache License Version 2.0
can be found in /usr/share/common-licenses/Apache-2.0.
License: APACHE-2-LLVM-EXCEPTIONS
On Debian systems, the full text of the Apache License Version 2.0
can be found in /usr/share/common-licenses/Apache-2.0.
.
--- LLVM Exceptions to the Apache 2.0 License ----
.
As an exception, if, as a result of your compiling your source code, portions
of this Software are embedded into an Object form of such source code, you
may redistribute such embedded portions in such Object form without complying
with the conditions of Sections 4(a), 4(b) and 4(d) of the License.
.
In addition, if you combine or link compiled forms of this Software with
software that is licensed under the GPLv2 ("Combined Software") and if a
court of competent jurisdiction determines that the patent provision (Section
3), the indemnity provision (Section 9) or other Section of the License
conflicts with the conditions of the GPLv2, you may retroactively and
prospectively choose to deem waived or otherwise exclude such Section(s) of
the License, but only in their entirety and only with respect to the Combined
Software.
License: BSL-1.0
Boost Software License - Version 1.0 - August 17th, 2003
.
Permission is hereby granted, free of charge, to any person or organization
obtaining a copy of the software and accompanying documentation covered by
this license (the "Software") to use, reproduce, display, distribute,
execute, and transmit the Software, and to prepare derivative works of the
Software, and to permit third-parties to whom the Software is furnished to
do so, all subject to the following:
.
The copyright notices in the Software and this entire statement, including
the above license grant, this restriction and the following disclaimer,
must be included in all copies of the Software, in whole or in part, and
all derivative works of the Software, unless such copies or derivative
works are solely in the form of machine-executable object code generated by
a source language processor.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE, TITLE AND NON-INFRINGEMENT. IN NO EVENT
SHALL THE COPYRIGHT HOLDERS OR ANYONE DISTRIBUTING THE SOFTWARE BE LIABLE
FOR ANY DAMAGES OR OTHER LIABILITY, WHETHER IN CONTRACT, TORT OR OTHERWISE,
ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
DEALINGS IN THE SOFTWARE.
License: Apache-2.0 or BSL-1.0
On Debian systems, the full text of the Apache License Version 2.0
can be found in /usr/share/common-licenses/Apache-2.0.
.
The Boost Software License text is included above under BSL-1.0.Review Information
rejected — allocated to siretart 16 days ago, started 16 days ago, completed 16 days ago.
Final Comment
Thanks for your diligence in preparing this package. I've taken a
look at the licensing and found a couple of spots that could use
some refinement in debian/copyright to ensure we're covering all
the bases.
The most important thing I spotted is that src/to_chars_ecma.rs is
explicitly described as a port of V8's DoubleToStringView. The code
itself contains several functions labeled as V8's (like
convert_2_digits, convert_8_digits, etc.). Since porting code
creates a derivative work under copyright law, we're legally
required by V8's BSD-3-Clause license to preserve their copyright
notice and license text.
This looks like a bit of a licensing omission by upstream—while the
comment attribution is great, it doesn't quite satisfy the BSD
requirement to include the actual license boilerplate. It would be
best if this were sorted out upstream eventually, but for now, we
absolutely need to document the V8 project authors' copyright and
the BSD-3-Clause text in debian/copyright to ensure the Debian
package is legally sound.
I also noticed that src/buffer.rs and src/to_chars_ecma.rs are
missing from the specific src/*.rs section that credits Junekey
Jeon. While src/to_chars_ecma.rs is a V8 port, src/buffer.rs seems
to be part of the core logic that Junekey Jeon originally authored
in the dragonbox crate. Similarly, tests/macros/mod.rs is missing
from the section covering the tests authored by Ulf Adams. Adding
these specifically would make the file coverage much clearer.
Everything else looks solid. Once these attributions are tidied up,
the package should be in great shape.
-rt
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 0.1.12-1 | b996cb2b… | 2026-06-07 10:06 | 2026-06-07 10:13 | siretart | accepted | VIEW |