DFSG NEW Queue

DFSG, Licensing & New Packages Team

Review: rust-facet-macro-types 0.46.5-1

Package Information

DescriptionUnsynn grammar and type definitions for facet macro ecosystem - Rust source code

Source code for Debianized Rust crate "facet-macro-types"

MaintainerDebian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net>
Changed ByAlexander Kjäll <alexander.kjall@gmail.com>
Distributionunstable
Architectureany
VCSgit: https://salsa.debian.org/rust-team/debcargo-conf.git [src/facet-macro-types] (browse)
Trackerhttps://tracker.debian.org/pkg/rust-facet-macro-types
Uploaded12 days ago

New Package Report

.changes◂
Sourcerust-facet-macro-types
Version0.46.5-1
Changed-ByAlexander Kjäll <alexander.kjall@gmail.com>
Architectureamd64 source
Distributionunstable
DateMon, 26 Oct 2026 18:41:31 +0000
Changelog◂ 
rust-facet-macro-types (0.46.5-1) unstable; urgency=medium
 .
   * Package facet-macro-types 0.46.5 from crates.io using debcargo 2.8.5+alpha.0
.dsc◂
Sectionrust
Priorityoptional
Componentmain
Package-Listlibrust-facet-macro-types-dev deb rust optional arch=any
debian/copyright◂ 
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: facet-macro-types
Upstream-Contact: Amos Wenger
Source: https://github.com/facet-rs/facet

Files: *
Copyright: 2025-2026 Amos Wenger
License: MIT or Apache-2.0

Files: debian/*
Copyright:
 2026 Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net>
 2026 Alexander Kjäll <alexander.kjall@gmail.com>
License: MIT or Apache-2.0

License: Apache-2.0
 Debian systems provide the Apache 2.0 license in
 /usr/share/common-licenses/Apache-2.0

License: MIT
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in all
 copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.

DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 11 days ago.

Report◂

DFSG NEW review for rust-facet-macro-types version 0.46.5-1

Summary

  • Licensing is DFSG-compliant and debian/copyright is accurate: Yes
  • Packaging is of good quality: Yes
  • Issues: 0 blocker, 0 important, 0 minor
  • debian/watch: version 5
  • debian/copyright: machine-readable
  • Scan before the review: nothing found

Licensing

debian/copyright is DEP-5 with the canonical Format line. Files: * names the sole upstream holder (2025-2026 Amos Wenger) under MIT or Apache-2.0, matching the crate's own license = "MIT OR Apache-2.0" in Cargo.toml; debian/* has its own stanza. The MIT text is reproduced in full and Apache-2.0 points at /usr/share/common-licenses/Apache-2.0, which exists. No non-free terms, no built/binary blobs, no vendored third-party code, and no file without a licence: the crate is two hand-written Rust sources plus Cargo metadata, README and a two-line rustdoc header. The pre-scan found no unlisted holder and no suspicious file.

Packaging

Ordinary, well-formed debcargo 2.8.5 package: debhelper-compat 13 with dh-sequence-cargo and --buildsystem cargo, Build-Depends-Arch exactly mirroring the crate's three dependencies at the versions Debian ships, no patches needed (crates.io normalisation already done), unit tests run at build time through dh_auto_test -- test --all, and an autopkgtest suite using dh-cargo. Standards-Version 4.7.4 is current against Policy 4.7.4.1, Vcs-Git/Vcs-Browser use the debcargo-conf conventions, changelog is well-formed for unstable. No packaging fault to fix.

Issues

None.

Verified ◂
  • Pre-scan (/review-input/prescan.md) listed no files and no missing holders: 'every holder found is named in debian/copyright'; the 8 scanned files are the 8 upstream files I inspected, and none carries a copyright or licence notice of its own.
  • Upstream inventory (all of it): .cargo_vcs_info.json, arborium-header.html, Cargo.lock, Cargo.toml, Cargo.toml.orig, README.md, src/lib.rs, src/renamerule.rs; debian/ holds 13 files. No LICENSE/COPYING anywhere in the tree.
  • src/renamerule.rs is independently written (own split_into_words), not a copy of serde_derive's RenameRule; no adapted/copied from notices exist in src/, and grep for copyright/licence wording in src/ returns nothing but unrelated identifiers.
  • arborium-header.html is a two-line docs.rs rustdoc header (comment plus a jsDelivr <script> for bearcove/arborium); it is not code executed by the package, comes from the upstream author's own project, and is covered by the Files: * stanza.
  • README.md's licence section states dual MIT/Apache-2.0, consistent with Cargo.toml; its ./LICENSE link is dead because crates.io ships no licence files, but the MIT text is reproduced in debian/copyright and Apache-2.0 by pointer, so both notices reach the binary package.
  • Cargo.lock is shipped in the upstream crates.io tarball (confirmed by listing rust-facet-macro-types_0.46.5.orig.tar.gz), is plain text with registry entries only, and is deleted by dh-cargo at configure time (rm_files("Cargo.lock") in /usr/share/perl5/Debian/Debhelper/Buildsystem/cargo.pm), so it is neither a DFSG nor a build problem.
  • Tree Cargo.toml is byte-identical to the one in the orig tarball; debian/ has no patches/ directory, so nothing is applied silently.
  • Dependencies resolve on the reviewing system: librust-unsynn-0.3+default-dev is provided by librust-unsynn-dev 0.3.0-1, dh-cargo is 34 (>= 33~ as used by debian/tests/control), and rustc is 1.97.1, satisfying the 1.90 MSRV and the Breaks: rustc (<< 1.90~).
  • Policy version from the policy tool is 4.7.4.1; Standards-Version: 4.7.4 matches on the first two components, so no issue.
  • override_dh_auto_test runs dh_auto_test -- test --all; the crate has unit tests in both src/lib.rs and src/renamerule.rs and no dev-dependencies, so the test step can compile and pass without anything missing from Build-Depends.
  • debian/tests/control uses /usr/share/cargo/bin/cargo-auto-test from dh-cargo, which is declared as its own dependency; the Architecture: !riscv64 on the third test is valid autopkgtest syntax and harmless.
  • uscan found upstream releases with debian/watch; a newer upstream version is available (upstream 0.50.0~rc.7, packaged 0.46.5), which is not a fault of the package.
  • Every pointer of debian/copyright to /usr/share/common-licenses names a file that is there (Apache-2.0).
Not confirmed ◂
  • The upstream copyright holder and years in Files: * (2025-2026 Amos Wenger) cannot be checked inside the package: the crate ships no copyright notices, and Cargo.toml has no authors field. They are plausible for facet-rs/facet and the pre-scan reports no unlisted holder, but a build or the upstream git history would be needed to confirm the years.
Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader was emailed about the review 11 days ago.

Review Information

accepted — allocated to awm 11 days ago, started 11 days ago, completed 11 days ago.

Final Comment

Back to Dashboard | View all reviews for this package