DFSG NEW Queue

DFSG, Licensing & New Packages Team

Review: rust-hdrhistogram 7.6.0-1

Package Information

DescriptionPort of HdrHistogram to Rust - Rust source code

Source code for Debianized Rust crate "hdrhistogram"

MaintainerDebian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net>
Changed ByYing-Chun Liu (PaulLiu) <paulliu@debian.org>
Sponsorpaulliu@debian.org
Distributionunstable
Architectureany
VCSgit: https://salsa.debian.org/rust-team/debcargo-conf.git [src/hdrhistogram] (browse)
Closes#1149984
Trackerhttps://tracker.debian.org/pkg/rust-hdrhistogram
Uploaded30 days ago

New Package Report

.changes◂
Distributionunstable
Sourcerust-hdrhistogram
Version7.6.0-1
Changed-ByYing-Chun Liu (PaulLiu) <paulliu@debian.org>
Architectureamd64 source
Changelog◂ 
rust-hdrhistogram (7.6.0-1) unstable; urgency=medium
 .
   * Team upload.
   * Package hdrhistogram 7.6.0 from crates.io using debcargo 2.8.3
     (Closes: #1149984)
.dsc◂
Package-Listlibrust-hdrhistogram-dev deb rust optional arch=any
Sectionrust
Priorityoptional
Componentmain
debian/copyright◂ 
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: hdrhistogram
Upstream-Contact:
 Jon Gjengset <jon@thesquareplanet.com>
 Marshall Pierce <marshall@mpierce.org>
Source: https://github.com/HdrHistogram/HdrHistogram_rust.git

Files: *
Copyright:
 2016-2022 Jon Gjengset <jon@thesquareplanet.com>
 2016-2019 Marshall Pierce <marshall@mpierce.org>
License: MIT or Apache-2.0

Files: debian/*
Copyright:
 2019-2026 Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net>
 2026 Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
 2019 nicoo <nicoo@debian.org>
License: MIT or Apache-2.0

License: Apache-2.0
 Debian systems provide the Apache 2.0 license in
 /usr/share/common-licenses/Apache-2.0

License: MIT
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in all
 copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.

Review Information

accepted — allocated to awm 27 days ago, started 27 days ago, completed 27 days ago.

Final Comment

Hi,

A couple of minor issues that could be fixed...

  1. [minor] [packaging] update-base64.diff is obsolete for the 7.6.0 sources
  • Files: debian/patches/update-base64.diff; tests/interval_log.rs (import block)
  • Evidence: The diff adds use base64::Engine; to tests/interval_log.rs. The pristine 7.6.0 file (in the orig tarball) already contains use base64::Engine as _; and B64STANDARD.decode(...), and src/serialization/interval_log/mod.rs:221 already has use base64::Engine as _; with base64::engine::general_purpose::STANDARD usage — i.e. upstream 7.6.0 is already on the 0.22 API. After patch application the file ends up with both use base64::Engine as _; and use base64::Engine;, the latter being an unused import (warning, not error).
  • Problem: This patch was needed for the 7.5.2 base64 0.21->0.22 bump and is now dead weight against 7.6.0: it applies cleanly (so the series still builds) but adds a redundant import and means the package carries a patch that upstream has already absorbed, which a sponsor would expect to be dropped.
  • Fix: Remove update-base64.diff and its line from debian/patches/series, then rebuild/retest to confirm the unused-import warning disappears and tests still pass.
  1. [minor] [packaging] Four of the five patches lack DEP-3 headers
  • Files: debian/patches/eliminate-ieee754-dev-depends.diff, eliminate-rug-dev-depends.diff, fix-tests-no-default-features.diff, update-base64.diff - Evidence: Each of these diffs starts directly with the Index:/diff hunks; only fix-racy-sync-tests.diff carries Description/Author/Origin/Forwarded/Last-Update headers.
  • Problem: Without DEP-3 headers (Description, Origin, Forwarded, Last-Update) the purpose and provenance of the patches — in particular who to forward the fixes to and that the upstream PR for fix-racy-sync-tests.diff (#151) is tracked — are not documented, and obsolete patches (see update-base64.diff) are hard to identify.
  • Fix: Add DEP-3 headers to the four headerless patches, noting Forwarded for any that should be proposed upstream (e.g. fix-tests-no-default-features.diff), or drop the obsolete update-base64.diff.

Thanks!

Back to Dashboard | View all reviews for this package