DFSG NEW review for rust-jsonschema-macros version 0.58.6-1

Summary

• Licensing is DFSG-compliant and debian/copyright is accurate: Yes
• Packaging is of good quality: Yes
• Issues: 0 blocker, 0 important, 0 minor
• debian/watch: version 5
• debian/copyright: machine-readable
• Scan before the review: nothing found

Licensing

The whole crate is MIT-licensed: Cargo.toml/Cargo.toml.orig declare license = "MIT" (workspace) and the single author is Dmitry Dygalo, who is the only copyright holder appearing anywhere in the tree (prescan: every holder found is named in debian/copyright). The tree is uniformly MIT text source and trybuild .stderr test fixtures, with no non-free wording, no built/minified/binary files, and no Files-Excluded. The exported debian/copyright is DEP-5 with one Files: * stanza (2020-2026 Dmitry Dygalo, MIT), a debian/* stanza, and the full MIT licence text. Sources carry no file-level headers, but all files are covered by the single stanza, the holder matches upstream metadata, and the full MIT text is reproduced. DFSG-compliant and accurate.

Packaging

Clean, standard debcargo-generated proc-macro crate packaging. debhelper compat 13 with dh --buildsystem cargo; Build-Depends carries <!nocheck> restrictions consistent with compat 13 dh skipping test targets under nocheck; the binary -dev Depends names substvars and the feature-collapsed jsonschema-macros-core dev deps; a complete Provides list; autopkgtests covering all feature combinations; upstream metadata, Vcs-* and a Homepage field. Standards-Version 4.7.4 matches current Policy 4.7.4.1. One build-runtime point I could not fully confirm (see unconfirmed) but it does not undermine the packaging's overall quality.

Issues

None.

Verified

• debian/copyright is machine-readable DEP-5, begins with the exact Format URL, has Files: * (2020-2026 Dmitry Dygalo, MIT), Files: debian/* (Debian Rust Maintainers, Eric Dorland, MIT), and a standalone License: MIT paragraph with the full text; no Files-Excluded.
• Every source file (src/lib.rs, tests/renamed_dependency.rs, tests/ui.rs, tests/ui/*.rs and *.stderr) is plain MIT text covered by Files: *; copyright holder matches Cargo.toml authors and upstream metadata; prescan confirms every holder found is in debian/copyright.
• Tree contains no binary/minified/built files or docs: all files are .rs, .stderr trybuild fixtures, Cargo metadata and .toml. The .stderr files are trybuild expected compile-fail output (verified one: invalid_top_level_schema_type.stderr). No embedded third-party code beyond declared dependencies.
• tests/control provides autopkgtests for default and each collapsed feature (arbitrary-precision, float-roundtrip, no-default-features), with flaky and !riscv64 restrictions; Depends includes serde_json and trybuild dev packages.
• compat 13 with explicit ${misc:Depends}; <!nocheck> on Build-Depends is correct at compat 13 (dh skips test overrides under nocheck). Standards-Version 4.7.4 fine against Policy 4.7.4.1. Vcs-Git/Vcs-Browser/Homepage/upstream metadata present; changelog sane (experimental, 0.58.6-1, closes the crates.io packaging).
• uscan found upstream releases with debian/watch; a newer upstream version is available (upstream 0.60.0, packaged 0.58.6), which is not a fault of the package.

Not confirmed

• The crate's dev-dependencies (trybuild, serde_json, and jsonschema = { path = "../jsonschema" }) are not in Build-Depends; tests/renamed_dependency.rs probes the sibling ../jsonschema crate, which is absent from this source. Whether a non-nocheck build's dh_auto_test (cargo test --all-targets) needs these installed is not verifiable here; this is likely why debcargo.toml sets test_is_broken = true (comment 'Circular dep on jsonschema?'). A real build/autopkgtest run would show whether the test step is skipped or fails without serde_json/trybuild in Build-Depends.

Proposed changes

None.