Review: rust-mio-serial 5.0.7-1
Package Information
| Description | Serial port implementation for mio - Rust source code Source code for Debianized Rust crate "mio-serial" |
|---|---|
| Maintainer | Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net> |
| Changed By | Michele Cane <michele.cane@proton.me> |
| Sponsor | tsimonq2@debian.org |
| Distribution | unstable |
| Architecture | any |
| VCS | git: https://salsa.debian.org/rust-team/debcargo-conf.git [src/mio-serial] (browse) |
| Tracker | https://tracker.debian.org/pkg/rust-mio-serial |
| Uploaded | 1 month, 1 day ago |
New Package Report
.changes
| Version | 5.0.7-1 |
|---|---|
| Changed-By | Michele Cane <michele.cane@proton.me> |
| Architecture | source amd64 |
| Distribution | unstable |
| Date | Wed, 07 Oct 2026 09:11:45 -0500 |
| Source | rust-mio-serial |
Changelog
rust-mio-serial (5.0.7-1) unstable; urgency=medium . * Package mio-serial 5.0.7 from crates.io using debcargo 2.8.4 * Initial Debian packaging. * Relax the nix dependency to the version available in Debian. * Add socat and writable pseudo-terminal paths for autopkgtests.
.dsc
| Section | rust |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | librust-mio-serial-dev deb rust optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: mio-serial Upstream-Contact: Zac Berkowitz <zac.berkowitz@gmail.com> Source: https://github.com/berkowski/mio-serial Files: * Copyright: 2017 Zac Berkowitz <zac.berkowitz@gmail.com> License: Expat Files: debian/* Copyright: 2026 Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net> 2026 Michele Cane <michele.cane@proton.me> License: Expat License: Expat Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 1 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 24 days ago.
Report
DFSG NEW review for rust-mio-serial version 5.0.7-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 1 minor
- debian/watch: version 5
- debian/copyright: machine-readable
Licensing
All upstream files are MIT (Expat) licensed under a single upstream LICENSE, Copyright (c) 2017 Zac Berkowitz, and debian/copyright matches every file in the tree. The whole source tree (LICENSE, Cargo.toml, Cargo.toml.orig, Cargo.lock, .cargo_vcs_info.json, .gitignore, README.md, CHANGELOG.md, appveyor.yml, .github/* including the com0com.cer CI certificate, src/, tests/, examples/) is covered by the Files: * / License: Expat stanza, and debian/* by its own stanza; the full Expat text is included and the short name matches the actual license. No non-free terms, no unreferenced or unlicensed files, no minified or generated binaries lacking source, and no vendored third-party code (dependencies serialport, mio, nix, log are linked not bundled). copyright-format 1.0 with the standard URL.
Packaging
Standard, current debcargo 2.8.4 output, correct in every structural respect: debhelper-compat 13 with dh-sequence-cargo and a minimal dh $@ --buildsystem cargo rules file; dependency split between Build-Depends and Build-Depends-Arch is right; every dependency name (librust-serialport-4-dev and its +libudev/+serde feature packages, librust-nix-0.30+term-dev, librust-mio-1+{default,os-ext,os-poll}-dev, librust-log-0.4, librust-env-logger-0.11, dh-cargo 34) resolves in the archive; Multi-Arch: same and the full Provides set are correct for collapse_features=true; patches are DEP-3 formatted, correctly ordered and the nix relaxation matches Debian's nix 0.30.1; autopkgtests are well designed (socat-backed pseudo-terminals under $AUTOPKGTEST_TMP, per-fixture unique port names via an atomic counter, feature matrix with appropriate riscv64 exclusions); changelog and Vcs-* fields are sane. Only a one-point Standards-Version lag.
Issues
minor packaging 1. Standards-Version is one point release behind current Policy ◂
- Files:
debian/control - Evidence:
Standards-Version: 4.7.4; current Debian Policy is 4.7.4.1 (2026-03-31), before this packaging (2026-10-07). - Problem: Policy 4.1 asks that the package not declare a newer standards version than it conforms to; it should state the current one. 4.7.4.1 is a small maintenance point release over 4.7.4, so this is cosmetic (debcargo's template value), not a conformance problem.
- Fix: Bump Standards-Version to 4.7.4.1 (or the then-current version) on the next upload.
Verified ◂
- Read every debian/ file: control, rules, changelog, source/format, copyright, copyright.debcargo.hint, debcargo.toml, cargo-checksum.json, patches/series, both patches, tests/control, upstream/metadata.
- Inventoried the entire upstream tree (gitignore:false glob/grep, .pc excluded): LICENSE, Cargo.toml, Cargo.toml.orig, Cargo.lock, .cargo_vcs_info.json, .gitignore, README.md, CHANGELOG.md, appveyor.yml, .github/{NOTES.md, com0com.cer, workflows/github-ci.yml}, src/lib.rs, tests/common.rs, tests/test_serialstream.rs, examples/read_serialport.rs.
- Tree-wide copyright/licence scan found licence text only in LICENSE and README.md; source/config/CI files carry no per-file headers and are governed by the single MIT LICENSE (2017 Zac Berkowitz), matching debian/copyright's
Files: */Expat stanza. No file lacks a licence. - debian/copyright is machine-readable (copyright-format 1.0, standard URL);
Files: *covers all upstream files including com0com.cer (plain Windows CI test certificate);Files: debian/*covers packaging; License: Expat paragraph contains the complete MIT text; no Files-Excluded needed since the orig tarball ships only these files. - All Build-Depends/Depends names resolve in the Debian unstable lists (librust-serialport-dev 4.8.1-3, librust-nix-dev 0.30.1-3+b1, librust-mio-dev 1.2.0-1, librust-env-logger-dev 0.11.10-1, dh-cargo 34, including the +libudev/+serde/+os-ext/+os-poll/+term virtual feature packages).
- dh-cargo on this system (Debian::Debhelper::Buildsystem::cargo.pm) removes Cargo.lock in configure and re-links from /usr/share/cargo/registry, so the source Cargo.lock (which still pins nix 0.31.3 and windows-sys 0.61.2, disagreeing with the patched Cargo.toml) has no effect on build or on the installed package.
- Patch order is correct: series applies auto/auto-remove-targets.patch (drops the windows-only windows-sys target) then relax-nix.patch (nix 0.31.3 -> 0.30); both are DEP-3 formatted with appropriate Forwarded values.
- Autopkgtest design: 5 cargo-auto-test stanzas cover all-features/default/libudev/serde/no-default; socat is in Depends; pseudo-terminal paths use $AUTOPKGTEST_TMP; tests derive per-fixture port names (atomic counter) so parallel runs are safe; compile-time option_env!("TEST_PORT_NAMES") is fed through the Test-Command environment.
- control/changelog/.dsc are mutually consistent (Architecture any, Multi-Arch same, correct Provides: 5.0.7/5.0/5 with +default/+libudev/+serde), Vcs-* point to salsa debcargo-conf src/mio-serial, no maintainer scripts (none needed), binary stanza omits Priority/Section (dpkg defaults to optional; standard debcargo practice).
- uscan found the packaged version as the newest upstream release (upstream
5.0.7, packaged5.0.7).
Not confirmed ◂
- Actual archive build/test run was not performed here (read-only review): the assert in relax-nix.patch that mio-serial's termios usage is API-compatible with nix 0.30 (Debian ships 0.30.1) is unverified by compilation. The correctness of the Debian-toolchain compile and of each autopkgtest in the CI environment therefore remains unconfirmed.
- lintian and licensecheck were run separately prior to this review and were not replicated.
Proposed changes ◂
None.
Review Information
accepted — allocated to awm 23 days ago, started 23 days ago, completed 23 days ago.