Review: rust-pkcs1-0.7 0.7.5-1
Package Information
| Description | Pure Rust implementation of Public-Key Cryptography Standards (PKCS) #1: RSA Cryptography Specifications Version 2.2 (RFC 8017) - Rust source code Source code for Debianized Rust crate "pkcs1" |
|---|---|
| Maintainer | Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net> |
| Changed By | kpcyrd <git@rxv.cc> |
| Distribution | unstable |
| Architecture | any |
| VCS | git: https://salsa.debian.org/rust-team/debcargo-conf.git [src/pkcs1-0.7] (browse) |
| Tracker | https://tracker.debian.org/pkg/rust-pkcs1-0.7 |
| Uploaded | 9 days ago |
New Package Report
.changes
| Distribution | unstable |
|---|---|
| Source | rust-pkcs1-0.7 |
| Version | 0.7.5-1 |
| Changed-By | kpcyrd <git@rxv.cc> |
| Architecture | amd64 source |
Changelog
rust-pkcs1-0.7 (0.7.5-1) unstable; urgency=medium . * Package pkcs1 0.7.5 from crates.io using debcargo 2.8.4
.dsc
| Component | main |
|---|---|
| Package-List | librust-pkcs1-0.7-dev deb rust optional arch=any |
| Section | rust |
| Priority | optional |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: pkcs1 Upstream-Contact: RustCrypto Developers Source: https://github.com/RustCrypto/formats/tree/master/pkcs1 Files: * Copyright: 2021-2023 RustCrypto Developers License: Apache-2.0 or MIT Files: debian/* Copyright: 2023 Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net> 2023 Jelmer Vernooij <jelmer@debian.org> License: Apache-2.0 or MIT License: Apache-2.0 Debian systems provide the Apache 2.0 license in /usr/share/common-licenses/Apache-2.0 License: MIT Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 9 days ago.
Report
DFSG NEW review for rust-pkcs1-0.7 version 0.7.5-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 0 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: 5 found
Licensing
The crate is dual-licensed Apache-2.0 OR MIT (license = "Apache-2.0 OR MIT" in Cargo.toml.orig, LICENSE-APACHE and LICENSE-MIT at the top of the tree), both DFSG-free and compatible. debian/copyright is DEP-5, has Files: * (2021-2023 RustCrypto Developers, Apache-2.0 or MIT) and a Files: debian/* stanza, carries the full MIT text (no common-licenses copy exists) and points to /usr/share/common-licenses/Apache-2.0. A tree-wide grep for copyright/licence wording found notices only in LICENSE-MIT, the README licence section and the two copyright files, so no holder or licence is unaccounted for; the five binary .der files are RSA key test vectors of the same project, covered by Files: *.
Packaging
This is unmodified debcargo 2.8.4 output for the semver-suffixed source package rust-pkcs1-0.7: debhelper compat 13 with dh-sequence-cargo, a two-line rules, no patches, 3.0 (quilt), Standards-Version 4.7.4 against Policy 4.7.4.1, correct Vcs-*/Homepage/X-Cargo-Crate fields, and a complete autopkgtest matrix with the dev-dependencies in debian/tests/control. Every package named in Build-Depends-Arch and Depends exists in unstable at a satisfying version, and the <!nocheck> markers are consistent with the cargo buildsystem, whose test step runs cargo build only. The Files: debian/* years (2023 against a 2026 upload) are drift, not an omission of a holder.
Issues
None.
Verified ◂
- debian/copyright read in full:
Format:is the copyright-format/1.0 URL,Files: *andFiles: debian/*stanzas, stand-aloneLicense: Apache-2.0andLicense: MITparagraphs; the MIT text matches LICENSE-MIT clause for clause (only line wrapping differs), and the Apache pointer matches /usr/share/common-licenses/Apache-2.0. - Tree-wide grep (gitignore off) for
Copyright,(C),©,SPDX-License-Identifier,Licensed under,Permission is hereby,GNU,Apache License,public domain,All rights reservedover the whole tree: the only hits outside debian/ are LICENSE-APACHE (verbatim Apache-2.0, appendix placeholderCopyright [yyyy] [name of copyright owner]), LICENSE-MIT (Copyright (c) 2021-2023 The RustCrypto Project Developers) and README.md's "Licensed under either of" section. No per-file notices exist, soFiles: *covers everything and no holder is missed; the prescan's author check agreeing is consistent with this. The RustCrypto Project Developersin LICENSE-MIT versusRustCrypto DevelopersinFiles: *is a shortened form of the same holder (Cargo.tomlauthorsuses the latter); copyright-format 6.8 allows shortening that does not sacrifice information, so this is not an inaccuracy.- All upstream files inventoried: 6 files at the top level (Cargo.toml, Cargo.toml.orig, CHANGELOG.md, README.md, LICENSE-APACHE, LICENSE-MIT, plus .cargo_vcs_info.json), 8 under src/ (including src/private_key/other_prime_info.rs) and 14 under tests/ (4 test files plus 10 example keys). No vendored third-party code, no subdirectory LICENSE/COPYING/NOTICE/AUTHORS, no generated code without its input.
tests/examples/rsa2048-priv-3prime.der,rsa2048-priv.der,rsa2048-pub.der,rsa4096-priv.derandrsa4096-pub.der: ASN.1 DER-encoded RSA private/public keys used as test vectors throughinclude_bytes!in tests/private_key.rs and tests/public_key.rs; each has a textual.pemcounterpart (-----BEGIN RSA PUBLIC KEY-----confirmed in rsa2048-pub.pem) so a readable form exists, they are not build output, and they are covered byFiles: *(Apache-2.0 or MIT).debian/copyright.debcargo.hintis debcargo's own template, shipped as debcargo leaves it; itsUNKNOWN-YEARS/UNKNOWN-LICENSE; FIXME (overlay)placeholders are resolved in the final debian/copyright, which records the MIT text for LICENSE-MIT.- Licence compatibility: Apache-2.0 (GPLv3-compatible, no field-of-use or non-commercial terms) and MIT combined as an alternative choice in one source package; nothing non-free anywhere in the tree.
- Read in full: debian/control, rules, changelog, copyright, copyright.debcargo.hint, debcargo.toml, source/format, tests/control, upstream/metadata. No debian/patches, no maintainer scripts, no install/links/dirs files, hence nothing to check there. debian/watch, debian/cargo-checksum.json and .pc/ were left out as instructed.
- compat 13:
dh_gencontrolautogenerates relationship substvars, anddh $@ --buildsystem cargowith/usr/share/perl5/Debian/Debhelper/Buildsystem/cargo.pmconfirmed (sub testruns/usr/share/cargo/bin/cargo buildunlesstestis passed,sub buildonly copies sources), soBuild-Depends-Archcarrying<!nocheck>on every entry matches what anocheckbuild actually needs. - Dependencies checked with apt-cache in unstable: dh-cargo 34 (Provides dh-sequence-cargo), librust-der-0.7-dev 0.7.10-1 (Provides +default/+oid/+pem/+std/+zeroize/+alloc), librust-spki-0.7-dev 0.7.3-1 (+default), librust-pkcs8-0.10-dev 0.10.2-1 (+alloc/+pem/base), librust-const-oid-0.9-dev 0.9.6-1 (+db), librust-hex-literal-0.4-dev 0.4.1-1, librust-tempfile-dev 3.27.0-1 (+default). Every name in Build-Depends-Arch, Depends and the autopkgtest Depends resolves at a satisfying version.
- autopkgtest: eight stanzas covering default, --no-default-features, and the alloc/pem/pkcs8/std/zeroize features, with the crate's dev-dependencies (const-oid +db, hex-literal, tempfile) listed there rather than in Build-Depends as dh-cargo's test step requires;
@supplies the librust-pkcs1-0.7-dev package and its Depends, which is where librust-pkcs8-0.10-* comes from. - Standards-Version 4.7.4 against the Policy 4.7.4.1 given by the policy tool (first two components 4.7 match). changelog: single 0.7.5-1 entry, unstable, urgency=medium, date 2026-11-09 is a Monday; the fresh changelog and the
Replaces/Breaks librust-pkcs1-dev (<< 0.7.6~)pair match the semver-suffix rename of the old unversioned package. - The
# FIXME (packages."(name)".section) ... consider overridingcomment in debian/control is debcargo's own generated remark about the long Description synopsis; it is a comment with no effect on the binary package. - uscan found the packaged version as the newest upstream release (upstream
0.7.5, packaged0.7.5). - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (Apache-2.0).
Not confirmed ◂
- No build or test run was possible in this read-only review; per the review instructions the package is taken to build and its autopkgtests to pass.
- Upstream README states an MSRV of Rust 1.65 while Cargo.toml/Cargo.toml.orig declare
rust-version = "1.60", which is what the packaging uses; upstream's own manifest is authoritative and unstable has a far newer rustc, so this was not treated as a packaging fault.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader was emailed about the review 9 days ago.
Review Information
accepted — allocated to mechtilde 9 days ago, started 9 days ago, completed 9 days ago.