Review: rust-rsa-0.9 0.9.10-1
Package Information
| Description | Pure Rust RSA implementation - Rust source code This package offers a portable RSA implementation in pure Rust. Source code for Debianized Rust crate "rsa" |
|---|---|
| Maintainer | Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net> |
| Changed By | kpcyrd <git@rxv.cc> |
| Distribution | unstable |
| Architecture | any |
| VCS | git: https://salsa.debian.org/rust-team/debcargo-conf.git [src/rsa-0.9] (browse) |
| Tracker | https://tracker.debian.org/pkg/rust-rsa-0.9 |
| Uploaded | 9 days ago |
New Package Report
.changes
| Source | rust-rsa-0.9 |
|---|---|
| Version | 0.9.10-1 |
| Changed-By | kpcyrd <git@rxv.cc> |
| Architecture | amd64 source |
| Distribution | unstable |
Changelog
rust-rsa-0.9 (0.9.10-1) unstable; urgency=medium . * Package rsa 0.9.10 from crates.io using debcargo 2.8.4
.dsc
| Package-List | librust-rsa-0.9-dev deb rust optional arch=any |
|---|---|
| Section | rust |
| Priority | optional |
| Component | main |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: rsa Upstream-Contact: RustCrypto Developers dignifiedquire <dignifiedquire@gmail.com> Source: https://github.com/RustCrypto/RSA Files: * Copyright: 2018-2026 RustCrypto Developers 2018-2026 dignifiedquire <dignifiedquire@gmail.com> License: MIT or Apache-2.0 Files: debian/* Copyright: 2023-2026 Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net> 2023 Jelmer Vernooij <jelmer@debian.org> 2025-2026 Daniel Kahn Gillmor <dkg@fifthhorseman.net> License: MIT or Apache-2.0 License: Apache-2.0 Debian systems provide the Apache 2.0 license in /usr/share/common-licenses/Apache-2.0 License: MIT Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 9 days ago.
Report
DFSG NEW review for rust-rsa-0.9 version 0.9.10-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 0 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: 7 found
Licensing
The tree is dual-licensed MIT OR Apache-2.0, as Cargo.toml, README.md and the two LICENSE files say; debian/copyright is DEP-5, reproduces the MIT text in full, points at /usr/share/common-licenses/Apache-2.0, and names the two upstream holders (RustCrypto Developers, dignifiedquire) carried in Cargo.toml. Greps for copyright/licence wording over the whole tree find no other licence, no narrower terms and no additional holder, and the seven unscanned binary files are RSA test keys used by the crate's own tests.
Packaging
Standard debcargo 2.8.4 output for the semver-suffixed Rust team layout: compat 13 with dh-sequence-cargo, a plain dh $@ --buildsystem cargo, feature/versioned Provides, and Replaces/Breaks handling the migration from the unsuffixed librust-rsa-dev 0.9.10-1. Every dependency and every feature package named in control and in debian/tests/control exists in unstable at a satisfying version, Standards-Version 4.7.4 matches Policy 4.7.4.1, and the single patch only relaxes two dependency versions to what the archive has.
Issues
None.
Verified ◂
- Read debian/copyright in full: DEP-5 with the exact 1.0 Format URL,
Files: *(MIT or Apache-2.0, RustCrypto Developers and dignifiedquire, 2018-2026) andFiles: debian/*, plus stand-aloneLicense: MIT(full text) andLicense: Apache-2.0(pointer to /usr/share/common-licenses/Apache-2.0). - Upstream licensing is consistent with that:
Cargo.toml/Cargo.toml.origcarrylicense = "MIT OR Apache-2.0", README.md says "Licensed under either of Apache License, Version 2.0 / MIT license", and LICENSE-APACHE and LICENSE-MIT are the standard texts. - Grep over all non-debian files for
Copyright,(C),©,SPDX-License-Identifier,Licensed under,Permission is hereby granted,GNU (Lesser) General Public,Apache License,Mozilla Public,public domain,All rights reservedmatched only LICENSE-APACHE, LICENSE-MIT and README.md; no source, test or bench file carries a copyright notice, so no holder beyond the two inFiles: *is claimed anywhere in the tree. - Prescan's holder check agrees: 5 holders declared, every holder found in the tree named in debian/copyright.
- The seven files the scan flagged as unrecognised binary data are ASN.1 DER RSA test keys:
tests/examples/pkcs1/rsa2048-priv.der,rsa2048-pub.der,rsa4096-priv.der,rsa4096-pub.der,tests/examples/pkcs8/rsa2048-priv.der,rsa2048-pub.der,rsa2048-sp800-56b-priv.der. They are loaded withinclude_bytes!by tests/pkcs1.rs:17-29, tests/pkcs8.rs:4-7 and the doc tests at src/key.rs:804,826; their base64 PEM forms sit beside them and .gitattributes marks those astext eol=lf. Test fixtures, covered byFiles: *, no separate licence. - No embedded third-party copy: grep for
openssl|boringssl|mbedtls|bearssl|golang|bouncy castle|libgcryptfinds only comments in tests/pkcs1.rs recording that key components were dumped withopenssl asn1parse; no third-party code or licence is present. - Build-Depends-Arch covers exactly what a default-feature build needs (std, pem, u64_digit), and every
librust-*name resolves in unstable at a satisfying version: num-bigint-dig 0.8.6 (the>= 0.8.6required, providing +i128/+prime/+u64-digit/+zeroize/+nightly/+serde), signature 2.2.0, pkcs8 0.10.2 with +encryption, serde 1.0.229, digest 0.10.7, rand-core 0.6.4, sha1/sha2/sha3 +oid, num-traits 0.2.19 +libm, subtle 2, spki 0.7, zeroize 1.5, const-oid 0.9, num-integer 0.1. - Test dependencies resolve too: base64ct 1.8.3, proptest 1.11.0, serde-test 1.0.177 (>= 1.0.89), hex-literal 0.4.1, rand-chacha 0.3.1, rand-xorshift 0.5.0, rand 0.8, dh-cargo 34 (>= 33~), rustc >= 1.65; the trailing
@in each stanza installs librust-rsa-0.9-dev, whose Depends bring the feature packages --all-features needs (num-bigint-dig+nightly, pkcs8+encryption, rand-core+getrandom, sha1/sha2+oid, serde+derive). - debian/patches/relax-deps.patch (only entry in series) has two hunks and both match the archive:
signature">2.0, <2.3"->"2.2"(unstable has 2.2.0) and the dev-dependencyrand_xorshift"0.3"->"0.5"(rand_xorshift 0.3 is no longer in unstable; 0.5.0-3 is). Nothing in src/, tests/ or benches/ uses rand_xorshift, so that hunk affects resolution only. The patch needs no forwarding upstream (it is Debian-archive-specific); Policy does not require DEP-3 headers. - debhelper compat 13 with
dh-sequence-cargois correct for this rules file (dh-cargo 34 Provides dh-sequence-cargo);${misc:Depends}is present, and at compat 13 that is the substvar that belongs in Depends. - benches/key.rs begins
#![feature(test)], but that is not an autopkgtest failure: /usr/share/cargo/bin/cargo-auto-test detectserror[E0554]and re-runs the same command withRUSTC_BOOTSTRAP=1. - Standards-Version 4.7.4 against Policy 4.7.4.1 (policy tool table of contents) - current. Changelog 0.9.10-1, unstable, urgency medium, signed by kpcyrd who is also the Uploader; the .dsc in the review directory matches (Testsuite: autopkgtest, Vcs-Git/Browser, Testsuite-Triggers).
- Replaces/Breaks
librust-rsa-dev (<< 0.9.11~)correctly cover the existing unsuffixed librust-rsa-dev 0.9.10-1+b1, which ships the same /usr/share/cargo/registry/rsa-0.9.10 path. - debian/copyright.debcargo.hint is debcargo's overlay hint (it still reads
FIXME (overlay) UNKNOWN-YEARS ...and names kpcyrd); it is a source-package-only file, covered byFiles: debian/*, and does not affect debian/copyright's accuracy. - Read in full: debian/{control,changelog,copyright,copyright.debcargo.hint,debcargo.toml,rules,patches/series,patches/relax-deps.patch,source/format,upstream/metadata,tests/control}, the .dsc, and Cargo.toml, Cargo.toml.orig, README.md, LICENSE-MIT, SECURITY.md, .gitattributes, .cargo_vcs_info.json, .github/workflows/ci.yml, benches/key.rs, tests/proptests.rs and the relevant parts of tests/pkcs1.rs, tests/pkcs8.rs, src/lib.rs, src/key.rs. debian/cargo-checksum.json and .pc/ were passed over as instructed.
- uscan found the packaged version as the newest upstream release (upstream
0.9.10, packaged0.9.10). - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (Apache-2.0).
Not confirmed ◂
- The upstream years in
Files: *(2018-2026) cannot be checked against upstream git history from the package; they rest on the two Cargo.toml authors plus the years filled in over debcargo'sFIXME (overlay) UNKNOWN-YEARSplaceholder. Files: debian/*names the Rust team, Jelmer Vernooij (2023) and Daniel Kahn Gillmor (2025-2026), but not the uploader kpcyrd, whose debcargo run produced these files; the files carry no notice of their own, so there is nothing to check the list against, and the team entry covers them.- No build or autopkgtest was run (read-only review); dependency and feature availability was checked only against the package lists via apt-cache.
- Why the model asked for what a review has no use for. During this review it asked once for something outside the package and the reviewing system (another file of the sandbox, or a URL), or was given part of the review tooling's own configuration, and that was refused or withheld. A model does this when something it has read tells it to, so look in the package for text addressed to a reviewing program, and treat this report with suspicion. Refused:
grep: "xd://policy" is not a file of the package or of the reviewing system.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader was emailed about the review 9 days ago.
Review Information
accepted — allocated to mechtilde 9 days ago, started 9 days ago, completed 9 days ago.