Review: rust-rstest-reuse 0.7.0+ds-1
Package Information
| Description | Reuse rstest attributes Source code for Debianized Rust crate "rstest_reuse" |
|---|---|
| Maintainer | Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net> |
| Changed By | Brian Cosgrove <cosgroveb@gmail.com> |
| Sponsor | tsimonq2@debian.org |
| Distribution | unstable |
| Architecture | any |
| VCS | git: https://salsa.debian.org/rust-team/debcargo-conf.git [src/rstest-reuse] (browse) |
| Tracker | https://tracker.debian.org/pkg/rust-rstest-reuse |
| Uploaded | 30 days ago |
New Package Report
.changes
| Changed-By | Brian Cosgrove <cosgroveb@gmail.com> |
|---|---|
| Architecture | source amd64 |
| Distribution | unstable |
| Date | Thu, 08 Oct 2026 10:45:35 -0500 |
| Source | rust-rstest-reuse |
| Version | 0.7.0+ds-1 |
Changelog
rust-rstest-reuse (0.7.0+ds-1) unstable; urgency=medium . * Package rstest_reuse 0.7.0 from crates.io using debcargo 2.8.4 . [ Reinhard Tartler ] * Package rstest_reuse 0.6.0 from crates.io using debcargo 2.6.0
.dsc
| Section | rust |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | librust-rstest-reuse-dev deb rust optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: rstest_reuse Upstream-Contact: Michele d'Amico <michele.damico@gmail.com> Source: https://github.com/la10736/rstest Files-Excluded: tests/acceptance.rs Files: * Copyright: 2018-2024 Michele d'Amico <michele.damico@gmail.com> 2024 Paul Gey <narpfel@gmx.de> License: Expat or Apache-2.0 Files: debian/* Copyright: 2023-2026 Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net> 2023 Reinhard Tartler <siretart@tauware.de> 2026 Brian Cosgrove <cosgroveb@gmail.com> License: Expat or Apache-2.0 License: Apache-2.0 Debian systems provide the Apache 2.0 license in /usr/share/common-licenses/Apache-2.0 License: Expat Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 1 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 24 days ago.
Report
DFSG NEW review for rust-rstest-reuse version 0.7.0+ds-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 1 minor
- debian/watch: version 5
- debian/copyright: machine-readable
Licensing
Every file in the tree is licensed MIT/Expat or Apache-2.0 (the crate's license = "MIT OR Apache-2.0" in Cargo.toml.orig), both DFSG-free and mutually compatible, with no non-free clauses anywhere. debian/copyright is DEP-5, with a Files: * catch-all covering all upstream files and a debian/* override for the packaging, full Expat text reproduced and Apache-2.0 pointed at /usr/share/common-licenses. Files-Excluded: tests/acceptance.rs matches the +ds repack (that file is indeed absent) and debian/debcargo.toml. No missing holder or missing licence text was found.
Packaging
Standard debcargo-generated packaging: 3.0 (quilt), debhelper-compat 13 with dh-sequence-cargo and --buildsystem cargo, DEP-3 patch, autopkgtest, Vcs-*/Homepage/upstream metadata, Standards-Version 4.7.4 (current is 4.7.4.1). Build- and test-dependencies were each confirmed to exist in the archive. Only a small changelog inaccuracy was found.
Issues
minor packaging 1. Stale 0.6.0 bullet inside the 0.7.0+ds-1 changelog entry of a new source package ◂
- Files:
debian/changelog:5-6 - Evidence:
[ Reinhard Tartler ]/* Package rstest_reuse 0.6.0 from crates.io using debcargo 2.6.0appear inside the singlerust-rstest-reuse (0.7.0+ds-1)entry, together with* Package rstest_reuse 0.7.0 from crates.io using debcargo 2.8.4. - Problem: rust-rstest-reuse is a new source package (librust-rstest-reuse-dev is not in the archive), so the first and only changelog entry should describe the 0.7.0 upload. Documenting a 0.6.0 packaging, attributed to a different uploader, inside the 0.7.0+ds-1 entry misrepresents the package's history; no 0.6.0 upload of this source package exists.
- Fix: Remove the
[ Reinhard Tartler ]block from this entry, or, if a 0.6.0 upload really happened, record it as its ownrust-rstest-reuse (0.6.0-...)changelog entry.
Verified ◂
- Read debian/copyright in full: DEP-5, Format line correct,
Files: *anddebian/*stanzas,Files-Excluded: tests/acceptance.rs, and stand-aloneLicense: Expat/License: Apache-2.0paragraphs; Expat text complete, Apache-2.0 referenced to /usr/share/common-licenses. - Inventoried the whole upstream tree (glob with hidden and gitignore disabled): Cargo.toml, Cargo.toml.orig, README.md, checkoutlist.md, LICENSE-APACHE, LICENSE-MIT, .cargo_vcs_info.json, src/lib.rs, and 14 files under tests/resources/; no binaries, fonts, images or vendored third-party code.
- Grepped the whole tree for Copyright/(C)/©/SPDX/Licensed under/GNU/Apache/MPL/public domain/All rights reserved: only the two LICENSE files and README.md carry licence notices, all MIT/Apache.
- Confirmed
tests/acceptance.rsis absent from the tree (excluded by the +ds repack, as declared in debian/copyright and debian/debcargo.toml); the excluded file is also the only user of the unpublished rstest_test path dev-dependency. - Read debian/control, rules, changelog, debcargo.toml, copyright.debcargo.hint, cargo-checksum.json, source/format, patches/series, the single patch, tests/control, upstream/metadata.
- Verified via apt-cache that the Build-Depends and autopkgtest Depends exist: librust-rstest-0.26+default-dev (librust-rstest-dev 0.26.1-3), librust-temp-testdir-0.2+default-dev (0.2.3-2+b1), librust-lazy-static-1+default-dev (1.5.0-3), librust-syn-2+extra-traits-dev (2.0.119-2), dh-cargo (34, provides dh-sequence-cargo); librust-rstest-reuse-dev itself is the package under review, not yet in the archive.
- Checked the patch is DEP-3 (Description/Origin/Forwarded/Last-Update) and that it only bumps the Cargo.toml rstest dev-dependency 0.19.0 to 0.26.1, consistent with the librust-rstest-0.26 test dependency.
- uscan found the packaged version as the newest upstream release (upstream
0.7.0, packaged0.7.0+ds).
Not confirmed ◂
- Could not build or run anything: whether the lib.rs doctests still pass against the bumped rstest 0.26.1 dev-dependency (upstream pinned 0.19.0) was not checked.
- The upstream copyright years and the attribution
2024 Paul Gey <narpfel@gmx.de>in debian/copyright come from upstream git history, which is not present in the source package; only the years 2018-19 in LICENSE-APACHE/LICENSE-MIT could be seen, so the 2018-2024 range could not be confirmed from the tree. - Whether the shipped debian/copyright.debcargo.hint (still containing
FIXME (overlay)/UNKNOWN-LICENSE) is acceptable debcargo-conf practice was not verified against the archive's other rust packages.
Proposed changes ◂
None.
Review Information
accepted — allocated to awm 23 days ago, started 23 days ago, completed 23 days ago.