Review: rust-tynm 0.2.0-1
Package Information
| Description | Returns type names in shorter form - Rust source code Source code for Debianized Rust crate "tynm" |
|---|---|
| Maintainer | Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net> |
| Changed By | Ying-Chun Liu (PaulLiu) <paulliu@debian.org> |
| Sponsor | paulliu@debian.org |
| Distribution | unstable |
| Architecture | any |
| VCS | git: https://salsa.debian.org/rust-team/debcargo-conf.git [src/tynm] (browse) |
| Tracker | https://tracker.debian.org/pkg/rust-tynm |
| Uploaded | 22 days ago |
New Package Report
.changes
| Architecture | amd64 source |
|---|---|
| Distribution | unstable |
| Date | Sat, 17 Oct 2026 03:07:06 +0000 |
| Source | rust-tynm |
| Version | 0.2.0-1 |
| Changed-By | Ying-Chun Liu (PaulLiu) <paulliu@debian.org> |
Changelog
rust-tynm (0.2.0-1) unstable; urgency=medium . * Team upload. * Package tynm 0.2.0 from crates.io using debcargo 2.8.3
.dsc
| Section | rust |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | librust-tynm-dev deb rust optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: tynm Upstream-Contact: Azriel Hoh <azriel91@gmail.com> Source: https://github.com/azriel91/tynm Files: * Copyright: 2019 Azriel Hoh <azriel91@gmail.com> License: MIT or Apache-2.0 Files: LICENSE-MIT Copyright: 2019 Azriel Hoh <azriel91@gmail.com> License: MIT Files: debian/* Copyright: 2026 Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net> 2026 Ying-Chun Liu (PaulLiu) <paulliu@debian.org> License: MIT or Apache-2.0 License: Apache-2.0 Debian systems provide the Apache 2.0 license in /usr/share/common-licenses/Apache-2.0 License: MIT Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 1 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 21 days ago.
Report
DFSG NEW review for rust-tynm version 0.2.0-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 1 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
The crate is dual-licensed MIT OR Apache-2.0, and both licence texts are present: LICENSE-MIT is a complete MIT grant (Copyright 2019 Azriel Hoh) and LICENSE-APACHE is the verbatim Apache-2.0 text. debian/copyright is DEP-5, names Azriel Hoh for upstream and the Debian Rust Maintainers and the uploader for debian/*, reproduces the MIT text in full and points Apache-2.0 at /usr/share/common-licenses/Apache-2.0. No non-free terms, licences of unclear provenance, or generated/binary artefacts were found; every upstream file (21 files, no sub-trees except src/ and .github/) is text under the same dual licence.
Packaging
The debcargo-generated packaging is sound: compat 13 with dh-sequence-cargo, Build-Depends-Arch correctly limited to what the default-feature build needs, a complete debcargo-style autopkgtest suite, valid changelog, Standards-Version 4.7.4, and all named dependencies/providers exist in the archive. The one blemish is a patch that relaxes the nom requirement to >= 7.0.0 although Debian ships nom 8.0.0, which the upstream 0.2.0 release targets, so the patch is unnecessary.
Issues
minor packaging 1. Patched nom requirement (>= 7.0.0) is unnecessary; Debian ships nom 8.0.0 ◂
- Files:
debian/patches/0001_relax-dependencies.patch:14,Cargo.toml.orig,debian/control:11,CHANGELOG.md - Basis: checked, in the package or with a reference tool
- Evidence: The patch says 'The upstream set the dependencies too strict' and changes
version = "8.0.0"toversion = ">= 7.0.0", while Cargo.toml.orig hasnom = { version = "8.0.0", ... }and CHANGELOG.md records 'Updatenomto8.0.0' for 0.2.0.apt-cache show librust-nom-devgives version 8.0.0-2, providinglibrust-nom+alloc-dev (= 8.0.0-2), which already satisfies the unpatched^8.0.0. - Problem: The patch rests on a false premise: Debian's nom package is 8.0.0, the version upstream deliberately moved to in this release. Keeping the relaxation leaves a stale, misleading delta against upstream and, in any environment where both nom 7 and 8 are available, would allow Cargo to resolve a version upstream does not support in this release.
- Fix: Drop debian/patches/0001_relax-dependencies.patch and the series entry, keep the upstream
version = "8.0.0", and set the Build-Depends-Arch/Depends constraint tolibrust-nom+alloc-dev (>= 8.0.0). If some Debian suite still lacks nom 8, say so explicitly in the patch rather than the current generic wording.
Verified ◂
- debian/copyright is DEP-5 (copyright-format 1.0) and its three Files stanzas cover the whole tree:
Files: *(dual MIT/Apache-2.0, 2019 Azriel Hoh),Files: LICENSE-MIT(MIT),Files: debian/*(Debian Rust Maintainers and Ying-Chun Liu). - LICENSE-MIT matches the MIT text reproduced in debian/copyright and its notice
Copyright 2019 Azriel Hoh; LICENSE-APACHE is the complete, unmodified Apache-2.0 text (202 lines), and Apache-2.0 is correctly referenced from /usr/share/common-licenses/Apache-2.0. - The prescan's author check found all three declared authors represented and no unlisted holder among the 21 scanned files; a tree-wide grep for Copyright/(C)/©/SPDX/licence phrases found no other holder or licence.
- All non-debian upstream files are plain text (Rust sources in src/, README.md, README.tpl, CHANGELOG.md, CONTRIBUTING.md, rustfmt.toml, .codecov.yml, coverage.sh, .github/workflows/.yml, Cargo.toml, Cargo.toml.orig, Cargo.lock, .cargo_vcs_info.json, .cargo/config.toml, LICENSE-); there are no binaries, archives, minified assets, fonts or images, so no missing-source or provenance concern.
- Cargo.toml is cargo's normalised manifest generated from the shipped Cargo.toml.orig (crates.io tarball), not a missing-source build product; Cargo.lock is a generated lock file that dh-cargo's configure step deletes (
rm_files("Cargo.lock")). - The unmangled orig tarball and the debian tarball match the unpacked tree (orig tar top directory tynm-0.2.0; debian tar contains only debian/ files, and its debian/patches/series lists exactly the one applied patch).
- debian/patches/0001_relax-dependencies.patch has DEP-3 headers (Description, Forwarded, Author, Last-Update) and applies to the normalised Cargo.toml; only its premise is stale (reported above).
- debian/control: debhelper-compat (= 13) with dh-sequence-cargo (provided by dh-cargo 34); Build-Depends-Arch carries cargo:native, rustc:native, libstd-rust-dev and librust-nom+alloc-dev, matching what the default-feature
cargo buildperformed by dh_auto_test needs; the binary Depends on the serde feature crates consistent with collapse_features = true and provides the collapsed feature names. - All dependency names exist in the archive: librust-nom-dev 8.0.0-2 provides librust-nom+alloc-dev, librust-serde-dev 1.0.229-1 provides librust-serde-1+default-dev and +derive-dev, librust-pretty-assertions-dev 1.4.1-1+b1 provides the test dependency, librust-serde-yaml-dev 0.9.34-1+b1 provides librust-serde-yaml-0.9+default-dev, and dh-cargo 34 provides dh-sequence-cargo.
- debian/tests/control has five autopkgtest cases (all-features, default, info, serde, no-features) using /usr/share/cargo/bin/cargo-auto-test with the needed dev-dependencies and Architecture restrictions; debian/rules is the standard single-line debcargo
dh $@ --buildsystem=cargo. - debian/changelog is a well-formed first entry for 0.2.0-1 to unstable dated Sat, 17 Oct 2026, and Standards-Version 4.7.4 has the current first two components.
- The debcargo overlay bookkeeping (debian/debcargo.toml, debian/copyright.debcargo.hint, debian/cargo-checksum.json) is present and the overlay-uncertain copyright fields in the hint were resolved in the shipped debian/copyright.
- uscan found the packaged version as the newest upstream release (upstream
0.2.0, packaged0.2.0). - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (Apache-2.0).
Not confirmed ◂
- No build was attempted; nothing in the package points to a build failure, and the version constraints checked above are satisfiable from the archive.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader was emailed about the review 19 days ago.
Review Information
accepted — allocated to awm 18 days ago, started 18 days ago, completed 18 days ago.