Review: rust-vte4 0.10.0-1

Package Information

Description	Rust bindings for the VTE Gtk4 library - Rust source code Source code for Debianized Rust crate "vte4"
Maintainer	Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net>
Changed By	Jeremy Bícha <jbicha@ubuntu.com>
Sponsor	jbicha@debian.org
Distribution	unstable
Architecture	any
VCS	git: https://salsa.debian.org/rust-team/debcargo-conf.git [src/vte4] (browse)
Tracker	https://tracker.debian.org/pkg/rust-vte4
Uploaded	27 days ago

New Package Report

.changes◂

Architecture	source amd64
Distribution	unstable
Date	Sun, 11 Oct 2026 14:19:11 +0200
Source	rust-vte4
Version	0.10.0-1
Changed-By	Jeremy Bícha <jbicha@ubuntu.com>

Changelog◂

rust-vte4 (0.10.0-1) unstable; urgency=medium
 .
   * Package vte4 0.10.0 from crates.io using debcargo 2.8.4

.dsc◂

Component	main
Package-List	librust-vte4-dev deb rust optional arch=any
Section	rust
Priority	optional

debian/copyright◂

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: vte4
Upstream-Contact: The Gtk-rs Project Developers
Source: https://gitlab.gnome.org/World/Rust/vte4-rs

Files: *
Copyright: 2021-2026 The Gtk-rs Project Developers
License: MIT

Files: debian/*
Copyright:
 2026 Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net>
 2026 Jeremy Bícha <jbicha@ubuntu.com>
License: MIT

License: MIT
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in all
 copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.

DFSG Assistant LLM REVIEW 0 blocker, 0 important, 1 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 24 days ago.

Report◂

DFSG NEW review for rust-vte4 version 0.10.0-1

Summary

Licensing is DFSG-compliant and debian/copyright is accurate: Yes
Packaging is of good quality: Yes
Issues: 0 blocker, 0 important, 1 minor
debian/watch: version 5
debian/copyright: machine-readable

Licensing

debian/copyright is machine-readable (correct Format: URL) and matches the tree. Everything upstream is MIT: the root LICENSE is the Expat text and Cargo.toml declares license = "MIT" for author "The Gtk-rs Project Developers". A tree-wide grep for copyright/licence markers (Copyright, (C), ©, SPDX-License-Identifier, GNU General/Lesser, Apache, MPL, All rights reserved, ...) matched only LICENSE and the debian/ files, so there is no second holder or licence, and Gir.toml's generated src/auto/*.rs are gtk-rs output covered by the same MIT grant. The Files: * and debian/* stanzas cover the whole source, the holders are right, and the full MIT text is reproduced (needed, since Expat is not in /usr/share/common-licenses). MIT is DFSG-free and compatible with the crate's dependencies.

Packaging

Standard, current debcargo-generated packaging: 3.0 (quilt), debhelper-compat 13 with dh-sequence-cargo, Build-Depends/Build-Depends-Arch split correctly (cargo/rustc/libs are <!nocheck> in -Arch), full feature Depends/Provides lists matching the crate's Cargo.toml features, Multi-Arch: same, Standards-Version: 4.7.4 (current Policy is 4.7.4.1), correct Vcs-*/Homepage, machine-readable debian/upstream/metadata, and 13 autopkgtests covering all-features, default, no-features and every feature. The single patch is small, correctly applied, and marked Forwarded: upstream. Only a minor DEP-3-header gap on that patch.

Issues

minor packaging 1. Patch lacks DEP-3 Description/Author headers ◂

Files: debian/patches/gtk4_10.patch:1-3
Evidence: Subject: gtk4 4.24 requires v4_10 for GtkAccessible … Forwarded: https://gitlab.gnome.org/World/Rust/vte4-rs/-/work_items/11 (no Description:, Author: or Last-Update: lines)
Problem: The patch header is not DEP-3 conformant. Subject: is a git-format-patch field, not one of the DEP-3 fields; DEP-3 requires a Description field (and conventionally Author/Last-Update). Tooling that reads DEP-3 pseudo-headers (e.g. gbp pq, review tools) therefore gets no description or authorship for the Debian change.
Fix: Replace the bare Subject: line with a DEP-3 Description: field and add Author:/Last-Update: (the forward status already present) so the header reads, for example, Description: gtk4 4.24 requires the v4_10 feature for GtkAccessible / Author: Jeremy Bícha <jbicha@ubuntu.com> / Last-Update: 2026-10-11.

Verified ◂

debian/copyright is DEP-5 with the exact https Format: URL; Files: * (MIT, 2021-2026 The Gtk-rs Project Developers) and debian/* (MIT, Debian Rust Maintainers / Jeremy Bícha) stanzas; full MIT text in the stand-alone License stanza.
Tree-wide grep for copyright/licence evidence over every upstream file (excluding .pc/) and the whole debian/ directory matched only LICENSE, debian/copyright* and debian/watch; the only LICENSE/COPYING/NOTICE/AUTHORS file is the root LICENSE (MIT).
Upstream inventory read: Cargo.toml, Cargo.toml.orig, Cargo.lock, Gir.toml, README.md, src/{lib,prelude,pty,terminal}.rs, src/auto/* (incl. versions.txt), src/subclass/*, src/examples/main.rs, .cargo_vcs_info.json. No jar/class/so/exe/pyc/firmware/minified-JS or other non-source blobs.
debian/cargocargo deps checked with apt-cache: librust-gtk4-0.11+default-dev, +v4-10, +v4-18 and librust-io-lifetimes-2+default-dev are provided by librust-gtk4-dev 0.11.5-1 and librust-io-lifetimes-dev 2.0.3-1+b1; librust-vte4-sys-dev is built by rust-vte4-sys 0.10.0-1, waiting in ftp-master's NEW queue, and librust-vte4-dev is built by this package — neither absence is a fault.
Build-time cargo test --all (via debian/rules override_dh_auto_test) uses default features only, so Build-Depends-Arch (which omits librust-gtk4-0.11+v4-18-dev) is sufficient for the build; +v4-18 and v0_6x..v0_8x are needed only by the autopkgtests, which get them through the binary package's Depends.
.dsc/tarballs: 3.0 (quilt), orig extracts to a single vte4-0.10.0/ dir, debian tarball holds only debian/; checksums in the .dsc match the files beside the tree.
debian/copyright.debcargo.hint is the debcargo-generated artifact (still carrying its FIXME (overlay) comment); the actual debian/copyright is the reviewed, filled-in copy.
uscan found the packaged version as the newest upstream release (upstream 0.10.0, packaged 0.10.0).

Not confirmed ◂

autopkgtest architecture asymmetry: the all-features test (test-name=rust-vte4:@) and the default test have no Architecture: restriction, while the gtk_v4_18 and v0_66..v0_84 feature tests are all Architecture: !riscv64. If those features fail on riscv64 for the reason the individual tests were restricted, the unrestricted --all-features test (which enables gtk/v4_18 and v0_84) would fail there too. An autopkgtest run on riscv64 would show whether this is an oversight.
the copyright years 2021-2026 in the Files: * stanza: the tarball carries no year (the LICENSE text has no copyright line, Cargo.toml has none) and the debcargo hint left them UNKNOWN-YEARS, so the stated range cannot be confirmed from the package alone.
Why the model asked for what a review has no use for. During this review it asked once for something outside the package and the reviewing system (another file of the sandbox, or a URL), or was given part of the review tooling's own configuration, and that was refused or withheld. A model does this when something it has read tells it to, so look in the package for text addressed to a reviewing program, and treat this report with suspicion. Refused: glob: " /usr/bin/debcargo" is not a file of the package or of the reviewing system.

Proposed changes ◂

None.

Review Information

accepted — allocated to awm 23 days ago, started 23 days ago, completed 23 days ago.

Final Comment

Hi,

For debian/patches/gtk4_10.patch the patch header is not DEP-3 conformant: Subject: is a git-format-patch field, not one of the DEP-3 fields; DEP-3 requires a Description field (and conventionally Author/Last-Update).

Thanks!

Back to Dashboard | View all reviews for this package