Review: scala-parser-combinators 2.4.0-1
Package Information
| Description | Scala standard parser combinator library for Scala 3 scala-parser-combinators builds parsers in plain Scala by combining small parsers with operators, with support for packrat parsing, lexical analysis and regular expressions. It was part of the Scala standard library. This package provides org.scala-lang.modules:scala-parser-combinators_3, built for Scala 3. |
|---|---|
| Maintainer | Debian Java Maintainers <pkg-java-maintainers@lists.alioth.debian.org> |
| Changed By | Juan Manuel Méndez Rey <juan.mendezr@proton.me> |
| Sponsor | tsimonq2@debian.org |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/java-team/scala-parser-combinators.git (browse) |
| Closes | #845795 |
| Popcon Installs | 354 |
| Binary NEW | Yes (new binary packages of a source already in sid) |
| Tracker | https://tracker.debian.org/pkg/scala-parser-combinators |
| Uploaded | 2 hours ago |
New Package Report
.changes
| Date | Wed, 28 Oct 2026 00:10:46 +0100 |
|---|---|
| Source | scala-parser-combinators |
| Version | 2.4.0-1 |
| Changed-By | Juan Manuel Méndez Rey <juan.mendezr@proton.me> |
| Architecture | source all |
| Distribution | unstable |
Changelog
scala-parser-combinators (2.4.0-1) unstable; urgency=medium
.
* New upstream release, built for Scala 3 with scala-debian-helper.
* Replace the Scala 2.11 package scala-parser-combinators with
libscala-parser-combinators-scala3-java.
* Upstream is now Apache-2.0: update debian/copyright.
* Standards-Version 4.7.4, debhelper-compat 14, watch file version 5.
* Add myself to Uploaders.
* Build-depend on dh-sequence-single-binary.
* Build-depend on dh-sequence-scala only.
* latexdraw now uses scala-parser-combinators-2.12, and this package
no longer ships the 2.11 jar (Closes: #845795)..dsc
| Section | java |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | libscala-parser-combinators-scala3-java deb java optional arch=all |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: scala-parser-combinators
Upstream-Contact: https://github.com/scala/scala-parser-combinators/issues
Source: https://github.com/scala/scala-parser-combinators
Files: *
Copyright: 2002-2024 EPFL
2011-2024 Lightbend, Inc.
EPFL and Lightbend, Inc.
License: Apache-2.0
Files: shared/src/test/scala/scala/util/parsing/combinator/PackratParsersTest.scala
Copyright: EPFL and Lightbend, Inc.
License: Apache-2.0
Comment:
grammars4 is a 10-line rewrite of the untyped lambda calculus parser of
tapl-scala (https://github.com/ilya-klyuchnikov/tapl-scala); no line is
shared with it. Test only.
Files: debian/*
Copyright: 2015 Emmanuel Bourg <ebourg@apache.org>
2026 Juan Manuel Méndez Rey <juan.mendezr@proton.me>
License: BSD-3-clause
License: Apache-2.0
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
.
http://www.apache.org/licenses/LICENSE-2.0
.
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
.
On Debian systems, the complete text of the license can be found in
"/usr/share/common-licenses/Apache-2.0".
License: BSD-3-clause
Permission to use, copy, modify, and distribute this software in source
or binary form for any purpose with or without fee is hereby granted,
provided that the following conditions are met:
.
1. Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
.
2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
.
3. Neither the name of the EPFL nor the names of its contributors
may be used to endorse or promote products derived from this
software without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
SUCH DAMAGE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 0 hours ago.
Report
DFSG NEW review for scala-parser-combinators version 2.4.0-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 0 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
Upstream is Apache-2.0: LICENSE is the full Apache License 2.0, NOTICE names EPFL (2002-2024) and Lightbend, Inc. (2011-2024), and every .scala file that carries a header carries the same notice. debian/copyright is DEP-5, its Files: * stanza names both holders and Apache-2.0, the PackratParsersTest override keeps the same holders and licence, and debian/* is BSD-3-clause with its full text (BSD-3-clause is not in /usr/share/common-licenses). No non-free terms, no unlicensed third-party code, no binary or generated files in the tree, and the prescan found no holder missing from debian/copyright.
Packaging
The packaging is a small, idiomatic dh_scala package: compat 14, a single Architecture: all binary built through dh-sequence-scala/dh-sequence-single-binary, minimal rules, Standards-Version 4.7.4 against Policy 4.7.4.1, correct Vcs-* fields, a DEP-5 copyright, a clean debian/scala-build matching the upstream source layout, and an autopkgtest using the helper's smoke test. No patches, no maintainer scripts, nothing stale in debian/. The old Scala 2.11 binary package is deliberately replaced (latexdraw now depends on scala-parser-combinators-2.12).
Issues
None.
Verified ◂
- Prescan /review-input/prescan.md: the author check scanned 64 files, found five declared authors and reported that every holder found is named in debian/copyright; it listed no files to account for.
- LICENSE is the full Apache License, Version 2.0; NOTICE says
Copyright (c) 2002-2024 EPFLandCopyright (c) 2011-2024 Lightbend, Inc.; build.sbt declareslicenses += (("Apache-2.0", ...)). - 52 of the 53 .scala files carry the header
Copyright EPFL and Lightbend, Inc./Licensed under Apache License 2.0; debian/copyright Files: * (EPFL 2002-2024, Lightbend 2011-2024, Apache-2.0) matches them. - shared/src/test/scala/scala/util/parsing/combinator/LongestMatchTest.scala carries no per-file header; it is upstream test-only source under the project's top-level Apache-2.0 LICENSE/NOTICE and is covered by Files: *; it is not compiled into the shipped jar (debian/scala-build lists main sources only).
- shared/src/test/.../PackratParsersTest.scala: the grammars4 block says
Adapted from https://github.com/ilya-klyuchnikov/tapl-scala/...and debian/copyright gives that file its own stanza with a Comment recording the origin and asserting no line is shared; the stanza keeps the Apache-2.0 licence and the EPFL/Lightbend holders. - debian/* is declared BSD-3-clause with the complete licence text; the text is the Scala/EPFL BSD-3 variant, which is DFSG-free, and debian/copyright itself is covered by that stanza.
- The Apache-2.0 text is referred to as /usr/share/common-licenses/Apache-2.0, which exists on the reviewing system; Apache-2.0 announcement and NOTICE obligations are met (NOTICE is installed by debian/libscala-parser-combinators-scala3-java.docs).
- No other licence markers anywhere in the tree: a case-insensitive search for MIT/BSD/GPL/LGPL/MPL/EPL/Creative Commons/public domain/SPDX found only the two BSD-3-clause stanzas of debian/copyright.
- No built artefacts, minified code, PDFs, images, fonts or vendored libraries in the tree; every file is .scala, .md, .sbt, .conf/.xml/.yml, or a small plain-text metadata file (.mailmap, .gitignore, project/build.properties, debian/source/format).
- debian/control: debhelper-compat (= 14) with a three-line rules using
dh $@ --buildsystem=scala; dh-sequence-scala (provided by scala-debian-helper 0.1) and dh-sequence-single-binary (provided by debhelper 14.5) exist in the archive; scala3 3.9.0 exists and supplies the compiler and default-jdk-headless. - Standards-Version 4.7.4 matches Policy 4.7.4.1 in its first two components, so it is current.
- debian/scala-build lists the JVM main sources (jvm/src/main/scala, shared/src/main/scala, shared/src/main/scala-2.13+), matching build.sbt's
-2.13+source-directory rule for Scala 3; the js/native PositionCache copies and the Scala 2.13- variant are correctly not built. - debian/tests/control runs /usr/share/scala-debian-helper/smoke-test with Restrictions: superficial; the .dsc carries Testsuite: autopkgtest and Testsuite-Triggers: scala-debian-helper generated from it.
- No debian/patches (3.0 (quilt) source with no patches), no maintainer scripts, no *.maintscript, no install/links/dirs files; the docs file installs only NOTICE.
- debian/copyright has no Files-Excluded and the tree contains nothing that looks repacked away; the .orig.tar.xz includes the complete upstream tree (.github, docs, project).
- debian/changelog: 2.4.0-1 to unstable, dated 2026-10-28, with the rename, licence change, Standards-Version/compat bump and bug closure #845795 described; earlier entries are consistent with the archive's 1.0.3-4.
- uscan found upstream releases with
debian/watch; a newer upstream version is available (upstream2.5.0, packaged2.4.0), which is not a fault of the package. - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (Apache-2.0).
Not confirmed ◂
- Whether any package in unstable still build-depends or depends on the binary package
scala-parser-combinatorsthat this upload stops building (the tools can check a package's own fields but cannot list reverse dependencies); latexdraw is confirmed to depend on scala-parser-combinators-2.12 instead, so at least that user has moved, and no transitional/Provides package is shipped for the old name. - debian/poms/scala-parser-combinators_3.pom.xml declares scala3-library_3 3.3.3 while the archive ships 3.9.0; whether dh_scala rewrites dependency versions at install time (the project's own version uses the @VERSION@ placeholder) could not be checked because scala-debian-helper is not installed here.
Proposed changes ◂
None.
Review Information
accepted — allocated to awm 0 hours ago, started 0 hours ago, completed 0 hours ago.