Review: scala-xml-2.12 2.3.0-1

Package Information

Description	XML library for Scala 2.12 (scala-xml_2.12) scala-xml is the standard XML library for Scala: an immutable data model for XML, an XML parser and serialization, plus support for XML literals in source code. It provides the scala.xml.* API (Node, Elem, Attribute, ...). This package provides org.scala-lang.modules:scala-xml_2.12 (version 2.3.0), cross-compiled for Scala 2.12. It is required to build scaladoc for the scala-2.12 compiler. Scala libraries are not binary-compatible across minor versions, so a per-series build (here _2.12) is needed. Built from source with no sbt, compiled directly with the Scala 2.12 compiler.
Maintainer	Debian Java Maintainers <pkg-java-maintainers@lists.alioth.debian.org>
Changed By	Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Sponsor	tsimonq2@debian.org
Distribution	unstable
Architecture	all
VCS	git: https://salsa.debian.org/java-team/scala-xml-2.12.git (browse)
Closes	#1139712
Tracker	https://tracker.debian.org/pkg/scala-xml-2.12
Uploaded	10 days ago

New Package Report

.changes◂

Version	2.3.0-1
Changed-By	Juan Manuel Méndez Rey <juan.mendezr@proton.me>
Architecture	source all
Distribution	unstable
Date	Thu, 11 Jun 2026 19:32:51 +0200
Source	scala-xml-2.12

Changelog◂

scala-xml-2.12 (2.3.0-1) unstable; urgency=medium
 .
   * Initial release. Pure-Scala org.scala-lang.modules:scala-xml_2.12
     (2.3.0), cross-compiled for Scala 2.12; needed for scaladoc in
     scala. Built from source with no sbt, with the Scala 2.12 compiler
     from the scala package. (Closes: #1139712)

.dsc◂

Priority	optional
Component	main
Package-List	scala-xml-2.12 deb java optional arch=all
Section	java

debian/copyright◂

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: scala-xml
Source: https://github.com/scala/scala-xml

Files: *
Copyright: 2002-2024 EPFL
           2011-2024 Lightbend, Inc.
           EPFL and Lightbend, Inc.
License: Apache-2.0

Files: shared/src/main/scala/scala/xml/Xhtml.scala
       shared/src/main/scala/scala/xml/parsing/XhtmlEntities.scala
       shared/src/main/scala/scala/xml/parsing/XhtmlParser.scala
Copyright: EPFL and Lightbend, Inc.
           2007 David Pollak, WorldWide Conferencing, LLC
License: Apache-2.0
Comment:
 These files carry the Scala Apache-2.0 header and, in the body, an older
 notice "(c) David Pollak 2007 WorldWide Conferencing, LLC" from the
 original contribution, which is listed here as an additional holder.

Files: shared/src/main/scala/scala/xml/include/*
Copyright: 2001-2003 Elliotte Rusty Harold
           EPFL and Lightbend, Inc.
License: LGPL-2.1 and Apache-2.0
Comment:
 Scala translation of Elliotte Rusty Harold's XIncluder 1.0d11 (LGPL-2.1),
 with some comments kept verbatim. The files carry only the Scala header.

Files: debian/*
Copyright: 2026 Juan Manuel Mendez Rey <juan.mendezr@proton.me>
License: Apache-2.0

License: Apache-2.0
 Licensed under the Apache License, Version 2.0 (the "License"); you may not
 use this file except in compliance with the License. You may obtain a copy of
 the License at
 .
     https://www.apache.org/licenses/LICENSE-2.0
 .
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
 WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 License for the specific language governing permissions and limitations under
 the License.
 .
 On Debian systems, the full text of the Apache License version 2.0 can be
 found in the file /usr/share/common-licenses/Apache-2.0.

License: LGPL-2.1
 XIncluder is free software; you can redistribute it and/or modify
 it under the terms of the GNU Lesser General Public License version 2.1
 as published by the Free Software Foundation.
 .
 XIncluder is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 GNU Lesser General Public License for more details.
 .
 THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESSED OR IMPLIED
 WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
 OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
 DISCLAIMED.  IN NO EVENT SHALL ELLIOTTE RUSTY HAROLD OR ANY
 OTHER CONTRIBUTORS TO THIS PACKAGE
 BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
 USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
 ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
 OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
 OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
 SUCH DAMAGE.
 .
 On Debian systems, the full text of the GNU Lesser General Public License
 version 2.1 can be found in the file /usr/share/common-licenses/LGPL-2.1.

DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 10 days ago.

Report◂

DFSG NEW review for scala-xml-2.12 version 2.3.0-1

Summary

Licensing is DFSG-compliant and debian/copyright is accurate: Yes
Packaging is of good quality: Yes
Issues: 0 blocker, 0 important, 0 minor
debian/watch: version 5
debian/copyright: machine-readable
Scan before the review: nothing found

Licensing

The source is Apache-2.0 throughout, with a correct extra holder for the three Xhtml files (David Pollak, WorldWide Conferencing, LLC) and an LGPL-2.1-and-Apache-2.0 stanza for the XIncluder-derived files under shared/src/main/scala/scala/xml/include/. LICENSE holds the full Apache-2.0 text and NOTICE the EPFL/Lightbend copyright, and NOTICE is installed as a doc. debian/copyright is DEP-5 with correct short names (Apache-2.0, LGPL-2.1), a pointer to /usr/share/common-licenses for each, and stanzas ordered so the specific files override Files: *. The prescan's holder check found no holder missing from debian/copyright, and a grep of the whole tree found no other (C)/copyright, SPDX or licence wording.

Packaging

Clean, minimal packaging: 3.0 (quilt) with no patches, debhelper-compat 14 (valid and recommended), Standards-Version 4.7.4 against Policy 4.7.4.1, one Architecture: all package, no maintainer scripts, no lintian-worthy layout. The jar is compiled directly with the Scala 2.12 compiler from exactly the source set upstream uses for 2.12 (scala, scala-2, scala-2.12) and installed through maven-repo-helper with a matching POM and the upstream Automatic-Module-Name; ${java:Depends} and ${misc:Depends} are supplied by javahelper and dh at compat 14. Build and runtime dependencies exist in unstable (scala 2.12.21, scala-library 2.12.21, scala-asm 9.9.0). The only observation is that upstream's test suite is neither built nor run (empty override_dh_auto_test and no debian/tests), which is not a Policy violation.

Issues

None.

Verified ◂

Prescan: the author check found every copyright holder in the tree named in debian/copyright (EPFL, Lightbend, David Pollak/WorldWide Conferencing, Elliotte Rusty Harold, and the packaging holder); no file or notice was flagged as unaccounted for.
LICENSE is the complete Apache License 2.0 text; NOTICE names 2002-2024 EPFL and 2011-2024 Lightbend, Inc., matching the Files: * stanza, and is installed via debian/scala-xml-2.12.docs.
Every Scala source under shared/src/main carries the project's Apache-2.0 header generated by build.sbt headerLicense; shared/src/main/scala/scala/xml/Xhtml.scala:20, parsing/XhtmlEntities.scala:20 and parsing/XhtmlParser.scala:23 additionally carry the '(c) David Pollak 2007 WorldWide Conferencing, LLC' notice, which has its own stanza.
shared/src/main/scala/scala/xml/include/sax/XIncluder.scala:25 ('Based on Eliotte Rusty Harold's SAXXIncluder') and XIncludeFilter.scala:67 ('translated from Elliotte Rusty Harold's Java source') are the XIncluder translation; the Files: include/* stanza declares them LGPL-2.1 and Apache-2.0, quotes the XIncluder LGPL notice and points at /usr/share/common-licenses/LGPL-2.1, so no licence text is missing.
No non-free wording anywhere: grep for non-commercial/no-modification/field-of-use/CC-NC/ND and for BSD, MIT-style 'permission is hereby', GPL, Mozilla or Eclipse text found hits only inside debian/copyright and debian/lrc.config.
No built or binary artefacts in the tree: no .jar, .class, minified JS, PDF or generated code; the only content compiled is the shipped Scala sources. .pc/ was left out as instructed.
jvm/src/test/resources/scala/xml/site.xml, archive/books.xml and archive/books/book/author.xml are XInclude test fixtures (site includes archive/books.xml, which includes books/book/author.xml), and utf8.xml/includee.xml/includer.xml are encoding/parsing fixtures; none carries a third-party notice.
jvm/src/test/scala/scala/xml/JavaByteSerialization.scala has no per-file header but only wraps commons-lang3 for tests; it is covered by Files: * and carries no third-party notice.
The orig tarball's top level equals the unpacked tree (same files, root scala-xml-2.12-2.3.0 matching source name and upstream version), so no Files-Excluded entry is needed.
debian/ holds only changelog, control, copyright, lrc.config, poms/, README.source, rules, .docs, .lintian-overrides, .poms, source/format, upstream/metadata and watch: no patches, no maintainer scripts, no tests/control.
Build dependencies resolve in unstable: scala 2.12.21+ds3, scala-library 2.12.21+ds3 and scala-asm 9.9.0-scala-1-1; 'scala (>= 2.12~)' and 'scala-asm (>= 9.9.0)' are satisfied, and the same scala source ships the scala-library that the binary Depends on.
debian/rules' source set matches upstream's build.sbt: for 2.12 it adds only the '-2' and '-2.12' directories to the base, exactly the three directories the override compiles; jvm/ has test sources only, so nothing is left uncompiled.
The bad-jar-name lintian override is justified and consistent with the existing in-archive scala-xml package's scala-xml_2.11-*.jar naming required by the org.scala-lang.modules:scala-xml_2.12 maven coordinates.
debian/compat is absent and debhelper-compat (= 14) used instead; compat 14 is a valid, recommended level per debhelper's own list, and at that level dh_gencontrol adds the relationship substvars, so listing ${java:Depends}/${misc:Depends} is correct.
uscan found the packaged version as the newest upstream release (upstream 2.3.0, packaged 2.3.0).
Every pointer of debian/copyright to /usr/share/common-licenses names a file that is there (Apache-2.0, LGPL-2.1).

Not confirmed ◂

javahelper's generation of ${java:Depends} and maven-repo-helper's --java-lib/--usj-name handling could not be checked directly: neither package is installed on the reviewing system, so neither dh_javahelper nor dh_mavenrepo has a manual page or source there.
The build assumes /usr/share/java/scala-compiler-2.12.jar, scala-library-2.12.jar and scala-reflect-2.12.jar exist (the scala package's versioned commands suggest series-named jars); the archive tool shows control fields only, so the file list of the scala binary could not be inspected.
jvm/src/test/resources/scala/xml/utf16.xml is a UTF-16 encoded file and was not opened (binary content).

Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader was emailed about the review 10 days ago.

Review Information

accepted — allocated to mechtilde 9 days ago, started 9 days ago, completed 9 days ago.

Final Comment

Other Reviews of this Package

Version	Hash	Allocated	Completed	Reviewer	Status	Details
2.3.0-1	d81e1b95…	2026-10-28 10:05	2026-10-28 10:05	dfsg-uploader	rejected	VIEW

Back to Dashboard | View all reviews for this package