Review: secsipidx 2.0.0-1
Package Information
| Description | Secure SIP Identity Extensions - IETF STIR and SHAKEN Secure SIP/Telephony Identity Extensions Overview Applications and libraries implementing STIR and SHAKEN (RFC8224, RFC8588), used in SIP/VoIP services: • RFC8224 - https://tools.ietf.org/html/rfc8224 • RFC8588 - https://tools.ietf.org/html/rfc8588 This package contains CLI tool and HTTP API server for checking or Building SIP identitysecsipidx |
|---|---|
| Maintainer | Debian Go Packaging Team <team+pkg-go@tracker.debian.org> |
| Changed By | Victor Seva <vseva@debian.org> |
| Sponsor | vseva@debian.org |
| Distribution | experimental |
| Architecture | any |
| VCS | git: https://salsa.debian.org/go-team/packages/secsipidx.git (browse) |
| Popcon Installs | 9 |
| Binary NEW | Yes (new binary packages of a source already in sid) |
| Tracker | https://tracker.debian.org/pkg/secsipidx |
| Uploaded | 13 hours ago |
New Package Report
.changes
| Distribution | experimental |
|---|---|
| Date | Wed, 04 Nov 2026 23:08:55 +0100 |
| Source | secsipidx |
| Version | 2.0.0-1 |
| Changed-By | Victor Seva <vseva@debian.org> |
| Architecture | source amd64 |
Changelog
secsipidx (2.0.0-1) experimental; urgency=medium . * New upstream version 2.0.0 * remove already applied patches upstream * golang-github-redis-go-redis-dev as Build-Depends * d/copyright: update years * bump API from 1 to 2 * remove t64 transition * d/copyright: fix BSD-3-Clause vs BSD-3-Cause-Clear * support LIBDIR config, patches forwarded to upstream
.dsc
| Section | libdevel |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | libsecsipid-dev deb libdevel optional arch=any libsecsipid2 deb libs optional arch=any secsipidx deb comm optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: secsipidx
Upstream-Contact: daniel@asipto.com
Source: https://github.com/asipto/secsipidx
Files: *
Copyright: 2019-2026 asipto.com
License: BSD-3-Clause-Clear
Files: secsipid/system_cas.go
Copyright: 2009 The Go Authors. All rights reserved.
License: BSD-3-Clause
Files: secsipidx.1
Copyright: 2020-2026 Victor Seva <vseva@debian.org>
License: BSD-3-Clause-Clear
Files: debian/*
Copyright: 2020-2026 Victor Seva <vseva@debian.org>
License: BSD-3-Clause-Clear
Comment: Debian packaging is licensed under the same terms as upstream
License: BSD-3-Clause-Clear
Redistribution and use in source and binary forms, with or without
modification, are permitted (subject to the limitations in the disclaimer
below) provided that the following conditions are met:
.
* Redistributions of source code must retain the above copyright notice,
this list of conditions and the following disclaimer.
.
* Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
.
* Neither the name of the copyright holder nor the names of its
contributors may be used to endorse or promote products derived from this
software without specific prior written permission.
.
NO EXPRESS OR IMPLIED LICENSES TO ANY PARTY'S PATENT RIGHTS ARE GRANTED BY
THIS LICENSE. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER
IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
POSSIBILITY OF SUCH DAMAGE.
License: BSD-3-Clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
.
1. Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
.
2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
.
3. Neither the name of the copyright holder nor the names of its
contributors may be used to endorse or promote products derived
from this software without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 2 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 11 hours ago.
Report
DFSG NEW review for secsipidx version 2.0.0-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 2 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
debian/copyright is DEP-5 with the canonical Format URL and covers the whole tree: Files: * (asipto.com, BSD-3-Clause-Clear), a stanza for secsipid/system_cas.go (The Go Authors, BSD-3-Clause, matching its "Copied and pasted from go standard library" header), and stanzas for secsipidx.1 and debian/* (Victor Seva). The Clear BSD text, which is not in /usr/share/common-licenses, is reproduced in full, as is BSD-3-Clause. All upper-case files are under the BSD-style LICENSE, no file carries foreign or non-free terms, there is no vendored third-party code, and the only generated file (csecsipid/libsecsipid.h, cgo output) has its generator input shipped. Nothing was found that is non-free or misdescribed.
Packaging
Well-maintained dh/dh-golang packaging: compat 13, --buildsystem=golang --with=golang, the C library built through the patched upstream Makefile and installed into the right multiarch paths, soname libsecsipid.so.2 matched to package libsecsipid2, a complete symbols file, Multi-Arch: same/foreign set where it matters, autopkgtests through autopkgtest-pkg-go, DEP-3 patches forwarded upstream, and Standards-Version 4.7.4 (current). Only two minor points: the binaries use the deprecated Built-Using substvar instead of Static-Built-Using, and one long description is garbled.
Issues
minor
packaging
1. All three binaries use ${misc:Built-Using} where ${misc:Static-Built-Using} is the field for statically built Go code
◂
- Files:
debian/control:30-31,debian/control:50-51,debian/control:67-68 - Basis: checked, in the package or with a reference tool
- Evidence:
Built-Using:/${misc:Built-Using},in all three Package stanzas. dh_golang(1p): "it was clarified Debian Policy in 2017 that the Built-Using field was intended only for license-required dependencies, hence the switch to the new Static-Built-Using field in 2022" and "will continue to generate the misc:Built-Using substvar until all Go packages have transitioned". Policy 7.8: "This field should be used only when there are license or DFSG requirements to retain the referenced source packages." deb-control(5): Static-Built-Using "must" list source packages "used during the build of this binary package, for static building purposes"; supported since dpkg 1.21.3, below the package'sdpkg-dev (>= 1.22.5). - Problem: These packages statically embed Go code from BSD/MIT-licensed source packages (uuid, go-redis, xxhash, ...), which imposes no licence requirement to retain their sources. Putting them in Built-Using is a deviation from Policy 7.8 and makes the archive keep those source versions on account of this package for no licensing reason. dh_golang already generates both substvars, so the package keeps the wrong one even after the compatibility substvar is retired.
- Fix: Replace
Built-Using: ${misc:Built-Using}withStatic-Built-Using: ${misc:Static-Built-Using}in all three stanzas (the substvar must still be named explicitly at compat 13).
minor packaging 2. Long descriptions contain corrupted text: "Building SIP identitysecsipidx" and "headers ans static libs" ◂
- Files:
debian/control:42,debian/control:57 - Basis: checked, in the package or with a reference tool
- Evidence:
This package contains CLI tool and HTTP API server for checking or/Building SIP identitysecsipidxandThis package contains headers ans static libs - Problem: The trailing
secsipidxis stuck onto the previous word, andansis a typo; both strings are shown by apt and in package listings, so the package's user-visible description is malformed. - Fix: Write e.g. "This package contains the CLI tool and HTTP API server for checking or building SIP identities" and "This package contains headers and static libs".
Verified ◂
- debian/copyright read in full (DEP-5, canonical Format URL); its four Files stanzas, the two stand-alone licence texts (BSD-3-Clause-Clear and BSD-3-Clause) and the absence of Files-Excluded were checked against the tree; the .orig tarball contains the same files as the tree apart from the two applied patches, so nothing needed excluding.
- Complete inventory of the 22 upstream files (top-level Makefile, Makefile.defs, go.mod, go.sum, LICENSE, README.md, main.go, main_test.go, secsipidx.1, .gitignore; csecsipid/{Makefile,secsipid.pc.in,csecsipid.go,libsecsipid.h,secsipid.h}; secsipid/{.gitignore,cache.go,cache_redis.go,secsipid.go,secsipid_test.go,system_cas.go}; .github/FUNDING.yml and .github/workflows/{go.yml,release.yaml}); all are matched by
Files: *or by the latersecsipid/system_cas.go,secsipidx.1anddebian/*stanzas. - LICENSE is "The Clear BSD License", Copyright 2019-2020 asipto.com; README states "License:
BSD 3-Clause Clear License"; both agree with the BSD-3-Clause-Clear stanza (only the year range differs, which is not noteworthy). - secsipid/system_cas.go:3 says "Copied and pasted from go standard library: crypto/x509"; its own stanza names The Go Authors and BSD-3-Clause, so the copied code is attributed and licensed separately from
Files: *. - secsipidx.1 ends with "written by Victor Seva ... for the Debian project"; its stanza names Victor Seva and BSD-3-Clause-Clear.
- csecsipid/libsecsipid.h:1 is "Code generated by cmd/cgo; DO NOT EDIT."; its generator input, csecsipid/csecsipid.go with the //export comments, is shipped, so it is not a built file whose preferred form is missing.
- Grep of the whole tree for Copyright/(C)/©/SPDX/licence wording/All rights reserved found only LICENSE, README, secsipid/system_cas.go and the man page; grep for non-commercial, no-modification and field-of-use wording found nothing. No images, fonts, sounds, PDFs, minified code or vendored third-party libraries are in the tree.
- Prescan (dfsg-author-check) reported every holder found as named; the three holders declared in debian/copyright are exactly asipto.com (LICENSE, README), The Go Authors (system_cas.go) and Victor Seva (secsipidx.1, debian/*).
- Soname is libsecsipid.so.2 (Makefile.defs LIBVERMAJ=2 and the -soname flag in csecsipid/Makefile) and the binary package is libsecsipid2; the -dev package ships usr/include, the .a and the .so symlink and the .pc file, the library package ships .so.; the symbols file's soname line and package column are consistent and all 13 SecSIPID* functions exported by csecsipid/libsecsipid.h are listed.
- The symbols file's minimum versions still carry the retired predecessor package's values (1.0.0
git20210108.dd56bc8f3ad, 1.1.1git..., 1.3.1) rather than 2.0.0; per deb-symbols(5) these only set minimal dependency versions, and since libsecsipid2 first exists at 2.0.0 the computed dependencies remain satisfiable, so this is not reported as a fault. - debian/libsecsipid2.lintian-overrides no longer suppresses anything (package libsecsipid2 matches soname libsecsipid.so.2); it is dead but harmless, so not reported.
- Both patches are DEP-3 with From/Date/Subject/Forwarded (one PR); their combined effect is the pkgconfig file installed as /usr/lib//pkgconfig/secsipid-2.pc, which matches debian/libsecsipid-dev.install, and the LIBDIR variable passed by debian/rules.
- compat 13 with the dh sequencer;
execute_after_dh_auto_build/override_dh_auto_installcopy the Makefiles into the Go build dir and install into debian/tmp, which the .install files then pick up; dh_auto_install -- --no-source is dh_golang's documented programmatic-package option. - Testsuite: autopkgtest-pkg-go (no debian/tests needed); golang-github-gomagedon-expectate-dev is marked <!nocheck>, which matches dh skipping dh_auto_test under nocheck at compat >= 13.
- Build-Depends: the Go modules actually linked (uuid, go-redis and its own dependencies cespare/xxhash, uber atomic, x/sys) are present, redis-dev's Depends pulling the indirect ones (checked with apt-cache), and dh-golang's default GO111MODULE=off makes go.mod/go.sum irrelevant to the build.
- Standards-Version 4.7.4 has the first two components of Policy 4.7.4.1, so it is current; Section/Architecture/Multi-Arch/Pre-Depends/Recommends and the Vcs-*/Homepage fields are all in order, and no maintainer scripts exist that could be non-idempotent.
- uscan found the packaged version as the newest upstream release (upstream
2.0.0, packaged2.0.0).
Not confirmed ◂
- No build or test was run here. The Makefile-driven
go build -buildmode=c-shared/c-archivein csecsipid/Makefile does not pass -trimpath (unlike dh's golang build step), so whether the shared library builds reproducibly was not checked. - go.sum carries entries for modules not in go.mod (bsm/ginkgo, gomega, testify, zeebo/xxh3, klauspost/cpuid, yaml); under dh-golang's GOPATH mode (GO111MODULE=off) they are unused, so whether a module-mode build would object was not checked.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader rejected this upload in response to the review.
Review Information
rejected — allocated to dfsg-uploader 10 hours ago, started 10 hours ago, completed 10 hours ago.
Final Comment
The uploader rejected this upload in response to the automated (LLM) review of it, so that they can fix the problems it found and upload again.
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 2.0.0-1 | 1f92b77a… | 2026-11-04 11:17 | 2026-11-04 11:17 | dfsg-transition | rejected | VIEW |
| 2.0.0-1 | 6b75049b… | 2026-11-04 14:49 | 2026-11-04 14:49 | dfsg-uploader | rejected | VIEW |
| 2.0.0-1 | cb3e5494… | 2026-11-04 22:05 | 2026-11-04 22:05 | dfsg-uploader | rejected | VIEW |