DFSG NEW Queue

DFSG, Licensing & New Packages Team

silo-llnl 4.12.2~pre2-1

Package Information

DescriptionDevelopment files for SILO Scientific I/O library from LLNL

Silo is a library for reading and writing a wide variety of scientific data to binary, disk files. The files Silo produces and the data within them can be easily shared and exchanged between wholly independently developed applications running on disparate computing platforms. Consequently, Silo facilitates the development of general purpose tools for processing scientific data. One of the more popular tools that process Silo data files is the VisIt visualization tool.

Silo supports gridless (point) meshes, structured meshes, unstructured- zoo and unstructured-arbitrary-polyhedral meshes, block structured AMR meshes, constructive solid geometry (CSG) meshes, piecewise-constant (e.g. zone-centered) and piecewise-linear (e.g. node-centered) variables defined on the node, edge, face or volume elements of meshes as well as the decomposition of meshes into arbitrary subset hierarchies including materials and mixing materials. In addition, Silo supports a wide variety of other useful objects to address various scientific computing application needs. Although the Silo library is a serial library, it has some key features which enable it to be applied quite effectively and scalable in parallel. Architecturally, the library is divided into two main pieces; an upper- level application programming interface (API) and a lower-level I/O implementation called a driver. Silo supports multiple I/O drivers, the two most common of which are the HDF5 (Hierarchical Data Format 5) and PDB (Portable Data Base) drivers.

MaintainerDebian Science Maintainers <debian-science-maintainers@lists.alioth.debian.org>
Changed ByAlastair McKinstry <mckinstry@debian.org>
Sponsormckinstry@debian.org
Distributionexperimental
Architectureany
VCSgit: https://salsa.debian.org/science-team/silo-llnl.git -b debian/latest (browse)
Popcon Installs363
Binary NEWYes (new binary packages of a source already in sid)
Trackerhttps://tracker.debian.org/pkg/silo-llnl
Uploaded1 hour ago

New Package Report

.changes◂
Changed-ByAlastair McKinstry <mckinstry@debian.org>
Architecturesource arm64
Distributionexperimental
DateMon, 16 Nov 2026 09:50:45 +0000
Sourcesilo-llnl
Version4.12.2~pre2-1
Changelog◂
silo-llnl (4.12.2~pre2-1) experimental; urgency=medium
 .
   * New upstream release
   * Fix pkg name to libsiloh5-4, drop minor version
.dsc◂
Package-Listlibsilo-bin deb science optional arch=any
libsilo-dev deb libdevel optional arch=any
libsiloh5-4 deb libs optional arch=any
python3-silo deb python optional arch=any
Sectionscience
Priorityoptional
Componentmain
debian/copyright◂
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://wci.llnl.gov/codes/silo
Upstream-Name: silo

Files: *
Copyright: (C) Copyright 1994-2010, Lawrence Livermore National Security, LLC.
License: BSD-3-Clause

Files: debian/*
Copyright: (C) Alastair McKinstry <mckinstry@debian.org>
License: BSD-3-Clause

License: BSD-3-Clause
 Redistribution and use in source and binary forms, with or without
 modification, are permitted provided that the following conditions
 are met:
 .
   * Redistributions of source code must retain the above copyright
     notice, this list of conditions and the disclaimer below.
   * Redistributions in binary form must reproduce the above copyright
     notice, this list of conditions and the disclaimer (as noted
     below) in the documentation and/or other materials provided with
     the distribution.
   * Neither the name of the LLNS/LLNL nor the names of its
     contributors may be used to endorse or promote products derived
     from this software without specific prior written permission.
 .
 THIS SOFTWARE  IS PROVIDED BY  THE COPYRIGHT HOLDERS  AND CONTRIBUTORS
 "AS  IS" AND  ANY EXPRESS  OR IMPLIED  WARRANTIES, INCLUDING,  BUT NOT
 LIMITED TO, THE IMPLIED  WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 A  PARTICULAR  PURPOSE ARE  DISCLAIMED.  IN  NO  EVENT SHALL  LAWRENCE
 LIVERMORE  NATIONAL SECURITY, LLC,  THE U.S.  DEPARTMENT OF  ENERGY OR
 CONTRIBUTORS BE LIABLE FOR  ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
 EXEMPLARY, OR  CONSEQUENTIAL DAMAGES  (INCLUDING, BUT NOT  LIMITED TO,
 PROCUREMENT OF  SUBSTITUTE GOODS  OR SERVICES; LOSS  OF USE,  DATA, OR
 PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
 LIABILITY, WHETHER  IN CONTRACT, STRICT LIABILITY,  OR TORT (INCLUDING
 NEGLIGENCE OR  OTHERWISE) ARISING IN  ANY WAY OUT  OF THE USE  OF THIS
 SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 .
 This work was produced at Lawrence Livermore National Laboratory under
 Contract  No.   DE-AC52-07NA27344 with  the  DOE.  Neither the  United
 States Government  nor Lawrence  Livermore National Security,  LLC nor
 any of  their employees,  makes any warranty,  express or  implied, or
 assumes   any   liability   or   responsibility  for   the   accuracy,
 completeness, or usefulness of any information, apparatus, product, or
 process  disclosed, or  represents  that its  use  would not  infringe
 privately-owned   rights.  Any  reference   herein  to   any  specific
 commercial products,  process, or  services by trade  name, trademark,
 manufacturer or otherwise does not necessarily constitute or imply its
 endorsement,  recommendation,   or  favoring  by   the  United  States
 Government or Lawrence Livermore National Security, LLC. The views and
 opinions  of authors  expressed  herein do  not  necessarily state  or
 reflect those  of the United  States Government or  Lawrence Livermore
 National  Security, LLC,  and shall  not  be used  for advertising  or
 product endorsement purposes.

DFSG Assistant LLM REVIEW 1 blocker, 1 important, 5 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 0 hours ago.

Report◂

DFSG NEW review for silo-llnl version 4.12.2~pre2-1

Summary

  • Licensing is DFSG-compliant and debian/copyright is accurate: No
  • Packaging is of good quality: No
  • Issues: 1 blocker, 1 important, 5 minor
  • debian/watch: version 5
  • debian/copyright: machine-readable
  • Scan before the review: 27 found

Licensing

No. The upstream tarball shipped as the source package contains src/fpzip and src/hzip, whose notices allow use and distribution only 'for noncommercial purposes' and require notifying DOE before commercialisation; upstream's own BSD_LICENSE_README says the BSD-licensed release does not contain these libraries, yet debian/copyright's 'Files: *' declares every file BSD-3-Clause. The binary packages are not affected (the CMake options that compile these directories are forced off in the BSD build, which is what debian/rules uses), but Debian distributes the source package, so this is a DFSG violation and needs a repack. Beyond that the tree is uniformly BSD-3-Clause from LLNS, the copyright file has the full licence text, and the only other gap is the FSF copyright in the generic INSTALL file.

Packaging

The package builds from CMake with debhelper compat 14 and its dependencies and control fields are mostly sound, but the move from autotools to CMake is half-done. silex is requested in debian/rules although only Qt5 build-dependencies are declared and silex requires Qt6, so the previously shipped /usr/bin/silex is silently dropped; the pkgconfig and version-script patches produce files no build rule reads, so no silo.pc and no symbol versioning; several Build-Depends are unused; and libsilo-bin ships /usr/bin/s2ex, a Python script with no shebang and no usable dependencies. There is neither an autopkgtest nor a build-time run of the upstream CTest suite.

Issues

blocker licensing 1. src/fpzip and src/hzip are non-free (noncommercial use only) yet are shipped in the source package and described as BSD-3-Clause ◂
  • Files: src/fpzip/fpzip.h:40-81, src/hzip/hzip.h:27-65, src/hzip/LICENSING, BSD_LICENSE_README:1-10, debian/copyright:5-7
  • Basis: checked, in the package or with a reference tool
  • Evidence: ** fpzip was developed as part of the LOCAL LDRD project at LLNL, and may be freely used and distributed for noncommercial purposes. and ** Commercialization of this product is prohibited without notifying the Department of Energy (DOE) (identical text in hzip.h and src/hzip/LICENSING); BSD_LICENSE_README: The BSD Open Source release distributions do not contain the Hzip and FPzip compression libraries while the legacy release distributions do. docs/intro.md:139 says plainly fpzip is off by default because fpzip is not BSD licensed. Meanwhile debian/copyright:5-7 is Files: * / Copyright: (C) Copyright 1994-2010, Lawrence Livermore National Security, LLC. / License: BSD-3-Clause.
  • Problem: Files: * matches these paths (copyright-format 6.9), so debian/copyright asserts a licence these files do not have, and the source package Debian distributes contains a field-of-use restriction (DFSG 1 and 2, Policy 2.2.1: free software may not be restricted to noncommercial use). The binary packages themselves are clean: CMakeLists.txt:152-159 makes SILO_ENABLE_FPZIP/SILO_ENABLE_HZIP dependent options that are forced off while SILO_BUILD_FOR_BSD_LICENSE stays at its ON default, which debian/rules never changes, and neither fpzip.h nor hzip.h is in silo_public_headers, so nothing from these directories is installed or linked.
  • Fix: Repack the upstream tarball without src/hzip and src/fpzip (add a Files-Excluded field naming them and note the repack in the copyright header), and remove the now-meaningless -DSILO_ENABLE_FPZIP lines from debian/rules. If FPZIP support is wanted, link the free libfpzip 1.3.0 that Debian already ships instead of the bundled 1.0.2.
important packaging 2. silex is requested but needs Qt6 while only Qt5 build-dependencies are declared, so silex is silently not built ◂
  • Files: debian/rules:37, debian/control:22-23, CMakeLists.txt:129, tools/silex/CMakeLists.txt:57-62
  • Basis: checked, in the package or with a reference tool
  • Evidence: debian/rules:37 passes -DSILO_ENABLE_SILEX=On, while Build-Depends has only qtbase5-dev, and qtchooser,. CMakeLists.txt:129: option(SILO_ENABLE_SILEX "Enable building of silex (requires Qt6)" OFF); tools/silex/CMakeLists.txt: find_package(Qt6 COMPONENTS Core Gui Widgets CONFIG) then message(WARNING "Silex depends on Qt6, but it could not be found. Silex will not be built") and return().
  • Problem: qtbase5-dev provides Qt5, not Qt6 (Debian's Qt6 development package is qt6-base-dev), so the build succeeds with a warning and produces no silex. libsilo-bin.install ships usr/bin/*, so /usr/bin/silex, which the autotools build produced (changelog 4.10.2-4, 'Build silex.'), disappears without note, and the Qt5 build-dependencies are dead weight.
  • Fix: Either replace qtbase5-dev/qtchooser with qt6-base-dev (plus qt6-base-dev-tools if moc is not pulled in) so silex is really built, or drop -DSILO_ENABLE_SILEX=On and the Qt5 Build-Depends, saying in debian/changelog that silex is no longer shipped.
minor licensing 3. debian/copyright does not name the Free Software Foundation, holder of the copyright in INSTALL ◂
  • Files: INSTALL:4, debian/copyright:5-7
  • Basis: checked, in the package or with a reference tool
  • Evidence: INSTALL:4 Copyright (C) 1994, 1995, 1996, 1999, 2000, 2001, 2002, 2004, 2005 Free / Software Foundation, Inc. followed by This file is free documentation; the Free Software Foundation gives unlimited permission to copy, distribute and modify it.
  • Problem: Policy 2.3 does not require this notice to be copied: INSTALL is generic FSF build documentation that is neither installed by any binary package nor used by the CMake build, and it carries its own plain-text permission notice. The DFSG team nevertheless asks for a complete copyright file, and 'Files: *' currently attributes this file to LLNS under BSD-3-Clause, which is wrong: the FSF's unlimited-permission notice applies, not the LLNL licence.
  • Fix: Add a Files: INSTALL stanza giving Copyright: 1994-1996, 1999-2002, 2004-2005 Free Software Foundation, Inc. and the FSF text ("This file is free documentation; the Free Software Foundation gives unlimited permission to copy, distribute and modify it."), not BSD-3-Clause. A stand-alone License: FSF-unlimited paragraph is cleanest.
minor packaging 4. pkgconfig.patch and version-script.patch create silo.pc.in and silo.ver that no build rule uses: no silo.pc is shipped and the version script is not applied ◂
  • Files: debian/patches/series:5,8, debian/patches/pkgconfig.patch, debian/patches/version-script.patch, debian/libsilo-dev.install:4
  • Basis: checked, in the package or with a reference tool
  • Evidence: The patches add only +++ b/silo.pc.in and +++ b/silo.ver. Neither name appears anywhere outside debian/patches (the CMake files never mention them), the drop-in -Wl,--version-script is nowhere in debian/rules, and debian/libsilo-dev.install:4 is # silo.pc usr/lib/${DEB_HOST_MULTIARCH}/pkgconfig.
  • Problem: Both patches are applied but have no effect: libsiloh5 is linked without the SILOH5_4_8 symbol versioning the version script was written to provide, and no pkg-config file is configured or installed, so consumers that used pkg-config silo before the CMake switchover get nothing. Dead patches that appear to do something are worse than absent ones.
  • Fix: Either wire them into the CMake build (add the version script to the silo target's link options and configure/install silo.pc) or drop both patches along with the commented line in libsilo-dev.install.
minor packaging 5. libsilo-bin ships /usr/bin/s2ex: not executable, no shebang, and importing modules the package does not depend on ◂
  • Files: debian/rules:67, tools/python/s2ex.py:1, debian/libsilo-bin.install:1, debian/control
  • Basis: checked, in the package or with a reference tool
  • Evidence: debian/rules:67 mv debian/tmp/usr/bin/s2ex.py debian/tmp/usr/bin/s2ex; tools/python/s2ex.py begins at line 1 with import exodus, Silo (no #! line); tools/python/CMakeLists.txt installs it with PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ GROUP_WRITE WORLD_READ, i.e. 0644. debian/libsilo-bin.install is usr/bin/* and libsilo-bin has no python3 dependency at all.
  • Problem: The package installs a command in /usr/bin that cannot be executed (no execute bit, no interpreter line) and would fail even if it were, since neither python3-silo nor the exodus module it imports is a dependency; python3-exodus is not in Debian. This is a broken interface shipped to users.
  • Fix: Do not install s2ex.py: drop the rename in debian/rules and add it to debian/not-installed, or ship it in python3-silo with #!/usr/bin/python3, the execute bit, and Depends on python3-silo (and on whatever provides exodus, if anything).
minor packaging 6. Build-Depends still list libfpzip-dev, chrpath and autoconf-archive, none of which the CMake build uses ◂
  • Files: debian/control:10-24, debian/rules
  • Basis: checked, in the package or with a reference tool
  • Evidence: Build-Depends include libfpzip-dev [ !i386 ... ],, chrpath, and autoconf-archive,. There is no find_package(FPZIP) anywhere in the tree (CMakeLists.txt:628-641 compiles ${Silo_SOURCE_DIR}/src/fpzip/*.cpp instead), and debian/rules contains neither chrpath nor autoreconf after the switch to dh $@ --buildsystem=cmake.
  • Problem: Unused build dependencies slow buildd installs and mislead readers about how the library is built; libfpzip-dev in particular suggests external fpzip is linked, which it is not. (autoconf-archive was needed by the old autoreconf.patch, now commented out of the series.)
  • Fix: Drop libfpzip-dev, chrpath and autoconf-archive from Build-Depends; keep libfpzip-dev only if the build is changed to link the system library.
minor packaging 7. No autopkgtest and the upstream CTest suite is neither built nor run ◂
  • Files: debian/rules, debian/tests/control (absent)
  • Basis: checked, in the package or with a reference tool
  • Evidence: CMakeLists.txt:134 option(BUILD_TESTING "Enable tests" OFF); debian/rules passes no -DBUILD_TESTING and has no override_dh_auto_test, and there is no debian/tests/ directory.
  • Problem: Upstream ships a large CTest suite under tests/ that would exercise the library, but nothing runs it at build time and nothing runs it in the archive's autopkgtests, so regressions in the library are only caught by user reports. Not a Policy violation, but a real gap for a library with an ABI promise.
  • Fix: Add a debian/tests/control (and the needed Depends) that builds and runs the test suite, or at least pass -DBUILD_TESTING=ON at build time; keep it small enough to run in an autopkgtest VM.
Verified ◂
  • Every other source file carries the same LLNS BSD-3-Clause notice (grep over src/, tools/, tests/, CMake/, config/): Copyright (C) 1994-2016 Lawrence Livermore National Security, LLC. with LLNL-CODE-425250; year ranges vary (1994-2016 in most files, 1994-2021 in CMake files, 1994-2026 in COPYRIGHT) but the holder is the same, so the year drift in debian/copyright is not an issue.
  • src/zfp-0.5.5 is a vendored copy of zfp 0.5.5 with its own BSD-3-Clause LICENSE from Lawrence Livermore National Security, LLC (LLNL-CODE-663824); it is covered by the Files: * stanza and its licence is compatible. It is compiled into libsiloh5 by default (name-mangled, per docs/intro.md:147-152). Debian ships zfp 1.0.1 (libzfp-dev 1.0.1-5+b2), a different API, so replacing the bundled copy is not a trivial change; no issue is raised.
  • COPYRIGHT (BSD-3-Clause, LLNL-CODE-425250), BSD_LICENSE_README and debian/copyright's stand-alone License: BSD-3-Clause paragraph agree; the paragraph also reproduces the DOE notice.
  • debian/copyright is DEP-5 with the correct Format URL, Files: * followed by an overriding Files: debian/* stanza, and no Files-Excluded field (so nothing upstream is currently excluded).
  • src/hzip and src/fpzip are upstream files: the only files the applied patches create are silo.pc.in and silo.ver, matching the scan's list.
  • The Debian binaries contain none of the non-free code: SILO_BUILD_FOR_BSD_LICENSE defaults to ON (CMakeLists.txt:133) and debian/rules does not turn it off, so the dependent options SILO_ENABLE_FPZIP and SILO_ENABLE_HZIP are unavailable and forced off (CMakeLists.txt:152-159); docs/intro.md:141-146 confirms 'To enable fpzip, you also have to disable a BSD only build'; and fpzip.h/hzip.h are not in silo_public_headers (CMakeLists.txt:681-699), so nothing of these directories is installed.
  • docs/globals.md:949 and docs/oldfm/Chapter2-man_pages2.txt:289: the 'non-commercial' wording is documentation about the third-party SZIP library, not a licence term of this package; Silo links HDF5/libaec, not the SZIP encoder.
  • docs/oldfm/Chapter1.fm, Chapter2-man_pages.fm, Chapter2-start.fm, Cover.fm, Silo.book.fm, Silo.bookLOP.fm, silo.h.fm, silo.h.in.fm: FrameMaker documents, i.e. the editable sources of docs/oldfm/Silo.book.pdf and of the man pages; they are source, not build output.
  • docs/oldfm/Silo.book.pdf is the output of the .fm files above; docs/silo_manaul_from_md.pdf is built from the Markdown sources in docs/ (alloc.md, conventions.md, files.md, globals.md, ... and docs/conf.py are all present).
  • docs/silo_node_orders.pptx: a presentation document, itself the editable form; no generated copy and no missing source. examples.gif, ghpages/images/output1.gif, output2.gif, output3.gif, silo_objects_roll.gif and silo_objects.png (0 bytes) are screenshots from upstream, covered by Files: *.
  • tests/all_objects_4102.pdb, all_objects_4111.pdb, all_objects_461.pdb, all_objects_472.pdb, all_objects_48.pdb, all_objects_491.pdb, not_a_silo_file.pdb, amr2d.silo, pion0244.silo, z1plt.silo: Silo data files used as test input, with the matching .h5 counterparts beside them; test data, not program code.
  • tests/xvers_data.tar.xz: an archive of test data for the cross-version tests; test data, not a missing source.
  • tools/silex/resources/silex.aps: MSVC resource-editor cache, used only by the WIN32 branch of tools/silex/CMakeLists.txt; irrelevant to the Debian build and not a binary blob of unclear provenance.
  • The top-level LICENSE file is 0 bytes; the licence text is present in COPYRIGHT and BSD_LICENSE_README and reproduced in full in debian/copyright, so nothing is missing from the package.
  • debian/bash_completion.d/libsilo-bin is never installed: debian/rules calls plain dh $@ --buildsystem=cmake, there is no Bash-Depends on dh-sequence-bash-completion and no --with bash-completion, so the file is inert (dead, but harmless).
  • Standards-Version 4.7.4 against Policy 4.7.4.1: first two components match, so it is current.
  • debhelper compat 14: dh_missing defaults to --fail-missing from compat 13, and all paths installed by the CMake build (bin, include, lib//libsiloh5.so, lib/*/cmake, lib/python3/dist-packages) are matched by the .install files; the stale debian/not-installed entry lib/*/libsiloh5.settings is an autotools leftover that matches nothing (unmatched patterns are ignored).
  • Patches applied by debian/patches/series (testsuite-fix.patch, pkgconfig.patch, version-script.patch, implicit-fn-decl.patch) all carry DEP-3 headers with Author, Description, Last-Updated and Forwarded.
  • Vcs-Git/Vcs-Browser point at salsa.debian.org/science-team/silo-llnl, Homepage is live, debian/source/format is 3.0 (quilt) and debian/gbp.conf uses DEP-14 branch names.
  • uscan found the packaged version as the newest upstream release (upstream 4.12.2~pre2, packaged 4.12.2~pre2).
Not confirmed ◂
  • debian/rules:42 passes -DCMAKE_CXX_FLAGSS=... (a typo for CMAKE_CXX_FLAGS, and with a stray - before $(HDF5_INC)). The variable is unused by CMake, so no hardening loss is visible: debhelper's cmake buildsystem puts CXXFLAGS/CPPFLAGS in the environment and CMake uses them at first configure. A build log with hardening-check would confirm C++ objects are still built hardened.
  • Whether the Qt6 route is otherwise complete (moc and the Qt6 Widgets modules are found by qt6-base-dev rather than some additional package) was not tested; the warning-and-return path in tools/silex/CMakeLists.txt makes a missing Qt6 harmless either way.
Proposed changes ◂

None.

Uploader's response to the LLM review

Waiting for the uploader's response until , because the review found serious issues.

Other Reviews of this Package

VersionHashAllocatedCompletedReviewerStatusDetails
4.12.1~pre2-1 63d243fb… 2026-06-23 18:30 2026-06-23 18:32 mechtilde accepted VIEW

Back to Dashboard | View all reviews for this package