Review: skalibs 2.16.0.0-1
New Package Report
.changes
| Architecture | source amd64 all |
|---|---|
| Distribution | unstable |
| Date | Mon, 19 Oct 2026 21:09:40 +0800 |
| Source | skalibs |
| Version | 2.16.0.0-1 |
| Changed-By | Shengjing Zhu <zhsj@debian.org> |
Changelog
skalibs (2.16.0.0-1) unstable; urgency=medium . * New upstream release v2.16.0.0 * Bump SO version to 2.16
.dsc
| Section | libs |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | libskarnet2.16 deb libs optional arch=any skalibs-dev deb libdevel optional arch=any skalibs-doc deb doc optional arch=all |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: skalibs
Source: https://skarnet.org/software/skalibs/
Files: *
Copyright: 2011-2018 Laurent Bercot <ska-skaware@skarnet.org>
License: ISC
Files: debian/*
Copyright: 2018, Shengjing Zhu <zhsj@debian.org>
License: ISC
Files: src/libposixplz/memmem.c
Copyright: 2005-2017 Rich Felker, Szabolcs Nagy, Timo Teräs, Alexander Monakov
License: Expat
Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:
.
The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
Files: doc/*
Copyright: 2011-2018 Laurent Bercot <ska-skaware@skarnet.org>
License: skalibs-doc-license
* The exact same disclaimer applies,
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
* You have the right to download, use and modify the documentation.
* You have the right to distribute unmodified copies of the documentation.
* You have the right to distribute modified copies of the documentation, provided that:
+ The contents and links (not necessarily the appearance) of this file, license.html,
are left unmodified;
+ On your documentation's main page, you explicitly state that the documentation has
been modified, and you set up a link to the original skalibs site, explicitly stating
that the original software and documentation can be found there;
+ The parts of the documentation that you have modified are unarguably and undeniably
distinguishable from the unmodified parts. You can, for instance, use a different text
color, different background color, or different text font.
License: ISC
Permission to use, copy, modify, and/or distribute this software for
any purpose with or without fee is hereby granted, provided that the
above copyright notice and this permission notice appear in all copies.
.
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 1 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 2 days ago.
Report
DFSG NEW review for skalibs version 2.16.0.0-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 1 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
All of the software is free: every source, header and tool file carries /* ISC license. */ and COPYING is the ISC text, and the one vendored file, src/libposixplz/memmem.c from musl, is Expat with its holders named in a dedicated stanza. The documentation's separate custom licence is a free attribution/marking licence, reproduced in debian/copyright. The only inaccuracy is small: the Linux Foundation's copyright in the DCO boilerplate file is not named, and the Files: * stanza calls that file ISC.
Packaging
The packaging is clean and conventional: dh at compat 14, hardening=+all, multiarch library and -dev packages with a symbols file carrying Build-Depends-Package, a doc package, an autopkgtest that compiles against the installed headers, no patches, and a current Standards-Version. The cross-build workarounds in rules (configure before clean, --build/--host, sysdep seeding) are documented in the changelog and correct.
Issues
minor
licensing
1. Files: * describes the DCO file as ISC and does not name the Linux Foundation
◂
- Files:
DCO:3-7,debian/copyright:5-8 - Basis: checked, in the package or with a reference tool
- Evidence: DCO:
Copyright (C) 2004, 2006 The Linux Foundation and its contributors./Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed.; debian/copyright:Files: */Copyright: 2011-2018 Laurent Bercot/License: ISC. - Problem: DCO is matched only by the catch-all stanza, so debian/copyright attributes it to Laurent Bercot under ISC, while the file is the Linux Foundation's Developer Certificate of Origin 1.1, carrying its own copyright and a verbatim-copies-only permission. This has no effect on the package's freeness (a licence document shipped unmodified is not part of the work being licensed), but the file is not described accurately, and its holder is missing.
- Fix: Add a stanza for it, for example
Files: DCOwithCopyright: 2004, 2006 The Linux Foundation and its contributorsand a shortLicense: dcoparagraph stating that verbatim copies are permitted and the text may not be changed, or aCommentsaying the same under the existing ISC short name.
Verified ◂
- Read every file of
debian/(control, rules, changelog, copyright, gbp.conf, source/format, the three install files, the doc-base file, the symbols header and tail, tests/control and both test files). - Read
debian/copyrightin full: DEP-5,Files: *(ISC),debian/*(ISC),src/libposixplz/memmem.c(Expat),doc/*(customskalibs-doc-license), plus stand-alone ISC and Expat texts; noFiles-Excluded. - Grepped the whole tree for
Copyright,(C),SPDX-License-Identifier,GNU *,Apache,Mozilla,public domain,All rights reserved,Licensed under,Permission is hereby grantedand similar; the only copyright notices are COPYING, DCO,doc/-internal prose,src/libposixplz/memmem.canddebian/. All C sources, headers,src/sysdeps/try*.c,src/headers/*-headerand thetools/helpers carry/* ISC license. */. src/libposixplz/memmem.cis the only vendored third-party code (musl's memmem, guarded by#ifndef SKALIBS_HASMEMMEM); its header names Rich Felker, Szabolcs Nagy, Timo Teräs and Alexander Monakov for 2005-2017 under the Expat text, exactly the dedicated stanza.- The
doc/licence (doc/license.html) grants download, use and modification and distribution of modified copies on condition of keepinglicense.htmlverbatim, marking changes and linking to the original site: attribution/marking conditions with no non-commercial, field-of-use or no-derivatives term, so DFSG-free. Its terms are reproduced in thedoc/*stanza, anddoc/license.htmlitself is shipped in skalibs-doc. - Prescan's only listed file,
DCO, is the Linux Foundation's Developer Certificate of Origin 1.1, a licence document; it is not DFSG-relevant as a work and is accounted for by the issue above. - No built files: the generated headers .gitignore lists (
sysdeps.h,types.h,uint16/32/64.h,ip46.h) are absent from the tarball and are produced fromsrc/headers/*by the shippedtools/gen-types.sh/gen-sysdepsh.sh;src/libstddjb/leapsecs_table.cis generated by the shippedtools/make-leapsecs_tableandtools/convert-leapsecs.cfromtools/leapsecs.txt(leap-second dates, factual data);package/deps.makis generated by the shippedtools/gen-deps.shand regenerated inoverride_dh_auto_configure-arch. No images, fonts, PDFs or archives in the tree. doc/index.htmlline 9 (public domain) is aKeywordsmeta tag, anddoc/libstddjb/index.htmllines 33-34 say the libstddjb API is based on code Dan J. Bernstein placed in the public domain: statements about origin, not licence terms applying to files here; no djb copyright notice appears in any source file.- The copyright year range in
Files: *(2011-2018) lags COPYING's (2011-2026) while naming the same holder Laurent Bercot; year drift only, deliberately not reported. - Standards-Version 4.7.4 matches the Policy 4.7.4.1 given by the policy tool;
dpkg-dev (>= 1.22.5)is satisfiable (dpkg-dev 1.23.11 in unstable, apt-cache); debhelper compat 14 is debhelper's recommended level. debian/skalibs-doc.doc-baseis installed by dh_installdocs (man dh_installdocs, FILES), and itsIndex: /usr/share/doc/skalibs/index.htmlexists becauseoverride_dh_auto_install-indepcopiesdoc/todebian/tmp/usr/share/doc/skalibs.debian/gbp.conf'soverlay = Trueis still a documented gbp buildpackage option alongsideexport-dir(gbp-buildpackage(1)), not an obsolete setting.- Two
(arch=kfreebsd-any)entries remain inlibskarnet2.16.symbols; they never match a current Debian architecture and are harmless dead entries. - uscan found the packaged version as the newest upstream release (upstream
2.16.0.0, packaged2.16.0.0).
Not confirmed ◂
- The symbols file cannot be compared with the built library without a build (dpkg-gensymbols); its new
@Base 2.16.0.0entries are consistent with the release but not proof. - The doc-base
Files: /usr/share/doc/skalibs/**/*.htmlpattern could not be checked for glob semantics, doc-base not being installed on the reviewing system; only dwww's file list would be affected. - The unpacked tree was not diffed against
skalibs_2.16.0.0.orig.tar.gz; only the .dsc was read, and it matches the tree's version, checksums and binaries.
Proposed changes ◂
None.
Review Information
accepted — allocated to awm 2 days ago, started 2 days ago, completed 2 days ago.
Final Comment
Auto-accepted (binary NEW): Already in Debian
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 2.15.0.0-1 | e5895626… | 2026-05-11 09:24 | 2026-05-11 09:31 | awm | accepted | VIEW |