DFSG NEW Queue

DFSG, Licensing & New Packages Team

Review: tcnopen 3.0.0.0-1

New Package Report

.changes
Changed-ByMarc Leeman
Architecturesource arm64
Distributionunstable
DateMon, 02 Mar 2026 17:41:25 +0100
Sourcetcnopen
Version3.0.0.0-1
Changelog
tcnopen (3.0.0.0-1) unstable; urgency=medium
 .
   * Initial release (Closes: #1053497)
.dsc
Package-Listlibtcnopen-dev deb libdevel optional arch=any
libtcnopen0 deb libs optional arch=any
Sectionlibdevel
Priorityoptional
Componentmain
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: TCNOpen
Upstream-Contact: https://sourceforge.net/p/tcnopen/wiki/Home/
Source: https://sourceforge.net/projects/tcnopen/
 This package was debianized by Marc Leeman
 <marc.leeman@gmail.com> on Mon, 2 Mar 2026 09:58:46 +0100
 .
 It was downloaded from <https://sourceforge.net/projects/tcnopen/>

Files: *
Copyright: 2022-2026, Armin-Hagen Weiss
           2022-2026, Bernd Löhr
           2022-2026, Chris Wetzler
           2022-2026, Iris Bosse
           2022-2026, Adrian Moran
           2022-2026, Anders Öberg
           2022-2026, Artem Rudskyy
           2022-2026, Bernd Brandstetter
           2022-2026, Chirag Khangani
           2022-2026, Elmar Kraska
           2022-2026, F Weisp
           2022-2026, Gari
           2022-2026, Holger Waldmann
           2022-2026, Javier Goikoetxea
           2022-2026, Matthias Mossner
           2022-2026, mkorta
           2022-2026, mike
           2022-2026, Stefan Bender
           2022-2026, Siddhi Wadgaonkar
           2022-2026, Stefan Strobel
           2022-2026, Ulverine
           2022-2026, Yoshio Sashida
           2022-2026, Mauro Barella
           2022-2026, SeSimonePachera
License: MPL-2.0

Files: debian/*
Copyright: 2026, Marc Leeman <marc.leeman@gmail.com>
License: GPL-3.0+

Files: spy/src/CMakeListsCustom.txt
       spy/src/trdp_spy/CMakeLists.txt
Copyright: 2022-2026, Armin-Hagen Weiss
           2022-2026, Bernd Löhr
           2022-2026, Chris Wetzler
           2022-2026, Iris Bosse
           2022-2026, Adrian Moran
           2022-2026, Anders Öberg
           2022-2026, Artem Rudskyy
           2022-2026, Bernd Brandstetter
           2022-2026, Chirag Khangani
           2022-2026, Elmar Kraska
           2022-2026, F Weisp
           2022-2026, Gari
           2022-2026, Holger Waldmann
           2022-2026, Javier Goikoetxea
           2022-2026, Matthias Mossner
           2022-2026, mkorta
           2022-2026, mike
           2022-2026, Stefan Bender
           2022-2026, Siddhi Wadgaonkar
           2022-2026, Stefan Strobel
           2022-2026, Ulverine
           2022-2026, Yoshio Sashida
           2022-2026, Mauro Barella
           2022-2026, SeSimonePachera
License: GPL-2+

Files: spy/*
Copyright: 2022-2026, Armin-Hagen Weiss
           2022-2026, Bernd Löhr
           2022-2026, Chris Wetzler
           2022-2026, Iris Bosse
           2022-2026, Adrian Moran
           2022-2026, Anders Öberg
           2022-2026, Artem Rudskyy
           2022-2026, Bernd Brandstetter
           2022-2026, Chirag Khangani
           2022-2026, Elmar Kraska
           2022-2026, F Weisp
           2022-2026, Gari
           2022-2026, Holger Waldmann
           2022-2026, Javier Goikoetxea
           2022-2026, Matthias Mossner
           2022-2026, mkorta
           2022-2026, mike
           2022-2026, Stefan Bender
           2022-2026, Siddhi Wadgaonkar
           2022-2026, Stefan Strobel
           2022-2026, Ulverine
           2022-2026, Yoshio Sashida
           2022-2026, Mauro Barella
           2022-2026, SeSimonePachera
License: GPL-3.0+

Files: spy/src/trdp_spy/packet-trdp_spy.h
       spy/src/trdp_spy/packet-trdp_spy.c
       spy/src/trdp_spy/trdpDict.c
       spy/src/trdp_spy/trdpDict.h
       spy/src/trdp_spy/trdp_env.c
       spy/src/trdp_spy/trdp_env.h
       spy/src/trdp_spy/Makefile
Copyright: 2022-2026, Armin-Hagen Weiss
           2022-2026, Bernd Löhr
           2022-2026, Chris Wetzler
           2022-2026, Iris Bosse
           2022-2026, Adrian Moran
           2022-2026, Anders Öberg
           2022-2026, Artem Rudskyy
           2022-2026, Bernd Brandstetter
           2022-2026, Chirag Khangani
           2022-2026, Elmar Kraska
           2022-2026, F Weisp
           2022-2026, Gari
           2022-2026, Holger Waldmann
           2022-2026, Javier Goikoetxea
           2022-2026, Matthias Mossner
           2022-2026, mkorta
           2022-2026, mike
           2022-2026, Stefan Bender
           2022-2026, Siddhi Wadgaonkar
           2022-2026, Stefan Strobel
           2022-2026, Ulverine
           2022-2026, Yoshio Sashida
           2022-2026, Mauro Barella
           2022-2026, SeSimonePachera
License: MPL-2.0

Files: spy/src/CMakeListsCustom.txt
       spy/src/trdp_spy/CMakeLists.txt
Copyright: 2022-2026, Armin-Hagen Weiss
           2022-2026, Bernd Löhr
           2022-2026, Chris Wetzler
           2022-2026, Iris Bosse
           2022-2026, Adrian Moran
           2022-2026, Anders Öberg
           2022-2026, Artem Rudskyy
           2022-2026, Bernd Brandstetter
           2022-2026, Chirag Khangani
           2022-2026, Elmar Kraska
           2022-2026, F Weisp
           2022-2026, Gari
           2022-2026, Holger Waldmann
           2022-2026, Javier Goikoetxea
           2022-2026, Matthias Mossner
           2022-2026, mkorta
           2022-2026, mike
           2022-2026, Stefan Bender
           2022-2026, Siddhi Wadgaonkar
           2022-2026, Stefan Strobel
           2022-2026, Ulverine
           2022-2026, Yoshio Sashida
           2022-2026, Mauro Barella
           2022-2026, SeSimonePachera
License: GPL-2+

License: GPL-2+
 This program is free software: you can redistribute it and/or
 modify it under the terms of the GNU General Public License as
 published by the Free Software Foundation, either version 2 of
 the License, or (at your option) any later version.
 .
 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 GNU General Public License for more details.
 .
 You should have received a copy of the GNU General Public License
 along with this program.  If not, see
 <http://www.gnu.org/licenses/>.
 .
 On Debian systems, the complete text of the GNU General Public
 License, version 2, can be found in the file
 `/usr/share/common-licenses/GPL-2'.

License: GPL-3.0+
 This program is free software: you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by
 the Free Software Foundation, either version 3 of the License, or
 (at your option) any later version.
 .
 This package is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 GNU General Public License for more details.
 .
 You should have received a copy of the GNU General Public License
 along with this program. If not, see <https://www.gnu.org/licenses/>.
 .
 On Debian systems, the complete text of the GNU General
 Public License version 3 can be found in "/usr/share/common-licenses/GPL-3".

License: MPL-2.0
 This Source Code Form is subject to the terms of the Mozilla Public
 License, v. 2.0. If a copy of the MPL was not distributed with this
 file, You can obtain one at http://mozilla.org/MPL/2.0/.
 .
 On Debian systems, see /usr/share/common-licenses/MPL-2.0 for the full
 text of the MPL version 2.0.

Review Information

rejected — allocated to awm 15 days ago, started 15 days ago, completed 15 days ago.

Final Comment

The debian/copyright looks like it has duplicate globs in there - see the note from lintian.
There also seem to be a bunch of corporate authors that have been omitted from the copyright
file, but who have asserted their rights in various places - see the Authors and SPDX notes.

Thanks!

Public Notes

15 days ago ● public

Search for authors

Command: ag -i 'copyright .* (by|rights|reserved)[. ]' | sed -e 's/^.*Copyright //i' -e 's/\(20\|19\)[0-9][0-9][, -]*//g' -e 's/[., ]*ALL RIGHTS RESERVED.*$//i' | sort -i | uniq -i
Exit code: 0


Alstom SA or its subsidiaries and others
Bombardier Transportation Inc. or its subsidiaries and others
by MIRA Limited, as the primary source for this
NewTec GmbH
NewTec GmbH System-Entwicklung und Beratung
Toshiba Corporation, Japan
UniControls
UniControls, a.s
15 days ago ● public

Search for SPDX license declarations

Command: grep -r -B1 'SPDX-'
Exit code: 0

spy/src/trdp_spy/Makefile-# 
spy/src/trdp_spy/Makefile:# SPDX-License-Identifier: MPL-2.0
--
spy/src/trdp_spy/packet-trdp_spy.c- *              Copyright 1998 Gerald Combs
spy/src/trdp_spy/packet-trdp_spy.c: *              SPDX-License-Identifier: GPL-2.0-or-later
15 days ago ● public

Lintian

Command: lintian -Iiv -L '>=warning' --show-overrides --color=never ../$(basename $PWD)_*.changes
Exit code: 2

N:
E: tcnopen source: duplicate-globbing-patterns spy/src/CMakeListsCustom.txt (lines 41 129) [debian/copyright]
N: 
N:   A globbing pattern was used again in debian/copyright. It always an error
N:   and may indicate confusion about the applicable license for the author or
N:   any reader of the file.
N:   
N:   Please remove all but one of the identical globbing patterns.
N: 
N:   Please refer to Bug#90574 and
N:   https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for
N:   details.
N: 
N:   Visibility: error
N:   Show-Always: no
N:   Check: debian/copyright/dep5
N: 
N:
E: tcnopen source: duplicate-globbing-patterns spy/src/trdp_spy/CMakeLists.txt (lines 41 129) [debian/copyright]
N:
W: tcnopen source: globbing-patterns-out-of-order spy/src/CMakeListsCustom.txt spy/* spy/src/CMakeListsCustom.txt [debian/copyright:69]
N: 
N:   The Files sections in debian/copyright are out of order. The relative
N:   directory depth should increase from one section to the next. That is the
N:   general pattern of the specification, with * at the top.
N:   
N:   When sections are in another order, some files may be associated with the
N:   wrong license.
N:   
N:   Please reorder the sections.
N: 
N:   Please refer to Bug#905747 and
N:   https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ for
N:   details.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: debian/copyright/dep5
N: 
N:
W: tcnopen source: globbing-patterns-out-of-order spy/src/trdp_spy/CMakeLists.txt spy/* spy/src/trdp_spy/CMakeLists.txt [debian/copyright:69]
N:
O: tcnopen source: source-contains-prebuilt-windows-binary [spy/plugins/2.6/epan/trdp_spy.dll]
N: 
N:   The source tarball contains a prebuilt binary for Microsoft Windows. They
N:   are usually provided for the convenience of users. These files usually
N:   just take up space in the tarball.
N:   
N:   However, they may be a DFSG violation in that the corresponding source and
N:   build system are not available.
N:   
N:   Check if upstream also provides source-only tarballs that you can use as
N:   the upstream distribution instead. If not, you may want to ask upstream to
N:   provide source-only tarballs.
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: files/source-missing
N: 
N:
O: tcnopen source: source-contains-prebuilt-windows-binary [spy/plugins/3.0/epan/trdp_spy.dll]
N:
O: tcnopen source: source-contains-prebuilt-windows-binary [spy/plugins/3.2/epan/trdp_spy.dll]
N:
O: tcnopen source: source-contains-prebuilt-windows-binary [spy/plugins/3.4/epan/trdp_spy.dll]
N:
O: tcnopen source: source-contains-prebuilt-windows-binary [spy/plugins/3.6/epan/trdp_spy.dll]
N:
O: tcnopen source: source-contains-prebuilt-windows-binary [spy/plugins/4.0/epan/trdp_spy.dll]
15 days ago ● public

duck - check URL redirections

Command: duck
Exit code: 1

I: debian/copyright:196: URL: http://mozilla.org/MPL/2.0/: INFORMATION (Certainty:possible)
   URL schema changed from HTTP to HTTPS during redirect(s): http://mozilla.org -> https://www.mozilla.org
   Please investigate and update the URL eventually, to avoid unnecessary redirects!

E: debian/control: Homepage: https://www.tcnopen.org/: ERROR (Certainty:certain)
   Curl:28 HTTP:0 Timeout was reached Connection timed out after 60002 milliseconds

15 days ago ● public

Licenserecon

Command: lrc -s
Exit code: 3

en: Versions: licenserecon '12.0'  licensecheck '3.3.9-1'

Parsing Source Tree  ....
Reading d/copyright  ....
  Globing pattern out of order above line 94
Running licensecheck ....

d/copyright      | licensecheck

MPL-2.0          | GPL-2 and/or MPL-2.0 spy/src/trdp_spy/packet-trdp_spy.c

Short option in use. Not all differences shown

15 days ago ● public

CME fix

Command: cme fix --verbose dpkg
Exit code: 0


Reading package lists... 0%

Reading package lists... 100%

Reading package lists... Done

Building dependency tree... 0%

Building dependency tree... 0%

Building dependency tree... 50%

Building dependency tree... 50%

Building dependency tree... Done

Reading state information... 0% 

Reading state information... 0%

Reading state information... Done
cme: running fix on dpkg configuration...
Connecting to api.ftp-master.debian.org to check 1 package versions. Please wait...
Got info from api.ftp-master.debian.org for 1 packages.
Warning in 'control source Standards-Version': Current standards version is '4.7.3'. Please read https://www.debian.org/doc/debian-policy/upgrading-checklist.html for the changes that may be needed on your package
to upgrade it from standard version '4.6.2' to '4.7.3'.

Offending value: '4.6.2'
double entry for copyright Files:"spy/src/CMakeListsCustom.txt
      spy/src/trdp_spy/CMakeLists.txt" Copyright, appending value

Changes applied to dpkg configuration:
- control source Standards-Version: '4.6.2' -> '4.7.3' # applied fix for :Current standards version is '4.7.3'. Please read https://www.debian.org/doc/debian-policy/upgrading-checklist.html for the changes that may be needed on your package
to upgrade it from standard version '4.6.2' to '4.7.3'.

- copyright Files:"spy/src/CMakeListsCustom.txt
      spy/src/trdp_spy/CMakeLists.txt" Copyright: '2022-2026, Armin-Hagen Weiss           2022-2026, Bernd Löhr[...]' -> '2022-2026, Armin-Hagen Weiss           2022-2026, Bernd Löhr[...]' # conflicting initial values
- copyright Files:"spy/src/CMakeListsCustom.txt
      spy/src/trdp_spy/CMakeLists.txt" License short_name: removed redundant initial value
- install:"libtcnopen-dev" content: removed idx 3 ("src/common/*.h ...")

Back to Dashboard | View all reviews for this package