Review: tomobase 0.0.0~dev1-2

Package Information

Description	base classes and utilities for tomographic tools Common base classes and utilities shared by tomoscan (tomography scan reading) and volio (volume load/save).
Maintainer	Debian PaN Maintainers <debian-pan-maintainers@alioth-lists.debian.net>
Changed By	Roland Mas <lolando@debian.org>
Sponsor	lolando@debian.org
Distribution	unstable
Architecture	all
VCS	git: https://salsa.debian.org/python-team/packages/tomobase.git (browse)
Tracker	https://tracker.debian.org/pkg/tomobase
Uploaded	8 days ago
Supersedes	0.0.0~dev1-1

New Package Report

.changes◂

Date	Fri, 16 Oct 2026 15:24:35 +0200
Source	tomobase
Version	0.0.0~dev1-2
Changed-By	Roland Mas <lolando@debian.org>
Architecture	source all
Distribution	unstable

Changelog◂

tomobase (0.0.0~dev1-2) unstable; urgency=medium
 .
   * Fix packaging issues detected by the DFSG-new-queue's LLM. Thanks!

.dsc◂

Priority	optional
Component	main
Package-List	python3-tomobase deb python optional arch=all
Section	python

debian/copyright◂

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: tomobase
Upstream-Contact: data analysis unit <henri.payno@esrf.fr>
Source: https://gitlab.esrf.fr/tomotools/tomobase

Files: *
Copyright: (c) European Synchrotron Radiation Facility (ESRF)
License: MIT

Files: debian/*
Copyright: 2026 Roland Mas <lolando@debian.org>
License: MIT

License: MIT
.
The tomobase library goal is to provide a python interface to read ESRF tomography dataset.
.
tomobase is distributed under the MIT license.
.
The MIT license follows:
.
Copyright (c) European Synchrotron Radiation Facility (ESRF)
.
Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
the Software without restriction, including without limitation the rights to
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
the Software, and to permit persons to whom the Software is furnished to do so,
subject to the following conditions:
.
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 7 days ago.

Report◂

DFSG NEW review for tomobase version 0.0.0~dev1-2

Summary

Licensing is DFSG-compliant and debian/copyright is accurate: Yes
Packaging is of good quality: Yes
Issues: 0 blocker, 0 important, 0 minor
debian/watch: version 5
debian/copyright: machine-readable
Scan before the review: nothing found

Licensing

The whole source tree is MIT-licensed with a single copyright holder, the European Synchrotron Radiation Facility (ESRF). debian/copyright is valid DEP-5: it has a correct Format line, a Files: * stanza for ESRF and a debian/* stanza for the Debian packaging by Roland Mas, and the full MIT text (not in /usr/share/common-licenses, so it must be reproduced) is present as a standalone License paragraph. It matches the upstream LICENSE file and the doc/conf.py header, and the scan reported no author missing from it.

Packaging

A clean modern single-binary Python package: debhelper-compat 14, dh-sequence-python3, pybuild via pybuild-plugin-pyproject, python3-all for a pure-Python module, Standards-Version 4.7.4 (current Policy is 4.7.4.1, so current enough), Vcs-* fields, Testsuite: autopkgtest-pkg-pybuild with debian/pybuild.testfiles, and a minimal rules. Runtime deps (h5py, silx, numpy) are picked up from the pyproject Requires-Dist into ${python3:Depends} by dh_python3, so no missing dependency. Only trivial nits remain (a no-op .pyremove), none of which a sponsor would require to be fixed.

Issues

None.

Verified

Whole tree read directory by directory; every file type accounted for. No file the prescan listed (it reported no missing copyright holder; the author check passed).
Only copyright/licence notices in the tree are LICENSE, debian/copyright and copyright = "2026, ESRF" (doc/conf.py:22). No per-file headers, no SPDX tags, no third-party licences, no vendored code, no other LICENSE/COPYING/NOTICE/AUTHORS files.
The four individual authors in pyproject.toml (Henri Payno, Pierre Paleo, Pierre-Olivier Autran, Jérôme Lesaint) are authors, not copyright holders; the declared holder ESRF is correct and matches the MIT notice in LICENSE.
doc/img/tomobase.svg, doc/img/tomobase-lockup.svg and doc/img/tomobase.png are the project's own logo/mark, covered by Files: * of debian/copyright; no other images or fonts in the tree.
No built artifacts shipped: no .pyc, .so, .jar, .class, .exe, minified JS/CSS, PDFs or generated code. The tree is .py/.rst/.html/.yml/.svg/.png plus pyproject.toml and LICENSE.
tomobase_0.0.0~~dev1.orig.tar.gz contains no debian/ and no .pc directory (the .pc/ in the unpacked tree is the review harness's quilt state and was ignored); tomobase_0.0.0~~dev1-2.debian.tar.xz contains only the debian/ files.
Runtime dependencies will be generated: pyproject.toml declares h5py>=3.0, silx>=2.0, numpy; dh_python3 translates Requires-Dist to Debian dependencies in ${python3:Depends} (dh_python3(1), NOTES/dependencies). python3-h5py 3.16.0 and python3-silx 2.2.2 satisfy the upstream version bounds.
Build/test dependencies exist: debhelper-compat, dh-sequence-python3, pybuild-plugin-pyproject, python3-all, python3-setuptools, python3-pytest, python3-numpy, python3-h5py, python3-silx are all in the archive.
debian/python3-tomobase.pyremove lists doc/conf.py, which is a harmless no-op: setuptools' packages.find(where=['.']) installs only the tomobase packages (doc/ has no init.py), so doc/conf.py is never installed to remove.
debian/rules is the minimal dh $@ --buildsystem=pybuild; debian/source/format is 3.0 (quilt); no debian/patches directory and no maintainer scripts to check. Changelog version 0.0.0~dev1-2 sorts before 0.0.0 and mirrors upstream 0.0.0.dev1; distribution unstable.
uscan found the packaged version as the newest upstream release (upstream 0.0.0~dev1, packaged 0.0.0~dev1).

Not confirmed

Whether a build with DEB_BUILD_PROFILES=nocheck needs python3-numpy: pyproject.toml build-system.requires lists numpy, but no setuptools build hook imports it and the package is pure Python, while Build-Depends marks python3-numpy, python3-h5py, python3-silx and python3-pytest <!nocheck> (test-only). A build would show whether the profile-less build is affected; no other indication of a build failure.

Proposed changes

None.

Review Information

accepted — allocated to awm 6 days ago, started 6 days ago, completed 6 days ago.

Final Comment

Other Reviews of this Package

Version	Hash	Allocated	Completed	Reviewer	Status	Details
0.0.0~dev1-1	78ad8636…	2026-10-17 21:40	2026-10-17 21:40	awm	accepted	VIEW

Back to Dashboard | View all reviews for this package