Review: tree-sitter-go 0.25.0-1
New Package Report
.dsc
| Priority | optional |
|---|---|
| Component | main |
| Package-List | librust-tree-sitter-go-dev deb rust optional arch=any tree-sitter-go-src deb libs optional arch=all |
| Section | rust |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: tree-sitter-go Source: https://github.com/tree-sitter/tree-sitter-go Files: * Copyright: 2016-2021 Max Brunsfeld <maxbrunsfeld@gmail.com> 2023-current Amaan Qureshi <amaanq12@gmail.com> License: MIT Files: src/tree_sitter/alloc.h src/tree_sitter/array.h src/tree_sitter/parser.h Copyright: 2018-2022, Max Brunsfeld License: MIT Comment: These files are copied from libtree-sitter-dev as part of generating the upstream project (via "tree-sitter generate") so it's possible to build standalone. Files: debian/* Copyright: 2025 Matthias Geiger <werdahias@debian.org> 2025 Antonin Delpeuch <antonin@delpeuch.eu> License: MIT License: MIT Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
Review Information
rejected — allocated to siretart 1 month, 8 days ago, started 1 month, 8 days ago, completed 1 month, 8 days ago.
Final Comment
1. Placeholder Text in debian/copyright
The file contains TODO_YEARS placeholders that must be replaced with actual copyright years:
Files: *
Copyright:
TODO_YEARS Ika <ikatyang@gmail.com>
TODO_YEARS Amaan Qureshi <amaanq12@gmail.com>
Evidence from LICENSE file:
Copyright (c) 2024 tree-sitter-grammars contributors
Copyright (c) 2019-2021 Ika
Required Fix: Replace the TODO_YEARS placeholders with the appropriate years (e.g., 2019-2021 for Ika and 2024 for the tree-sitter-grammars contributors).
2. Missing Copyright Holder
The LICENSE file lists "tree-sitter-grammars contributors" as a copyright holder:
Copyright (c) 2024 tree-sitter-grammars contributors
However, debian/copyright does not include this entry for the Files: * stanza.
Required Fix: Add "2024 tree-sitter-grammars contributors" to the copyright holders for Files: *.
Required Fixes
3. Missing Coverage for schema/*/src/tree_sitter/ Files
The following files in the schema/ subdirectories are copies of the same tree-sitter runtime header files that are documented for src/tree_sitter/:
schema/json/src/tree_sitter/alloc.hschema/json/src/tree_sitter/array.hschema/json/src/tree_sitter/parser.hschema/core/src/tree_sitter/alloc.hschema/core/src/tree_sitter/array.hschema/core/src/tree_sitter/parser.hschema/legacy/src/tree_sitter/alloc.hschema/legacy/src/tree_sitter/array.hschema/legacy/src/tree_sitter/parser.h
These files should be covered by the same stanza (Max Brunsfeld, MIT license) as src/tree_sitter/*.h.
Required Fix: Update the Files: stanza to include these paths, for example:
Files:
src/tree_sitter/alloc.h
src/tree_sitter/array.h
src/tree_sitter/parser.h
schema/*/src/tree_sitter/alloc.h
schema/*/src/tree_sitter/array.h
schema/*/src/tree_sitter/parser.h
Copyright:
2018-2022, Max Brunsfeld
License: MIT
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 0.25.0+ds-1 | 9f06dbb1… | 2026-02-16 11:44 | 2026-02-18 00:18 | siretart | accepted | VIEW |