Team Review: tree-sitter-verilog 1.0.3-1
Review Information
| Package | tree-sitter-verilog — 1.0.3-1 |
|---|---|
| Reviewer | mechtilde |
| Allocated | 3 days ago |
| Started | 3 days ago |
| Status | team TEAM |
New Package Report
Vote Tally
Votes are advisory. The final decision is made when completing the review.
Notes
CME fix
Command: cme fix --verbose dpkg
Exit code: 0
Paketlisten werden gelesen… 0%
Paketlisten werden gelesen… 100%
Paketlisten werden gelesen… Fertig
Abhängigkeitsbaum wird aufgebaut… 0%
Abhängigkeitsbaum wird aufgebaut… 0%
Abhängigkeitsbaum wird aufgebaut… 50%
Abhängigkeitsbaum wird aufgebaut… 50%
Abhängigkeitsbaum wird aufgebaut… Fertig
Statusinformationen werden eingelesen… 0%
Statusinformationen werden eingelesen… 0%
Statusinformationen werden eingelesen… Fertig
cme: running fix on dpkg configuration...
Connecting to api.ftp-master.debian.org to check 3 package versions. Please wait...
Got info from api.ftp-master.debian.org for 0 packages.
Warning in 'control source Standards-Version': Current standards version is '4.7.3'. Please read https://www.debian.org/doc/debian-policy/upgrading-checklist.html for the changes that may be needed on your package
to upgrade it from standard version '4.7.2' to '4.7.3'.
Offending value: '4.7.2'
Warning in 'control source Build-Depends:3': package librust-cc-1+default-dev is unknown. Check for typos if not a virtual package.
Offending value: 'librust-cc-1+default-dev (>= 1.0.89)'
Warning in 'control source Build-Depends:4': package librust-tree-sitter-0+default-dev is unknown. Check for typos if not a virtual package.
Offending value: 'librust-tree-sitter-0+default-dev (>= 0.25)'
Warning in 'control source Build-Depends:5': package librust-tree-sitter-language-0.1+default-dev is unknown. Check for typos if not a virtual package.
Offending value: 'librust-tree-sitter-language-0.1+default-dev'
Warning in 'control source Build-Depends:8': unnecessary greater-than versioned dependency: tree-sitter-cli (>= 0.21). Debian has stable -> 0.22.6-6+b1; unstable -> 0.25.9-7; testing -> 0.25.9-7;
Offending value: 'tree-sitter-cli (>= 0.21)'
Warning in 'control binary:"librust-tree-sitter-verilog-dev" Depends:1': package librust-cc-1+default-dev is unknown. Check for typos if not a virtual package.
Offending value: 'librust-cc-1+default-dev (>= 1.1.22-~~)'
Warning in 'control binary:"librust-tree-sitter-verilog-dev" Depends:2': package librust-tree-sitter-language-0.1+default-dev is unknown. Check for typos if not a virtual package.
Offending value: 'librust-tree-sitter-language-0.1+default-dev'
Changes applied to dpkg configuration:
- control source Standards-Version: '4.7.2' -> '4.7.3' # applied fix for :Current standards version is '4.7.3'. Please read https://www.debian.org/doc/debian-policy/upgrading-checklist.html for the changes that may be needed on your package
to upgrade it from standard version '4.7.2' to '4.7.3'.
- control source Build-Depends:8: 'tree-sitter-cli (>= 0.21)' -> 'tree-sitter-cli' # applied fix for :unnecessary greater-than versioned dependency: tree-sitter-cli (>= 0.21). Debian has stable -> 0.22.6-6+b1; unstable -> 0.25.9-7; testing -> 0.25.9-7;
Connecting to api.ftp-master.debian.org to check librust-cc-1+default-dev versions. Please wait...
got no info for librust-cc-1+default-dev
Connecting to api.ftp-master.debian.org to check librust-tree-sitter-0+default-dev versions. Please wait...
got no info for librust-tree-sitter-0+default-dev
Connecting to api.ftp-master.debian.org to check librust-tree-sitter-language-0.1+default-dev versions. Please wait...
got no info for librust-tree-sitter-language-0.1+default-dev
In the real world these dependencies do get installed because newer packages have 'Provides:...' and so forth. When I try and install the Build-Depends I see the following:
Note, selecting 'dh-rust' instead of 'dh-sequence-rust'
Note, selecting 'librust-cc-dev' instead of 'librust-cc-1+default-dev'
Note, selecting 'librust-tree-sitter-dev' instead of 'librust-tree-sitter-0+default-dev'
Note, selecting 'librust-tree-sitter-language-dev' instead of 'librust-tree-sitter-language-0.1+default-dev'
It seems most likely that at least some of this is an artifact of sitting in the NEW queue for six months and we should NOT penalise people for that. When we have a queue that is under one month we can maybe consider this, but I would just note it in my accept message. Build depends on -dev packages can also often be met through a Provides in any case. This is the "Tree Sitter Team" and having a ...-default-dev that they can depend on may be there way of upgrading through rapid change.
the main attraction of this package is src/parser.c: a generated 25MB monster (which compresses well, btw). It is generated from src/grammar.json and appears to be regenerated on build.
The package appears to be MIT licensed and authors are properly attributed in debian/copyright. LGTM