Review: vigie 0.0.1
Package Information
| Description | OpenStack operator API - api Vigie is an OpenStack operator API aimed to ease the administration of an existing deployment. It typically can be used by operators to do daily tasks such as purging all resources of a project, evacuate a compute or a network node for maintenance and more. This package provides the API. |
|---|---|
| Maintainer | Debian OpenStack <team+openstack@tracker.debian.org> |
| Changed By | Thomas Goirand <zigo@debian.org> |
| Sponsor | zigo@debian.org |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/openstack-team/services/vigie.git (browse) |
| Closes | #1147763 |
| Tracker | https://tracker.debian.org/pkg/vigie |
| Uploaded | 5 days ago |
New Package Report
.changes
| Architecture | source all |
|---|---|
| Distribution | unstable |
| Date | Mon, 06 Oct 2025 09:25:01 +0200 |
| Source | vigie |
| Version | 0.0.1 |
| Changed-By | Thomas Goirand |
Changelog
vigie (0.0.1) unstable; urgency=medium . * Initial release. (Closes: #1147763)
.dsc
| Section | python |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | python3-vigie deb python optional arch=all vigie-api deb net optional arch=all vigie-common deb net optional arch=all vigie-worker deb net optional arch=all |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: vigie
Source: https://salsa.debian.org/openstack-team/services/vigie
Files: *
Copyright: (c) 2025, Thomas Goirand <zigo@debian.org>
License: Apache-2.0
License: Apache-2.0
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
.
http://www.apache.org/licenses/LICENSE-2.0
.
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
.
On Debian-based systems the full text of the Apache version 2.0 license
can be found in `/usr/share/common-licenses/Apache-2.0'.
Review Information
rejected — allocated to awm 5 days ago, started 5 days ago, completed 5 days ago.
Final Comment
Hi,
Please review the full notes from Lintian, particularly:
- needs dependency on 'ucf'
- systemd config just execs systemv init script
I don't normally moan too much about man pages, but in this case a man page seems like it could be worthwhile as well.
Thanks!
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 0.0.1 | f307667d… | 2026-09-18 09:41 | 2026-09-18 09:41 | awm | accepted | VIEW |
Public Notes
5 days ago
● public
Lintian
Command: lintian -Iiv -L '>=warning' --show-overrides --color=never ../$(basename $PWD)_*.changes
Exit code: 0
N:
W: vigie-api: maintainer-script-needs-depends-on-ucf ucf (does not satisfy ucf) [config:1150]
N:
N: This script calls ucf, but the package does not depend or pre-depend on
N: the ucf package.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: scripts
N:
N:
W: vigie-api: maintainer-script-needs-depends-on-ucf ucf (does not satisfy ucf) [postinst:1148]
N:
W: vigie-common: maintainer-script-needs-depends-on-ucf ucf (does not satisfy ucf) [config:1151]
N:
W: vigie-common: maintainer-script-needs-depends-on-ucf ucf (does not satisfy ucf) [postinst:1150]
N:
W: vigie-common: no-manual-page [usr/bin/vigie-manage]
N:
N: Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should have
N: a manual page
N:
N: Note that though the man program has the capability to check for several
N: program names in the NAMES section, each of these programs should have its
N: own manual page (a symbolic link to the appropriate manual page is
N: sufficient) because other manual page viewers such as xman or tkman don't
N: support this.
N:
N: If the name of the manual page differs from the binary by case, man may be
N: able to find it anyway; however, it is still best practice to match the
N: exact capitalization of the executable in the manual page.
N:
N: If the manual pages are provided by another package on which this package
N: depends, Lintian may not be able to determine that manual pages are
N: available. In this case, after confirming that all binaries do have manual
N: pages after this package and its dependencies are installed, please add a
N: Lintian override.
N:
N: Please refer to Manual pages (Section 12.1) in the Debian Policy Manual
N: for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: documentation/manual
N: Renamed from: binary-without-manpage
N:
N:
W: vigie-common: no-manual-page [usr/bin/vigie-worker]
N:
W: vigie-api: systemd-service-file-wraps-init-script ExecStart [usr/lib/systemd/system/vigie-api.service]
N:
N: The listed service file simply uses ths existing SysV init script via
N: ExecStart, ExecStop, etc.
N:
N: The main logic of more complex init scripts should be moved into helper
N: scripts which can be used directly from both the .service file and the
N: init script. This will also make the init scripts more readable and easier
N: to support other alternatives. Note that as /etc/init.d/* files are
N: conffiles, such updates are not guaranteed to reach users.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: systemd
N:
N:
W: vigie-worker: systemd-service-file-wraps-init-script ExecStart [usr/lib/systemd/system/vigie-worker.service]