Review: wattsi 0.0~git20260506.8b5e695+dfsg-1
Package Information
| Description | Preprocessor for the HTML Standard Wattsi is a build tool for creating the HTML Standard from its source. It works in concert with other scripts. |
|---|---|
| Maintainer | Fab Stz <fabstz-it@yahoo.fr> |
| Changed By | Fab Stz <fabstz-it@yahoo.fr> |
| Sponsor | maytham@debian.org |
| Distribution | unstable |
| Architecture | any |
| VCS | git: https://salsa.debian.org/debian/wattsi.git (browse) |
| Closes | #1133348 |
| Blocked Bugs | #1133423 (wishlist) |
| Tracker | https://tracker.debian.org/pkg/wattsi |
| Uploaded | 2 hours ago |
New Package Report
.changes
| Distribution | unstable |
|---|---|
| Date | Fri, 08 May 2026 20:11:35 +0200 |
| Source | wattsi |
| Version | 0.0~git20260506.8b5e695+dfsg-1 |
| Changed-By | Fab Stz <fabstz-it@yahoo.fr> |
| Architecture | source amd64 |
Changelog
wattsi (0.0~git20260506.8b5e695+dfsg-1) unstable; urgency=medium . * Initial release. Closes: #1133348
.dsc
| Component | main |
|---|---|
| Package-List | wattsi deb devel optional arch=any |
| Section | devel |
| Priority | optional |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: wattsi
Source: https://github.com/whatwg/wattsi
Files-Excluded:
.gitignore
src/icon.jpeg
src/lib/debug.pas
Comment:
- src/lib/debug.pas
Mentions the code in function GetStackTrace is a verbatim copy from
http://wiki.freepascal.org/Logging_exceptions
This function is needed only when the binary is built in Debug mode, which is
not the case for the Debian package.
According to [1] and [2] the code from that wiki wouldn't be free
"As there is no specific license indicated on the wiki, all author's rights
and copyrights of submissions remain with the original authors."
[1] https://web.archive.org/web/20231207202427/https://wiki.freepascal.org/Talk:licensing
[2] https://web.archive.org/web/20250512082052/https://wiki.freepascal.org/Licensing#Licensing/copyright_of_Wiki_articles
Files: *
Copyright: Google, Inc.
License: Expat
Files: src/wattsi.pas
Copyright: 2014, Google, Inc.
2015, Ian Hickson.
WHATWG (Apple, Google, Mozilla, Microsoft).
License: Expat AND CC-BY-4.0
Comment: CC-BY-4.0 & WHATWG (Apple, Google, Mozilla, Microsoft) through
application of patch Replace-privacy-breach-by-base64-reprensentation-of-pictu.patch
Files: src/lib/*
Copyright: 2014, Google, Inc.
2015, Ian Hickson.
License: Expat
Files: src/lib/base64encoder.pas
Copyright: 1999, Sebastian Guenther
1999-2000, Michael Van Canneyt and Florian Klaempfl
2012, Ian Hickson
License: LGPL-2.1-or-later with linking-exception exception
Files: src/lib/heaptrc.pp
Copyright: 1999-2000 by the Free Pascal development team.
License: LGPL-2.1-or-later with linking-exception exception
Comment: LGPL-2.1-or-later as defined in the "src:fpc" Debian package
License: LGPL-2.1-or-later with linking-exception exception
The source code of the Free Pascal Runtime Libraries and packages,
and thus this derivative work, are distributed under the Library
GNU General Public License (see the file COPYING.LGPL) with the
following modification:
.
As a special exception, the copyright holders of this library give
you permission to link this library with independent modules to
produce an executable, regardless of the license terms of these
independent modules, and to copy and distribute the resulting
executable under terms of your choice, provided that you also
meet, for each linked independent module, the terms and conditions
of the license of that module. An independent module is a module
which is not derived from or based on this library. If you modify
this library, you may extend this exception to your version of the
library, but you are not obligated to do so. If you do not wish to
do so, delete this exception statement from your version.
.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
.
On Debian systems, the complete text of version 2.1 of the GNU Lesser
General Public License can be found in '/usr/share/common-licenses/LGPL-2.1'.
License: Expat
Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:
.
The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
License: CC-BY-4.0
Creative Commons Attribution 4.0 International
.
Creative Commons Corporation (“Creative Commons”) is not a law firm
and does not provide legal services or legal advice. Distribution of
Creative Commons public licenses does not create a lawyer-client or
other relationship. Creative Commons makes its licenses and related
information available on an “as-is” basis. Creative Commons gives
no warranties regarding its licenses, any material licensed under their
terms and conditions, or any related information. Creative Commons
disclaims all liability for damages resulting from their use to the
fullest extent possible.
.
Using Creative Commons Public Licenses
.
Creative Commons public licenses provide a standard set of terms and
conditions that creators and other rights holders may use to share
original works of authorship and other material subject to copyright and
certain other rights specified in the public license below. The following
considerations are for informational purposes only, are not exhaustive,
and do not form part of our licenses.
.
Considerations for licensors: Our public licenses are intended for use
by those authorized to give the public permission to use material in
ways otherwise restricted by copyright and certain other rights. Our
licenses are irrevocable. Licensors should read and understand the terms
and conditions of the license they choose before applying it. Licensors
should also secure all rights necessary before applying our licenses
so that the public can reuse the material as expected. Licensors should
clearly mark any material not subject to the license. This includes other
CC-licensed material, or material used under an exception or limitation
to copyright. More considerations for licensors.
.
Considerations for the public: By using one of our public licenses,
a licensor grants the public permission to use the licensed material
under specified terms and conditions. If the licensor’s permission is
not necessary for any reason–for example, because of any applicable
exception or limitation to copyright–then that use is not regulated
by the license. Our licenses grant only permissions under copyright and
certain other rights that a licensor has authority to grant. Use of the
licensed material may still be restricted for other reasons, including
because others have copyright or other rights in the material. A licensor
may make special requests, such as asking that all changes be marked or
described. Although not required by our licenses, you are encouraged
to respect those requests where reasonable. More considerations for
the public.
.
Creative Commons Attribution 4.0 International Public License
.
By exercising the Licensed Rights (defined below), You accept and agree to
be bound by the terms and conditions of this Creative Commons Attribution
4.0 International Public License ("Public License"). To the extent this
Public License may be interpreted as a contract, You are granted the
Licensed Rights in consideration of Your acceptance of these terms and
conditions, and the Licensor grants You such rights in consideration
of benefits the Licensor receives from making the Licensed Material
available under these terms and conditions.
.
Section 1 – Definitions.
.
a. Adapted Material means material subject to Copyright and Similar
Rights that is derived from or based upon the Licensed Material and
in which the Licensed Material is translated, altered, arranged,
transformed, or otherwise modified in a manner requiring permission
under the Copyright and Similar Rights held by the Licensor. For
purposes of this Public License, where the Licensed Material is
a musical work, performance, or sound recording, Adapted Material
is always produced where the Licensed Material is synched in timed
relation with a moving image.
.
b. Adapter's License means the license You apply to Your Copyright
and Similar Rights in Your contributions to Adapted Material in
accordance with the terms and conditions of this Public License.
.
c. Copyright and Similar Rights means copyright and/or similar
rights closely related to copyright including, without limitation,
performance, broadcast, sound recording, and Sui Generis
Database Rights, without regard to how the rights are labeled
or categorized. For purposes of this Public License, the rights
specified in Section 2(b)(1)-(2) are not Copyright and Similar
Rights.
.
d. Effective Technological Measures means those measures that,
in the absence of proper authority, may not be circumvented under
laws fulfilling obligations under Article 11 of the WIPO Copyright
Treaty adopted on December 20, 1996, and/or similar international
agreements.
.
e. Exceptions and Limitations means fair use, fair dealing, and/or
any other exception or limitation to Copyright and Similar Rights
that applies to Your use of the Licensed Material.
.
f. Licensed Material means the artistic or literary work, database,
or other material to which the Licensor applied this Public License.
.
g. Licensed Rights means the rights granted to You subject to the
terms and conditions of this Public License, which are limited
to all Copyright and Similar Rights that apply to Your use of the
Licensed Material and that the Licensor has authority to license.
.
h. Licensor means the individual(s) or entity(ies) granting rights
under this Public License.
.
i. Share means to provide material to the public by any means or
process that requires permission under the Licensed Rights, such
as reproduction, public display, public performance, distribution,
dissemination, communication, or importation, and to make material
available to the public including in ways that members of the public
may access the material from a place and at a time individually
chosen by them.
.
j. Sui Generis Database Rights means rights other than copyright
resulting from Directive 96/9/EC of the European Parliament and of
the Council of 11 March 1996 on the legal protection of databases,
as amended and/or succeeded, as well as other essentially equivalent
rights anywhere in the world.
.
k. You means the individual or entity exercising the Licensed Rights
under this Public License. Your has a corresponding meaning.
.
Section 2 – Scope.
.
a. License grant.
.
1. Subject to the terms and conditions of this Public License,
the Licensor hereby grants You a worldwide, royalty-free,
non-sublicensable, non-exclusive, irrevocable license to
exercise the Licensed Rights in the Licensed Material to:
.
A. reproduce and Share the Licensed Material, in whole
or in part; and
.
B. produce, reproduce, and Share Adapted Material.
.
2. Exceptions and Limitations. For the avoidance of doubt,
where Exceptions and Limitations apply to Your use, this
Public License does not apply, and You do not need to comply
with its terms and conditions.
.
3. Term. The term of this Public License is specified in
Section 6(a).
.
4. Media and formats; technical modifications allowed. The
Licensor authorizes You to exercise the Licensed Rights in
all media and formats whether now known or hereafter created,
and to make technical modifications necessary to do so. The
Licensor waives and/or agrees not to assert any right or
authority to forbid You from making technical modifications
necessary to exercise the Licensed Rights, including technical
modifications necessary to circumvent Effective Technological
Measures. For purposes of this Public License, simply making
modifications authorized by this Section 2(a)(4) never produces
Adapted Material.
.
5. Downstream recipients.
.
A. Offer from the Licensor – Licensed Material. Every
recipient of the Licensed Material automatically receives
an offer from the Licensor to exercise the Licensed Rights
under the terms and conditions of this Public License.
.
B. No downstream restrictions. You may not offer or
impose any additional or different terms or conditions
on, or apply any Effective Technological Measures to, the
Licensed Material if doing so restricts exercise of the
Licensed Rights by any recipient of the Licensed Material.
.
6. No endorsement. Nothing in this Public License constitutes
or may be construed as permission to assert or imply that You
are, or that Your use of the Licensed Material is, connected
with, or sponsored, endorsed, or granted official status by,
the Licensor or others designated to receive attribution as
provided in Section 3(a)(1)(A)(i).
.
b. Other rights.
.
1. Moral rights, such as the right of integrity, are not
licensed under this Public License, nor are publicity, privacy,
and/or other similar personality rights; however, to the extent
possible, the Licensor waives and/or agrees not to assert any
such rights held by the Licensor to the limited extent necessary
to allow You to exercise the Licensed Rights, but not otherwise.
.
2. Patent and trademark rights are not licensed under this
Public License.
.
3. To the extent possible, the Licensor waives any right to
collect royalties from You for the exercise of the Licensed
Rights, whether directly or through a collecting society under
any voluntary or waivable statutory or compulsory licensing
scheme. In all other cases the Licensor expressly reserves
any right to collect such royalties.
.
Section 3 – License Conditions.
.
Your exercise of the Licensed Rights is expressly made subject to the
following conditions.
.
a. Attribution.
.
1. If You Share the Licensed Material (including in modified
form), You must:
.
A. retain the following if it is supplied by the Licensor
with the Licensed Material:
.
i. identification of the creator(s) of the Licensed
Material and any others designated to receive
attribution, in any reasonable manner requested by
the Licensor (including by pseudonym if designated);
.
ii. a copyright notice;
.
iii. a notice that refers to this Public License;
.
iv. a notice that refers to the disclaimer of
warranties;
.
v. a URI or hyperlink to the Licensed Material to
the extent reasonably practicable;
.
B. indicate if You modified the Licensed Material and
retain an indication of any previous modifications; and
.
C. indicate the Licensed Material is licensed under this
Public License, and include the text of, or the URI or
hyperlink to, this Public License.
.
2. You may satisfy the conditions in Section 3(a)(1) in any
reasonable manner based on the medium, means, and context in
which You Share the Licensed Material. For example, it may
be reasonable to satisfy the conditions by providing a URI or
hyperlink to a resource that includes the required information.
.
3. If requested by the Licensor, You must remove any of the
information required by Section 3(a)(1)(A) to the extent
reasonably practicable.
.
4. If You Share Adapted Material You produce, the Adapter's
License You apply must not prevent recipients of the Adapted
Material from complying with this Public License.
.
Section 4 – Sui Generis Database Rights.
.
Where the Licensed Rights include Sui Generis Database Rights that apply
to Your use of the Licensed Material:
.
a. for the avoidance of doubt, Section 2(a)(1) grants You the right
to extract, reuse, reproduce, and Share all or a substantial portion
of the contents of the database;
.
b. if You include all or a substantial portion of the database
contents in a database in which You have Sui Generis Database Rights,
then the database in which You have Sui Generis Database Rights
(but not its individual contents) is Adapted Material; and
.
c. You must comply with the conditions in Section 3(a) if You Share
all or a substantial portion of the contents of the database.
For the avoidance of doubt, this Section 4 supplements and does not
replace Your obligations under this Public License where the Licensed
Rights include other Copyright and Similar Rights.
.
Section 5 – Disclaimer of Warranties and Limitation of Liability.
.
a. Unless otherwise separately undertaken by the Licensor, to the
extent possible, the Licensor offers the Licensed Material as-is
and as-available, and makes no representations or warranties
of any kind concerning the Licensed Material, whether express,
implied, statutory, or other. This includes, without limitation,
warranties of title, merchantability, fitness for a particular
purpose, non-infringement, absence of latent or other defects,
accuracy, or the presence or absence of errors, whether or not
known or discoverable. Where disclaimers of warranties are not
allowed in full or in part, this disclaimer may not apply to You.
.
b. To the extent possible, in no event will the Licensor be
liable to You on any legal theory (including, without limitation,
negligence) or otherwise for any direct, special, indirect,
incidental, consequential, punitive, exemplary, or other losses,
costs, expenses, or damages arising out of this Public License or use
of the Licensed Material, even if the Licensor has been advised of
the possibility of such losses, costs, expenses, or damages. Where
a limitation of liability is not allowed in full or in part, this
limitation may not apply to You.
.
c. The disclaimer of warranties and limitation of liability provided
above shall be interpreted in a manner that, to the extent possible,
most closely approximates an absolute disclaimer and waiver of
all liability.
.
Section 6 – Term and Termination.
.
a. This Public License applies for the term of the Copyright and
Similar Rights licensed here. However, if You fail to comply with
this Public License, then Your rights under this Public License
terminate automatically.
.
b. Where Your right to use the Licensed Material has terminated
under Section 6(a), it reinstates:
.
1. automatically as of the date the violation is cured,
provided it is cured within 30 days of Your discovery of the
violation; or
.
2. upon express reinstatement by the Licensor.
.
c. For the avoidance of doubt, this Section 6(b) does not affect
any right the Licensor may have to seek remedies for Your violations
of this Public License.
.
d. For the avoidance of doubt, the Licensor may also offer the
Licensed Material under separate terms or conditions or stop
distributing the Licensed Material at any time; however, doing so
will not terminate this Public License.
.
e. Sections 1, 5, 6, 7, and 8 survive termination of this Public
License.
.
Section 7 – Other Terms and Conditions.
.
a. The Licensor shall not be bound by any additional or different
terms or conditions communicated by You unless expressly agreed.
.
b. Any arrangements, understandings, or agreements regarding the
Licensed Material not stated herein are separate from and independent
of the terms and conditions of this Public License.
.
Section 8 – Interpretation.
.
a. For the avoidance of doubt, this Public License does not, and
shall not be interpreted to, reduce, limit, restrict, or impose
conditions on any use of the Licensed Material that could lawfully
be made without permission under this Public License.
.
b. To the extent possible, if any provision of this Public License
is deemed unenforceable, it shall be automatically reformed to the
minimum extent necessary to make it enforceable. If the provision
cannot be reformed, it shall be severed from this Public License
without affecting the enforceability of the remaining terms and
conditions.
.
c. No term or condition of this Public License will be waived and
no failure to comply consented to unless expressly agreed to by
the Licensor.
.
d. Nothing in this Public License constitutes or may be interpreted
as a limitation upon, or waiver of, any privileges and immunities
that apply to the Licensor or You, including from the legal processes
of any jurisdiction or authority.
.
Creative Commons is not a party to its public licenses. Notwithstanding,
Creative Commons may elect to apply one of its public licenses to material
it publishes and in those instances will be considered the “Licensor.”
Except for the limited purpose of indicating that material is shared
under a Creative Commons public license or as otherwise permitted by
the Creative Commons policies published at creativecommons.org/policies,
Creative Commons does not authorize the use of the trademark “Creative
Commons” or any other trademark or logo of Creative Commons without
its prior written consent including, without limitation, in connection
with any unauthorized modifications to any of its public licenses or
any other arrangements, understandings, or agreements concerning use of
licensed material. For the avoidance of doubt, this paragraph does not
form part of the public licenses.
.
Creative Commons may be contacted at creativecommons.org.
DFSG Assistant LLM REVIEW 0 blocker, 1 important, 1 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 1 hour ago.
Report
DFSG NEW review for wattsi version 0.0~git20260506.8b5e695+dfsg-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: No - Packaging is of good quality: Yes
- Issues: 0 blocker, 1 important, 1 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
The licences themselves are DFSG-free: Expat for the WHATWG/Google code, LGPL-2.1-or-later with the Free Pascal linking exception for the three FPC-derived files (a permissive-enough exception), and CC-BY-4.0 for the WHATWG tracking-vector SVG that the privacy patch embeds, with its full text in debian/copyright. The +dfsg repack is genuine: .gitignore, src/icon.jpeg and src/lib/debug.pas are gone from the tree, and no copy of the non-free wiki GetStackTrace code is left (only the replacement strings in src/lib/unixpaths.pas). debian/copyright is nevertheless inaccurate in its holders: the only catch-all stanza credits every file to Google, Inc., so the Debian packaging the maintainer wrote in 2026 is misattributed, and src/lib/heaptrc.patch, which reproduces FPC's heaptrc.pp with its Free Pascal copyright notice, is declared Expat.
Packaging
Good packaging: debhelper 14 with the plain dh $@ sequencer, Standards-Version: 4.7.4 (current against Policy 4.7.4.1), the arch-specific compilers and pandoc correctly in Build-Depends-Arch and only debhelper-compat in Build-Depends, every build dependency present in unstable. All seven patches carry DEP-3 headers with Forwarded, apply cleanly, and the ones that alter behaviour (version source, DFSG removal, build flags) are explained by debian/README.source. The man page is generated from debian/wattsi.1.md and installed through debian/wattsi.manpages; upstream/metadata, salsa-ci.yml, gbp.conf and source/format are all present and sane. The unusual 147~0.0~git… binary version from override_dh_gencontrol is deliberate, documented, and consistent with the dbgsym package's = ${binary:Version} dependency; the only real gap is the absence of an autopkgtest, and the in-tree test harness cannot serve as one because it needs the unshipped html5lib-tests.
Issues
important licensing 1. debian/copyright credits the Debian packaging to Google, Inc. and never names Fab Stz ◂
- Files:
debian/copyright:20-22,debian/rules,debian/control,debian/changelog,debian/patches/debian-set-real-version.patch:1-3,debian/wattsi.1.md,debian/salsa-ci.yml - Basis: checked, in the package or with a reference tool
- Evidence: The only catch-all is
Files: */Copyright: Google, Inc./License: Expat. The packaging is the maintainer's own work with his own dates, e.g.debian/patches/debian-set-real-version.patchbeginsFrom: Fab Stz <fabstz-it@yahoo.fr>/Date: Thu, 9 Apr 2026 23:01:50 +0200. - Problem:
Files: *matches every path, includingdebian/*(copyright-format 6.9), sodebian/rules,debian/control,debian/changelog, the sevendebian/patches/*and the hand-writtendebian/wattsi.1.mdare described as Google's work under Expat. Nothing in the file mentions the Debian maintainer or the licence of the packaging, so the copyright information for those files is wrong even though the source stanzas are not. - Fix: Add a stanza after the upstream ones, e.g.
Files: debian/*withCopyright: 2026, Fab Stz <fabstz-it@yahoo.fr>andLicense: Expat(or whichever licence the packaging is meant to carry).
minor licensing 2. src/lib/heaptrc.patch contains FPC's heaptrc.pp under its Free Pascal copyright but is covered only by the Expat src/lib/* stanza ◂
- Files:
debian/copyright:32-35,debian/copyright:43-46,src/lib/heaptrc.patch:11-13 - Basis: checked, in the package or with a reference tool
- Evidence: The patch quotes
This file is part of the Free Pascal run time library.andCopyright (c) 1999-2000 by the Free Pascal development team..Files: src/lib/heaptrc.ppgives that fileLGPL-2.1-or-later with linking-exception exception, but the pattern names the single pathheaptrc.pponly, soheaptrc.patchfalls underFiles: src/lib/*=Copyright: 2014, Google, Inc. / 2015, Ian Hickson./License: Expat. - Problem: The file is a diff against FPC's
heaptrc.ppand reproduces a substantial part of it together with FPC's copyright notice, so recording Google and Ian Hickson as its holders and Expat as its licence is inaccurate. The licence is free, so nothing about it is non-DFSG. - Fix: Widen the stanza to
Files: src/lib/heaptrc.pp src/lib/heaptrc.patch(or add a stanza for the patch) with the sameLGPL-2.1-or-later with linking-exception exceptionlicence and the Free Pascal copyright line.
Verified ◂
- Read all of
debian/(control, rules, changelog, copyright, install, clean, wattsi.manpages, wattsi.1.md, README.source, gbp.conf, salsa-ci.yml, set_version.sh, source/format, upstream/metadata,patches/seriesand all seven patches), and every upstream file that carries a licence, copyright or provenance notice:LICENSE,src/LICENSE,src/lib/README,src/lib/base64encoder.pas,src/lib/heaptrc.pp,src/lib/heaptrc.patch,src/lib/filter.pl,src/html/entities/README. - Every holder the scan found is named in debian/copyright under a stanza that matches its file: Google, Inc.; Ian Hickson; the Free Pascal development team; Sebastian Guenther; Michael Van Canneyt; Florian Klaempfl; WHATWG (Apple, Google, Mozilla, Microsoft). No other copyright or licence wording exists in the tree (grep over all upstream files for copyright/(C)/©/SPDX/licence names/GPL/LGPL/Apache/MPL/public domain).
Files-Excludednames exactly the three paths absent from the tree (.gitignore,src/icon.jpeg,src/lib/debug.pas), and the reason in the header Comment matches the removed file. No occurrence of the wiki-derivedGetStackTraceremains;src/lib/unixutils.pasonly prints a replacement message, and the two other{$IFDEF DEBUG} debugreferences (src/lib/autostorable.pas:25,src/html/test.pas:8) are in units that are not compiled by the release build.src/LICENSEis the provenance note forsrc/icon.jpeg, which the repack excludes; nothing else in the package references that image.src/html/entities/entities.inc(33040 lines) is generated code, but both its input (entities.json) and its generator (src/html/entities/preprocessor.pas) are shipped, so the preferred form for modification is present.src/lib/tests/json-*.jsonandresutils.txtare test data registered as FPCtestdataresources byjson.rc/resutils.rc;src/html/test.pasis a standalone test program that is not built and whose data paths (/home/ianh/...) are dead.- The base64 SVG added by the privacy patch is the WHATWG asset named in the patch; the
src/wattsi.passtanza carriesCC-BY-4.0and the full CC-BY-4.0 text follows. The in-source comment atsrc/wattsi.pas:1708is truncated atFile is originally licensed under, but the licence is documented in debian/copyright. - Checked against debhelper 14.5 and its sources: at compat 14
dh_gencontroladds${misc:Depends},${shlibs:Depends}and${fpc:Static-Built-Using}to their fields itself and strips a field's trailing comma;dh_auto_installanddh_auto_testdo nothing because the upstream Makefile has noinstall,testorchecktarget;execute_before_dh_gencontrolruns before dh_gencontrol reads the substvars, sofpc-dependsoutput is used. - Build deps exist in unstable: debhelper 14.5 (provides
debhelper-compat (= 14)), fp-compiler, fp-units-fcl, fp-units-net, fp-utils, pandoc 3.11-1.Standards-Version: 4.7.4matches the reviewing system's Policy 4.7.4.1. - uscan found upstream releases with
debian/watch; a newer upstream version is available (upstream0.0~git20260914.49fc4eb, packaged0.0~git20260506.8b5e695+dfsg), which is not a fault of the package. - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (LGPL-2.1).
Not confirmed ◂
fpc-depends, run indebian/rules, could not be verified: fpc is not installed on the reviewing system, there is no man page for it, and the fp-utils package description lists only data2inc, fpcmake, h2pas, plex/pyacc, ppdep, ppudump, ppufiles, ppumove and ptop. If the archive's fpc does not ship it, the build stops at dh_gencontrol; a build would show it either way.- The licence of
src/html/entities/entities.json: the README beside it gives only the URLhttps://html.spec.whatwg.org/entities.jsonand the file states no licence of its own, soFiles: *records it as Google/Expat. The HTML Standard is WHATWG's CC-BY-4.0 work (the copyright file itself names WHATWG for CC-BY-4.0 material), but I could not fetch the upstream file to see what licence, if any, is attached to this data, and it may be uncopyrightable data in any case. - Hardening: the release build uses FPC's own
@hardening(debian-build-03) rather than dpkg-buildflags, anddebian/salsa-ci.ymlsetsSALSA_CI_DISABLE_BLHC: 1, so I could not check what hardening the resulting binary actually gets. Nothing here is verifiable without the FPC toolchain.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader rejected this upload in response to the review.
Review Information
rejected — allocated to dfsg-uploader 0 hours ago, started 0 hours ago, completed 0 hours ago.
Final Comment
The uploader rejected this upload in response to the automated (LLM) review of it, so that they can fix the problems it found and upload again.