Review: yq-go 4.53.2-1
New Package Report
.changes
| Changed-By | Christoph Martin |
|---|---|
| Architecture | source amd64 |
| Distribution | experimental |
| Date | Mon, 11 May 2026 18:06:49 +0200 |
| Source | yq-go |
| Version | 4.53.2-1 |
Changelog
yq-go (4.53.2-1) experimental; urgency=medium . [ ChangZhuo Chen (陳昌倬) ] * Initial release (Closes: #908117) * Update Build-Depends * Update Maintainer * Patch import path . [ Christoph Martin ] * update debian/* files to dh-make-golang versions * New upstream version 4.53.2 * fix auto_test * add alternates to yq * add help2man generated manpage
.dsc
| Section | utils |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | yq-go deb utils optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Source: https://github.com/mikefarah/yq Upstream-Name: yq Files: * Copyright: Copyright (c) 2017 Mike Farah License: Expat Files: debian/* Copyright: 2026 Christoph Martin <chrism@debian.org> License: Expat Comment: Debian packaging is licensed under the same terms as upstream License: Expat Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
Review Information
rejected — allocated to siretart 17 days ago, started 17 days ago, completed 17 days ago.
Final Comment
Thanks for your diligence in bringing yq-go to the archive. I've completed a DFSG review of version 4.53.2-1 and noticed a few things that need to be addressed in debian/copyright before this can be accepted.
Specifically, scripts/shunit2 (Apache-2.0, Kate Ward) and scripts/release-deb.sh (Roberto Mier Escandón) are currently missing their respective stanzas in the machine-readable copyright file. These omissions are unfortunately a reason for rejection at this stage.
I noticed a slight slip in the following areas:
scripts/shunit2is an embedded copy of the shunit2 framework. It is licensed under Apache-2.0 and carries a copyright from Kate Ward (2008-2020). This needs its own stanza and the Apache-2.0 license text (or a reference to/usr/share/common-licenses/Apache-2.0).scripts/release-deb.shcontains a copyright statement for Roberto Mier Escandón (2021). While we can assume this is under the same Expat license as the rest of the package, the copyright holder must still be explicitly listed indebian/copyrightto comply with the license terms.
Additionally, while not a DFSG violation, scripts/shunit2 is an embedded code copy. In Debian, we generally prefer to use the packaged version of such tools, but if it must be bundled, it definitely needs to be fully documented.
Once these entries are added to debian/copyright, the package should be good to go from a licensing perspective.
-rt
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 4.53.2+ds-1 | 1f0bf711… | 2026-05-18 11:27 | 2026-05-18 11:36 | siretart | accepted | VIEW |
| 4.53.2-2 | dd6cca56… | 2026-05-13 14:52 | 2026-05-13 19:30 | siretart | rejected | VIEW |
| 4.53.2-1 | 4f3ebe3d… | 2026-05-13 09:38 | 2026-05-13 10:12 | siretart | rejected | VIEW |
Public Notes
Search for authors
Command: ag -i 'copyright .* (by|rights|reserved)[. ]' | sed -e 's/^.*Copyright //i' -e 's/\(20\|19\)[0-9][0-9][, -]*//g' -e 's/[., ]*ALL RIGHTS RESERVED.*$//i' | sort -i | uniq -i
Exit code: 0
Kate Ward
Missed Author Check
Command: dnq author-check -prepare
Exit code: 0
Author check: scanned 543 files.
NOT IN debian/copyright (2):
Kate Ward
scripts/shunit2:4
Roberto Mier Escandón <rmescandon@gmail.com>
scripts/release-deb.sh:3
Result: ATTENTION REQUIRED — 2 authors not in debian/copyright