Review: zam-plugins 4.5+ds-4
New Package Report
.changes
| Source | zam-plugins |
|---|---|
| Version | 4.5+ds-4 |
| Changed-By | Dennis Braun <snd@debian.org> |
| Architecture | source amd64 all |
| Distribution | unstable |
| Date | Sat, 07 Nov 2026 17:33:27 +0100 |
Changelog
zam-plugins (4.5+ds-4) unstable; urgency=medium . * Add ZamPiano files under STK-4.3 license * debian/copyright: CC-BY --> CC-BY-4.0 * Bump d/copyright years * Add libfftw3-dev to B-Ds * Once again, update the plugin list in the descriptions
.dsc
| Component | main |
|---|---|
| Package-List | zam-plugins deb sound optional arch=all zam-plugins-clap deb sound optional arch=any zam-plugins-jack deb sound optional arch=any zam-plugins-ladspa deb sound optional arch=any zam-plugins-lv2 deb sound optional arch=any zam-plugins-vst deb sound optional arch=any zam-plugins-vst3 deb sound optional arch=any |
| Section | sound |
| Priority | optional |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: zam-plugins
Upstream-Contact: Damien Zammit <damien@zamaudio.com>
Source: https://github.com/zamaudio/zam-plugins
Comment: We remove ttf fonts because of no license
and the lib dir and we use zita-convolver4 from debian.
Files-Excluded:
lib
plugins/*/artwork/Allstar4.ttf
plugins/*/artwork/Amperzand.ttf
Files: *
Copyright: 2013-2026 Damien Zammit <damien@zamaudio.com>
License: GPL-2+
Files: debian/*
Copyright:
2013-2017 Jaromír Mikeš <mira.mikes@seznam.cz>
2020-2026 Dennis Braun <snd@debian.org>
2023 Olivier Humbert <trembuh@tuxfamily.org>
License: GPL-2+
Files:
plugins/ZamChild670/generatedwdfutilities.h
plugins/ZamChild670/sidechainamplifier.cpp
plugins/ZamChild670/sidechainamplifier.h
plugins/ZamChild670/tubemodel.cpp
plugins/ZamChild670/tubemodel.h
plugins/ZamChild670/variablemuamplifier.cpp
plugins/ZamChild670/variablemuamplifier.h
plugins/ZamChild670/wavechild670.cpp
plugins/ZamChild670/wavechild670.h
plugins/ZamChild670/wdfcircuits.cpp
plugins/ZamChild670/wdfcircuits.h
Copyright: 2012 Peter Raffensperger
License: GPL-2
Files:
plugins/ZamNoise/Denoise.cpp
plugins/ZamNoise/Denoise.hpp
Copyright: 2001 Jeffrey J. Welty
License: GPL-2+
Files:
plugins/ZamPiano/instrument.hpp
plugins/ZamPiano/PianoNote.cpp
Copyright:
2011 Romain Michon <rmichon@ccrma.stanford.edu>
License: STK-4.3
Files:
plugins/ZamVerb/convolution.hpp
plugins/ZamVerb/convolution.cpp
plugins/ZamHeadX2/convolution.hpp
plugins/ZamHeadX2/convolution.cpp
Copyright:
2012 Robin Gareus <robin@gareus.org>
2017 Damien Zammit <damien@zamaudio.com>
License: GPL-2+
Files: plugins/ZaMaximX2/artwork/zamaximx2.svg
plugins/ZaMultiComp/artwork/zamulticomp.svg
plugins/ZaMultiCompX2/artwork/zamulticompx2.svg
plugins/ZamAutoSat/artwork/zamautosat.svg
plugins/ZamChild670/artwork/zamchild670.svg
plugins/ZamComp/artwork/zamcomp.svg
plugins/ZamCompX2/artwork/zamcompx2.svg
plugins/ZamDelay/artwork/zamdelay.svg
plugins/ZamEcho/artwork/zamecho.svg
plugins/ZamDynamicEQ/artwork/zamdynamiceq.svg
plugins/ZamEQ2/artwork/zameq2.svg
plugins/ZamGEQ31/artwork/zamgeq31.svg
plugins/ZamGate/artwork/zamgate.svg
plugins/ZamGateX2/artwork/zamgatex2.svg
plugins/ZamGrains/artwork/zamgrains.svg
plugins/ZamHeadX2/artwork/zamheadx2.svg
plugins/ZamNoise/artwork/zamnoise.svg
plugins/ZamPhono/artwork/zamphono.svg
plugins/ZamPiano/artwork/zampiano.svg
plugins/ZamSFZ/artwork/zamsfz.svg
plugins/ZamSynth/artwork/zamsynth.svg
plugins/ZamTube/artwork/zamtube.svg
plugins/ZamVerb/artwork/zamverb.svg
Copyright: 2013-2022 Damien Zammit <damien@zamaudio.com>
License: CC-BY-4.0
Files: plugins/ZamNoise/bessel.inc
Copyright: 1984, 1987, 2000 Stephen L. Moshier
License: Cephes
License: Cephes
Cephes Math Library Release 2.8: June, 2000
Copyright 1984, 1987, 2000 by Stephen L. Moshier
.
Some software in this archive may be from the book _Methods and
Programs for Mathematical Functions_ (Prentice-Hall, 1989) or
from the Cephes Mathematical Library, a commercial product. In
either event, it is copyrighted by the author. What you see here
may be used freely but it comes with no support or guarantee.
.
The two known misprints in the book are repaired here in the
source listings for the gamma function and the incomplete beta
integral.
Files: plugins/ZamSFZ/libsfz/sfz.cpp
plugins/ZamSFZ/libsfz/sfz.h
Copyright: 2012 Steve Folta
2008-2009 Anders Dahnielson
Comment: The code was taken from the SFZero project. The license
information can be found in the NOTICE.SFZero file within the source code
License: Expat
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
.
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS
ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
DEALINGS IN THE SOFTWARE.
Files: widgets/ZamWidgets.hpp
Copyright: 2012-2016 Filipe Coelho <falktx@falktx.com>
License: ISC
License: GPL-2
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; version 2 of the License.
.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
.
On Debian systems, the complete text of the GNU General Public
License version 2 can be found in `/usr/share/common-licenses/GPL-2'.
License: GPL-2+
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 2 of the License, or
(at your option) any later version.
.
This package is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
.
On Debian systems, the complete text of the GNU General Public
License version 2 can be found in `/usr/share/common-licenses/GPL-2'.
.
You should have received a copy of the GNU General Public License
along with this program. If not, see <https://www.gnu.org/licenses/>.
License: CC-BY-4.0
http://creativecommons.org/licenses/by/4.0/
Creative Commons Attribution 4.0 International Public License
.
By exercising the Licensed Rights (defined below), You accept and agree
to be bound by the terms and conditions of this Creative Commons
Attribution 4.0 International Public License ("Public License"). To the
extent this Public License may be interpreted as a contract, You are
granted the Licensed Rights in consideration of Your acceptance of
these terms and conditions, and the Licensor grants You such rights in
consideration of benefits the Licensor receives from making the
Licensed Material available under these terms and conditions.
.
Section 1 -- Definitions.
.
a. Adapted Material means material subject to Copyright and Similar
Rights that is derived from or based upon the Licensed Material
and in which the Licensed Material is translated, altered,
arranged, transformed, or otherwise modified in a manner requiring
permission under the Copyright and Similar Rights held by the
Licensor. For purposes of this Public License, where the Licensed
Material is a musical work, performance, or sound recording,
Adapted Material is always produced where the Licensed Material is
synched in timed relation with a moving image.
.
b. Adapter's License means the license You apply to Your Copyright
and Similar Rights in Your contributions to Adapted Material in
accordance with the terms and conditions of this Public License.
.
c. Copyright and Similar Rights means copyright and/or similar rights
closely related to copyright including, without limitation,
performance, broadcast, sound recording, and Sui Generis Database
Rights, without regard to how the rights are labeled or
categorized. For purposes of this Public License, the rights
specified in Section 2(b)(1)-(2) are not Copyright and Similar
Rights.
.
d. Effective Technological Measures means those measures that, in the
absence of proper authority, may not be circumvented under laws
fulfilling obligations under Article 11 of the WIPO Copyright
Treaty adopted on December 20, 1996, and/or similar international
agreements.
.
e. Exceptions and Limitations means fair use, fair dealing, and/or
any other exception or limitation to Copyright and Similar Rights
that applies to Your use of the Licensed Material.
.
f. Licensed Material means the artistic or literary work, database,
or other material to which the Licensor applied this Public
License.
.
g. Licensed Rights means the rights granted to You subject to the
terms and conditions of this Public License, which are limited to
all Copyright and Similar Rights that apply to Your use of the
Licensed Material and that the Licensor has authority to license.
.
h. Licensor means the individual(s) or entity(ies) granting rights
under this Public License.
.
i. Share means to provide material to the public by any means or
process that requires permission under the Licensed Rights, such
as reproduction, public display, public performance, distribution,
dissemination, communication, or importation, and to make material
available to the public including in ways that members of the
public may access the material from a place and at a time
individually chosen by them.
.
j. Sui Generis Database Rights means rights other than copyright
resulting from Directive 96/9/EC of the European Parliament and of
the Council of 11 March 1996 on the legal protection of databases,
as amended and/or succeeded, as well as other essentially
equivalent rights anywhere in the world.
.
k. You means the individual or entity exercising the Licensed Rights
under this Public License. Your has a corresponding meaning.
.
Section 2 -- Scope.
.
a. License grant.
.
1. Subject to the terms and conditions of this Public License,
the Licensor hereby grants You a worldwide, royalty-free,
non-sublicensable, non-exclusive, irrevocable license to
exercise the Licensed Rights in the Licensed Material to:
.
a. reproduce and Share the Licensed Material, in whole or
in part; and
.
b. produce, reproduce, and Share Adapted Material.
.
2. Exceptions and Limitations. For the avoidance of doubt, where
Exceptions and Limitations apply to Your use, this Public
License does not apply, and You do not need to comply with
its terms and conditions.
.
3. Term. The term of this Public License is specified in Section
6(a).
.
4. Media and formats; technical modifications allowed. The
Licensor authorizes You to exercise the Licensed Rights in
all media and formats whether now known or hereafter created,
and to make technical modifications necessary to do so. The
Licensor waives and/or agrees not to assert any right or
authority to forbid You from making technical modifications
necessary to exercise the Licensed Rights, including
technical modifications necessary to circumvent Effective
Technological Measures. For purposes of this Public License,
simply making modifications authorized by this Section 2(a)
(4) never produces Adapted Material.
.
5. Downstream recipients.
.
a. Offer from the Licensor -- Licensed Material. Every
recipient of the Licensed Material automatically
receives an offer from the Licensor to exercise the
Licensed Rights under the terms and conditions of this
Public License.
.
b. No downstream restrictions. You may not offer or impose
any additional or different terms or conditions on, or
apply any Effective Technological Measures to, the
Licensed Material if doing so restricts exercise of the
Licensed Rights by any recipient of the Licensed
Material.
.
6. No endorsement. Nothing in this Public License constitutes or
may be construed as permission to assert or imply that You
are, or that Your use of the Licensed Material is, connected
with, or sponsored, endorsed, or granted official status by,
the Licensor or others designated to receive attribution as
provided in Section 3(a)(1)(A)(i).
.
b. Other rights.
.
1. Moral rights, such as the right of integrity, are not
licensed under this Public License, nor are publicity,
privacy, and/or other similar personality rights; however, to
the extent possible, the Licensor waives and/or agrees not to
assert any such rights held by the Licensor to the limited
extent necessary to allow You to exercise the Licensed
Rights, but not otherwise.
.
2. Patent and trademark rights are not licensed under this
Public License.
.
3. To the extent possible, the Licensor waives any right to
collect royalties from You for the exercise of the Licensed
Rights, whether directly or through a collecting society
under any voluntary or waivable statutory or compulsory
licensing scheme. In all other cases the Licensor expressly
reserves any right to collect such royalties.
.
Section 3 -- License Conditions.
.
Your exercise of the Licensed Rights is expressly made subject to the
following conditions.
.
a. Attribution.
.
1. If You Share the Licensed Material (including in modified
form), You must:
.
a. retain the following if it is supplied by the Licensor
with the Licensed Material:
.
i. identification of the creator(s) of the Licensed
Material and any others designated to receive
attribution, in any reasonable manner requested by
the Licensor (including by pseudonym if
designated);
.
ii. a copyright notice;
.
iii. a notice that refers to this Public License;
.
iv. a notice that refers to the disclaimer of
warranties;
.
v. a URI or hyperlink to the Licensed Material to the
extent reasonably practicable;
.
b. indicate if You modified the Licensed Material and
retain an indication of any previous modifications; and
.
c. indicate the Licensed Material is licensed under this
Public License, and include the text of, or the URI or
hyperlink to, this Public License.
.
2. You may satisfy the conditions in Section 3(a)(1) in any
reasonable manner based on the medium, means, and context in
which You Share the Licensed Material. For example, it may be
reasonable to satisfy the conditions by providing a URI or
hyperlink to a resource that includes the required
information.
.
3. If requested by the Licensor, You must remove any of the
information required by Section 3(a)(1)(A) to the extent
reasonably practicable.
.
4. If You Share Adapted Material You produce, the Adapter's
License You apply must not prevent recipients of the Adapted
Material from complying with this Public License.
.
Section 4 -- Sui Generis Database Rights.
.
Where the Licensed Rights include Sui Generis Database Rights that
apply to Your use of the Licensed Material:
.
a. for the avoidance of doubt, Section 2(a)(1) grants You the right
to extract, reuse, reproduce, and Share all or a substantial
portion of the contents of the database;
.
b. if You include all or a substantial portion of the database
contents in a database in which You have Sui Generis Database
Rights, then the database in which You have Sui Generis Database
Rights (but not its individual contents) is Adapted Material; and
.
c. You must comply with the conditions in Section 3(a) if You Share
all or a substantial portion of the contents of the database.
.
For the avoidance of doubt, this Section 4 supplements and does not
replace Your obligations under this Public License where the Licensed
Rights include other Copyright and Similar Rights.
.
Section 5 -- Disclaimer of Warranties and Limitation of Liability.
.
a. UNLESS OTHERWISE SEPARATELY UNDERTAKEN BY THE LICENSOR, TO THE
EXTENT POSSIBLE, THE LICENSOR OFFERS THE LICENSED MATERIAL AS-IS
AND AS-AVAILABLE, AND MAKES NO REPRESENTATIONS OR WARRANTIES OF
ANY KIND CONCERNING THE LICENSED MATERIAL, WHETHER EXPRESS,
IMPLIED, STATUTORY, OR OTHER. THIS INCLUDES, WITHOUT LIMITATION,
WARRANTIES OF TITLE, MERCHANTABILITY, FITNESS FOR A PARTICULAR
PURPOSE, NON-INFRINGEMENT, ABSENCE OF LATENT OR OTHER DEFECTS,
ACCURACY, OR THE PRESENCE OR ABSENCE OF ERRORS, WHETHER OR NOT
KNOWN OR DISCOVERABLE. WHERE DISCLAIMERS OF WARRANTIES ARE NOT
ALLOWED IN FULL OR IN PART, THIS DISCLAIMER MAY NOT APPLY TO YOU.
.
b. TO THE EXTENT POSSIBLE, IN NO EVENT WILL THE LICENSOR BE LIABLE
TO YOU ON ANY LEGAL THEORY (INCLUDING, WITHOUT LIMITATION,
NEGLIGENCE) OR OTHERWISE FOR ANY DIRECT, SPECIAL, INDIRECT,
INCIDENTAL, CONSEQUENTIAL, PUNITIVE, EXEMPLARY, OR OTHER LOSSES,
COSTS, EXPENSES, OR DAMAGES ARISING OUT OF THIS PUBLIC LICENSE OR
USE OF THE LICENSED MATERIAL, EVEN IF THE LICENSOR HAS BEEN
ADVISED OF THE POSSIBILITY OF SUCH LOSSES, COSTS, EXPENSES, OR
DAMAGES. WHERE A LIMITATION OF LIABILITY IS NOT ALLOWED IN FULL OR
IN PART, THIS LIMITATION MAY NOT APPLY TO YOU.
.
c. The disclaimer of warranties and limitation of liability provided
above shall be interpreted in a manner that, to the extent
possible, most closely approximates an absolute disclaimer and
waiver of all liability.
.
Section 6 -- Term and Termination.
.
a. This Public License applies for the term of the Copyright and
Similar Rights licensed here. However, if You fail to comply with
this Public License, then Your rights under this Public License
terminate automatically.
.
b. Where Your right to use the Licensed Material has terminated under
Section 6(a), it reinstates:
.
1. automatically as of the date the violation is cured, provided
it is cured within 30 days of Your discovery of the
violation; or
.
2. upon express reinstatement by the Licensor.
.
For the avoidance of doubt, this Section 6(b) does not affect any
right the Licensor may have to seek remedies for Your violations
of this Public License.
.
c. For the avoidance of doubt, the Licensor may also offer the
Licensed Material under separate terms or conditions or stop
distributing the Licensed Material at any time; however, doing so
will not terminate this Public License.
.
d. Sections 1, 5, 6, 7, and 8 survive termination of this Public
License.
.
Section 7 -- Other Terms and Conditions.
.
a. The Licensor shall not be bound by any additional or different
terms or conditions communicated by You unless expressly agreed.
.
b. Any arrangements, understandings, or agreements regarding the
Licensed Material not stated herein are separate from and
independent of the terms and conditions of this Public License.
.
Section 8 -- Interpretation.
.
a. For the avoidance of doubt, this Public License does not, and
shall not be interpreted to, reduce, limit, restrict, or impose
conditions on any use of the Licensed Material that could lawfully
be made without permission under this Public License.
.
b. To the extent possible, if any provision of this Public License is
deemed unenforceable, it shall be automatically reformed to the
minimum extent necessary to make it enforceable. If the provision
cannot be reformed, it shall be severed from this Public License
without affecting the enforceability of the remaining terms and
conditions.
.
c. No term or condition of this Public License will be waived and no
failure to comply consented to unless expressly agreed to by the
Licensor.
.
d. Nothing in this Public License constitutes or may be interpreted
as a limitation upon, or waiver of, any privileges and immunities
that apply to the Licensor or You, including from the legal
processes of any jurisdiction or authority.
License: ISC
Permission to use, copy, modify, and/or distribute this software for any purpose with
or without fee is hereby granted, provided that the above copyright notice and this
permission notice appear in all copies.
.
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD
TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN
NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL
DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER
IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
License: STK-4.3
Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files
(the "Software"), to deal in the Software without restriction,
including without limitation the rights to use, copy, modify, merge,
publish, distribute, sublicense, and/or sell copies of the Software,
and to permit persons to whom the Software is furnished to do so,
subject to the following conditions:
.
The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.
.
Any person wishing to distribute modifications to the Software is
requested to send the modifications to the original developer so that
they can be incorporated into the canonical version. This is, however,
not a binding provision of this license.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR
ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF
CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 4 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 14 days ago.
Report
DFSG NEW review for zam-plugins version 4.5+ds-4
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 4 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
The tree is DFSG-free throughout: GPL-2 / GPL-2+ for Damien Zammit's code, GPL-2-only for the (unbuilt) Wavechild670 files, Expat for libsfz, ISC for ZamWidgets.hpp and the DPF notice, STK-4.3 for the ZamPiano tables, the Cephes permission for bessel.inc and CC-BY-4.0 for the 23 SVG artwork files -- all accepted licences, all with their texts present or a /usr/share/common-licenses pointer. The two unlicensed TrueType fonts and the bundled zita-convolver library are gone from the tree and declared in Files-Excluded, and the code that uses them (the PNG artwork compiled into the plugins, libzita-convolver-dev) is licensed. debian/copyright is DEP-5 and matches the file notices, with one gap: NOTICE.DPF and NOTICE.SFZero match no stanza and so fall to Files: *, which names Damien Zammit and GPL-2+ for files that carry Filipe Coelho's ISC notice and Steve Folta's Expat notice.
Packaging
The split into six real packages plus a metapackage is done correctly: install files cover exactly what make install writes, the sub-packages carry Breaks+Replaces on the old single zam-plugins, the descriptions' plugin lists match the plugins actually built and the plugin formats each Makefile enables, dependencies are complete (libx11-dev arrives through libgl-dev -> libglx-dev) and present in the archive, dh compat 14 with LTO/bindnow, Standards-Version current at 4.7.4 against Policy 4.7.4.1, and a real autopkgtest. What is left is debris from the recent churn: a misspelled 22 KB duplicate of debian/copyright in debian/, four lintian-overrides files whose override line has been replaced by a copy of lintian's own report, and a meaningless Replaces of the metapackage on itself.
Issues
minor licensing 1. Files: * claims NOTICE.DPF and NOTICE.SFZero as Damien Zammit's GPL-2+ work, but they carry Filipe Coelho's ISC and Steve Folta's Expat notices ◂
- Files:
debian/copyright:12-15,NOTICE.DPF,NOTICE.SFZero - Basis: checked, in the package or with a reference tool
- Evidence: NOTICE.DPF:
Copyright (C) 2012-2014 Filipe Coelho <falktx@falktx.com>andPermission to use, copy, modify, and/or distribute this software for any purpose with or without fee is hereby granted, provided that the above copyright notice and this permission notice appear in all copies.NOTICE.SFZero:Copyright (C) 2012 Steve FoltaandPermission is hereby granted, free of charge, to any person obtaining a copy .... No Files stanza of debian/copyright names either file, so the catch-allFiles: *(Copyright: 2013-2026 Damien Zammit, License: GPL-2+) applies to them. - Problem: debian/copyright therefore names the wrong holder and the wrong licence for two files it ships. Both files are third-party attribution notices, and the ISC and Expat texts are already in the file for other stanzas, so this is a stanza-coverage error rather than a licensing problem for the binaries. An earlier copy of the file (debian/copytight-decopy) had
Files: NOTICE.SFZero plugins/ZamSFZ/libsfz/*(Expat) andFiles: NOTICE.DPF widgets/*(ISC); the current file narrowed those patterns to the code only and lost the notices. - Fix: Add NOTICE.DPF to the ISC stanza (or give it its own Files stanza with Copyright Filipe Coelho, License: ISC) and NOTICE.SFZero to the Expat stanza (Copyright Steve Folta, License: Expat).
minor packaging 2. debian/copytight-decopy is an accidentally committed, misspelled duplicate of debian/copyright ◂
- Files:
debian/copytight-decopy - Basis: checked, in the package or with a reference tool
- Evidence: Same
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/, sameComment: We remove ttf fonts because of no licenseand sameFiles-Excludedblock as debian/copyright, but with broken Copyright fields such asinbuf[c], n_samples * sizeof (float))and2012, Peter RaffenspergerunderFiles: *. - Problem: It is a 499-line leftover from the copyright-file rewrite (its name is a typo of
copyright). Nothing in debian/rules or the install files refers to it and dh_installdocs does not install it, so it only bloats the source package -- but it contains copyright and licence statements that contradict debian/copyright, in a directory whose every file is supposed to be the packaging. - Fix: Delete debian/copytight-decopy.
minor packaging 3. Four lintian-overrides files contain a copy of lintian's own report line in place of the override they describe ◂
- Files:
debian/zam-plugins-lv2.lintian-overrides:4,debian/zam-plugins-clap.lintian-overrides:4,debian/zam-plugins-vst.lintian-overrides:4,debian/zam-plugins-vst3.lintian-overrides:4,debian/zam-plugins-ladspa.lintian-overrides:2 - Basis: checked, in the package or with a reference tool
- Evidence:
# Fonts are embedded specifically for rendering the plugin GUI artworkis followed byduplicate-override-context (lines 4 5) [usr/share/lintian/overrides/zam-plugins-lv2](and the same, at lines 2/3, in the ladspa file). - Problem: That line is a lintian tag from its own output, not a lintian override: it names a tag that never fires and suppresses nothing, and the override its comment introduces (the tag for the DejaVu font that DPF embeds in the GUI) is missing altogether. So the files neither do what the comments say nor parse as intended.
- Fix: Replace the pasted line with the real override for the embedded-font tag on the files those packages ship, or drop the comment and the line.
minor packaging 4. The metapackage zam-plugins Replaces its own older versions ◂
- Files:
debian/control:33-34 - Basis: checked, in the package or with a reference tool
- Evidence:
Package: zam-plugins/Architecture: all...Replaces: zam-plugins (<< 4.5+ds-3) - Problem: A package cannot take files over from an older version of itself, so this Replaces does nothing. The field that matters for the package split is on the packages that now own the files, and all six of them correctly have
Breaks: zam-plugins (<< 4.5+ds-3)withReplaces:of the same version. It is a leftover from the split (the changelog for 4.5+ds-2 records removing the metapackage's Breaks). - Fix: Drop the Replaces field from the zam-plugins metapackage.
Verified ◂
- debian/copyright read in full: DEP-5 with
Format: ... 1.0, Upstream-Name/Source/Contact, a Comment and a two-entry Files-Excluded, then stanzas for*,debian/*, the ten ZamChild670 files, Denoise.cpp/.hpp, instrument.hpp and PianoNote.cpp, the two convolution.cpp/.hpp pairs, the 23 SVGs, bessel.inc, libsfz/sfz.cpp/.h and widgets/ZamWidgets.hpp, plus stand-alone licence texts for GPL-2, GPL-2+, CC-BY-4.0, ISC, STK-4.3, Expat and Cephes. - Every plugin source header was read or grepped: all Damien Zammit code says
either version 2 of the License, or (at your option) any later version, matching the GPL-2+ of Files: * and the GPL-2 text of COPYING; the files with other notices (Raffensperger GPL-2, Welty GPL-2+, Gareus/Damien GPL-2+, Michon STK-4.3, Moshier Cephes, Coelho ISC) each have the matching stanza. - The
Files: plugins/.../artwork/*.svgstanza matches exactly the 23 SVG files that glob finds, and nothing else has a CC-BY notice. - No non-free wording anywhere: grep over the whole tree for non-commercial, no-derivatives, personal use, all rights reserved, field-of-use wording and similar found only the GPL text itself. No LICENSE/COPYING/NOTICE file other than the root COPYING, NOTICE.DPF, NOTICE.SFZero and debian/README* exists below the top level.
- Files-Excluded is borne out: there is no
lib/directory and no.ttf/.otffile in the tree. The removed Allstar4/Amperzand fonts are referenced only as font-family names inside the SVG sources (they are what the PNG artwork was rendered with); the build compiles the PNGs through *Artwork.cpp, so nothing in the build depends on the fonts. - PNG artwork (59 files, knob/led/toggle/plugin screenshots) was recorded by name and not opened; all of it falls under Files: * (Damien Zammit, GPL-2+), which is the only attribution the package offers for it.
- The HRTF response tables plugins/ZamHeadX2/l1..l50 and r1..r50 and the seven plugins/ZamVerb/*_4.inc impulse tables contain only float data, no notice; they also fall under Files: * and were searched with grep (including the files over 4 MiB) without finding licence text. The scan's six >4 MiB text files are these and the largest Inkscape SVGs, which grep searched whole.
- dpf/ is an empty directory in the orig tarball (
zamaudio-zam-plugins-64cb54a/, a GitHub archive of an uninitialised submodule); the build copies /usr/share/dpf from dpf-source, so no DPF code is shipped and no DPF licence belongs in debian/copyright. - Licence combination is sound: libzita-convolver (GPL-3+) is linked by ZamVerb/ZamHeadX2 only, the plugin sources are GPL-2+, which allows the GPL-3 combination; the GPL-2-only ZamChild670 files are not built (ZamChild670, ZamPiano, ZamSFZ and ZamSynth are absent from the top-level PLUGINS list), so no GPL-2-only code enters a binary.
- Plugin/description consistency checked against the
TARGETS +=lines of every plugins/*/Makefile: the 19 built plugins are exactly those listed in the descriptions, and the LADSPA description correctly omits the four plugins with no ladspa target (ZaMultiComp, ZamHeadX2, ZamPhono, ZamVerb). - Install files cover exactly the trees
make installwrites (usr/bin, usr/lib/{ladspa,lv2,vst,vst3,clap}) and the metapackage installs nothing; upgrade path from the old single zam-plugins is handled by Breaks+Replaces (<< 4.5+ds-3) on all six real packages. - Build-Depends checked against apt-cache: dpf-source 1.7+ds1-1 (arch all), libzita-convolver-dev 4.0.3-2, libjack-dev, ladspa-sdk, libfftw3-dev, libsamplerate0-dev, liblo-dev and pkgconf all exist; libx11-dev, which DPF needs, comes through libgl-dev -> libglx-dev. Standards-Version 4.7.4 against Policy 4.7.4.1 is current.
- debian/rules: dh compat 14, no override of dh_auto_test, no substvar problems; dpf is copied before configure, the build receives CPPFLAGS through CFLAGS/CXXFLAGS plus LTO/bindnow, and the clean target passes trailing-slash directories to dh_clean, which is the form dh_clean accepts (a directory argument without the slash would abort the build).
- autopkgtest: Tests: smoke for the default package with Depends
@, ffmpeg, ladspa-sdk, lilv-utils, lv2file; lv2file and the other three are in the archive, and the script exercises LV2, LADSPA and the linked libraries. - uscan found the packaged version as the newest upstream release (upstream
4.5, packaged4.5+ds). - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (GPL-2).
Not confirmed ◂
- Provenance of the 100 HRTF response files (plugins/ZamHeadX2/l1..r50) and of the ZamVerb *.inc impulse responses: no measuring source, licence or attribution is given anywhere in the package, and debian/copyright simply attributes them to Damien Zammit. Nothing shows them coming from a restricted data set, but nothing shows they are his own measurements either.
- The generic widget PNGs (knob.png, ledred.png, ledyellow.png, toggle*.png, slidereq.png) are DPF-style example artwork and may be Filipe Coelho's ISC work rather than Damien's; dpf-source is not installed on the reviewing system, so I could not compare.
- debian/rules passes NOOPT=true to the upstream Makefile on every architecture but amd64. What DPF's Makefile.base.mk does with NOOPT could not be checked (dpf-source is not installed); if it drops optimisation, all non-amd64 builds are unoptimised, which a build log would show.
debian/watchlooks atgithub.com/zamaudio/@package@, but theSourcefield ofdebian/copyrightnamesgithub.com/zamaudio/zam-plugins. Whether these are the same upstream was not checked.debian/watchlooks atgithub.com/zamaudio/@package@, butRepositoryindebian/upstream/metadatanamesgithub.com/zamaudio/zam-plugins. Whether these are the same upstream was not checked.
Proposed changes ◂
None.
Uploader's response to the LLM review
oops the debian/copytight-decopy shouldnt be in the package. it will be removed by next upload. but all other stuff is fixed.
— Dennis Braun (snd), 13 days ago
Review Information
accepted — allocated to awm 1 day ago, started 1 day ago, completed 1 day ago.
Final Comment
Superseded by review of later version
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 4.5+ds-5 | 89de29a6… | 2026-11-21 07:06 | 2026-11-21 07:23 | awm | accepted | VIEW |
| 4.5+ds-3 | 0981a4cc… | 2026-11-07 16:32 | 2026-11-07 16:32 | dfsg-uploader | rejected | VIEW |
| 4.5+ds-2 | a5c038b1… | 2026-11-02 22:30 | 2026-11-06 15:32 | eamanu | rejected | VIEW |
| 4.5+ds-2 | a5c038b1… | 2026-11-06 15:32 | 2026-11-06 15:32 | dfsg-uploader | rejected | VIEW |
| 4.5+ds-1 | 1392fb70… | 2026-10-30 17:00 | 2026-10-30 17:00 | dfsg-uploader | rejected | VIEW |