Review: zam-plugins 4.5+ds-3
Package Information
| Description | Collection of LV2, CLAP, VST3, LADSPA, LINUX-VST and JACK plugins Plugins for high quality audio processing. The purpose of these plugins is to provide high quality DSP without using an excessive amount of CPU. There currently is no official documentation on how to use these plugins, but anyone who is familiar with outboard gear should be able to work it out. The default settings and almost every slider is calibrated to standard ranges. Package contain these plugins: * ZamAutoSat Automatic saturator (mono) * ZaMaximX2 Lightweight maximiser/limiter (stereo) * ZamComp Dynamic range compressor (mono) * ZamCompX2 Dynamic range compressor (stereo) * ZamDelay Basic delay plugin (mono) * ZamEQ2 Parametric equaliser (mono) * ZamGate Gate plugin (mono) * ZamGateX2 Gate plugin (stereo) * ZamGEQ31 31 band graphic equaliser (mono) * ZamHeadX2 Acoustic HRTF stereo widener (stereo) * ZamTube Triode tube amp simulator (mono) * ZaMultiComp Multiband compressor (mono) * ZaMultiCompX2 Multiband compressor (stereo) * ZamDynamicEQ Dynamic equaliser * ZamPhono A collection filters for restoring vinyl records. * ZamVerb Stereo reverb plugin * ZamGrains Looper and rhythm slicer * ZamNoise Noise reduction based on Gnome Wave Cleaner * ZamEcho Single parameter plugin suitable for DJ transition This meta package of zam-plugins contains plugins for all supported frameworks. |
|---|---|
| Maintainer | Debian Multimedia Maintainers <debian-multimedia@lists.debian.org> |
| Changed By | Dennis Braun <snd@debian.org> |
| Sponsor | snd@debian.org |
| Distribution | unstable |
| Architecture | any all |
| VCS | git: https://salsa.debian.org/multimedia-team/zam-plugins.git (browse) |
| Popcon Installs | 2431 |
| Binary NEW | Yes (new binary packages of a source already in sid) |
| Tracker | https://tracker.debian.org/pkg/zam-plugins |
| Uploaded | 1 day ago |
New Package Report
.changes
| Source | zam-plugins |
|---|---|
| Version | 4.5+ds-3 |
| Changed-By | Dennis Braun <snd@debian.org> |
| Architecture | source amd64 all |
| Distribution | unstable |
| Date | Fri, 06 Nov 2026 15:03:39 +0100 |
Changelog
zam-plugins (4.5+ds-3) unstable; urgency=medium . * Refresh Breaks and Replaces and refresh the plugin lists again * Remove the ttf files with no license and list files under GPL-2
.dsc
| Package-List | zam-plugins deb sound optional arch=all zam-plugins-clap deb sound optional arch=any zam-plugins-jack deb sound optional arch=any zam-plugins-ladspa deb sound optional arch=any zam-plugins-lv2 deb sound optional arch=any zam-plugins-vst deb sound optional arch=any zam-plugins-vst3 deb sound optional arch=any |
|---|---|
| Section | sound |
| Priority | optional |
| Component | main |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: zam-plugins
Upstream-Contact: Damien Zammit <damien@zamaudio.com>
Source: https://github.com/zamaudio/zam-plugins
Comment: We remove ttf fonts because of no license
and the lib dir and we use zita-convolver4 from debian.
Files-Excluded:
lib
plugins/*/artwork/Allstar4.ttf
plugins/*/artwork/Amperzand.ttf
Files: *
Copyright: 2013-2023 Damien Zammit <damien@zamaudio.com>
License: GPL-2+
Files: debian/*
Copyright:
2013-2017 Jaromír Mikeš <mira.mikes@seznam.cz>
2020-2023 Dennis Braun <snd@debian.org>
2023 Olivier Humbert <trembuh@tuxfamily.org>
License: GPL-2+
Files:
plugins/ZamChild670/generatedwdfutilities.h
plugins/ZamChild670/sidechainamplifier.cpp
plugins/ZamChild670/sidechainamplifier.h
plugins/ZamChild670/tubemodel.cpp
plugins/ZamChild670/tubemodel.h
plugins/ZamChild670/variablemuamplifier.cpp
plugins/ZamChild670/variablemuamplifier.h
plugins/ZamChild670/wavechild670.cpp
plugins/ZamChild670/wavechild670.h
plugins/ZamChild670/wdfcircuits.cpp
plugins/ZamChild670/wdfcircuits.h
Copyright: 2012 Peter Raffensperger
License: GPL-2
Files:
plugins/ZamNoise/Denoise.cpp
plugins/ZamNoise/Denoise.hpp
Copyright: 2001 Jeffrey J. Welty
License: GPL-2+
Files:
plugins/ZamVerb/convolution.hpp
plugins/ZamVerb/convolution.cpp
plugins/ZamHeadX2/convolution.hpp
plugins/ZamHeadX2/convolution.cpp
Copyright:
2012 Robin Gareus <robin@gareus.org>
2017 Damien Zammit <damien@zamaudio.com>
License: GPL-2+
Files: plugins/ZaMaximX2/artwork/zamaximx2.svg
plugins/ZaMultiComp/artwork/zamulticomp.svg
plugins/ZaMultiCompX2/artwork/zamulticompx2.svg
plugins/ZamAutoSat/artwork/zamautosat.svg
plugins/ZamChild670/artwork/zamchild670.svg
plugins/ZamComp/artwork/zamcomp.svg
plugins/ZamCompX2/artwork/zamcompx2.svg
plugins/ZamDelay/artwork/zamdelay.svg
plugins/ZamEcho/artwork/zamecho.svg
plugins/ZamDynamicEQ/artwork/zamdynamiceq.svg
plugins/ZamEQ2/artwork/zameq2.svg
plugins/ZamGEQ31/artwork/zamgeq31.svg
plugins/ZamGate/artwork/zamgate.svg
plugins/ZamGateX2/artwork/zamgatex2.svg
plugins/ZamGrains/artwork/zamgrains.svg
plugins/ZamHeadX2/artwork/zamheadx2.svg
plugins/ZamNoise/artwork/zamnoise.svg
plugins/ZamPhono/artwork/zamphono.svg
plugins/ZamPiano/artwork/zampiano.svg
plugins/ZamSFZ/artwork/zamsfz.svg
plugins/ZamSynth/artwork/zamsynth.svg
plugins/ZamTube/artwork/zamtube.svg
plugins/ZamVerb/artwork/zamverb.svg
Copyright: 2013-2022 Damien Zammit <damien@zamaudio.com>
License: CC-BY
Files: plugins/ZamNoise/bessel.inc
Copyright: 1984, 1987, 2000 Stephen L. Moshier
License: Cephes
License: Cephes
Cephes Math Library Release 2.8: June, 2000
Copyright 1984, 1987, 2000 by Stephen L. Moshier
.
Some software in this archive may be from the book _Methods and
Programs for Mathematical Functions_ (Prentice-Hall, 1989) or
from the Cephes Mathematical Library, a commercial product. In
either event, it is copyrighted by the author. What you see here
may be used freely but it comes with no support or guarantee.
.
The two known misprints in the book are repaired here in the
source listings for the gamma function and the incomplete beta
integral.
Files: plugins/ZamSFZ/libsfz/sfz.cpp
plugins/ZamSFZ/libsfz/sfz.h
Copyright: 2012 Steve Folta
2008-2009 Anders Dahnielson
Comment: The code was taken from the SFZero project. The license
information can be found in the NOTICE.SFZero file within the source code
License: Expat
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
.
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS
ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
DEALINGS IN THE SOFTWARE.
Files: widgets/ZamWidgets.hpp
Copyright: 2012-2016 Filipe Coelho <falktx@falktx.com>
License: ISC
License: GPL-2
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; version 2 of the License.
.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
.
On Debian systems, the complete text of the GNU General Public
License version 2 can be found in `/usr/share/common-licenses/GPL-2'.
License: GPL-2+
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 2 of the License, or
(at your option) any later version.
.
This package is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
.
On Debian systems, the complete text of the GNU General Public
License version 2 can be found in `/usr/share/common-licenses/GPL-2'.
.
You should have received a copy of the GNU General Public License
along with this program. If not, see <https://www.gnu.org/licenses/>.
License: CC-BY
Creative Commons Attribution 4.0 International Public License
.
By exercising the Licensed Rights (defined below), You accept and agree
to be bound by the terms and conditions of this Creative Commons
Attribution 4.0 International Public License ("Public License"). To the
extent this Public License may be interpreted as a contract, You are
granted the Licensed Rights in consideration of Your acceptance of
these terms and conditions, and the Licensor grants You such rights in
consideration of benefits the Licensor receives from making the
Licensed Material available under these terms and conditions.
.
Section 1 -- Definitions.
.
a. Adapted Material means material subject to Copyright and Similar
Rights that is derived from or based upon the Licensed Material
and in which the Licensed Material is translated, altered,
arranged, transformed, or otherwise modified in a manner requiring
permission under the Copyright and Similar Rights held by the
Licensor. For purposes of this Public License, where the Licensed
Material is a musical work, performance, or sound recording,
Adapted Material is always produced where the Licensed Material is
synched in timed relation with a moving image.
.
b. Adapter's License means the license You apply to Your Copyright
and Similar Rights in Your contributions to Adapted Material in
accordance with the terms and conditions of this Public License.
.
c. Copyright and Similar Rights means copyright and/or similar rights
closely related to copyright including, without limitation,
performance, broadcast, sound recording, and Sui Generis Database
Rights, without regard to how the rights are labeled or
categorized. For purposes of this Public License, the rights
specified in Section 2(b)(1)-(2) are not Copyright and Similar
Rights.
.
d. Effective Technological Measures means those measures that, in the
absence of proper authority, may not be circumvented under laws
fulfilling obligations under Article 11 of the WIPO Copyright
Treaty adopted on December 20, 1996, and/or similar international
agreements.
.
e. Exceptions and Limitations means fair use, fair dealing, and/or
any other exception or limitation to Copyright and Similar Rights
that applies to Your use of the Licensed Material.
.
f. Licensed Material means the artistic or literary work, database,
or other material to which the Licensor applied this Public
License.
.
g. Licensed Rights means the rights granted to You subject to the
terms and conditions of this Public License, which are limited to
all Copyright and Similar Rights that apply to Your use of the
Licensed Material and that the Licensor has authority to license.
.
h. Licensor means the individual(s) or entity(ies) granting rights
under this Public License.
.
i. Share means to provide material to the public by any means or
process that requires permission under the Licensed Rights, such
as reproduction, public display, public performance, distribution,
dissemination, communication, or importation, and to make material
available to the public including in ways that members of the
public may access the material from a place and at a time
individually chosen by them.
.
j. Sui Generis Database Rights means rights other than copyright
resulting from Directive 96/9/EC of the European Parliament and of
the Council of 11 March 1996 on the legal protection of databases,
as amended and/or succeeded, as well as other essentially
equivalent rights anywhere in the world.
.
k. You means the individual or entity exercising the Licensed Rights
under this Public License. Your has a corresponding meaning.
.
Section 2 -- Scope.
.
a. License grant.
.
1. Subject to the terms and conditions of this Public License,
the Licensor hereby grants You a worldwide, royalty-free,
non-sublicensable, non-exclusive, irrevocable license to
exercise the Licensed Rights in the Licensed Material to:
.
a. reproduce and Share the Licensed Material, in whole or
in part; and
.
b. produce, reproduce, and Share Adapted Material.
.
2. Exceptions and Limitations. For the avoidance of doubt, where
Exceptions and Limitations apply to Your use, this Public
License does not apply, and You do not need to comply with
its terms and conditions.
.
3. Term. The term of this Public License is specified in Section
6(a).
.
4. Media and formats; technical modifications allowed. The
Licensor authorizes You to exercise the Licensed Rights in
all media and formats whether now known or hereafter created,
and to make technical modifications necessary to do so. The
Licensor waives and/or agrees not to assert any right or
authority to forbid You from making technical modifications
necessary to exercise the Licensed Rights, including
technical modifications necessary to circumvent Effective
Technological Measures. For purposes of this Public License,
simply making modifications authorized by this Section 2(a)
(4) never produces Adapted Material.
.
5. Downstream recipients.
.
a. Offer from the Licensor -- Licensed Material. Every
recipient of the Licensed Material automatically
receives an offer from the Licensor to exercise the
Licensed Rights under the terms and conditions of this
Public License.
.
b. No downstream restrictions. You may not offer or impose
any additional or different terms or conditions on, or
apply any Effective Technological Measures to, the
Licensed Material if doing so restricts exercise of the
Licensed Rights by any recipient of the Licensed
Material.
.
6. No endorsement. Nothing in this Public License constitutes or
may be construed as permission to assert or imply that You
are, or that Your use of the Licensed Material is, connected
with, or sponsored, endorsed, or granted official status by,
the Licensor or others designated to receive attribution as
provided in Section 3(a)(1)(A)(i).
.
b. Other rights.
.
1. Moral rights, such as the right of integrity, are not
licensed under this Public License, nor are publicity,
privacy, and/or other similar personality rights; however, to
the extent possible, the Licensor waives and/or agrees not to
assert any such rights held by the Licensor to the limited
extent necessary to allow You to exercise the Licensed
Rights, but not otherwise.
.
2. Patent and trademark rights are not licensed under this
Public License.
.
3. To the extent possible, the Licensor waives any right to
collect royalties from You for the exercise of the Licensed
Rights, whether directly or through a collecting society
under any voluntary or waivable statutory or compulsory
licensing scheme. In all other cases the Licensor expressly
reserves any right to collect such royalties.
.
Section 3 -- License Conditions.
.
Your exercise of the Licensed Rights is expressly made subject to the
following conditions.
.
a. Attribution.
.
1. If You Share the Licensed Material (including in modified
form), You must:
.
a. retain the following if it is supplied by the Licensor
with the Licensed Material:
.
i. identification of the creator(s) of the Licensed
Material and any others designated to receive
attribution, in any reasonable manner requested by
the Licensor (including by pseudonym if
designated);
.
ii. a copyright notice;
.
iii. a notice that refers to this Public License;
.
iv. a notice that refers to the disclaimer of
warranties;
.
v. a URI or hyperlink to the Licensed Material to the
extent reasonably practicable;
.
b. indicate if You modified the Licensed Material and
retain an indication of any previous modifications; and
.
c. indicate the Licensed Material is licensed under this
Public License, and include the text of, or the URI or
hyperlink to, this Public License.
.
2. You may satisfy the conditions in Section 3(a)(1) in any
reasonable manner based on the medium, means, and context in
which You Share the Licensed Material. For example, it may be
reasonable to satisfy the conditions by providing a URI or
hyperlink to a resource that includes the required
information.
.
3. If requested by the Licensor, You must remove any of the
information required by Section 3(a)(1)(A) to the extent
reasonably practicable.
.
4. If You Share Adapted Material You produce, the Adapter's
License You apply must not prevent recipients of the Adapted
Material from complying with this Public License.
.
Section 4 -- Sui Generis Database Rights.
.
Where the Licensed Rights include Sui Generis Database Rights that
apply to Your use of the Licensed Material:
.
a. for the avoidance of doubt, Section 2(a)(1) grants You the right
to extract, reuse, reproduce, and Share all or a substantial
portion of the contents of the database;
.
b. if You include all or a substantial portion of the database
contents in a database in which You have Sui Generis Database
Rights, then the database in which You have Sui Generis Database
Rights (but not its individual contents) is Adapted Material; and
.
c. You must comply with the conditions in Section 3(a) if You Share
all or a substantial portion of the contents of the database.
.
For the avoidance of doubt, this Section 4 supplements and does not
replace Your obligations under this Public License where the Licensed
Rights include other Copyright and Similar Rights.
.
Section 5 -- Disclaimer of Warranties and Limitation of Liability.
.
a. UNLESS OTHERWISE SEPARATELY UNDERTAKEN BY THE LICENSOR, TO THE
EXTENT POSSIBLE, THE LICENSOR OFFERS THE LICENSED MATERIAL AS-IS
AND AS-AVAILABLE, AND MAKES NO REPRESENTATIONS OR WARRANTIES OF
ANY KIND CONCERNING THE LICENSED MATERIAL, WHETHER EXPRESS,
IMPLIED, STATUTORY, OR OTHER. THIS INCLUDES, WITHOUT LIMITATION,
WARRANTIES OF TITLE, MERCHANTABILITY, FITNESS FOR A PARTICULAR
PURPOSE, NON-INFRINGEMENT, ABSENCE OF LATENT OR OTHER DEFECTS,
ACCURACY, OR THE PRESENCE OR ABSENCE OF ERRORS, WHETHER OR NOT
KNOWN OR DISCOVERABLE. WHERE DISCLAIMERS OF WARRANTIES ARE NOT
ALLOWED IN FULL OR IN PART, THIS DISCLAIMER MAY NOT APPLY TO YOU.
.
b. TO THE EXTENT POSSIBLE, IN NO EVENT WILL THE LICENSOR BE LIABLE
TO YOU ON ANY LEGAL THEORY (INCLUDING, WITHOUT LIMITATION,
NEGLIGENCE) OR OTHERWISE FOR ANY DIRECT, SPECIAL, INDIRECT,
INCIDENTAL, CONSEQUENTIAL, PUNITIVE, EXEMPLARY, OR OTHER LOSSES,
COSTS, EXPENSES, OR DAMAGES ARISING OUT OF THIS PUBLIC LICENSE OR
USE OF THE LICENSED MATERIAL, EVEN IF THE LICENSOR HAS BEEN
ADVISED OF THE POSSIBILITY OF SUCH LOSSES, COSTS, EXPENSES, OR
DAMAGES. WHERE A LIMITATION OF LIABILITY IS NOT ALLOWED IN FULL OR
IN PART, THIS LIMITATION MAY NOT APPLY TO YOU.
.
c. The disclaimer of warranties and limitation of liability provided
above shall be interpreted in a manner that, to the extent
possible, most closely approximates an absolute disclaimer and
waiver of all liability.
.
Section 6 -- Term and Termination.
.
a. This Public License applies for the term of the Copyright and
Similar Rights licensed here. However, if You fail to comply with
this Public License, then Your rights under this Public License
terminate automatically.
.
b. Where Your right to use the Licensed Material has terminated under
Section 6(a), it reinstates:
.
1. automatically as of the date the violation is cured, provided
it is cured within 30 days of Your discovery of the
violation; or
.
2. upon express reinstatement by the Licensor.
.
For the avoidance of doubt, this Section 6(b) does not affect any
right the Licensor may have to seek remedies for Your violations
of this Public License.
.
c. For the avoidance of doubt, the Licensor may also offer the
Licensed Material under separate terms or conditions or stop
distributing the Licensed Material at any time; however, doing so
will not terminate this Public License.
.
d. Sections 1, 5, 6, 7, and 8 survive termination of this Public
License.
.
Section 7 -- Other Terms and Conditions.
.
a. The Licensor shall not be bound by any additional or different
terms or conditions communicated by You unless expressly agreed.
.
b. Any arrangements, understandings, or agreements regarding the
Licensed Material not stated herein are separate from and
independent of the terms and conditions of this Public License.
.
Section 8 -- Interpretation.
.
a. For the avoidance of doubt, this Public License does not, and
shall not be interpreted to, reduce, limit, restrict, or impose
conditions on any use of the Licensed Material that could lawfully
be made without permission under this Public License.
.
b. To the extent possible, if any provision of this Public License is
deemed unenforceable, it shall be automatically reformed to the
minimum extent necessary to make it enforceable. If the provision
cannot be reformed, it shall be severed from this Public License
without affecting the enforceability of the remaining terms and
conditions.
.
c. No term or condition of this Public License will be waived and no
failure to comply consented to unless expressly agreed to by the
Licensor.
.
d. Nothing in this Public License constitutes or may be interpreted
as a limitation upon, or waiver of, any privileges and immunities
that apply to the Licensor or You, including from the legal
processes of any jurisdiction or authority.
License: ISC
Permission to use, copy, modify, and/or distribute this software for any purpose with
or without fee is hereby granted, provided that the above copyright notice and this
permission notice appear in all copies.
.
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD
TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN
NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL
DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER
IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
DFSG Assistant LLM REVIEW 1 blocker, 0 important, 4 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 1 day ago.
Report
DFSG NEW review for zam-plugins version 4.5+ds-3
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: No - Packaging is of good quality: Yes
- Issues: 1 blocker, 0 important, 4 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
Every file in the tree is free-licensed, and the licences combine: GPL-2+ for Damien Zammit's code and most third-party parts, GPL-2-only for Peter Raffensperger's Wavechild670 files in plugins/ZamChild670 (compatible with the rest), plus ISC, Expat, Cephes, CC BY 4.0 and STK-4.3, all DFSG-free. debian/copyright is nevertheless inaccurate and incomplete. plugins/ZamPiano/instrument.hpp and PianoNote.cpp are Romain Michon's 2011 code, declared licence: STK-4.3, but no Files stanza names them, so they fall under Files: * as Damien Zammit's GPL-2+ work; the holder is missing and the STK-4.3 text is absent. The artwork stanza also uses the short name CC-BY for material that is actually CC BY 4.0, which copyright-format section 7.1 defines as CC BY 1.0-3.0.
Packaging
The packaging is sound: a clean split into one package per plugin format plus the JACK clients and an empty meta package, debhelper compat 14 rules with hardening, LTO and a verbose/terse switch, working Breaks/Replaces for the pre-split versions, DEP-3 patches, an autopkgtest that actually loads the LV2 and LADSPA plugins, current Standards-Version, and Vcs-*/Homepage/upstream metadata in place. Remaining problems are small: the ladspa and vst package descriptions list the wrong plugin sets, the lintian overrides contain a self-referential duplicate-override-context line, and libfftw3-dev is only an indirect build dependency.
Issues
blocker licensing 1. debian/copyright credits plugins/ZamPiano/instrument.hpp and PianoNote.cpp to Damien Zammit as GPL-2+, but they are Romain Michon's STK-4.3 code ◂
- Files:
debian/copyright:12-14,plugins/ZamPiano/instrument.hpp:1-3,plugins/ZamPiano/PianoNote.cpp:5-6 - Basis: checked, in the package or with a reference tool
- Evidence: instrument.hpp:
//Set of C++ wave table function///©Romain Michon (rmichon@ccrma.stanford.edu), 2011///licence: STK-4.3; PianoNote.cpp://Parameters for piano.dsp/////(c) Romain Michon (rmichon@ccrma.stanford.edu), 2011. debian/copyright has no stanza matching plugins/ZamPiano/* (the only mention of the directory isplugins/ZamPiano/artwork/zampiano.svgin the CC-BY stanza at line 72), so both files fall underFiles: *:Copyright: 2013-2023 Damien Zammit <damien@zamaudio.com>/License: GPL-2+. - Problem: The files are not Damien Zammit's GPL-2+ work. instrument.hpp is Romain Michon's look-up-table helper for piano.dsp, carries his copyright and declares STK-4.3, and it embeds STK wavetable data (
readMarmstk1); PianoNote.cpp holds the piano.dsp parameter tables and carries the same (c) line. The STK-4.3 licence requires its notice to be reproduced, and it is not a licence in /usr/share/common-licenses, so debian/copyright must carry its text; the file itself only keeps the pointerlicence: STK-4.3. As written the copyright file names the wrong holder and the wrong licence and omits a required licence text, contrary to Policy 12.5 and copyright-format 5.2 and 6.7. - Fix: Add a Files stanza for
plugins/ZamPiano/instrument.hppandplugins/ZamPiano/PianoNote.cppwithCopyright: 2011 Romain Michon <rmichon@ccrma.stanford.edu>andLicense: STK-4.3, plus a stand-aloneLicense: STK-4.3paragraph containing the full STK 4.3 licence text (including STK's own copyright holders).
minor
licensing
2. The artwork stanza uses the short name CC-BY for CC BY 4.0, which that short name does not denote
◂
- Files:
debian/copyright:54-78,debian/copyright:157 - Basis: checked, in the package or with a reference tool
- Evidence: Files stanza listing the 23
plugins/*/artwork/*.svgfiles ends withLicense: CC-BY, and the stand-alone paragraph it refers to (line 157) isCreative Commons Attribution 4.0 International Public License. - Problem: copyright-format 7.1 defines
CC-BYas the Creative Commons Attribution licence 1.0, 2.0, 2.5 and 3.0, and says short names "must not be used to refer to any other licenses". The files are CC BY 4.0, whose short name isCC-BY-4.0(the text is also provided as /usr/share/common-licenses/CC-BY-4.0), so the file misstates the licence version to any machine parser. - Fix: Use
CC-BY-4.0as the short name in that stanza and in the stand-alone paragraph; referring to /usr/share/common-licenses/CC-BY-4.0 instead of embedding the 300-line text is optional.
minor packaging 3. zam-plugins-ladspa lists ZamHeadX2 and ZaMultiComp, which build no LADSPA plugin, and zam-plugins-vst omits ZamGrains, ZamPhono and ZamVerb, which do build VST2 ◂
- Files:
debian/control:217-275,debian/control:339-395,plugins/ZamHeadX2/Makefile,plugins/ZaMultiComp/Makefile,plugins/ZamGrains/Makefile,plugins/ZamPhono/Makefile,plugins/ZamVerb/Makefile - Basis: checked, in the package or with a reference tool
- Evidence: The ladspa description has bullets
* ZamHeadX2and* ZaMultiComp, but plugins/ZamHeadX2/Makefile lists onlyTARGETS += jack,lv2_sep,vst2,vst3,clapand plugins/ZaMultiComp/Makefile onlyjack,lv2_sep,vst2,vst3,clap- noTARGETS += ladspa; the vst description jumps from* ZamDynamicEQto* ZamNoise, omitting ZamGrains, ZamPhono and ZamVerb, whose Makefiles all haveTARGETS += vst2. - Problem: The 4.5+ds-2 changelog says these lists were fixed, but they are still wrong: users are told a package contains ZamHeadX2 and ZaMultiComp LADSPA plugins it does not have, and are not told about three VST2 plugins it does contain.
- Fix: Drop the ZamHeadX2 and ZaMultiComp bullets from the zam-plugins-ladspa description and add ZamGrains, ZamPhono and ZamVerb to the zam-plugins-vst description (or replace the per-plugin lists with a note that not every plugin provides every format).
minor
packaging
4. The lintian-override files override duplicate-override-context with the override file itself as context, silencing lintian's own warning instead of the tag the comment describes
◂
- Files:
debian/zam-plugins-lv2.lintian-overrides:3-4,debian/zam-plugins-vst.lintian-overrides:3-4,debian/zam-plugins-vst3.lintian-overrides:3-4,debian/zam-plugins-clap.lintian-overrides:3-4,debian/zam-plugins-ladspa.lintian-overrides:1-2 - Basis: checked, in the package or with a reference tool
- Evidence:
# Fonts are embedded specifically for rendering the plugin GUI artworkfollowed byduplicate-override-context (lines 4 5) [usr/share/lintian/overrides/zam-plugins-lv2]; the ladspa file has the same pair with(lines 2 3), while that file has two lines. - Problem: The tag being overridden is lintian's diagnostic about duplicate overrides, and its context is the override file itself, citing line numbers that no longer exist. The result is dead weight that suppresses lintian's report about overrides while the embedded DejaVu font the comment is about (it comes in through dpf-source, which Depends on fonts-dejavu-core) stays unoverridden.
- Fix: Delete these lines and their comment from all five files, or, if the embedded font really needs an override, replace them with an override for the tag lintian actually emits for it.
minor packaging 5. Build-Depends has no libfftw3-dev although three plugin Makefiles ask pkg-config for fftw3f; it only arrives transitively through libzita-convolver-dev ◂
- Files:
debian/control,plugins/ZamHeadX2/Makefile,plugins/ZamVerb/Makefile,plugins/ZamNoise/Makefile - Basis: inferred from what was read, not seen directly
- Evidence: ZamHeadX2 and ZamVerb Makefiles:
BASE_FLAGS += $(shell $(PKG_CONFIG) --cflags samplerate fftw3f)andLINK_FLAGS += $(shell $(PKG_CONFIG) --libs fftw3f samplerate); ZamNoise Makefile:$(PKG_CONFIG) --cflags fftw3f. Build-Depends listslibzita-convolver-dev (>= 4.0.0)but not libfftw3-dev, and apt-cache shows libzita-convolver-devDepends: libfftw3-dev, libzita-convolver4 (= ...). - Problem: The build works today only because libzita-convolver-dev happens to depend on libfftw3-dev; if that dependency is ever dropped, the fftw3f.pc lookup returns nothing and the link of ZamHeadX2, ZamVerb and ZamNoise fails. A package should name, in Build-Depends, every package whose headers or pkg-config files its build uses (Policy 7.7 and 4.9).
- Fix: Add
libfftw3-devto Build-Depends.
Verified ◂
- Prescan author check: my own grep of the whole tree for
Copyright,(c),©,SPDX-License-Identifier,Permission is hereby granted,All rights reservedandpublic domainfound exactly the holders named in debian/copyright, except Romain Michon in plugins/ZamPiano, which is reported above; no other holder is missing. - The six files over 4 MiB that the prescan could only scan partly are plugins/ZamVerb/hallA_4.inc, hallB_4.inc, plate_4.inc, roomA_4.inc, roomB_4.inc and studioB_4.inc (4.6-7.6 MB each): comma-separated float arrays #included by plugins/ZamVerb/ZamVerbImpulses.cpp as fixed reverb impulse responses. Upstream data, not build output, and covered by
Files: *; studioA_4.inc (2.7 MB) is the same kind of file. - The 100 files plugins/ZamHeadX2/l1-l50 and r1-r50 (101 KB each) are float arrays #included by plugins/ZamHeadX2/convolution.cpp to fill
static const float fir_left[50][25][200]and fir_right; upstream data, covered byFiles: *, not build output. - No *.ttf survives the repack and there is no lib/ directory, as debian/copyright's Files-Excluded and Comment state; dpf/ is an empty directory (DPF is taken at build time from /usr/share/dpf of dpf-source 1.7+ds1-1), so no DPF source and no ISC stanza for it is needed.
- All 23 plugins//artwork/.svg files are exactly the 23 listed in the CC-BY stanza, name for name; the bitmaps (knob.png, ledred.png, toggle*.png, *.png) and the generated *Artwork.cpp files are data covered by
Files: *, by the same author. - Third-party licences match the notices: plugins/ZamChild670's 12 files say
Wavechild670 is licensed under the GNU GPL v2 license(Peter Raffensperger); plugins/ZamNoise/Denoise.{cpp,hpp} are GPL-2+ (Jeffrey J. Welty, Gnome Wave Cleaner,either version 2 of the License, or (at your option) any later version); plugins/{ZamVerb,ZamHeadX2}/convolution.{cpp,hpp} are GPL-2+ (Robin Gareus 2012, modified by Damien Zammit 2017); plugins/ZamNoise/bessel.inc is Cephes with its text reproduced; plugins/ZamSFZ/libsfz/sfz.{cpp,h} are Expat with its text reproduced (NOTICE.SFZero also in the tree); widgets/ZamWidgets.hpp is ISC from Filipe Coelho with its text reproduced. GPL-2-only ZamChild670 code combines with the GPL-2+ code without conflict. - No non-free terms anywhere: no non-commercial, no-derivatives, no-modification or field-of-use wording, no
All rights reservedapplied to code; the Cephes text ("may be used freely but it comes with no support or guarantee") is the permissive grant Debian has long accepted. - Packaging metadata: Standards-Version 4.7.4 matches the current Policy 4.7.x and is not an issue; debhelper-compat (= 14); dpf-source (1.7+ds1-1), libzita-convolver-dev (4.0.3, Multi-Arch: same), ladspa-sdk, lv2file (0.95-4) and lilv-utils (0.28.0) all exist in unstable, so the declared build and test dependencies are installable.
- Installed layout matches upstream's install target and the .install manifests (only /usr/bin and /usr/lib/{ladspa,lv2,vst,vst3,clap}); the six binary packages cover every format the pre-split package had, and each contains
Breaks/Replaces: zam-plugins (<< 4.5+ds-3), which covers the old combined package and the two earlier 4.5+ds uploads. - Both patches in debian/patches have DEP-3 headers (From, Date, Subject), debian/tests/control pulls what the smoke script needs (@, ffmpeg, ladspa-sdk, lilv-utils, lv2file), and the script runs every LV2 plugin on generated audio, every LADSPA plugin, and an ldd check on all shipped objects.
- Coverage: every file under debian/ read except debian/watch; the heads of all source files carrying a licence or copyright line were read, plus COPYING, NOTICE.DPF, NOTICE.SFZero, README.md and the upstream changelog.
- uscan found the packaged version as the newest upstream release (upstream
4.5, packaged4.5+ds). - Every pointer of
debian/copyrightto /usr/share/common-licenses names a file that is there (GPL-2).
Not confirmed ◂
- Where the impulse-response data in plugins/ZamHeadX2/l*,r* and plugins/ZamVerb/*.inc came from: nothing in the tree says, and neither dataset has its own notice, so I assumed they are upstream's own measurements or derivations, as
Files: *states. - plugins/ZamSFZ/libsfz/sfz.cpp and sfz.h contain no licence header at all; NOTICE.SFZero names only Steve Folta, while debian/copyright also credits Anders Dahnielson, whose terms could not be checked.
- Whether the LADSPA/VST/CLAP sets in each package match exactly what gets built also depends on DPF's Makefile.plugins.mk from dpf-source, which is not part of this source package; I checked only the plugins' own Makefiles.
- Cross builds: debian/rules exports an EXE_WRAPPER=qemu- and cross compilers but declares no qemu Build-Depends, so a cross build may fail when dpf/utils/lv2_ttl_generator is run. Not an archive build, so not reported as an issue.
- The smoke test uses
lv2file -nand--ignore-clipping; lv2file is not installed on the reviewing system, so I could not check that those options do what the script expects. debian/watchlooks atgithub.com/zamaudio/@package@, but theSourcefield ofdebian/copyrightnamesgithub.com/zamaudio/zam-plugins. Whether these are the same upstream was not checked.debian/watchlooks atgithub.com/zamaudio/@package@, butRepositoryindebian/upstream/metadatanamesgithub.com/zamaudio/zam-plugins. Whether these are the same upstream was not checked.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader rejected this upload in response to the review.
Review Information
rejected — allocated to dfsg-uploader 10 hours ago, started 10 hours ago, completed 10 hours ago.
Final Comment
The uploader rejected this upload in response to the automated (LLM) review of it, so that they can fix the problems it found and upload again.
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 4.5+ds-2 | a5c038b1… | 2026-11-02 22:30 | 2026-11-06 15:32 | eamanu | rejected | VIEW |
| 4.5+ds-2 | a5c038b1… | 2026-11-06 15:32 | 2026-11-06 15:32 | dfsg-uploader | rejected | VIEW |
| 4.5+ds-1 | 1392fb70… | 2026-10-30 17:00 | 2026-10-30 17:00 | dfsg-uploader | rejected | VIEW |