DFSG NEW Queue

DFSG, Licensing & New Packages Team

zipremove 0.10.0-1

Package Information

Descriptionextends the native zipfile module with remove-related capabilities

zipremove extends the native zipfile module with remove-related capabilities.

The same codebase is currently being integrated into the CPython standard library and is scheduled to be available natively in Python 3.16.

MaintainerDaniel Baumann <daniel@debian.org>
Changed ByDaniel Baumann <daniel@debian.org>
Sponsormail@daniel-baumann.ch
Distributionsid
Architectureall
VCSgit: https://forgejo.debian.net/python/zipremove (browse)
Closes#1154698
Trackerhttps://tracker.debian.org/pkg/zipremove
Uploaded2 hours ago

New Package Report

.changes◂
DateSat, 21 Nov 2026 19:16:29 +0100
Sourcezipremove
Version0.10.0-1
Changed-ByDaniel Baumann <daniel@debian.org>
Architecturesource all
Distributionsid
Changelog◂
zipremove (0.10.0-1) sid; urgency=medium
 .
   * Initial upload to sid, needed for tox-ini-fmt (Closes: #1154698).
.dsc◂
Componentmain
Package-Listpython3-zipremove deb python optional arch=all
Sectionpython
Priorityoptional
debian/copyright◂
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: zipremove
Upstream-Contact: https://github.com/danny0838/zipremove/issues
Source: https://github.com/danny0838/zipremove/tags

Files: *
Copyright: 2025 Danny Lin <danny0838@gmail.com>
License: MIT

Files: debian/*
Copyright: 2026 Daniel Baumann <daniel@debian.org>
License: MIT

License: MIT
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
 in the Software without restriction, including without limitation the rights
 to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 copies of the Software, and to permit persons to whom the Software is
 furnished to do so, subject to the following conditions:
 .
 The above copyright notice and this permission notice shall be included in
 all copies or substantial portions of the Software.
 .
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.

DFSG Assistant LLM REVIEW 0 blocker, 1 important, 0 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 1 hour ago.

Report◂

DFSG NEW review for zipremove version 0.10.0-1

Summary

  • Licensing is DFSG-compliant and debian/copyright is accurate: Yes
  • Packaging is of good quality: No
  • Issues: 0 blocker, 1 important, 0 minor
  • debian/watch: version 5
  • debian/copyright: machine-readable
  • Scan before the review: nothing found

Licensing

debian/copyright is DEP-5 with the exact copyright-format 1.0 Format: URL. Files: * declares MIT for 2025 Danny Lin, which is exactly what LICENSE.txt says and the only licence or copyright statement anywhere in the upstream tree (no notices in .github/, pyproject.toml, setup.py, src/ or tests/); the later Files: debian/* stanza correctly overrides it for the packaging, with MIT and 2026 Daniel Baumann. The MIT notice is reproduced in full in the file, so nothing outside /usr/share/common-licenses is left unreproduced. No non-free terms, no Files-Excluded needed, no bundled third-party library, and the prescan found no holder missing. One small CPython-derived compatibility shim is noted under unconfirmed.

Packaging

The packaging is modern and otherwise policy-clean: debhelper compat 14 via debhelper-compat, dh-sequence-python3 and dh-sequence-single-binary, a correct PEP 517 build (pybuild-plugin-pyproject with setuptools, and wheel supplied transitively through python3-build), no ${python3:Depends} needed at compat 14, DEP-5 copyright, upstream metadata, Vcs-* fields, Standards-Version 4.7.4 (current against Policy 4.7.4.1) and a sid changelog with a bug closure. The one substantive gap is test coverage: debian/rules switches the build test step off with a bare # disabled and there is no debian/tests/control, so upstream's test suite is never run by the build daemons or by autopkgtest.

Issues

important packaging 1. Upstream test suite is disabled in debian/rules and no autopkgtest replaces it ◂
  • Files: debian/rules:8-9, debian/tests/control

  • Basis: checked, in the package or with a reference tool

  • Evidence:

    debian/rules:8-9:

    override_dh_auto_test:
    	# disabled
    

    and no debian/tests/ directory exists, while upstream ships tests/test_zipfile.py (2483 lines) and .github/workflows/test.yml runs python -m unittest -v.

  • Problem: The only tests for code that rewrites ZIP archives in place (remove, repack, copy) are suppressed at build time and nothing in Debian runs them afterwards; the archive therefore gets no regression coverage for a new library, and the bare # disabled records no reason. The reason is probably that the tests import helpers from CPython's own test suite (from test.test_zipfile... at tests/test_zipfile.py:14-58), which the -stdlib package does not contain (the reviewing system's /usr/lib/python3.14/test/ has only support/ and no test_zipfile.py), so a plain build-time run would fail; that is not documented and does not prevent an autopkgtest.

  • Fix: Add debian/tests/control running the upstream suite (for example Test-Command: python3 -m unittest discover -v, Depends: @, python3-all plus the matching libpython3.x-testsuite for test.test_zipfile, or file the bug the testsuite package asks for to move the needed files into libpython3.x-stdlib), and/or enable the build-time tests with the same dependency. If the suite genuinely cannot be run, say why in the comment or in debian/README.source instead of leaving # disabled.

Verified ◂
  • Read every file under debian/: control, rules, changelog, copyright, source/format, upstream/metadata; there are no patches, install/links/docs files, maintainer scripts, autopkgtests or gbp.conf.
  • Read every upstream file (13 paths: the seven top-level files, the two .github/workflows/, src/zipremove/__init__.py and the three tests/ files); the only licence/copyright statement is LICENSE.txt (MIT, 2025 Danny Lin), matching Files: *; the prescan's author check agrees that every holder found is named.
  • debian/copyright is DEP-5, the Format: URL is the exact 1.0 one, Files: * and debian/* are ordered so the packaging stanza wins, and the full MIT text is in the file. No file in the tree is a candidate for a Files-Excluded line.
  • No non-free wording, no SPDX-License-Identifier, no All rights reserved, no bundled third-party code, and no built or binary artefacts in the tree; .pc/ was ignored as instructed.
  • dh-sequence-single-binary exists: apt-cache shows debhelper 14.5 provides it, and /usr/share/perl5/Debian/Debhelper/Sequence/single_binary.pm only adds dh_auto_install --destdir=debian/python3-zipremove/, which matches pybuild's destdir from PYBUILD_NAME=zipremove.
  • pyproject.toml needs setuptools and wheel; pybuild-plugin-pyproject Depends on python3-build, which Depends on python3-wheel, so no build dependency is missing.
  • Standards-Version 4.7.4 against the policy tool's Policy 4.7.4.1 is current; the changelog uses sid with a plausible date and closes #1154698.
  • tests/ is upstream code that is not installed into the binary package, so Policy 2.3 does not require its notices; it is in any case covered by the Files: * MIT stanza.
  • uscan found the packaged version as the newest upstream release (upstream 0.10.0, packaged 0.10.0).
Not confirmed ◂
  • src/zipremove/__init__.py:47-59 polyfills _sanitize_filename with code that is identical, apart from comments, to CPython 3.14's _sanitize_filename (/usr/lib/python3.14/zipfile/__init__.py:404-417, PSF-2.0), and the module is installed in the binary package. Whether seven such lines are a copyrightable copy that needs a PSF-2.0 holder and licence stanza in debian/copyright is a judgment call; the holder would be the Python Software Foundation (or the CPython contributor), not Danny Lin alone.
  • Why the model asked for what a review has no use for. During this review it asked once for something outside the package and the reviewing system (another file of the sandbox, or a URL), or was given part of the review tooling's own configuration, and that was refused or withheld. A model does this when something it has read tells it to, so look in the package for text addressed to a reviewing program, and treat this report with suspicion. Refused: read: "xd://read/sources" is not a file of the package or of the reviewing system.
Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader was emailed about the review 1 hour ago.

Back to Dashboard | View all reviews for this package