Review: dart-leak-tracker-flutter-testing 3.0.10-1
Package Information
| Description | leak tracking for Flutter tests This package ships the leak_tracker_flutter_testing library as sources, so that other Dart packages can depend on it at build time. |
|---|---|
| Maintainer | Emfox Zhou <emfox@debian.org> |
| Changed By | Emfox Zhou <emfox@debian.org> |
| Sponsor | emfox@debian.org |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/dart-team/dart-leak-tracker-flutter-testing.git (browse) |
| Closes | #1152239 |
| Tracker | https://tracker.debian.org/pkg/dart-leak-tracker-flutter-testing |
| Uploaded | 11 days ago |
New Package Report
.changes
| Architecture | source all |
|---|---|
| Distribution | unstable |
| Date | Tue, 27 Oct 2026 08:52:34 +0800 |
| Source | dart-leak-tracker-flutter-testing |
| Version | 3.0.10-1 |
| Changed-By | Emfox Zhou <emfox@debian.org> |
Changelog
dart-leak-tracker-flutter-testing (3.0.10-1) unstable; urgency=medium . * Initial release. (Closes: #1152239)
.dsc
| Section | devel |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | dart-leak-tracker-flutter-testing deb devel optional arch=all |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: leak_tracker_flutter_testing
Source: https://github.com/dart-lang/leak_tracker/tree/main/pkgs/leak_tracker_flutter_testing
Files: *
Copyright: 2022, the Dart project authors
License: BSD-3-clause
Files: test/tests/_formatting_test.dart
test/tests/end_to_end/leak_detection_test.dart
Copyright: 2023 The Chromium Authors
License: BSD-3-clause
Files: debian/*
Copyright: 2026, Emfox Zhou <emfox@debian.org>
License: BSD-3-clause
License: BSD-3-clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
met:
.
* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
* Redistributions in binary form must reproduce the above
copyright notice, this list of conditions and the following
disclaimer in the documentation and/or other materials provided
with the distribution.
* Neither the name of Google LLC nor the names of its
contributors may be used to endorse or promote products derived
from this software without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
DFSG Assistant LLM REVIEW 0 blocker, 0 important, 0 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 11 days ago.
Report
DFSG NEW review for dart-leak-tracker-flutter-testing version 3.0.10-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: Yes - Packaging is of good quality: Yes
- Issues: 0 blocker, 0 important, 0 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: nothing found
Licensing
Every one of the 25 upstream files is covered: Files: * gives the Dart project authors and BSD-3-clause, and the two files whose own headers name Copyright 2023 The Chromium Authors are carved out in a later stanza. The full BSD-3-clause text (the Dart/Google variant, including the "Neither the name of Google LLC" clause) is reproduced in the stand-alone License paragraph, and no non-free wording, binary, minified or generated code appears anywhere in the tree. The prescan's author check found no holder that debian/copyright fails to name.
Packaging
A simple, correct source-only Dart package: debhelper compat 14 with dh $@, the single-binary addon properly requested, and debian/install placing lib/ and pubspec.yaml under /usr/share/dart/packages/leak_tracker_flutter_testing/. The versioned dependencies mirror pubspec.yaml exactly and are satisfiable (three of them are in NEW, the rest in the archive), an offline autopkgtest exists, and changelog, source format, Vcs-*, upstream metadata and Standards-Version 4.7.4 are all in order.
Issues
None.
Verified ◂
- All 25 files of the tarball are accounted for:
Files: *(BSD-3-clause, "2022, the Dart project authors") covers every file, and the later stanzaFiles: test/tests/_formatting_test.dartandtest/tests/end_to_end/leak_detection_test.dartcovers the only two files whose headers sayCopyright 2023 The Chromium Authors; no other copyright or licence wording exists in lib/, test/ or the top-level files. LICENSEis the Google/Dart BSD-3-clause text, anddebian/copyrightreproduces it in full in its stand-aloneLicense: BSD-3-clauseparagraph, so the permissive notice is retained as the licence requires.- The prescan's answer (
every holder found is named in debian/copyright) matches the tree; the Dart project headers in lib/ and test/ name the same holder asFiles: *, and the Chromium headers are the only other holder. - No binaries, archives, .class/.jar/.so, minified or generated source in the orig tarball (only .dart, .md and .yaml).
lib/DEPENDENCIES.mdis a layerlens-generated mermaid diagram of the shipped sources, not generated code with a missing input. - The unpacked tree matches
dart-leak-tracker-flutter-testing_3.0.10.orig.tar.gz; the debian tarball contains nodebian/patches, so there are no patches to review, and.pc/is quilt's unpack artifact (it is not in the orig tarball). debian/controldependencies mirrorpubspec.yamlexactly:flutter (>= 3.18.0),dart-leak-tracker (>= 11.0.1)/(<< 12.0.0),dart-leak-tracker-testing (>= 3.0.1)/(<< 4.0.0),dart-matcher (>= 0.12.16)/(<< 0.13.0),dart-meta (>= 1.8.0), i.e. pubspec'sflutter,>=11.0.1 <12.0.0,>=3.0.1 <4.0.0,^0.12.16,^1.8.0.- Every runtime dependency and autopkgtest dependency is satisfiable: apt-cache has
flutter3.47.5,dart-meta1.19.0,dart-sdk3.13.4,flutter-testerandflutter-patched-sdk3.47.5;dart-leak-tracker11.0.2-1,dart-leak-tracker-testing3.0.2-1 anddart-matcher0.12.20-1 are in ftp-master's NEW queue and fall inside the declared ranges, so they are not reportable as missing. - Build-Depends are satisfiable: debhelper 14.5 in the archive Provides both
debhelper-compat (= 14)anddh-sequence-single-binary(apt-cache), and the addon exists at/usr/share/perl5/Debian/Debhelper/Sequence/single_binary.pm. debian/installgiveslibandpubspec.yamlwith the destinationusr/share/dart/packages/leak_tracker_flutter_testing/; dh_install(1) installs a directory source under its own name into the destination (plugins usr/share/my-prog->usr/share/my-prog/plugins/), so the installed layout is.../leak_tracker_flutter_testing/lib/..., which is what the pubspec name and the smoke test expect.- At compat 14
dh_missingdefaults to--fail-missing, but it only scansdebian/tmp(default--sourcedir) and exits 0 when that does not exist;dh_installinstalls intodebian/dart-leak-tracker-flutter-testingand nothing createsdebian/tmp, so the uninstalledtest/,CHANGELOG.md,LICENSEandanalysis_options.yamldo not fail the build (checked in dh_missing(1) and /usr/bin/dh_missing). debian/rules'soverride_dh_installonly touches directory mtimes afterdh_install;${SOURCE_DATE_EPOCH}is exported by dpkg-buildpackage, so thefind/touchcannot fail there.- Changelog is a well-formed initial release (
3.0.10-1, unstable, urgency medium, closes #1152239, date Tue 27 Oct 2026 is consistent);debian/source/formatis3.0 (quilt);Vcs-Git,Vcs-Browser,Homepageanddebian/upstream/metadataare present and sane; Standards-Version 4.7.4 matches current Policy 4.7.4.1. debian/tests/controlnames the shippeddebian/tests/smokescript, whose POSIX-sh body builds apackage_config.jsonfor the installed packages, compiles a small program against the Flutter patched SDK and runs it under flutter_tester, offline, writing only undermktemp -d.- uscan found the packaged version as the newest upstream release (upstream
3.0.10, packaged3.0.10).
Not confirmed ◂
- The smoke test's hard-coded engine locations (
/usr/lib/flutter-engine/linux-x64/flutter_testerand.../flutter_patched_sdk/) and its frontend_server invocation could not be exercised or checked against the package that ships them, because flutter/flutter-engine are not installed on the reviewing system; the paths are plausible for the archive'ssky-engine/flutter-testerlayout but unverified. - The APIs the shipped
lib/and the smoke test use fromdart-leak-tracker11.0.2-1 anddart-leak-tracker-testing3.0.2-1 (for exampleLeakTesting.collectedLeaksReporter,IgnoredLeaks.isIgnored,withDisposalStackTrace,withIgnoredAll) could not be checked, since those packages are only in the NEW queue and not installable or readable here. - File modes (executability of
debian/rulesanddebian/tests/smoke) are not visible through the read-only file tools used, so they were assumed to be executable as autopkgtest requires.
Proposed changes ◂
None.
Uploader's response to the LLM review
The uploader was emailed about the review 11 days ago.
Review Information
accepted — allocated to awm 11 days ago, started 11 days ago, completed 11 days ago.
Final Comment
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 3.0.10-1 | b015afb4… | 2026-10-27 05:57 | 2026-10-27 05:57 | dfsg-uploader | rejected | VIEW |