Review: dart-leak-tracker-flutter-testing 3.0.10-1

Package Information

Description	leak tracking for Flutter tests This package ships the leak_tracker_flutter_testing library as sources, so that other Dart packages can depend on it at build time.
Maintainer	Emfox Zhou <emfox@debian.org>
Changed By	Emfox Zhou <emfox@debian.org>
Sponsor	emfox@debian.org
Distribution	unstable
Architecture	all
VCS	git: https://salsa.debian.org/dart-team/dart-leak-tracker-flutter-testing.git (browse)
Closes	#1152239
Tracker	https://tracker.debian.org/pkg/dart-leak-tracker-flutter-testing
Uploaded	12 days ago

New Package Report

.changes◂

Source	dart-leak-tracker-flutter-testing
Version	3.0.10-1
Changed-By	Emfox Zhou <emfox@debian.org>
Architecture	source all
Distribution	unstable
Date	Tue, 27 Oct 2026 08:52:34 +0800

Changelog◂

dart-leak-tracker-flutter-testing (3.0.10-1) unstable; urgency=medium
 .
   * Initial release. (Closes: #1152239)

.dsc◂

Priority	optional
Component	main
Package-List	dart-leak-tracker-flutter-testing deb devel optional arch=all
Section	devel

debian/copyright◂

Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: leak_tracker_flutter_testing
Source: https://github.com/dart-lang/leak_tracker/tree/main/pkgs/leak_tracker_flutter_testing

Files: *
Copyright: 2022, the Dart project authors
License: BSD-3-clause

Files: debian/*
Copyright: 2026, Emfox Zhou <emfox@debian.org>
License: BSD-3-clause

License: BSD-3-clause
 Redistribution and use in source and binary forms, with or without
 modification, are permitted provided that the following conditions are
 met:
 .
  * Redistributions of source code must retain the above copyright
    notice, this list of conditions and the following disclaimer.
  * Redistributions in binary form must reproduce the above
    copyright notice, this list of conditions and the following
    disclaimer in the documentation and/or other materials provided
    with the distribution.
  * Neither the name of Google LLC nor the names of its
    contributors may be used to endorse or promote products derived
    from this software without specific prior written permission.
 .
 THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

DFSG Assistant LLM REVIEW 1 blocker, 0 important, 0 minor

This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.

Reviewed 11 days ago.

Report◂

DFSG NEW review for dart-leak-tracker-flutter-testing version 3.0.10-1

Summary

Licensing is DFSG-compliant and debian/copyright is accurate: No
Packaging is of good quality: Yes
Issues: 1 blocker, 0 important, 0 minor
debian/watch: version 5
debian/copyright: machine-readable
Scan before the review: nothing found

Licensing

Every file in the tree is BSD-3-clause and DFSG-free: the root LICENSE is the 3-clause text (Dart project authors, Google LLC clause) and every upstream Dart source points to it, with no other licence or restrictive wording anywhere. debian/copyright is DEP-5 and its licence text matches LICENSE word for word, but it is inaccurate: its catch-all Files: * stanza names only the Dart project authors, while two test files are copyright 2023 The Chromium Authors, a holder the file never names.

Packaging

Tidy single-binary dh packaging: compat 14 with dh-sequence-single-binary named explicitly (compat 15 will need it), debian/install putting lib/ and pubspec.yaml under /usr/share/dart/packages/leak_tracker_flutter_testing, and a Depends that mirrors pubspec.yaml's constraints with correct upper bounds. The maintainer's SOURCE_DATE_EPOCH touch in override_dh_install is safe because dh computes that variable from the changelog, Standards-Version 4.7.4 matches Policy 4.7.4.1, and the autopkgtest is a self-contained smoke test needing no network. No patches, maintainer scripts or install-time generated files to review.

Issues

blocker licensing 1. debian/copyright names only the Dart project authors, not The Chromium Authors, holder of two test files ◂

Files: debian/copyright:6, test/tests/_formatting_test.dart:1, test/tests/end_to_end/leak_detection_test.dart:1
Basis: checked, in the package or with a reference tool
Evidence: // Copyright 2023 The Chromium Authors. All rights reserved. / // Use of this source code is governed by a BSD-style license that can be found in the LICENSE file. — versus debian/copyright's only upstream stanza: Files: * / Copyright: 2022, the Dart project authors / License: BSD-3-clause
Problem: These two files are copyright The Chromium Authors, a different holder from the Dart project authors, and no stanza of debian/copyright names it; the Files: * stanza therefore states the wrong copyright for them. Policy 12.5 requires debian/copyright to carry the package's copyright information, and DEP-5 stanzas must name the holder of every group of files. The licence (BSD-3-clause, per the files' pointer to the root LICENSE) is right; only the holder is missing.

Fix:

Add, after the Files: * stanza, a stanza for the two files:

Files: test/tests/_formatting_test.dart
 test/tests/end_to_end/leak_detection_test.dart
Copyright: 2023 The Chromium Authors
License: BSD-3-clause

(later stanzas override earlier ones, so no change to Files: * is needed beyond this).

Verified ◂

Read every upstream file in the tree: LICENSE, README.md, CHANGELOG.md, pubspec.yaml, analysis_options.yaml, lib/ (5 Dart files + DEPENDENCIES.md), test/ (7 test files, 3 test_infra files, 2 READMEs), and every file under debian/ including tests/smoke and upstream/metadata.
Root LICENSE and the stand-alone License: BSD-3-clause paragraph in debian/copyright match word for word, including the Neither the name of Google LLC ... clause; the Files: * copyright year 2022 differs from the headers' 2023/2024, which is immaterial drift.
All 11 other upstream .dart files carry Copyright (c) 2022–2024, the Dart project authors ... BSD-style license ... LICENSE file, matching the Files: * stanza; the debian/* stanza covers the packaging files.
Grep for SPDX-License-Identifier, Licensed under, GNU, Lesser, Apache, Mozilla, public domain, Permission is hereby granted found only the BSD-style license ... LICENSE file headers: no second licence in the tree.
Grep for non-commercial, noncommercial, no modification, NoDeriv, CC-BY-NC, field of use, Good, not Evil, not be used, commercial, proprietary, patent, trade secret found nothing: no non-free terms.
No built artifacts: the tree is only Markdown, YAML and Dart sources; there is no minified JS/CSS, jar, class file, shared object or PDF. lib/DEPENDENCIES.md is a layerlens-generated Markdown dependency diagram whose input is the lib/ sources shipped beside it.
debian/rules's find ... -exec touch -d "@${SOURCE_DATE_EPOCH}" cannot fail on an unset variable: dh calls Dh_Lib::get_source_date_epoch (from set_buildflags) and sets SOURCE_DATE_EPOCH from the changelog when the environment does not.
dh-sequence-single-binary is a virtual package provided by debhelper 14.5, so the Build-Depends is satisfiable; at compat 14 the add-on is implicitly active for a one-binary source, and naming it keeps debian/install handling under compat 15.
Dependency names and ranges check out against the archive/NEW: dart-meta 1.19.0-2 and dart-sdk 3.13.4 are in the archive; dart-leak-tracker 11.0.2-1, dart-leak-tracker-testing 3.0.2-1 and dart-matcher 0.12.20-1 are in ftp-master's NEW and satisfy the >=/<< bounds, which match pubspec.yaml's constraints.
The autopkgtest's dart-sdk paths exist on the reviewing system: /usr/lib/dart/bin/dartaotruntime and /usr/lib/dart/bin/snapshots/frontend_server_aot.dart.snapshot.
Changelog is sane: version 3.0.10-1 for upstream 3.0.10, distribution unstable, a dated entry with a bug closure; gbp.conf, source/format (3.0 quilt, no patches) and docs (README.md) are consistent with the tree.
uscan found the packaged version as the newest upstream release (upstream 3.0.10, packaged 3.0.10).

Not confirmed ◂

flutter, flutter-tester and flutter-patched-sdk appear neither in the archive lists nor in ftp-master's NEW queue, so Depends: flutter (>= 3.18.0) and the autopkgtest dependencies on those packages, and the test's /usr/lib/flutter-engine/linux-x64/{flutter_patched_sdk,flutter_tester} paths, could not be verified; no flutter is installed on the reviewing system.
The file mode of debian/tests/smoke (autopkgtest requires it to be executable) could not be read with read-only access.

Proposed changes ◂

None.

Uploader's response to the LLM review

The uploader rejected this upload in response to the review.

Review Information

rejected — allocated to dfsg-uploader 11 days ago, started 11 days ago, completed 11 days ago.

Final Comment

The uploader rejected this upload in response to the automated (LLM) review of it, so that they can fix the problems it found and upload again.

Other Reviews of this Package

Version	Hash	Allocated	Completed	Reviewer	Status	Details
3.0.10-1	838902c7…	2026-10-27 23:36	2026-10-27 23:36	awm	accepted	VIEW

Back to Dashboard | View all reviews for this package