golang-github-expr-lang-expr 1.18.0-1
Package Information
| Description | Expression language and expression evaluation for Go (library) Expr is a Go-centric expression language designed to deliver dynamic configurations with unparalleled accuracy, safety, and speed. Expr combines simple syntax with powerful features for ease of use. |
|---|---|
| Maintainer | Debian Go Packaging Team <team+pkg-go@tracker.debian.org> |
| Changed By | Maytham Alsudany <maytham@debian.org> |
| Sponsor | maytham@debian.org |
| Distribution | unstable |
| Architecture | all |
| VCS | git: https://salsa.debian.org/go-team/packages/golang-github-expr-lang-expr.git (browse) |
| Closes | #1150237 |
| Tracker | https://tracker.debian.org/pkg/golang-github-expr-lang-expr |
| Uploaded | 2 hours ago |
New Package Report
.changes
| Date | Sun, 22 Nov 2026 08:17:26 +0800 |
|---|---|
| Source | golang-github-expr-lang-expr |
| Version | 1.18.0-1 |
| Changed-By | Maytham Alsudany <maytham@debian.org> |
| Architecture | source all |
| Distribution | unstable |
Changelog
golang-github-expr-lang-expr (1.18.0-1) unstable; urgency=medium . * Initial release (Closes: #1150237)
.dsc
| Priority | optional |
|---|---|
| Component | main |
| Package-List | golang-github-expr-lang-expr-dev deb golang optional arch=all |
| Section | golang |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Source: https://github.com/expr-lang/expr Upstream-Name: expr Upstream-Contact: https://github.com/expr-lang/expr/issues Files: * Copyright: 2018 Anton Medvedev License: Expat Files: internal/spew/* Copyright: 2015-2016 Dave Collins <dave@davec.name> License: ISC Files: debian/* Copyright: 2026 Maytham Alsudany <maytham@debian.org> License: Expat Comment: Debian packaging is licensed under the same terms as upstream License: Expat Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. License: ISC Permission to use, copy, modify, and distribute this software for any purpose with or without fee is hereby granted, provided that the above copyright notice and this permission notice appear in all copies. . THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
DFSG Assistant LLM REVIEW 3 blocker, 0 important, 1 minor
This is an LLM based review using a Debian Inference based workflow. It was not written by a member of the DFSG team and has not been checked by one. It is not a decision on the package: it may be wrong, and it may have missed things.
Reviewed 1 hour ago.
Report
DFSG NEW review for golang-github-expr-lang-expr version 1.18.0-1
Summary
- Licensing is DFSG-compliant and
debian/copyrightis accurate: No - Packaging is of good quality: Yes
- Issues: 3 blocker, 0 important, 1 minor
- debian/watch: version 5
- debian/copyright: machine-readable
- Scan before the review: 2 found
Licensing
debian/copyright is DEP-5, but it does not describe the whole tree: internal/testify (stretchr/testify) and internal/difflib (pmezard/go-difflib) are vendored third-party code with no copyright or licence notice in the tree, and Files: * wrongly attributes them to Anton Medvedev under Expat (difflib is not even Expat-licensed). parser/lexer/utils.go reproduces code from Go's strconv/quote.go, and the Go Authors' notice is missing. The rest of the tree is fine: root Expat licence, and internal/spew is correctly attributed ISC to Dave Collins.
Packaging
The packaging is sound: 3.0 (quilt) with no patches, compat 13 with dh-sequence-golang, Go-team Vcs fields, XS-Go-Import-Path, upstream metadata and autopkgtest-pkg-go, a sane initial 1.18.0-1 changelog and current Standards-Version 4.7.4. The only defect is a minor one: both Build-Depends and Depends name golang-github-gdamore-tcell-v3-dev although the shipped source imports github.com/gdamore/tcell/v2; the v2 dev package arrives only transitively through tview.
Issues
blocker licensing 1. internal/difflib is vendored go-difflib with no licence notice, documented as Anton Medvedev's Expat code ◂
- Files:
internal/difflib/difflib.go:1,internal/difflib/difflib_test.go:1,debian/copyright - Basis: checked, in the package or with a reference tool
- Evidence:
internal/difflib/difflib.gostarts// Package difflib is a partial port of Python difflib module.and contains no copyright or licence line (no file under internal/difflib/ does);.github/scripts/coverage.mjs:9calls it'internal/difflib', // Test dependency. This is vendored dependency; the only stanza covering it isFiles: */Copyright: 2018 Anton Medvedev/License: Expat. - Problem: This is copied third-party code shipped in the source package and, as Go source, in the -dev binary package (dh-golang's configure copies every .go file and install copies everything under src/ not matched by DH_GOLANG_EXCLUDES). Its copyright notice and licence are nowhere in the tree, and debian/copyright attributes it to the wrong holder and licence: it is testify's diff dependency, go-difflib, whose notice is a BSD-3-clause one held by Patrick Mezard. Policy 2.3 requires the notice in debian/copyright because the installed copy has none, and the source package is distributed too.
- Fix: Add a
Files: internal/difflib/*stanza withCopyright: 2013 Patrick MezardandLicense: BSD-3-clause, including the licence text or pointing at /usr/share/common-licenses/BSD, and confirm the notice against the go-difflib version upstream copied from.
blocker licensing 2. internal/testify is vendored stretchr/testify with no notice; Mat Ryer, Tyler Bunnell and contributors are not named ◂
- Files:
internal/testify/assert/assertions.go:1,internal/testify/require/require.go:1,debian/copyright - Basis: checked, in the package or with a reference tool
- Evidence: No file under
internal/testify/carries a copyright or licence line;internal/testify/assert/assertions.go:29generates its companions with../_codegen, the testify code generator, and imports the vendoredinternal/spewandinternal/difflib.debian/copyrightsays onlyFiles: */Copyright: 2018 Anton Medvedev. - Problem: The copy of testify is shipped in the -dev binary package as Go source with no notice in the files, so Policy 2.3 requires its copyright to be in debian/copyright. The holders (Mat Ryer, Tyler Bunnell and contributors) are absent and Files: * attributes the code to expr's author. The licence itself is Expat, whose text is already present, but the attribution is not.
- Fix: Add a
Files: internal/testify/*stanza withCopyright: Mat Ryer, Tyler Bunnell and contributorsandLicense: Expat(confirm the years/holders against the testify release vendored).
blocker licensing 3. debian/copyright does not name The Go Authors for parser/lexer/utils.go, which reproduces strconv/quote.go code ◂
- Files:
parser/lexer/utils.go:33,parser/lexer/utils.go:76,parser/lexer/utils.go:155,debian/copyright - Basis: checked, in the package or with a reference tool
- Evidence:
parser/lexer/utils.go:33and:76:// The following logic is adapted fromstrconv/quote.go; `:155`: `// 4. Unicode escape sequences, reproduced from `strconv/quote.go; the doc comment ofunescapeChar(:103-108, "but a multibyte conversion is attempted which is more expensive than when the value is known to fit within one byte") is copied verbatim from Go's function. - Problem: The file is compiled into the library and installed in the -dev package, yet Files: * records only
2018 Anton Medvedevand Expat. The reproduced parts of Go's standard library are under the Go BSD-3-clause licence (Copyright 2009 The Go Authors), whose notice the file does not retain; Policy 2.3 therefore requires it in debian/copyright. - Fix: Give parser/lexer/utils.go its own Files stanza with both
2018 Anton Medvedevand2009 The Go AuthorsunderLicense: Expat and BSD-3-clause, including the BSD text or /usr/share/common-licenses/BSD; alternatively confirm with upstream that the copied fragments were rewritten, in which case only the comment need change.
minor packaging 4. Build-Depends and Depends name tcell v3, but the shipped debug package imports github.com/gdamore/tcell/v2 ◂
- Files:
debian/control:8,debian/control:20,debug/debugger.go:10 - Basis: checked, in the package or with a reference tool
- Evidence:
debian/controlhasgolang-github-gdamore-tcell-v3-devin Build-Depends and Depends;debug/debugger.go:10importsgithub.com/gdamore/tcell/v2(only repl/go.mod, excluded from the build, mentions tcell too, also v2). apt-cache: golang-github-gdamore-tcell-v3-dev ships tcell/v3 only, while golang-github-gdamore-tcell.v2-dev provides tcell/v2 and is pulled in only because golang-github-rivo-tview-dev depends on it. - Problem: The code is built in GOPATH mode (dh-golang's GO111MODULE=off), so debug/ is among the build targets and needs tcell/v2. The declared v3 dependency provides nothing the package builds against and is dead weight; the build works only because tview-dev happens to pull in the v2 dev package transitively, and the -dev package's Depends names the wrong package for the source it ships. No build or install failure follows, hence minor.
- Fix: Replace golang-github-gdamore-tcell-v3-dev with golang-github-gdamore-tcell.v2-dev in both Build-Depends and the -dev package's Depends.
Verified ◂
- Read debian/copyright (DEP-5, Format 1.0) in full, plus debian/control, rules, changelog, gbp.conf, salsa-ci.yml, source/format and upstream/metadata; there are no debian/patches, install files or maintainer scripts.
- Grepped the whole tree (minus .pc) for Copyright, (C), ©, SPDX-License-Identifier, Licensed under, GNU/Apache/Mozilla, public domain, All rights reserved and licence/license: the only notices are LICENSE (Expat, 2018 Anton Medvedev) and the internal/spew headers (ISC, Dave Collins). No non-free wording.
Files: internal/spew/*correctly overrides Files: * for internal/spew/; its ISC text matches the file headers, and the wildcard also covers internal/spew/testdata/dumpcgo.go. The 2013 vs 2015-2016 year difference is only drift.- test/fuzz/fuzz_expr_seed_corpus.zip is generated by test/fuzz/fuzz_corpus.sh from test/fuzz/fuzz_corpus.txt, both present; dh-golang installs only .go files, testdata/ and DH_GOLANG_INSTALL_EXTRA (fuzz_corpus.txt), so the zip remains source-only.
- testdata/crash.txt is a 6-byte binary fuzz crash input: test data.
- .github/images/out.gif is the demo recording generated from .github/images/demo.tape in the same directory; neither is installed.
- Generated files have their generators in the source package: vm/func_types[generated].go from vm/func_types/main.go, vm/runtime/helpers[generated].go from vm/runtime/helpers/main.go, and testdata/generated.txt from test/gen.
- Confirmed from /usr/share/perl5/Debian/Debhelper/Buildsystem/golang.pm that internal/testify and internal/difflib are installed into the -dev package: configure copies all .go files into the build tree and install copies every file under src/ not matched by DH_GOLANG_EXCLUDES.
- Reviewed debian/control dependencies against apt-cache: golang-any, golang-github-rivo-tview-dev, golang-github-gdamore-tcell-v3-dev and golang-github-gdamore-tcell.v2-dev all exist; tview-dev depends on the .v2 dev package.
- Sampled external imports across the tree: only debug/ (tcell/v2, tview) and repl/ (bettercap/readline, but repl is in DH_GOLANG_EXCLUDES and not built or installed) import outside the tree, so the Build-Depends set is otherwise complete.
- Standards-Version 4.7.4 matches Policy 4.7.4.1 in its first two components; compat 13, dh-sequence-golang, Multi-Arch: foreign on an Architecture: all -dev package, and ${misc:Depends} are all correct; the 1.18.0-1 unstable initial changelog is sane.
- uscan found the packaged version as the newest upstream release (upstream
1.18.0, packaged1.18.0).
Not confirmed ◂
- Could not compare parser/lexer/utils.go with the Go standard library: no Go toolchain is installed here, so Go's LICENSE/strconv/quote.go could not be read; the attribution finding rests on the file's own “adapted/reproduced” comments and the verbatim doc comment.
- Did not open .github/images/out.gif or test/fuzz/fuzz_expr_seed_corpus.zip (binary files); judged them by their tape/generator and by where they sit.
- Could not determine whether test/crowdsec/*.go and testdata/crowdsec.json are copied from the CrowdSec project; no provenance or notice is recorded in the tree.
Proposed changes ◂
None.
Uploader's response to the LLM review
Waiting for the uploader's response until , because the review found serious issues.
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 1.17.8-1 | 8033991e… | 2026-10-08 02:59 | 2026-10-08 03:25 | awm | rejected | VIEW |