Review: golang-github-wneessen-go-mail 0.7.2+dfsg-1
Review Information
rejected — allocated to siretart 1 month, 10 days ago, started 1 month, 10 days ago, completed 1 month, 10 days ago.
Final Comment
1. Missing Copyright Holders in debian/copyright
The debian/copyright file claims that all files are:
Files: *
Copyright: 2022 Winni Neessen
License: Expat
However, the source code reveals multiple copyright holders that are not properly documented:
- Go Authors: Files in the
smtp/directory contain// SPDX-FileCopyrightText: Copyright 2010 The Go Authors. All rights reserved.(e.g.,./smtp/smtp_test.goline 1,./smtp/smtp.goline 1) - Andrew Smith: The
internal/pkcs7/files contain// SPDX-FileCopyrightText: Copyright (c) 2015 Andrew Smith(e.g.,./internal/pkcs7/pkcs7.goline 1) - Mozilla Services Project: The same files contain
// SPDX-FileCopyrightText: Copyright (c) 2017-2024 The mozilla services project(e.g.,./internal/pkcs7/pkcs7.goline 2)
2. Dual Licensing Not Properly Documented
Several files in the smtp/ directory are dual-licensed under both BSD-3-Clause AND MIT:
// SPDX-License-Identifier: BSD-3-Clause AND MIT
(e.g., ./smtp/smtp_test.go line 12, ./smtp/smtp.go line 12)
The debian/copyright file only mentions the MIT license (Expat) and doesn't account for this dual licensing.
3. Inconsistent Copyright Attribution
The actual copyright notices in source files refer to "The go-mail Authors" (e.g., ./smime_test.go line 1), but debian/copyright attributes everything to "Winni Neessen". While the main LICENSE file does use "The go-mail Authors", this inconsistency needs clarification.
Nitpicks / Suggestions
-
The copyright year range in
debian/copyrightshows "2022" but the actualLICENSEfile shows "2022-2025" - consider updating for consistency. -
Consider adding a comment in
debian/copyrightexplaining the relationship between "The go-mail Authors" and the individual contributors for clarity.
The package appears to be free software suitable for Debian main once these copyright documentation issues are resolved. The licenses themselves (MIT and BSD-3-Clause) are DFSG-compliant.
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 0.7.2-1 | d7aff244… | 2026-02-09 04:42 | 2026-02-09 04:42 | awm | rejected | VIEW |