Review: grout 0.16.0-1
New Package Report
.changes
| Date | Thu, 11 Jun 2026 07:32:02 +0000 |
|---|---|
| Source | grout |
| Version | 0.16.0-1 |
| Changed-By | Robin Jarry |
| Architecture | source amd64 all |
| Distribution | unstable |
Changelog
grout (0.16.0-1) unstable; urgency=medium . * Initial packaging (Closes: #1139685)
.dsc
| Priority | optional |
|---|---|
| Component | main |
| Package-List | grout deb net optional arch=linux-any grout-headers deb net optional arch=all |
| Section | net |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: grout
Upstream-Contact: Robin Jarry <rjarry@redhat.com>
Source: https://github.com/DPDK/grout
Files: *
Copyright: 2023-2026 Robin Jarry
2024-2025 Christophe Fontaine
2025 Abhiram R N
2025 Anthony Harivel
2025 Maxime Leroy, Free Mobile
2025 Olivier Gournet
2026 David Marchand
2026 Matej Mužila
2026 SmartShare Systems
License: BSD-3-Clause
Files: main/sd_notify.c
Copyright: 2024 Robin Jarry
License: MIT-0
Files: main/sys_queue.h
Copyright: 1991, 1993 The Regents of the University of California
2023 Robin Jarry
License: BSD-3-Clause
Files: frr/*
Copyright: 2024-2025 Christophe Fontaine, Red Hat
2025 Maxime Leroy, Free Mobile
2026 Robin Jarry
License: GPL-2.0-or-later
License: BSD-3-Clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
.
1. Redistributions of source code must retain the above copyright notice,
this list of conditions and the following disclaimer.
.
2. Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.
.
3. Neither the name of the copyright holder nor the names of its contributors
may be used to endorse or promote products derived from this software
without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
POSSIBILITY OF SUCH DAMAGE.
License: GPL-2.0-or-later
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
.
You should have received a copy of the GNU General Public License
along with this program. If not, see <https://www.gnu.org/licenses/>.
.
On Debian systems, the complete text of the GNU General Public License
version 2 can be found in /usr/share/common-licenses/GPL-2.
License: MIT-0
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so.
.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
Review Information
rejected — allocated to siretart 1 day ago, started 1 day ago, completed 1 day ago.
Final Comment
Thanks for your diligence on this package. There are several DFSG
compliance and licensing issues in debian/copyright that must be
addressed.
First, there are a couple of BSD-3-Clause files where the source
copyright holders are missing from debian/copyright:
- meson_options.txt contains "Copyright (c) 2024 Vincent Jardin"
(line 2), but Vincent Jardin is not listed in debian/copyright. - smoke/bgp_frr_test.sh contains "Copyright (c) 2025 Andrea Panattoni"
(line 3), but Andrea Panattoni is not listed in debian/copyright.
Under the terms of the BSD-3-Clause license, copyright notices must
be reproduced verbatim, so these contributors should be added to the
list of copyright holders under the main Files: * stanza or their own
sections.
Second, the logo files docs/logo.svg and docs/logo-white.svg contain
embedded metadata licensing them under Creative Commons
Attribution-ShareAlike 4.0 International (CC-BY-SA-4.0) by Robin
Jarry. Currently, these files are covered by the catch-all Files: *
stanza in debian/copyright which declares BSD-3-Clause. To comply
with licenses, these files should have their own stanza
specifying the CC-BY-SA-4.0 license, and the full license text
needs to be included in debian/copyright as it is not present
in the common licenses archive.
Additionally, the RDF metadata inside these SVGs contains a dc:rights
field stating "All rights reserved" alongside the CC-BY-SA-4.0
license reference. While this is likely an artifact of the drawing
tool's default configuration, it presents a major conflict. This
needs to be clarified in debian/copyright. Please discuss the
copyright situation with upstream and document the conclusions in
debian/copyright.
-rt
Public Notes
Missed Author Check
Command: dnq author-check -prepare
Exit code: 0
Author check: scanned 445 files.
NOT IN debian/copyright (3):
Andrea Panattoni
smoke/bgp_frr_test.sh:3
Free Software Foundation, Inc
licenses/GPL-2.0-or-later.txt:5
Vincent Jardin
meson_options.txt:2
Result: ATTENTION REQUIRED — 3 authors not in debian/copyright
Lintian
Command: lintian -Iiv -L '>=warning' --show-overrides --color=never ../$(basename $PWD)_*.changes
Exit code: 0
N:
N: libpcap and zlib are pulled in via static linking against libdpdk-dev.
O: grout: embedded-library libpcap [usr/bin/grout]
N:
N: The given ELF object appears to have been statically linked to a library.
N: Doing this is strongly discouraged due to the extra work needed by the
N: security team to fix all the extra embedded copies or trigger the package
N: rebuilds, as appropriate.
N:
N: If the package uses a modified version of the given library it is highly
N: recommended to coordinate with the library's maintainer to include the
N: changes on the system version of the library.
N:
N: Please refer to Embedded code copies (Section 4.13) in the Debian Policy
N: Manual for details.
N:
N: Visibility: error
N: Show-Always: no
N: Check: libraries/embedded
N:
N:
N: libpcap and zlib are pulled in via static linking against libdpdk-dev.
O: grout: embedded-library zlib [usr/bin/grout]