Review: labwc-tweaks 0.1.0-1
New Package Report
.changes
| Changed-By | Nikolas Nyby |
|---|---|
| Architecture | source arm64 |
| Distribution | unstable |
| Date | Mon, 01 Jun 2026 21:41:15 -0400 |
| Source | labwc-tweaks |
| Version | 0.1.0-1 |
Changelog
labwc-tweaks (0.1.0-1) unstable; urgency=medium . * Initial release. (Closes: #1138664)
.dsc
| Package-List | labwc-tweaks deb x11 optional arch=any |
|---|---|
| Section | x11 |
| Priority | optional |
| Component | main |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: labwc-tweaks
Upstream-Contact: Johan Malm <jgm323@gmail.com>
Source: https://github.com/labwc/labwc-tweaks
Files: *
Copyright:
2021-2026 Johan Malm
2021-2026 labwc-tweaks contributors
License: BSD-3-Clause
Files: debian/*
Copyright: Copyright (c) 2026 Nikolas Nyby
License: GPL-2
License: BSD-3-Clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
1. Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
3. Neither the name of the University nor the names of its contributors
may be used to endorse or promote products derived from this software
without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE HOLDERS OR
CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
License: GPL-2
This package is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License, v2, as
published by the Free Software Foundation
.
This package is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>
.
On Debian systems, the complete text of the GNU General
Public License version 2 can be found in "/usr/share/common-licenses/GPL-2".
Review Information
rejected — allocated to siretart 16 days ago, started 16 days ago, completed 16 days ago.
Final Comment
Thanks for your diligence on this initial release of labwc-tweaks. I
found a few points in the copyright file that need a bit of adjustment
before the package can be accepted into the archive.
The most significant issue is that the main license for the project is
documented as BSD-3-Clause in debian/copyright, but the upstream
source (including the README, the LICENSE file, and several source
headers like src/xml.cpp) explicitly states that the project is
licensed under GPL-2.0-only. This needs to be corrected to accurately
reflect the project's primary license.
I also noticed that a few contributors are missing from the
attribution list. Specifically, Alf Gaida (in bin/lxqt-transupdate) and
Luís Pereira (in cmake/LXQtTranslate.cmake) should be documented.
Luís's file also mentions Alexander Sokolov as the original author, so
it would be good to include him as well.
The AppStream metadata (data/labwc_tweaks.appdata.xml.in) is licensed
under CC0-1.0 according to Config.cmake, so a block for that license
and the "Labwc Team" (or Johan Malm) should be added.
I also spotted a slight year discrepancy: tests/tap.h has a copyright
notice for Johan Malm from 2020, but the current debian/copyright starts
at 2021. It's best to include 2020 to be fully verbatim.
Finally, while the "labwc-tweaks contributors" catch-all is fine if
that's how upstream refers to them, the specific names found in the
headers should definitely be called out individually in their
respective file blocks.
-rt
Other Reviews of this Package
| Version | Hash | Allocated | Completed | Reviewer | Status | Details |
|---|---|---|---|---|---|---|
| 0.1.0-1 | 004e6f73… | 2026-06-07 13:52 | 2026-06-07 13:59 | siretart | accepted | VIEW |
Public Notes
Missed Author Check
Command: dnq author-check -prepare
Exit code: 0
Author check: scanned 138 files.
NOT IN debian/copyright (2):
Alf Gaida <agaida@siduction.org>
bin/lxqt-transupdate:4
Luís Pereira <luis.artur.pereira@gmail.com>
cmake/LXQtTranslate.cmake:2
Result: ATTENTION REQUIRED — 2 authors not in debian/copyright
Lintian
Command: lintian -Iiv -L '>=warning' --show-overrides --color=never ../$(basename $PWD)_*.changes
Exit code: 0
N:
W: labwc-tweaks: appstream-metadata-validation-failed Problems reported by "appstreamcli validate-tree".
N:
N: The specified AppStream metadata file fail to validate using 'appstreamcli
N: validate-tree --no-net path-to-package-root'.
N:
N: Please refer to https://wiki.debian.org/AppStream/Guidelines for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: appstream-metadata
N:
N:
W: labwc-tweaks: description-synopsis-starts-with-article
N:
N: The first line of the "Description:" should omit any initial indefinite or
N: definite article: "a", "an", or "the". A good heuristic is that it should
N: be possible to substitute the package name and synopsis into this formula:
N:
N: The package name provides {a,an,the,some} synopsis.
N:
N: Please refer to The package synopsis, or short description (Section 6.2.2)
N: in the Debian Developer's Reference for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: fields/description
N:
N:
W: labwc-tweaks: no-manual-page [usr/bin/labwc-tweaks]
N:
N: Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should have
N: a manual page
N:
N: Note that though the man program has the capability to check for several
N: program names in the NAMES section, each of these programs should have its
N: own manual page (a symbolic link to the appropriate manual page is
N: sufficient) because other manual page viewers such as xman or tkman don't
N: support this.
N:
N: If the name of the manual page differs from the binary by case, man may be
N: able to find it anyway; however, it is still best practice to match the
N: exact capitalization of the executable in the manual page.
N:
N: If the manual pages are provided by another package on which this package
N: depends, Lintian may not be able to determine that manual pages are
N: available. In this case, after confirming that all binaries do have manual
N: pages after this package and its dependencies are installed, please add a
N: Lintian override.
N:
N: Please refer to Manual pages (Section 12.1) in the Debian Policy Manual
N: for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: documentation/manual
N: Renamed from: binary-without-manpage
N: