Review: lcalc 2.2.2-1
Package Information
| Description | program for calculating with L-functions lcalc is a program for computing zeros and values of L-functions. Supported L-functions include the Riemann zeta function, the L-function of the Ramanujan delta function, and L-functions of elliptic curves defined over the rationals. |
|---|---|
| Maintainer | Debian Math Team <team+math@tracker.debian.org> |
| Changed By | Tobias Hansen <thansen@debian.org> |
| Distribution | experimental |
| Architecture | any |
| VCS | git: https://salsa.debian.org/math-team/lcalc.git (browse) |
| Popcon Installs | 479 |
| Binary NEW | Yes (new binary packages of a source already in sid) |
| Tracker | https://tracker.debian.org/pkg/lcalc |
| Uploaded | 18 days ago |
New Package Report
.changes
| Source | lcalc |
|---|---|
| Version | 2.2.2-1 |
| Changed-By | Tobias Hansen <thansen@debian.org> |
| Architecture | source amd64 |
| Distribution | experimental |
| Date | Sun, 04 Oct 2026 05:42:23 +0100 |
Changelog
lcalc (2.2.2-1) experimental; urgency=medium . * New upstream release. * Transition library soname to liblfunction2. * Do not install /usr/include/lcalc/config.h.
.dsc
| Section | math |
|---|---|
| Priority | optional |
| Component | main |
| Package-List | lcalc deb math optional arch=any liblfunction-dev deb libdevel optional arch=any liblfunction2 deb libs optional arch=any |
debian/copyright
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: lcalc
Source: http://oto.math.uwaterloo.ca/~mrubinst/L_function_public/CODE/
Files: *
Copyright: Copyright (C) 2001,2002,2003,2004 Michael Rubinstein
License: GPL-2+
Files: src/libLfunction/Lexplicit_formula.h
Copyright: Kevin McGown, Michael Rubinstein
License: GPL-2+
Files: src/libLfunction/mpreal.h
Copyright: 2008-2020 Pavel Holoborodko
License: GPL-3+
Files: debian/*
Copyright: 2008 Tim Abbott <tabbott@mit.edu>
2013-2019 Tobias Hansen <thansen@debian.org>
2015-2021 Julien Puydt <jpuydt@debian.org>
License: GPL-2+
License: GPL-2+
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License version 2 as
published by the Free Software Foundation; either version 2 of the
License, or (at your option) any later version.
.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
.
You should have received a copy of the GNU General Public License
along with this program. If not, see https://www.gnu.org/licenses/.
.
On Debian systems, the complete text of the GNU General
Public License version 2 can be found in /usr/share/common-licenses/GPL-2
License: GPL-3+
On Debian GNU/Linux systems, the complete text of the GNU General Public
License version 3 can be found in `/usr/share/common-licenses/GPL-3'
Review Information
accepted — allocated to awm 18 days ago, started 18 days ago, completed 18 days ago.
Final Comment
Hi,
Some minor issues spotted...
1: m4/ax_openmp.m4 is not described (copyright inaccuracy, minor)
This file is new in 2.2.2 and has its own named author/licence origin. Its header (line 1): # Modified version of AC_OPENMP from autoconf 2.73 c.m4 file (Dima Pasechnik, 2026/03). It falls into the Files: * catch-all, which attributes it to "(2001–2004) Michael Rubinstein, GPL-2+". That is wrong on both counts: it is autoconf-derived (GPL-3+ under autoconf's terms) and was authored/adapted by Dima Pasechnik. Fix: add a stanza Files: m4/ax_openmp.m4 / Copyright: Dima Pasechnik / License: GPL-3+ (or note the autoconf origin). Not DFSG-blocking — it is clearly free build tooling — but the holder/licence attribution is inaccurate, and debian/copyright is the one place upstream source licensing must be pinned down.
2: Build-Depends missing autoconf/automake/libtool → FTBFS on clean buildds (must fix)
The source ships no generated autotools files whatsoever — no configure, aclocal.m4, Makefile.in, build-aux/, src/config.h.in (I globbed; none exist anywhere outside .pc/), and doc/INSTALL confirms upstream uploads git trees. The tarball fetched by debian/watch (https://gitlab.com/sagemath/lcalc/-/archive/v2.2.2/..., a GitLab archive URL) is a bare git export, so the Debian build must regenerate the whole autotools system from configure.ac/Makefile.am.
debian/rules does nothing special (just dh_auto_configure -- --with-pari), and in compat 14 dh automatically injects the +autoreconf addon (verified in /usr/share/perl5/Debian/Debhelper/SequencerUtil.pm: push(@addon_requests, '+autoreconf') for not compat(9,1)), so dh_autoreconf runs autoreconf -f -i (it only early-exits if there is no configure.ac, and configure.ac exists, requiring AC_PREREQ([2.72])). autoreconf/autoconf/automake/libtoolize are not in Build-Depends and are not pulled in by build-essential, libpari-dev, pkgconf or gengetopt. A clean buildd therefore fails with autoreconf: command not found.
Fix: add autoconf (>= 2.72) (AC_PREREQ), automake, and libtool to Build-Depends (compat 14's auto-reconf then regenerates configure/Makefile.in/ltmain.sh correctly). This is the one change I would require before upload.
3: stale upstream URLs (minor)
debian/control Homepage: and debian/copyright Source: still cite the abandoned oto.math.uwaterloo.ca/~mrubinst/L_function_public/… site, while the project (and the watch) moved to gitlab.com/sagemath/lcalc years ago. Recommend updating both to the gitlab URLs for consistency. Not policy-violating.
Thanks!